70766 2011-10-24 14:47:48 -0700 LayerRendererChromium::setVisible called needlessly without a visibility change 2011-10-25 13:58:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmocny mmocny jamesr kbr nduca webkit.review.bot oldest_to_newest 489661 0 mmocny 2011-10-24 14:47:48 -0700 LayerRendererChromium::setVisible called needlessly without a visibility change 489662 1 112253 mmocny 2011-10-24 14:50:00 -0700 Created attachment 112253 Patch 489671 2 mmocny 2011-10-24 14:54:58 -0700 This fixes the issues with setVisibilityCHROMIUM(true) being spammed after the recently plumbing changes (https://bugs.webkit.org/show_bug.cgi?id=70635). There are other options to prevent this, but talking with Nat it seems that there is no need for LayerRendererChromium::setVisible to be called unless visibility actually changed. 489675 3 112253 nduca 2011-10-24 14:58:03 -0700 Comment on attachment 112253 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112253&action=review Seems ok modulo the comment above. > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:51 > + , m_visible(false) True or false here? I was expecting true personally. Do GL contexts start up "invisible"? 489695 4 112253 kbr 2011-10-24 15:19:40 -0700 Comment on attachment 112253 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112253&action=review Nat's question is a good one. Small issue in the ChangeLog needs to be fixed as well. > Source/WebCore/ChangeLog:10 > + No new tests. (OOPS!) This second OOPS will have to be removed in order for the commit queue to process this patch. 490048 5 112339 mmocny 2011-10-25 08:27:14 -0700 Created attachment 112339 Patch 490138 6 112339 kbr 2011-10-25 10:45:47 -0700 Comment on attachment 112339 Patch Looks fine. r=me 490334 7 112339 webkit.review.bot 2011-10-25 13:58:23 -0700 Comment on attachment 112339 Patch Clearing flags on attachment: 112339 Committed r98392: <http://trac.webkit.org/changeset/98392> 490336 8 webkit.review.bot 2011-10-25 13:58:28 -0700 All reviewed patches have been landed. Closing bug. 112253 2011-10-24 14:50:00 -0700 2011-10-25 08:27:09 -0700 Patch bug-70766-20111024174958.patch text/plain 2493 mmocny U3VidmVyc2lvbiBSZXZpc2lvbjogOTgyODIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyMzZjZmY0YTMxZDg3NDdj NDAzN2NlZTc5ZTY1MzM4YjAyZjE0MDViLi44YTEyMzIxMmE0NGIyNDEyOGI1YTkyZTNmMDc2NDZk OGU4MTMzYzkxIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMTAtMjQgIE1pY2hh bCBNb2NueSAgPG1tb2NueUBnb29nbGUuY29tPgorCisgICAgICAgIExheWVyUmVuZGVyZXJDaHJv bWl1bTo6c2V0VmlzaWJsZSBjYWxsZWQgbmVlZGxlc3NseSB3aXRob3V0IGEgdmlzaWJpbGl0eSBj aGFuZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcw NzY2CisKKyAgICAgICAgQ2hlY2sgdGhhdCB2aXNpYmlsaXR5IGhhcyBhY3R1YWxseSBjaGFuZ2Vk IGJlZm9yZSBjYWxsaW5nIExheWVyUmVuZGVyZXJDaHJvbWl1bTo6c2V0VmlzaWJsZQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4g KE9PUFMhKQorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXll clRyZWVIb3N0SW1wbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDQ0xheWVyVHJlZUhvc3RJbXBs OjpDQ0xheWVyVHJlZUhvc3RJbXBsKToKKyAgICAgICAgKFdlYkNvcmU6OkNDTGF5ZXJUcmVlSG9z dEltcGw6OnNldFZpc2libGUpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L2NjL0NDTGF5ZXJUcmVlSG9zdEltcGwuaDoKKwogMjAxMS0xMC0yMSAgTmF0IER1Y2EgIDxuZHVj YUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBBZGQgaXNUcmFjZUV2ZW50RW5h YmxlZCB0byBQbGF0Zm9ybVN1cHBvcnQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdElt cGwuY3BwCmluZGV4IGE5ZWU0Y2FiOTk5MmNmOTlkNzE2ZjUzNGU4Y2ZiOTk3Y2YxZjI1YzYuLmZk ZWE5NzI1NzUxMWJlMWZkNDUzZTQ2NTY3MzE4ZjZmZmJlMmVkZTIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdElt cGwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2Nj L0NDTGF5ZXJUcmVlSG9zdEltcGwuY3BwCkBAIC00OCw2ICs0OCw3IEBAIENDTGF5ZXJUcmVlSG9z dEltcGw6OkNDTGF5ZXJUcmVlSG9zdEltcGwoY29uc3QgQ0NTZXR0aW5ncyYgc2V0dGluZ3MsIEND TGF5ZXJUcmVlCiAgICAgLCBtX3NvdXJjZUZyYW1lTnVtYmVyKC0xKQogICAgICwgbV9mcmFtZU51 bWJlcigwKQogICAgICwgbV9zZXR0aW5ncyhzZXR0aW5ncykKKyAgICAsIG1fdmlzaWJsZShmYWxz ZSkKIHsKICAgICBBU1NFUlQoQ0NQcm94eTo6aXNJbXBsVGhyZWFkKCkpOwogfQpAQCAtMTI4LDYg KzEyOSwxMCBAQCB2b2lkIENDTGF5ZXJUcmVlSG9zdEltcGw6OnNldFJvb3RMYXllcihQYXNzUmVm UHRyPENDTGF5ZXJJbXBsPiBsYXllcikKIAogdm9pZCBDQ0xheWVyVHJlZUhvc3RJbXBsOjpzZXRW aXNpYmxlKGJvb2wgdmlzaWJsZSkKIHsKKyAgICBpZiAobV92aXNpYmxlID09IHZpc2libGUpCisg ICAgICAgIHJldHVybjsKKyAgICBtX3Zpc2libGUgPSB2aXNpYmxlOworCiAgICAgaWYgKG1fbGF5 ZXJSZW5kZXJlcikKICAgICAgICAgbV9sYXllclJlbmRlcmVyLT5zZXRWaXNpYmxlKHZpc2libGUp OwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vY2MvQ0NMYXllclRyZWVIb3N0SW1wbC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0SW1wbC5oCmluZGV4IDM3YTQ2OTgxZjYy N2E4MDIzZDYzMjY3NTk3ZjQ0MGQyMDQ3MDQyMzEuLmY2YTgzMDIzMmYyMzljOTM5MzI1Y2U1OTQz NDQ5NjAzODYxMWMyZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdEltcGwuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmgKQEAg LTEwOSw2ICsxMDksNyBAQCBwcml2YXRlOgogICAgIFJlZlB0cjxDQ0xheWVySW1wbD4gbV9yb290 TGF5ZXJJbXBsOwogICAgIENDU2V0dGluZ3MgbV9zZXR0aW5nczsKICAgICBJbnRTaXplIG1fdmll d3BvcnRTaXplOworICAgIGJvb2wgbV92aXNpYmxlOwogfTsKIAogfTsK 112339 2011-10-25 08:27:14 -0700 2011-10-25 13:58:22 -0700 Patch bug-70766-20111025112713.patch text/plain 2498 mmocny U3VidmVyc2lvbiBSZXZpc2lvbjogOTgzMzMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2NmI3NDI1OGZlODljYWM0 NjJmMDRhMWViYjdlMTVlZWRhM2YxY2M1Li40NWE2NzM5MGViODliMjI4YmFlNzVmOGQxZTIxMDRi YzlkNTJkOTNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMTAtMjUgIE1pY2hh bCBNb2NueSAgPG1tb2NueUBnb29nbGUuY29tPgorCisgICAgICAgIExheWVyUmVuZGVyZXJDaHJv bWl1bTo6c2V0VmlzaWJsZSBjYWxsZWQgbmVlZGxlc3NseSB3aXRob3V0IGEgdmlzaWJpbGl0eSBj aGFuZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcw NzY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hl Y2sgdGhhdCB2aXNpYmlsaXR5IGhhcyBhY3R1YWxseSBjaGFuZ2VkIGJlZm9yZSBjYWxsaW5nIExh eWVyUmVuZGVyZXJDaHJvbWl1bTo6c2V0VmlzaWJsZQorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0SW1wbC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpDQ0xheWVyVHJlZUhvc3RJbXBsOjpDQ0xheWVyVHJlZUhvc3RJbXBsKToKKyAgICAgICAg KFdlYkNvcmU6OkNDTGF5ZXJUcmVlSG9zdEltcGw6OnNldFZpc2libGUpOgorICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdEltcGwuaDoKKwogMjAx MS0xMC0yNSAgQW5kcmV5IEtvc3lha292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IEpTIGV4Y2VwdGlvbiBpbiBKYXZhU2NyaXB0U291cmNlRnJhbWUub25T aG93UG9wb3Zlci9zaG93T2JqZWN0UG9wb3ZlcigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVl SG9zdEltcGwuY3BwCmluZGV4IGE5ZWU0Y2FiOTk5MmNmOTlkNzE2ZjUzNGU4Y2ZiOTk3Y2YxZjI1 YzYuLjUxNGMwZTlmYWIyYTRlYmFmYWJmN2VmMWE3M2E1ZmNjNzBhNDFlNzMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVl SG9zdEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL2NjL0NDTGF5ZXJUcmVlSG9zdEltcGwuY3BwCkBAIC00OCw2ICs0OCw3IEBAIENDTGF5ZXJU cmVlSG9zdEltcGw6OkNDTGF5ZXJUcmVlSG9zdEltcGwoY29uc3QgQ0NTZXR0aW5ncyYgc2V0dGlu Z3MsIENDTGF5ZXJUcmVlCiAgICAgLCBtX3NvdXJjZUZyYW1lTnVtYmVyKC0xKQogICAgICwgbV9m cmFtZU51bWJlcigwKQogICAgICwgbV9zZXR0aW5ncyhzZXR0aW5ncykKKyAgICAsIG1fdmlzaWJs ZSh0cnVlKQogewogICAgIEFTU0VSVChDQ1Byb3h5Ojppc0ltcGxUaHJlYWQoKSk7CiB9CkBAIC0x MjgsNiArMTI5LDEwIEBAIHZvaWQgQ0NMYXllclRyZWVIb3N0SW1wbDo6c2V0Um9vdExheWVyKFBh c3NSZWZQdHI8Q0NMYXllckltcGw+IGxheWVyKQogCiB2b2lkIENDTGF5ZXJUcmVlSG9zdEltcGw6 OnNldFZpc2libGUoYm9vbCB2aXNpYmxlKQogeworICAgIGlmIChtX3Zpc2libGUgPT0gdmlzaWJs ZSkKKyAgICAgICAgcmV0dXJuOworICAgIG1fdmlzaWJsZSA9IHZpc2libGU7CisKICAgICBpZiAo bV9sYXllclJlbmRlcmVyKQogICAgICAgICBtX2xheWVyUmVuZGVyZXItPnNldFZpc2libGUodmlz aWJsZSk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmgKaW5kZXggMzdhNDY5 ODFmNjI3YTgwMjNkNjMyNjc1OTdmNDQwZDIwNDcwNDIzMS4uZjZhODMwMjMyZjIzOWM5MzkzMjVj ZTU5NDM0NDk2MDM4NjExYzJmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0SW1wbC5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdEltcGwu aApAQCAtMTA5LDYgKzEwOSw3IEBAIHByaXZhdGU6CiAgICAgUmVmUHRyPENDTGF5ZXJJbXBsPiBt X3Jvb3RMYXllckltcGw7CiAgICAgQ0NTZXR0aW5ncyBtX3NldHRpbmdzOwogICAgIEludFNpemUg bV92aWV3cG9ydFNpemU7CisgICAgYm9vbCBtX3Zpc2libGU7CiB9OwogCiB9Owo=