70747 2011-10-24 11:28:16 -0700 check-webkit-style complains about WEBKIT_EXPORT in test/WebUnitTests.h 2011-10-24 12:01:34 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nduca levin abarth levin ojan tony webkit.review.bot oldest_to_newest 489469 0 nduca 2011-10-24 11:28:16 -0700 WebUnitTests.h has WEBKIT_EXPORT's for testing purposes. This makes check-webkit-style sad. On this bug, we discussed adding a WEBKIT_EXPORT_PRIVATE to avoid this: https://bugs.webkit.org/show_bug.cgi?id=70688 However, the conclusion was that we should probably just make cws not complain about test/ exports. 489498 1 112221 levin 2011-10-24 11:55:08 -0700 Created attachment 112221 Patch 489501 2 112221 tony 2011-10-24 11:56:55 -0700 Comment on attachment 112221 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112221&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:1607 > 'WEBKIT_EXPORT should only appear in the chromium public directory.') Nit: Do we want to update the error text? 489507 3 112221 levin 2011-10-24 11:59:33 -0700 Comment on attachment 112221 Patch ok I'll add " (or tests)" 489510 4 levin 2011-10-24 12:01:34 -0700 Committed as http://trac.webkit.org/changeset/98264 112221 2011-10-24 11:55:08 -0700 2011-10-24 11:59:33 -0700 Patch bug-70747-20111024115507.patch text/plain 2849 levin U3VidmVyc2lvbiBSZXZpc2lvbjogOTgyNTgKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1Yjk3M2RhNzIzOWY1OWE3YjJjNjQwMmViNDIxZGYzNDk0 NDNhMzBmLi4xYzdmYjk5N2NjNTM0ODk0MzQ1MDI1NGI0ODhkMzY3ZmE5MzlhM2MyIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMTAtMjQgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIGNoZWNrLXdlYmtpdC1zdHlsZSBjb21wbGFpbnMgYWJvdXQgV0VCS0lUX0VYUE9SVCBpbiB0 ZXN0L1dlYlVuaXRUZXN0cy5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03MDc0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6IEFsbG93 IFdFQktJVF9FWFBPUlQgaW4gdGVzdHMgZGlyLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv c3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5OiBDb3JyZXNwb25kaW5nIHRlc3QuCisKIDIw MTEtMTAtMjQgIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgogCiAgICAgICAg IFtRdF1bV0syXSBDcmFzaCB3aGVuIHJ1bm5pbmcgcGl4ZWwgdGVzdHMKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggNTRiMTVkMThlYmE2MzY5MTQy ZWQ5Y2YwNWJlZjkwZWJkNmU5YjRmMy4uNDlkOTEzZDE2MTZmOTJmNTU3ZjEwMDNjMjMyMjMwYzk4 NmU4MDkzNyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAu cHkKQEAgLTE2MDIsNyArMTYwMiw3IEBAIGRlZiBjaGVja19mdW5jdGlvbl9kZWZpbml0aW9uKGZp bGVuYW1lLCBmaWxlX2V4dGVuc2lvbiwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyCiAKICAgICBt b2RpZmllcnNfYW5kX3JldHVybl90eXBlID0gZnVuY3Rpb25fc3RhdGUubW9kaWZpZXJzX2FuZF9y ZXR1cm5fdHlwZSgpCiAgICAgaWYgZmlsZW5hbWUuZmluZCgnL2Nocm9taXVtLycpICE9IC0xIGFu ZCBzZWFyY2gocidcYldFQktJVF9FWFBPUlRcYicsIG1vZGlmaWVyc19hbmRfcmV0dXJuX3R5cGUp OgotICAgICAgICBpZiBmaWxlbmFtZS5maW5kKCcvY2hyb21pdW0vcHVibGljLycpID09IC0xOgor ICAgICAgICBpZiBmaWxlbmFtZS5maW5kKCcvY2hyb21pdW0vcHVibGljLycpID09IC0xIGFuZCBm aWxlbmFtZS5maW5kKCcvY2hyb21pdW0vdGVzdHMvJykgPT0gLTE6CiAgICAgICAgICAgICBlcnJv cihmdW5jdGlvbl9zdGF0ZS5mdW5jdGlvbl9uYW1lX3N0YXJ0X3Bvc2l0aW9uLnJvdywgJ3JlYWRh YmlsaXR5L3dlYmtpdF9leHBvcnQnLCA1LAogICAgICAgICAgICAgICAgICAgJ1dFQktJVF9FWFBP UlQgc2hvdWxkIG9ubHkgYXBwZWFyIGluIHRoZSBjaHJvbWl1bSBwdWJsaWMgZGlyZWN0b3J5Licp CiAgICAgICAgIGVsaWYgbm90IGZpbGVfZXh0ZW5zaW9uID09ICJoIjoKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXgg MTMwNTg4ZWE1ZjJjMGU0ZDk0NjE1ODRkYjY1MzNlYTI3N2YwYjZjMy4uZmE2ODQ5ZWNkOWY4M2Qx NmYyOTYwMzA2ZmMwMGZiYjMyNDc3MmUwZCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKQEAgLTQ1MjQsNiArNDUyNCwx MCBAQCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICAg ICAgICAgICAgICAgICAgIHNlbGYucGVyZm9ybV9saW50KCdXRUJLSVRfRVhQT1JUIGludCBmb28o KTtcbicsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdXZWJL aXQvY2hyb21pdW0vcHVibGljL3Rlc3QuaCcsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHdlYmtpdF9leHBvcnRfZXJyb3JfcnVsZXMpKQorICAgICAgICBzZWxm LmFzc2VydEVxdWFscygnJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgc2VsZi5wZXJmb3Jt X2xpbnQoJ1dFQktJVF9FWFBPUlQgaW50IGZvbygpO1xuJywKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgJ1dlYktpdC9jaHJvbWl1bS90ZXN0cy90ZXN0LmgnLAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB3ZWJraXRfZXhwb3J0 X2Vycm9yX3J1bGVzKSkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoJ1dFQktJVF9FWFBPUlQg c2hvdWxkIG9ubHkgYmUgdXNlZCBpbiBoZWFkZXIgZmlsZXMuICBbcmVhZGFiaWxpdHkvd2Via2l0 X2V4cG9ydF0gWzVdJywKICAgICAgICAgICAgICAgICAgICAgICAgICAgc2VsZi5wZXJmb3JtX2xp bnQoJ1dFQktJVF9FWFBPUlQgaW50IGZvbygpO1xuJywKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgJ1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvdGVzdC5jcHAnLAo=