70746 2011-10-24 11:25:27 -0700 Use StringBuilder in CSSRuleList::rulesText()/CSSSelectorList::selectorsText() 2011-10-24 14:00:36 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mihnea mihnea macpherson webkit.review.bot oldest_to_newest 489467 0 mihnea 2011-10-24 11:25:27 -0700 Improve performance in CSSRuleList::rulesText()/CSSSelectorList::selectorsText() by using StringBuilder instead of String. 489502 1 112223 mihnea 2011-10-24 11:57:44 -0700 Created attachment 112223 Patch 489508 2 112223 tony 2011-10-24 12:00:53 -0700 Comment on attachment 112223 Patch We should also switch over CSSRulesList::rulesText(). 489622 3 112223 webkit.review.bot 2011-10-24 14:00:32 -0700 Comment on attachment 112223 Patch Clearing flags on attachment: 112223 Committed r98281: <http://trac.webkit.org/changeset/98281> 489623 4 webkit.review.bot 2011-10-24 14:00:36 -0700 All reviewed patches have been landed. Closing bug. 112223 2011-10-24 11:57:44 -0700 2011-10-24 14:00:32 -0700 Patch 70746.patch text/plain 3292 mihnea ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2ZWIyOWIyLi5lYmViNWFjIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMTAtMjQgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAg ICAgICAgVXNlIFN0cmluZ0J1aWxkZXIgaW4gQ1NTUnVsZUxpc3Q6OnJ1bGVzVGV4dCgpL0NTU1Nl bGVjdG9yTGlzdDo6c2VsZWN0b3JzVGV4dCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03MDc0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAg KiBjc3MvQ1NTUnVsZUxpc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUnVsZUxpc3Q6OnJ1 bGVzVGV4dCk6CisgICAgICAgICogY3NzL0NTU1NlbGVjdG9yTGlzdC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpDU1NTZWxlY3Rvckxpc3Q6OnNlbGVjdG9yc1RleHQpOgorICAgICAgICAqIGNzcy9X ZWJLaXRDU1NLZXlmcmFtZXNSdWxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYktpdENTU0tl eWZyYW1lc1J1bGU6OmNzc1RleHQpOiBVc2UgQ1NTUnVsZUxpc3Q6OnJ1bGVzVGV4dCgpIG1ldGhv ZCBpbnN0ZWFkIG9mIGV4cGxpY2l0IGxvb3AuCisKIDIwMTEtMTAtMjQgIFNpbW9uIEZyYXNlciAg PHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wcm92ZSBkZWJ1ZyBjb21wb3Np dGluZyBib3JkZXIgY29sb3JzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUnVs ZUxpc3QuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1J1bGVMaXN0LmNwcAppbmRleCA5OWRl Y2JiLi43ODM5MzY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUnVsZUxpc3Qu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NSdWxlTGlzdC5jcHAKQEAgLTI0LDYgKzI0 LDcgQEAKIAogI2luY2x1ZGUgIkNTU1J1bGUuaCIKICNpbmNsdWRlICJDU1NTdHlsZVNoZWV0Lmgi CisjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5nQnVpbGRlci5oPgogCiBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAKQEAgLTk3LDE1ICs5OCwxNSBAQCB1bnNpZ25lZCBDU1NSdWxlTGlzdDo6aW5zZXJ0UnVs ZShDU1NSdWxlKiBydWxlLCB1bnNpZ25lZCBpbmRleCkKIAogU3RyaW5nIENTU1J1bGVMaXN0Ojpy dWxlc1RleHQoKSBjb25zdAogewotICAgIFN0cmluZyByZXN1bHQ7CisgICAgU3RyaW5nQnVpbGRl ciByZXN1bHQ7CiAKICAgICBmb3IgKHVuc2lnbmVkIGluZGV4ID0gMDsgaW5kZXggPCBsZW5ndGgo KTsgKytpbmRleCkgewotICAgICAgICByZXN1bHQgKz0gIiAgIjsKLSAgICAgICAgcmVzdWx0ICs9 IGl0ZW0oaW5kZXgpLT5jc3NUZXh0KCk7Ci0gICAgICAgIHJlc3VsdCArPSAiXG4iOworICAgICAg ICByZXN1bHQuYXBwZW5kKCIgICIpOworICAgICAgICByZXN1bHQuYXBwZW5kKGl0ZW0oaW5kZXgp LT5jc3NUZXh0KCkpOworICAgICAgICByZXN1bHQuYXBwZW5kKCJcbiIpOwogICAgIH0KIAotICAg IHJldHVybiByZXN1bHQ7CisgICAgcmV0dXJuIHJlc3VsdC50b1N0cmluZygpOwogfQogCiB9IC8v IG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU2Vs ZWN0b3JMaXN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTZWxlY3Rvckxpc3QuY3BwCmlu ZGV4IDliMGZhODAuLjgwNDMwNTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NT ZWxlY3Rvckxpc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTZWxlY3Rvckxpc3Qu Y3BwCkBAIC0yOCw2ICsyOCw3IEBACiAjaW5jbHVkZSAiQ1NTU2VsZWN0b3JMaXN0LmgiCiAKICNp bmNsdWRlICJDU1NQYXJzZXJWYWx1ZXMuaCIKKyNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdCdWls ZGVyLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAtMTA3LDE1ICsxMDgsMTUgQEAgdm9p ZCBDU1NTZWxlY3Rvckxpc3Q6OmRlbGV0ZVNlbGVjdG9ycygpCiAKIFN0cmluZyBDU1NTZWxlY3Rv ckxpc3Q6OnNlbGVjdG9yc1RleHQoKSBjb25zdAogewotICAgIFN0cmluZyByZXN1bHQ7CisgICAg U3RyaW5nQnVpbGRlciByZXN1bHQ7CiAKICAgICBmb3IgKENTU1NlbGVjdG9yKiBzID0gZmlyc3Qo KTsgczsgcyA9IG5leHQocykpIHsKICAgICAgICAgaWYgKHMgIT0gZmlyc3QoKSkKLSAgICAgICAg ICAgIHJlc3VsdCArPSAiLCAiOwotICAgICAgICByZXN1bHQgKz0gcy0+c2VsZWN0b3JUZXh0KCk7 CisgICAgICAgICAgICByZXN1bHQuYXBwZW5kKCIsICIpOworICAgICAgICByZXN1bHQuYXBwZW5k KHMtPnNlbGVjdG9yVGV4dCgpKTsKICAgICB9CiAKLSAgICByZXR1cm4gcmVzdWx0OworICAgIHJl dHVybiByZXN1bHQudG9TdHJpbmcoKTsKIH0KIAogdGVtcGxhdGUgPHR5cGVuYW1lIEZ1bmN0b3I+ CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvV2ViS2l0Q1NTS2V5ZnJhbWVzUnVsZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvV2ViS2l0Q1NTS2V5ZnJhbWVzUnVsZS5jcHAKaW5kZXgg ZDZjYzQzNS4uN2Q3NmUxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1dlYktpdENT U0tleWZyYW1lc1J1bGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9XZWJLaXRDU1NLZXlm cmFtZXNSdWxlLmNwcApAQCAtMTQ3LDE0ICsxNDcsOCBAQCBTdHJpbmcgV2ViS2l0Q1NTS2V5ZnJh bWVzUnVsZTo6Y3NzVGV4dCgpIGNvbnN0CiAgICAgcmVzdWx0ICs9IG1fbmFtZTsKICAgICByZXN1 bHQgKz0gIiB7IFxuIjsKIAotICAgIGlmIChtX2xzdENTU1J1bGVzKSB7Ci0gICAgICAgIHVuc2ln bmVkIGxlbiA9IG1fbHN0Q1NTUnVsZXMtPmxlbmd0aCgpOwotICAgICAgICBmb3IgKHVuc2lnbmVk IGkgPSAwOyBpIDwgbGVuOyBpKyspIHsKLSAgICAgICAgICAgIHJlc3VsdCArPSAiICAiOwotICAg ICAgICAgICAgcmVzdWx0ICs9IG1fbHN0Q1NTUnVsZXMtPml0ZW0oaSktPmNzc1RleHQoKTsKLSAg ICAgICAgICAgIHJlc3VsdCArPSAiXG4iOwotICAgICAgICB9Ci0gICAgfQorICAgIGlmIChtX2xz dENTU1J1bGVzKQorICAgICAgICByZXN1bHQgKz0gbV9sc3RDU1NSdWxlcy0+cnVsZXNUZXh0KCk7 CiAKICAgICByZXN1bHQgKz0gIn0iOwogICAgIHJldHVybiByZXN1bHQ7Cg==