70745 2011-10-24 11:14:17 -0700 Enable MEDIA_SOURCE feature for Chromium 2011-10-27 07:11:24 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 70767 71016 0 acolwell webkit-unassigned jchaffraix levin webkit.review.bot oldest_to_newest 489463 0 acolwell 2011-10-24 11:14:17 -0700 Set the ENABLE_MEDIA_SOURCE feature define to 1 so the MediaSource API can be exposed in Chromium behind a command-line flag. 489465 1 112216 acolwell 2011-10-24 11:18:04 -0700 Created attachment 112216 Patch 489529 2 112216 webkit.review.bot 2011-10-24 12:28:12 -0700 Comment on attachment 112216 Patch Clearing flags on attachment: 112216 Committed r98266: <http://trac.webkit.org/changeset/98266> 489530 3 webkit.review.bot 2011-10-24 12:28:16 -0700 All reviewed patches have been landed. Closing bug. 489676 4 levin 2011-10-24 14:58:33 -0700 Broke the chromium build so rolled out. 489678 5 jchaffraix 2011-10-24 15:00:12 -0700 Here is the relevant part of the log: 12>webcore_bindings.lib(V8DerivedSources02.obj) : error LNK2001: unresolved external symbol "private: static bool WebCore::RuntimeEnabledFeatures::isMediaSourceEnabled" (?isMediaSourceEnabled@RuntimeEnabledFeatures@WebCore@@0_NA) 12>.\build\Release\TestWebKitAPI.exe : fatal error LNK1120: 1 unresolved externals 12>Build log was saved at "file://e:\google-windows-1\chromium-win-release\build\Source\WebKit\chromium\build\Release\obj\TestWebKitAPI\BuildLog.htm" 12>TestWebKitAPI - 2 error(s), 0 warning(s) 13>Linking... 14>webcore_bindings.lib(V8DerivedSources02.obj) : error LNK2001: unresolved external symbol "private: static bool WebCore::RuntimeEnabledFeatures::isMediaSourceEnabled" (?isMediaSourceEnabled@RuntimeEnabledFeatures@WebCore@@0_NA) 14>.\build\Release\DumpRenderTree.exe : fatal error LNK1120: 1 unresolved externals 14>Build log was saved at "file://e:\google-windows-1\chromium-win-release\build\Source\WebKit\chromium\build\Release\obj\DumpRenderTree\BuildLog.htm" 14>DumpRenderTree - 2 error(s), 0 warning(s) 13>webcore_bindings.lib(V8DerivedSources02.obj) : error LNK2001: unresolved external symbol "private: static bool WebCore::RuntimeEnabledFeatures::isMediaSourceEnabled" (?isMediaSourceEnabled@RuntimeEnabledFeatures@WebCore@@0_NA) 13>.\build\Release\webkit_unit_tests.exe : fatal error LNK1120: 1 unresolved externals 13>Build log was saved at "file://e:\google-windows-1\chromium-win-release\build\Source\WebKit\chromium\build\Release\obj\webkit_unit_tests\BuildLog.htm" 13>webkit_unit_tests - 2 error(s), 0 warning(s) Full log: http://build.webkit.org/builders/Chromium%20Win%20Release/builds/33707/steps/compile-webkit/logs/stdio 490260 6 112378 acolwell 2011-10-25 12:50:41 -0700 Created attachment 112378 Patch 490262 7 112378 acolwell 2011-10-25 12:52:06 -0700 Comment on attachment 112378 Patch reuploading the original patch. I believe the Windows build problems that caused it to get reverted was because Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp wasn't getting rebuilt by the Windows bots. 490287 8 112378 levin 2011-10-25 13:16:33 -0700 Comment on attachment 112378 Patch I'm not cq+ because I can't help if there are difficulties with landing this again. 491520 9 112378 webkit.review.bot 2011-10-27 06:31:43 -0700 Comment on attachment 112378 Patch Clearing flags on attachment: 112378 Committed r98562: <http://trac.webkit.org/changeset/98562> 491521 10 webkit.review.bot 2011-10-27 06:31:47 -0700 All reviewed patches have been landed. Closing bug. 112216 2011-10-24 11:18:04 -0700 2011-10-25 12:50:37 -0700 Patch bug-70745-20111024111803.patch text/plain 1182 acolwell U3VidmVyc2lvbiBSZXZpc2lvbjogOTgyNTYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg ZWFhMzI1MWQ0NTU5Y2M3NGQ3ZDY2YjkxNDI0ZjUxMDE1ZmVjMjgyMy4uYTZiMTY4ODFmY2Y3MTFi YjdlMTEwMWU2MDZmNzM5N2ZlZTQxMGMwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMiBAQAorMjAxMS0xMC0yNCAgQWFyb24gQ29sd2VsbCAgPGFjb2x3ZWxsQGNocm9t aXVtLm9yZz4KKworICAgICAgICBFbmFibGUgTUVESUFfU09VUkNFIGZlYXR1cmUgZm9yIENocm9t aXVtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDc0 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmVh dHVyZXMuZ3lwaToKKwogMjAxMS0xMC0yNCAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBhbGxvdyBkZWJ1Z2dpbmcgZGVkaWNh dGVkIHdvcmtlciBpbml0aWFsaXphdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9mZWF0dXJlcy5neXBpIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBp CmluZGV4IGRmNGE2OWRjZjc2YTcyYWJlOWE5Y2IxMWI3MmMyNGFmMDU1ZTdjMTQuLjczMTExZTJh NDZiNjg2ZWE1MDY2ZDJiMzUzNDNkNTAwMDk3MzRlNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2Zl YXR1cmVzLmd5cGkKQEAgLTYzLDYgKzYzLDcgQEAKICAgICAgICdFTkFCTEVfSkFWQVNDUklQVF9E RUJVR0dFUj0xJywKICAgICAgICdFTkFCTEVfSkFWQVNDUklQVF9JMThOX0FQST0xJywKICAgICAg ICdFTkFCTEVfTElOS19QUkVGRVRDSD0xJywKKyAgICAgICdFTkFCTEVfTUVESUFfU09VUkNFPTEn LAogICAgICAgJ0VOQUJMRV9NRURJQV9TVEFUSVNUSUNTPTEnLAogICAgICAgJ0VOQUJMRV9NRURJ QV9TVFJFQU09MScsCiAgICAgICAnRU5BQkxFX01FVEVSX1RBRz0xJywK 112378 2011-10-25 12:50:41 -0700 2011-10-27 06:31:42 -0700 Patch bug-70745-20111025125040.patch text/plain 1150 acolwell U3VidmVyc2lvbiBSZXZpc2lvbjogOTgzNzYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg NjY3NTkyYjVkMDFkYTIxMWRmZTEyNWM2NjM3ODYyNWExNzlkN2RhNi4uMjI2YmRhMDY2MjJhMTli NGJiNWIwNGYxNzBmZmQ2NjkyZjM2ZWIxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMiBAQAorMjAxMS0xMC0yNSAgQWFyb24gQ29sd2VsbCAgPGFjb2x3ZWxsQGNocm9t aXVtLm9yZz4KKworICAgICAgICBFbmFibGUgTUVESUFfU09VUkNFIGZlYXR1cmUgZm9yIENocm9t aXVtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDc0 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmVh dHVyZXMuZ3lwaToKKwogMjAxMS0xMC0yNSAgR2VuZSBHaXJhcmQgIDxnaXJhcmRAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJlLWVuYWJsZSB0b3VjaCB0ZXN0cyAoZnJvbSA2NjU3NykKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaSBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQppbmRleCBkZjRhNjlkY2Y3NmE3MmFiZTlhOWNiMTFi NzJjMjRhZjA1NWU3YzE0Li43MzExMWUyYTQ2YjY4NmVhNTA2NmQyYjM1MzQzZDUwMDA5NzM0ZTc1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkKKysrIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpCkBAIC02Myw2ICs2Myw3IEBACiAg ICAgICAnRU5BQkxFX0pBVkFTQ1JJUFRfREVCVUdHRVI9MScsCiAgICAgICAnRU5BQkxFX0pBVkFT Q1JJUFRfSTE4Tl9BUEk9MScsCiAgICAgICAnRU5BQkxFX0xJTktfUFJFRkVUQ0g9MScsCisgICAg ICAnRU5BQkxFX01FRElBX1NPVVJDRT0xJywKICAgICAgICdFTkFCTEVfTUVESUFfU1RBVElTVElD Uz0xJywKICAgICAgICdFTkFCTEVfTUVESUFfU1RSRUFNPTEnLAogICAgICAgJ0VOQUJMRV9NRVRF Ul9UQUc9MScsCg==