70726 2011-10-24 08:07:31 -0700 Web Inspector: fix empty line handling in source maps. 2011-10-25 07:26:15 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 podivilov podivilov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 489332 0 podivilov 2011-10-24 08:07:31 -0700 Web Inspector: fix empty line handling in source maps. 489333 1 112186 podivilov 2011-10-24 08:08:59 -0700 Created attachment 112186 Patch 490009 2 112186 yurys 2011-10-25 06:47:57 -0700 Comment on attachment 112186 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112186&action=review > Source/WebCore/inspector/front-end/CompilerSourceMapping.js:161 > + stringCharIterator.next(); I think you need to check hasNext() here and probably at line 156. > LayoutTests/inspector/debugger/compiler-source-mapping.html:81 > + "mappings":"AAAA;;;CACA", Add test for comma? 490029 3 podivilov 2011-10-25 07:26:15 -0700 Committed r98345: <http://trac.webkit.org/changeset/98345> 112186 2011-10-24 08:08:59 -0700 2011-10-25 06:47:57 -0700 Patch bug-70726-20111024190857.patch text/plain 4673 podivilov U3VidmVyc2lvbiBSZXZpc2lvbjogOTgxMDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2ZmFjMGMxMjc5NTFhMDdl NDE2NGFlNWE1OTU0OTE4ZjhhYTIxMmFlLi43MjViYTRiYzEwOWY1MTRmOTljNTY0YjA3N2JiMTgx ODM1ZDM0NTY3IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTAtMjQgIFBhdmVs IFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogZml4IGVtcHR5IGxpbmUgaGFuZGxpbmcgaW4gc291cmNlIG1hcHMuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDcyNgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVu ZC9Db21waWxlclNvdXJjZU1hcHBpbmcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ2xvc3Vy ZUNvbXBpbGVyU291cmNlTWFwcGluZy5wcm90b3R5cGUuX3BhcnNlTWFwcGluZ3MpOgorCiAyMDEx LTEwLTIxICBBbGVqYW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtjYWlyb10gRm9yd2FyZCBkZWNsYXJhdGlvbiBvZiBHcmFwaGljc0NvbnRleHRTdGF0ZSB1c2Vz IGNsYXNzIGluc3RlYWQgb2Ygc3RydWN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0NvbXBpbGVyU291cmNlTWFwcGluZy5qcyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvQ29tcGlsZXJTb3VyY2VNYXBwaW5nLmpzCmluZGV4IDY2YTU3 YjliZjY0Yjk4ODNmMTAzMjkzMmRiOTFmM2RkMDQ0MmI3YjQuLjc0Y2QxNmIyZTE1OGQzZTg2MTc0 NWMyOTYxZmZjYzdiZDBhZDM2ZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvQ29tcGlsZXJTb3VyY2VNYXBwaW5nLmpzCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvQ29tcGlsZXJTb3VyY2VNYXBwaW5nLmpzCkBAIC0xNTEsNyAr MTUxLDE5IEBAIFdlYkluc3BlY3Rvci5DbG9zdXJlQ29tcGlsZXJTb3VyY2VNYXBwaW5nLnByb3Rv dHlwZSA9IHsKICAgICAgICAgdmFyIHNvdXJjZVVSTCA9IHRoaXMuX3NvdXJjZXNbMF07CiAgICAg ICAgIHZhciByZXZlcnNlTWFwcGluZ3MgPSB0aGlzLl9yZXZlcnNlTWFwcGluZ3NCeVNvdXJjZVVS TFtzb3VyY2VVUkxdOwogCi0gICAgICAgIGRvIHsKKyAgICAgICAgd2hpbGUgKHRydWUpIHsKKyAg ICAgICAgICAgIGlmIChzdHJpbmdDaGFySXRlcmF0b3IucGVlaygpID09PSAiLCIpCisgICAgICAg ICAgICAgICAgc3RyaW5nQ2hhckl0ZXJhdG9yLm5leHQoKTsKKyAgICAgICAgICAgIGVsc2Ugewor ICAgICAgICAgICAgICAgIHdoaWxlIChzdHJpbmdDaGFySXRlcmF0b3IucGVlaygpID09PSAiOyIp IHsKKyAgICAgICAgICAgICAgICAgICAgbGluZU51bWJlciArPSAxOworICAgICAgICAgICAgICAg ICAgICBjb2x1bW5OdW1iZXIgPSAwOworICAgICAgICAgICAgICAgICAgICBzdHJpbmdDaGFySXRl cmF0b3IubmV4dCgpOworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICBpZiAoIXN0 cmluZ0NoYXJJdGVyYXRvci5oYXNOZXh0KCkpCisgICAgICAgICAgICAgICAgICAgIGJyZWFrOwor ICAgICAgICAgICAgfQorCiAgICAgICAgICAgICBjb2x1bW5OdW1iZXIgKz0gdGhpcy5fZGVjb2Rl VkxRKHN0cmluZ0NoYXJJdGVyYXRvcik7CiAgICAgICAgICAgICBpZiAoIXRoaXMuX2lzU2VwYXJh dG9yKHN0cmluZ0NoYXJJdGVyYXRvci5wZWVrKCkpKSB7CiAgICAgICAgICAgICAgICAgdmFyIHNv dXJjZUluZGV4RGVsdGEgPSB0aGlzLl9kZWNvZGVWTFEoc3RyaW5nQ2hhckl0ZXJhdG9yKTsKQEAg LTE2OSwxMiArMTgxLDcgQEAgV2ViSW5zcGVjdG9yLkNsb3N1cmVDb21waWxlclNvdXJjZU1hcHBp bmcucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgIGlmICghcmV2ZXJzZU1hcHBpbmdzW3Nv dXJjZUxpbmVOdW1iZXJdKQogICAgICAgICAgICAgICAgICAgICByZXZlcnNlTWFwcGluZ3Nbc291 cmNlTGluZU51bWJlcl0gPSBbbGluZU51bWJlciwgY29sdW1uTnVtYmVyXTsKICAgICAgICAgICAg IH0KLQotICAgICAgICAgICAgaWYgKHN0cmluZ0NoYXJJdGVyYXRvci5uZXh0KCkgPT09ICI7Iikg ewotICAgICAgICAgICAgICAgIGxpbmVOdW1iZXIgKz0gMTsKLSAgICAgICAgICAgICAgICBjb2x1 bW5OdW1iZXIgPSAwOwotICAgICAgICAgICAgfQotICAgICAgICB9IHdoaWxlKHN0cmluZ0NoYXJJ dGVyYXRvci5oYXNOZXh0KCkpOworICAgICAgICB9CiAgICAgfSwKIAogICAgIF9pc1NlcGFyYXRv cjogZnVuY3Rpb24oY2hhcikKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA2OGJlMzhiNjYxYTgxNDM5NWI5MmViYWQzMzE4YTg3 OGRjNmM2NTI0Li4wNTM2MzY3Y2FkNTI0M2Y3MzZhN2RlZjliYzQ5NzlkYTIzNWVhMmJlIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTAtMjQgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxv dkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogZml4IGVtcHR5IGxpbmUg aGFuZGxpbmcgaW4gc291cmNlIG1hcHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03MDcyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2RlYnVnZ2VyL2NvbXBpbGVyLXNvdXJjZS1tYXBw aW5nLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBpbnNwZWN0b3IvZGVidWdnZXIvY29tcGlsZXIt c291cmNlLW1hcHBpbmcuaHRtbDoKKwogMjAxMS0xMC0yMSAgQ2FyeSBDbGFyayAgPGNhcnljbGFy a0Bnb29nbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgZ2FyZGVuaW5nOiBmaXJzdCBjaHVu ayBvZiByZWJhc2VsaW5lcyBmb3IgQ2hyb21pdW0tU2tpYQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvaW5zcGVjdG9yL2RlYnVnZ2VyL2NvbXBpbGVyLXNvdXJjZS1tYXBwaW5nLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9jb21waWxlci1zb3VyY2UtbWFwcGlu Zy1leHBlY3RlZC50eHQKaW5kZXggNWY5NGExOTdjMmEzNDIwYWU1MjM0NmU2YjgyZjQzNzU5NmYy NzE2NS4uN2E5NGEyMTY0MjI1ZjFiMWEzMmRhYjMxMTdmNzhmOWE0YmI2YTM0MSAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2RlYnVnZ2VyL2NvbXBpbGVyLXNvdXJjZS1tYXBwaW5n LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZGVidWdnZXIvY29tcGls ZXItc291cmNlLW1hcHBpbmctZXhwZWN0ZWQudHh0CkBAIC01LDMgKzUsNSBAQCBSdW5uaW5nOiB0 ZXN0U2ltcGxlTWFwcGluZwogCiBSdW5uaW5nOiB0ZXN0Tm9NYXBwaW5nRW50cnkKIAorUnVubmlu ZzogdGVzdEVtcHR5TGluZQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZGVi dWdnZXIvY29tcGlsZXItc291cmNlLW1hcHBpbmcuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rv ci9kZWJ1Z2dlci9jb21waWxlci1zb3VyY2UtbWFwcGluZy5odG1sCmluZGV4IGIxZjY1ZTM3NTlh MmE2NGUzOGUyZTUxN2NiN2UzMWNkMGFlYjJlZjEuLjUwNzc3ZTQxOGNkYTg1OGI1N2JhOGI4ZWE1 OGFiYTY5YWMyOTUyNTAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dl ci9jb21waWxlci1zb3VyY2UtbWFwcGluZy5odG1sCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rv ci9kZWJ1Z2dlci9jb21waWxlci1zb3VyY2UtbWFwcGluZy5odG1sCkBAIC03Myw2ICs3MywxOCBA QCBmdW5jdGlvbiB0ZXN0KCkKICAgICAgICAgICAgIGNoZWNrTWFwcGluZygwLCAwLCAiZXhhbXBs ZS5qcyIsIDAsIDAsIG1hcHBpbmcpOwogICAgICAgICAgICAgY2hlY2tNYXBwaW5nKDAsIDIsICJl eGFtcGxlLmpzIiwgMCwgMiwgbWFwcGluZyk7CiAgICAgICAgICAgICBuZXh0KCk7CisgICAgICAg IH0sCisKKyAgICAgICAgZnVuY3Rpb24gdGVzdEVtcHR5TGluZShuZXh0KQorICAgICAgICB7Cisg ICAgICAgICAgICB2YXIgbWFwcGluZ1BheWxvYWQgPSB7CisgICAgICAgICAgICAgICAgIm1hcHBp bmdzIjoiQUFBQTs7O0NBQ0EiLAorICAgICAgICAgICAgICAgICJzb3VyY2VzIjpbImV4YW1wbGUu anMiXQorICAgICAgICAgICAgfTsKKyAgICAgICAgICAgIHZhciBtYXBwaW5nID0gbmV3IFdlYklu c3BlY3Rvci5DbG9zdXJlQ29tcGlsZXJTb3VyY2VNYXBwaW5nKG1hcHBpbmdQYXlsb2FkKTsKKyAg ICAgICAgICAgIGNoZWNrTWFwcGluZygwLCAwLCAiZXhhbXBsZS5qcyIsIDAsIDAsIG1hcHBpbmcp OworICAgICAgICAgICAgY2hlY2tSZXZlcnNlTWFwcGluZygzLCAxLCAiZXhhbXBsZS5qcyIsIDEs IG1hcHBpbmcpOworICAgICAgICAgICAgbmV4dCgpOwogICAgICAgICB9CiAgICAgXSk7CiB9Owo=