70725 2011-10-24 08:00:03 -0700 [Qt][WK2] Crash when running pixel tests 2011-10-24 10:33:28 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kbalazs kbalazs oldest_to_newest 489331 0 kbalazs 2011-10-24 08:00:03 -0700 Linux, 64-bit, up-to-date qt5. #0 0x00007f14d526f509 in memcpy () from /lib64/libc.so.6 #1 0x00007f14d62b5849 in MD5Update (ctx=0x764188, buf=0xc3cff0 "", len=2304) at tools/../../3rdparty/md5/md5.cpp:95 #2 0x00007f14d62b8b27 in QCryptographicHash::addData (this=0x7fff5f3ec840, data= 0x9cc8f0 "\377\377\377\377... #3 0x00000000004096ea in WTR::TestInvocation::dumpPixelsAndCompareWithExpected(OpaqueWKImage const*, OpaqueWKArray const*) () #4 0x000000000040c140 in WTR::TestInvocation::didReceiveMessageFromInjectedBundle(OpaqueWKString const*, void const*) () #5 0x00007f14d986d71e in WebKit::WebContextInjectedBundleClient::didReceiveMessageFromInjectedBundle(WebKit::WebContext*, WTF::String const&, WebKit::APIObject*) () from /home/balazs/work/master_clean/wk2BUild/Release/bin/../lib/libQtWebKit.so.4 489397 1 kbalazs 2011-10-24 10:07:50 -0700 Oops, my fault in http://trac.webkit.org/changeset/94524: hash.addData(reinterpret_cast<const char*>(image.constScanLine(row)), image.width() * image.bytesPerLine()); |width * bytesperline| is a bit too much ... 489403 2 112207 kbalazs 2011-10-24 10:13:23 -0700 Created attachment 112207 Patch 489407 3 112207 cshu 2011-10-24 10:19:33 -0700 Comment on attachment 112207 Patch Just curious how this worked before. In addition, bytesPerLine sounds like it has taken width into consideration. 489408 4 112207 cshu 2011-10-24 10:21:17 -0700 Comment on attachment 112207 Patch sorry, i thought the code was added but it was removed. r=me. 489415 5 112207 kbalazs 2011-10-24 10:32:03 -0700 Comment on attachment 112207 Patch Clearing flags on attachment: 112207 Committed r98252: <http://trac.webkit.org/changeset/98252> 489416 6 kbalazs 2011-10-24 10:32:10 -0700 All reviewed patches have been landed. Closing bug. 489418 7 kbalazs 2011-10-24 10:33:28 -0700 (In reply to comment #4) > (From update of attachment 112207 [details]) > sorry, i thought the code was added but it was removed. r=me. Sure, the value we passed was way too high, but sometimes it was working well with memory garbage :) Thanks for the review. 112207 2011-10-24 10:13:23 -0700 2011-10-24 10:32:03 -0700 Patch bug-70725-20111024191321.patch text/plain 1556 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogOTgyMzQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2NGM2OWI3OTcwZjY2MWRhYmZjMDA5ZjRjMGQ4OGFhYjdl MzU4ZjZhLi5lYThmNzcyYzYyNjE2ZGZhNDMwOTEyYzNiNWY3OTg5YTc0NzRhNjA1IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMTAtMjQgIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgorCisg ICAgICAgIFtRdF1bV0syXSBDcmFzaCB3aGVuIHJ1bm5pbmcgcGl4ZWwgdGVzdHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwNzI1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVy L3F0L1Rlc3RJbnZvY2F0aW9uUXQuY3BwOgorICAgICAgICAoV1RSOjpUZXN0SW52b2NhdGlvbjo6 ZHVtcFBpeGVsc0FuZENvbXBhcmVXaXRoRXhwZWN0ZWQpOgorCiAyMDExLTEwLTI0ICBBbGVqYW5k cm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXSzJdIFtHVEtdIFdl YktpdFRlc3RSdW5uZXIgY3Jhc2hlcyB3aXRoIGhlYXAgY29ycnVwdGlvbgpkaWZmIC0tZ2l0IGEv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9UZXN0SW52b2NhdGlvblF0LmNwcCBiL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvcXQvVGVzdEludm9jYXRpb25RdC5jcHAKaW5kZXggOGU1NWM4NTk3ZDkx ZDFhNmEwZmQ1MTQ4YWJhMzJjMjliNDkyZDZhOC4uMTYyMjM1ZTRhNWM3MWJiNTAzMWVjYjU1ZjQ4 OGIxMTE1ZGE1ZTVhNCAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9UZXN0 SW52b2NhdGlvblF0LmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL3F0L1Rlc3RJbnZv Y2F0aW9uUXQuY3BwCkBAIC02OCw3ICs2OCw3IEBAIHZvaWQgVGVzdEludm9jYXRpb246OmR1bXBQ aXhlbHNBbmRDb21wYXJlV2l0aEV4cGVjdGVkKFdLSW1hZ2VSZWYgaW1hZ2VSZWYsIFdLQXJyCiAg ICAgUUltYWdlIGltYWdlID0gV0tJbWFnZUNyZWF0ZVFJbWFnZShpbWFnZVJlZik7CiAgICAgUUNy eXB0b2dyYXBoaWNIYXNoIGhhc2goUUNyeXB0b2dyYXBoaWNIYXNoOjpNZDUpOwogICAgIGZvciAo dW5zaWduZWQgcm93ID0gMDsgcm93IDwgaW1hZ2UuaGVpZ2h0KCk7ICsrcm93KQotICAgICAgICBo YXNoLmFkZERhdGEocmVpbnRlcnByZXRfY2FzdDxjb25zdCBjaGFyKj4oaW1hZ2UuY29uc3RTY2Fu TGluZShyb3cpKSwgaW1hZ2Uud2lkdGgoKSAqIGltYWdlLmJ5dGVzUGVyTGluZSgpKTsKKyAgICAg ICAgaGFzaC5hZGREYXRhKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgY2hhcio+KGltYWdlLmNvbnN0 U2NhbkxpbmUocm93KSksIGltYWdlLmJ5dGVzUGVyTGluZSgpKTsKIAogICAgIFFCeXRlQXJyYXkg YWN0dWFsSGFzaCA9IGhhc2gucmVzdWx0KCkudG9IZXgoKTsKICAgICBBU1NFUlQoYWN0dWFsSGFz aC5zaXplKCkgPT0gMzIpOwo=