70693 2011-10-23 05:58:19 -0700 [Qt][WK2] QDesktopWebView and QTouchWebView should be declared in the meta type system. 2011-10-25 06:37:39 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 70315 1 zeno zeno webkit.review.bot oldest_to_newest 489012 0 zeno 2011-10-23 05:58:19 -0700 Without that we cannot use these types in the template based functions of the meta type system. (QVariant) If we instantiate a QDesktopWebView or a QTouchWebView in QML but want to acess it also in C++, then we need to ask the meta type system in c++ for the type of the object. 489013 1 112109 zeno 2011-10-23 06:05:22 -0700 Created attachment 112109 patch for review. is there a good reason why we should not do that? 489059 2 112109 vestbo 2011-10-23 12:49:16 -0700 Comment on attachment 112109 patch for review. Yepp, this is the place we should do it. But it should be QML_DECLARE_TYPE(QTouchWebView), to get the pointer automatically and cover the list-usecase. http://doc.qt.nokia.com/4.7-snapshot/qdeclarativeengine.html#QML_DECLARE_TYPE 489065 3 112125 zeno 2011-10-23 13:51:01 -0700 Created attachment 112125 patch for review. 489979 4 112125 hausmann 2011-10-25 05:31:08 -0700 Comment on attachment 112125 patch for review. r=me 490001 5 112125 webkit.review.bot 2011-10-25 06:37:36 -0700 Comment on attachment 112125 patch for review. Clearing flags on attachment: 112125 Committed r98337: <http://trac.webkit.org/changeset/98337> 490002 6 webkit.review.bot 2011-10-25 06:37:39 -0700 All reviewed patches have been landed. Closing bug. 112109 2011-10-23 06:05:22 -0700 2011-10-23 13:51:01 -0700 patch for review. 70693_20111023-150353.patch text/plain 1608 zeno ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4NDQ4OTgwLi45MGM3YjllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMTAtMjMgIFplbm8gQWxiaXNzZXIgIDx6ZW5vLmFsYmlzc2VyQG5va2lhLmNvbT4K KworICAgICAgICBbUXRdW1dLMl0gUURlc2t0b3BXZWJWaWV3IGFuZCBRVG91Y2hXZWJWaWV3IHNo b3VsZCBiZSBkZWNsYXJlZCBpbiB0aGUgbWV0YSB0eXBlIHN5c3RlbS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwNjkzCisKKyAgICAgICAgVGhpcyBj aGFuZ2UgYWxsb3dzIHVzIHRvIHVzZSB0aGUgdGVtcGxhdGUgYmFzZWQgZmVhdHVyZXMgb2YgdGhl IG1ldGEgdHlwZSBzeXN0ZW0KKyAgICAgICAgc3VjaCBhcyB1c2luZyB0aGUgV2ViVmlldyBjbGFz c2VzIGFzIHR5cGVzIGZvciBRVmFyaWFudC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcWRlc2t0b3B3ZWJ2aWV3Lmg6 CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xdG91Y2h3ZWJ2aWV3Lmg6CisKIDIwMTEtMTAt MjAgIFplbm8gQWxiaXNzZXIgIDx6ZW5vLmFsYmlzc2VyQG5va2lhLmNvbT4KIAogICAgICAgICBb UXRdW1dLMl0gUmV3cml0ZSBNaW5pQnJvd3NlciBpbiBRTUwKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcWRlc2t0b3B3ZWJ2aWV3LmggYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL3F0L3FkZXNrdG9wd2Vidmlldy5oCmluZGV4IGQ5M2Q1ZDguLjJjM2Qx YzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcWRlc2t0b3B3 ZWJ2aWV3LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xZGVza3RvcHdl YnZpZXcuaApAQCAtMTMxLDYgKzEzMSw3IEBAIHByaXZhdGU6CiAgICAgUURlc2t0b3BXZWJWaWV3 UHJpdmF0ZSAqZDsKIH07CiAKK1FfREVDTEFSRV9NRVRBVFlQRShRRGVza3RvcFdlYlZpZXcqKQog UV9ERUNMQVJFX01FVEFUWVBFKFFEZXNrdG9wV2ViVmlldzo6TmF2aWdhdGlvblBvbGljeSkKIAog I2VuZGlmIC8qIHFkZXNrdG9wd2Vidmlld19oICovCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL3F0L3F0b3VjaHdlYnZpZXcuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvcXQvcXRvdWNod2Vidmlldy5oCmluZGV4IDA1OTQyNmUuLmZhZTg4ZGEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXRvdWNod2Vidmlldy5oCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXRvdWNod2Vidmlldy5oCkBAIC01 NCw0ICs1NCw2IEBAIHByaXZhdGU6CiAgICAgUVRvdWNoV2ViVmlld1ByaXZhdGUgKmQ7CiB9Owog CitRX0RFQ0xBUkVfTUVUQVRZUEUoUVRvdWNoV2ViVmlldyopCisKICNlbmRpZiAvKiBxdG91Y2h3 ZWJ2aWV3X2ggKi8K 112125 2011-10-23 13:51:01 -0700 2011-10-25 06:37:35 -0700 patch for review. 70693_20111023-223220.patch text/plain 1639 zeno ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiMDU5ZTNlLi5iNmFkM2EwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMTAtMjMgIFplbm8gQWxiaXNzZXIgIDx6ZW5vLmFsYmlzc2VyQG5va2lhLmNvbT4K KworICAgICAgICBbUXRdW1dLMl0gUURlc2t0b3BXZWJWaWV3IGFuZCBRVG91Y2hXZWJWaWV3IHNo b3VsZCBiZSBkZWNsYXJlZCBpbiB0aGUgbWV0YSB0eXBlIHN5c3RlbS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwNjkzCisKKyAgICAgICAgVGhpcyBj aGFuZ2UgYWxsb3dzIHVzIHRvIHVzZSB0aGUgdGVtcGxhdGUgYmFzZWQgZmVhdHVyZXMgb2YgdGhl IG1ldGEgdHlwZSBzeXN0ZW0KKyAgICAgICAgc3VjaCBhcyB1c2luZyB0aGUgV2ViVmlldyBjbGFz c2VzIGFzIHR5cGVzIGZvciBRVmFyaWFudC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcWRlc2t0b3B3ZWJ2aWV3Lmg6 CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xdG91Y2h3ZWJ2aWV3Lmg6CisKIDIwMTEtMTAt MjAgIFplbm8gQWxiaXNzZXIgIDx6ZW5vLmFsYmlzc2VyQG5va2lhLmNvbT4KIAogICAgICAgICBb UXRdW1dLMl0gRGlzYWJsZSBDb250ZXh0IE1lbnVzIHVudGlsIHdlIGhhdmUgYSBwcm9wZXIgUU1M IGltcGxlbWVudGF0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3FkZXNrdG9wd2Vidmlldy5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9x ZGVza3RvcHdlYnZpZXcuaAppbmRleCBkOTNkNWQ4Li41YmZmZjdjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FkZXNrdG9wd2Vidmlldy5oCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcWRlc2t0b3B3ZWJ2aWV3LmgKQEAgLTEzMSw2ICsx MzEsNyBAQCBwcml2YXRlOgogICAgIFFEZXNrdG9wV2ViVmlld1ByaXZhdGUgKmQ7CiB9OwogCitR TUxfREVDTEFSRV9UWVBFKFFEZXNrdG9wV2ViVmlldykKIFFfREVDTEFSRV9NRVRBVFlQRShRRGVz a3RvcFdlYlZpZXc6Ok5hdmlnYXRpb25Qb2xpY3kpCiAKICNlbmRpZiAvKiBxZGVza3RvcHdlYnZp ZXdfaCAqLwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xdG91 Y2h3ZWJ2aWV3LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F0b3VjaHdlYnZp ZXcuaAppbmRleCAwNTk0MjZlLi4zZTZiNTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL3F0L3F0b3VjaHdlYnZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL3F0L3F0b3VjaHdlYnZpZXcuaApAQCAtNTQsNCArNTQsNiBAQCBwcml2YXRlOgog ICAgIFFUb3VjaFdlYlZpZXdQcml2YXRlICpkOwogfTsKIAorUU1MX0RFQ0xBUkVfVFlQRShRVG91 Y2hXZWJWaWV3KQorCiAjZW5kaWYgLyogcXRvdWNod2Vidmlld19oICovCg==