70672 2011-10-21 23:32:20 -0700 Make relayout-nested-positioned-elements-crash.html more reliable 2011-10-22 18:21:31 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin kenneth oldest_to_newest 488890 0 benjamin 2011-10-21 23:32:20 -0700 The test relayout-nested-positioned-elements-crash.html is flaky when executing WebCore asynchronously. The reason is the test written in a weird way. In the follow code, the code of runTest() _cannot_ be executed in order for the test to succeed. In the test result, the PASS is followed by a whitespace. That whitespace is what the TextIterator output for the input element, because it still has a renderer, because runTest() was never executed. If you execute WebCore asynchronously from the test runner, the function runTest() may or may not be run, causing the test to be flaky. <p>This tests that we don't cause an assertion failure on relayout of nested positioned elements. This test PASSED if we don't cause an assertion failure.</p> <div style="position:absolute"> <span style="position:relative"> PASS <div style="position:absolute"> <input id="hideMe"/> </div> </span> </div> <script> window.setTimeout(runTest, 0); // For some reason we need the setTimeout() for this test to work. function runTest() { document.getElementById("hideMe").style.display = "none"; } Assuming the test is correct, we should rewrite it in a way that is more reliable. 488894 1 112079 benjamin 2011-10-21 23:38:23 -0700 Created attachment 112079 Patch 488929 2 112079 kenneth 2011-10-22 06:25:10 -0700 Comment on attachment 112079 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112079&action=review I see this as an improvement, but I have a few comments. > LayoutTests/ChangeLog:9 > + Change the test to use the Javascript test framework. > + Ensure the element has the correct style in the final state. Any comment on why or when it was unreliable? > LayoutTests/fast/block/positioning/relayout-nested-positioned-elements-crash.html:17 > +description("This tests that we don't cause an assertion failure on relayout of nested positioned elements. This test pass if we don't cause an assertion failure."); and the element has the correct style in the final state. ? 488930 3 kenneth 2011-10-22 06:28:21 -0700 The description is comment 1 is pretty good and could be summarized in the ChangeLog. 488974 4 benjamin 2011-10-22 17:48:27 -0700 Committed r98197: <http://trac.webkit.org/changeset/98197> 112079 2011-10-21 23:38:23 -0700 2011-10-22 18:21:31 -0700 Patch bug-70672-20111021233821.patch text/plain 3788 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogOTc3MjMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBiYThmZjlmMWRmMDNhYTE2MjMxMGQ2 ZjI4MzQ2YTVmM2FmZDliNTkwLi4wODJkYmVhMDk2YjI2YjkzNGM3NDM2MjIxNDhhZjkyNjRjOWQ1 YjY3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTAtMjEgIEJlbmphbWluIFBvdWxhaW4g IDxiZW5qYW1pbkB3ZWJraXQub3JnPgorCisgICAgICAgIE1ha2UgcmVsYXlvdXQtbmVzdGVkLXBv c2l0aW9uZWQtZWxlbWVudHMtY3Jhc2guaHRtbCBtb3JlIHJlbGlhYmxlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDY3MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZSB0aGUgdGVzdCB0byB1c2Ug dGhlIEphdmFzY3JpcHQgdGVzdCBmcmFtZXdvcmsuCisgICAgICAgIEVuc3VyZSB0aGUgZWxlbWVu dCBoYXMgdGhlIGNvcnJlY3Qgc3R5bGUgaW4gdGhlIGZpbmFsIHN0YXRlLgorCisgICAgICAgICog ZmFzdC9ibG9jay9wb3NpdGlvbmluZy9yZWxheW91dC1uZXN0ZWQtcG9zaXRpb25lZC1lbGVtZW50 cy1jcmFzaC1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9ibG9jay9wb3NpdGlvbmluZy9y ZWxheW91dC1uZXN0ZWQtcG9zaXRpb25lZC1lbGVtZW50cy1jcmFzaC5odG1sOgorCiAyMDExLTEw LTE3ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAg ICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByOTc2NjkuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9mYXN0L2Jsb2NrL3Bvc2l0aW9uaW5nL3JlbGF5b3V0LW5lc3RlZC1wb3NpdGlvbmVkLWVsZW1l bnRzLWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvYmxvY2svcG9zaXRpb25p bmcvcmVsYXlvdXQtbmVzdGVkLXBvc2l0aW9uZWQtZWxlbWVudHMtY3Jhc2gtZXhwZWN0ZWQudHh0 CmluZGV4IGM5ZGYxODk0M2M1MjgxZmNhMmVkODc2Zjg0ZTc3YzcxMzc2NmE5YTcuLjA2NjYxYjlh Y2QwMDE4ZWEyNmI2ZmE3MmUzYzNmOWE2MzRkYjQyNWYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L2Zhc3QvYmxvY2svcG9zaXRpb25pbmcvcmVsYXlvdXQtbmVzdGVkLXBvc2l0aW9uZWQtZWxlbWVu dHMtY3Jhc2gtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvYmxvY2svcG9zaXRp b25pbmcvcmVsYXlvdXQtbmVzdGVkLXBvc2l0aW9uZWQtZWxlbWVudHMtY3Jhc2gtZXhwZWN0ZWQu dHh0CkBAIC0xLDMgKzEsMTAgQEAKLVRoaXMgdGVzdHMgdGhhdCB3ZSBkb24ndCBjYXVzZSBhbiBh c3NlcnRpb24gZmFpbHVyZSBvbiByZWxheW91dCBvZiBuZXN0ZWQgcG9zaXRpb25lZCBlbGVtZW50 cy4gVGhpcyB0ZXN0IFBBU1NFRCBpZiB3ZSBkb24ndCBjYXVzZSBhbiBhc3NlcnRpb24gZmFpbHVy ZS4KK1RoaXMgdGVzdHMgdGhhdCB3ZSBkb24ndCBjYXVzZSBhbiBhc3NlcnRpb24gZmFpbHVyZSBv biByZWxheW91dCBvZiBuZXN0ZWQgcG9zaXRpb25lZCBlbGVtZW50cy4gVGhpcyB0ZXN0IHBhc3Mg aWYgd2UgZG9uJ3QgY2F1c2UgYW4gYXNzZXJ0aW9uIGZhaWx1cmUuCisKK09uIHN1Y2Nlc3MsIHlv dSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNU IENPTVBMRVRFIi4KKworCitQQVNTIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJoaWRlTWUiKS5z dHlsZS5kaXNwbGF5IGlzICJub25lIgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQor CitURVNUIENPTVBMRVRFCiAKLVBBU1MgCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Js b2NrL3Bvc2l0aW9uaW5nL3JlbGF5b3V0LW5lc3RlZC1wb3NpdGlvbmVkLWVsZW1lbnRzLWNyYXNo Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Jsb2NrL3Bvc2l0aW9uaW5nL3JlbGF5b3V0LW5lc3Rl ZC1wb3NpdGlvbmVkLWVsZW1lbnRzLWNyYXNoLmh0bWwKaW5kZXggOWJmM2E4MGIwNmM1NWY2ZTRl NWNjYWE0MmJiYjJjNzBiYzBjNzI4MC4uMzdjZDVkYzk2ZGE2ZDM5MmY4ZTI0MmQ3ZTQzMDUyYTNi NGQwZDQ1OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9ibG9jay9wb3NpdGlvbmluZy9y ZWxheW91dC1uZXN0ZWQtcG9zaXRpb25lZC1lbGVtZW50cy1jcmFzaC5odG1sCisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvYmxvY2svcG9zaXRpb25pbmcvcmVsYXlvdXQtbmVzdGVkLXBvc2l0aW9uZWQt ZWxlbWVudHMtY3Jhc2guaHRtbApAQCAtMSwyNyArMSwzNiBAQAogPGh0bWw+CiA8aGVhZD4KLTx0 aXRsZT5UZXN0IGNhc2UgZm9yIGJ1ZyA2NDI4NjwvdGl0bGU+Ci08c2NyaXB0PgotaWYgKHdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlcikKLSAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNU ZXh0KCk7Ci08L3NjcmlwdD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vLi4vanMv cmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9mYXN0 L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+CiA8L2hlYWQ+CiA8Ym9keT4K LTxwPlRoaXMgdGVzdHMgdGhhdCB3ZSBkb24ndCBjYXVzZSBhbiBhc3NlcnRpb24gZmFpbHVyZSBv biByZWxheW91dCBvZiBuZXN0ZWQgcG9zaXRpb25lZCBlbGVtZW50cy4gVGhpcyB0ZXN0IFBBU1NF RCBpZiB3ZSBkb24ndCBjYXVzZSBhbiBhc3NlcnRpb24gZmFpbHVyZS48L3A+Cis8cCBpZD0iZGVz Y3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgogPGRpdiBzdHlsZT0icG9z aXRpb246YWJzb2x1dGUiPgogICAgIDxzcGFuIHN0eWxlPSJwb3NpdGlvbjpyZWxhdGl2ZSI+Ci0g ICAgICAgIFBBU1MKICAgICAgICAgPGRpdiBzdHlsZT0icG9zaXRpb246YWJzb2x1dGUiPgogICAg ICAgICAgICAgPGlucHV0IGlkPSJoaWRlTWUiLz4KICAgICAgICAgPC9kaXY+CiAgICAgPC9zcGFu PgogPC9kaXY+CiA8c2NyaXB0PgorZGVzY3JpcHRpb24oIlRoaXMgdGVzdHMgdGhhdCB3ZSBkb24n dCBjYXVzZSBhbiBhc3NlcnRpb24gZmFpbHVyZSBvbiByZWxheW91dCBvZiBuZXN0ZWQgcG9zaXRp b25lZCBlbGVtZW50cy4gVGhpcyB0ZXN0IHBhc3MgaWYgd2UgZG9uJ3QgY2F1c2UgYW4gYXNzZXJ0 aW9uIGZhaWx1cmUuIik7Cit3aW5kb3cuanNUZXN0SXNBc3luYyA9IHRydWU7CisKIHdpbmRvdy5z ZXRUaW1lb3V0KHJ1blRlc3QsIDApOyAvLyBGb3Igc29tZSByZWFzb24gd2UgbmVlZCB0aGUgc2V0 VGltZW91dCgpIGZvciB0aGlzIHRlc3QgdG8gd29yay4KIGZ1bmN0aW9uIHJ1blRlc3QoKQogewog ICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJoaWRlTWUiKS5zdHlsZS5kaXNwbGF5ID0gIm5v bmUiOworICAgIHdpbmRvdy5zZXRUaW1lb3V0KGZpbmFsaXplVGV4dCwgMCk7Cit9CisKK2Z1bmN0 aW9uIGZpbmFsaXplVGV4dCgpCit7CisgICAgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKyAg ICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoJ2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJoaWRlTWUi KS5zdHlsZS5kaXNwbGF5JywgJ25vbmUnKTsKKyAgICBmaW5pc2hKU1Rlc3QoKTsKIH0KIDwvc2Ny aXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwv c2NyaXB0PgogPC9ib2R5PgogPC9odG1sPgo=