70657 2011-10-21 15:54:54 -0700 watchlist for WebIDL shouldn't trigger on Internals.idl 2011-11-04 13:49:13 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth levin ojan webkit.review.bot oldest_to_newest 488740 0 abarth 2011-10-21 15:54:54 -0700 watchlist for WebIDL shouldn't trigger on Internals.idl 496406 1 113702 abarth 2011-11-04 13:20:13 -0700 Created attachment 113702 Patch 496415 2 113702 levin 2011-11-04 13:30:11 -0700 Comment on attachment 113702 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113702&action=review > Tools/Scripts/webkitpy/common/config/watchlist:35 > + "filename": r"Source/WebCore/(?!inspector)(?!testing).*\.idl" Why testing when the bug is about Internals.idl ? 496417 3 113702 levin 2011-11-04 13:30:58 -0700 Comment on attachment 113702 Patch oh I get it. This bug is really about not trigger for test file idl changes. ok. 496440 4 113702 webkit.review.bot 2011-11-04 13:49:08 -0700 Comment on attachment 113702 Patch Clearing flags on attachment: 113702 Committed r99314: <http://trac.webkit.org/changeset/99314> 496442 5 webkit.review.bot 2011-11-04 13:49:13 -0700 All reviewed patches have been landed. Closing bug. 113702 2011-11-04 13:20:13 -0700 2011-11-04 13:49:08 -0700 Patch bug-70657-20111104132011.patch text/plain 1261 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk5MzEwKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTQgQEAKKzIwMTEtMTEtMDQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICB3YXRjaGxpc3QgZm9yIFdlYklETCBzaG91bGRuJ3QgdHJpZ2dlciBvbiBJbnRlcm5h bHMuaWRsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 MDY1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElu dGVybmFscy5pZGwgaXNuJ3QgcGFydCBvZiB0aGUgV2ViLWZhY2luZyBJREwgaW4gdGhlIHByb2pl Y3QuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvd2F0Y2hsaXN0 OgorCiAyMDExLTExLTA0ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAK ICAgICAgICAgRml4IFdLVFIgY3Jhc2ggd2hlbiBydW5uaW5nIE5QTl9Db252ZXJ0UG9pbnQgdGVz dC4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy93YXRjaGxpc3QK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3dhdGNo bGlzdAkocmV2aXNpb24gOTkyOTUpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9j b25maWcvd2F0Y2hsaXN0CSh3b3JraW5nIGNvcHkpCkBAIC0zMiw3ICszMiw3IEBACiAgICAgICAg ICAgICAiZmlsZW5hbWUiOiByIlNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci8iLAogICAgICAgICB9LAogICAgICAgICAiV2ViSURMIjogewotICAgICAgICAgICAgImZp bGVuYW1lIjogciJTb3VyY2UvV2ViQ29yZS8oPyFpbnNwZWN0b3IpLipcLmlkbCIKKyAgICAgICAg ICAgICJmaWxlbmFtZSI6IHIiU291cmNlL1dlYkNvcmUvKD8haW5zcGVjdG9yKSg/IXRlc3Rpbmcp LipcLmlkbCIKICAgICAgICAgfSwKICAgICAgICAgIlRocmVhZGluZ0ZpbGVzIjogewogICAgICAg ICAgICAgImZpbGVuYW1lIjogciJTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZFNwZWNp ZmljXC4iCg==