70626 2011-10-21 11:35:30 -0700 Flush denormals in Biquad, ZeroPole, and DynamicsCompressor 2011-10-21 14:03:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rtoy rtoy crogers kbr rtoy webkit.review.bot oldest_to_newest 488532 0 rtoy 2011-10-21 11:35:30 -0700 Flush denormals in Biquad, ZeroPole, and DynamicsCompressor 488533 1 111996 rtoy 2011-10-21 11:38:13 -0700 Created attachment 111996 Patch 488538 2 rtoy 2011-10-21 11:44:53 -0700 This is an extension of the previous patch for flushing denormals. Chris suggested that the Biquad, ZeroPole, and DynamicsCompressor have the state variables checked for denormals and flushed so that they don't propagate further within the class. 488544 3 crogers 2011-10-21 11:57:20 -0700 This looks fine to me. 488576 4 111996 kbr 2011-10-21 12:53:00 -0700 Comment on attachment 111996 Patch Looks fine. 488644 5 111996 webkit.review.bot 2011-10-21 14:03:49 -0700 Comment on attachment 111996 Patch Clearing flags on attachment: 111996 Committed r98144: <http://trac.webkit.org/changeset/98144> 488645 6 webkit.review.bot 2011-10-21 14:03:56 -0700 All reviewed patches have been landed. Closing bug. 111996 2011-10-21 11:38:13 -0700 2011-10-21 14:03:49 -0700 Patch bug-70626-20111021113812.patch text/plain 4374 rtoy U3VidmVyc2lvbiBSZXZpc2lvbjogOTgwNzcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyZWEyZmM5YTJjMDMzODQx MDRkMDhlZWY5MTQzNDU4NWUzZTNiNDFhLi5kMTkxODhkMjhiODU1ZTZkZmI5NTMyMWNiNzc1Mjkz YjEyMmI4N2Y4IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTEtMTAtMjEgIFJheW1v bmQgVG95ICA8cnRveUBnb29nbGUuY29tPgorCisgICAgICAgIEZsdXNoIGRlbm9ybWFscyBpbiBC aXF1YWQsIFplcm9Qb2xlLCBhbmQgRHluYW1pY3NDb21wcmVzc29yLgorCisgICAgICAgIFdlIG9u bHkgZmx1c2ggd2hlbiBzYXZpbmcgdGhlIHN0YXRlIHZhcmlhYmxlcyBpbnN0ZWFkIG9mIGluIHRo ZQorICAgICAgICBsb29wcyBzbyB0aGF0IHdlIGRvbid0IGltcGFjdCBwZXJmb3JtYW5jZSB0b28g bXVjaCB3aGVuIHRoZXJlIGFyZQorICAgICAgICBubyBkZW5vcm1hbHMuICBUaGlzIHdpbGwgYXQg bGVhc3Qgbm90IHByb3BhZ2F0ZSB0aGUgZGVub3JtYWxzIGFueQorICAgICAgICBmdXJ0aGVyIHdp dGhpbiB0aGUgY2xhc3MuCisgICAgICAgIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzA2MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2F1ZGlvL0JpcXVhZC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpCaXF1YWQ6OnByb2Nlc3MpOgorICAgICAgICBGbHVzaCBkZW5vcm1hbHMgd2hlbiBz dG9yaW5nIHRoZSBmaWx0ZXIgc3RhdGUgYmFjayBpbiB0byBjbGFzcworICAgICAgICBmaWx0ZXIg c3RhdGUuICAKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9EeW5hbWljc0NvbXByZXNzb3JLZXJu ZWwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RHluYW1pY3NDb21wcmVzc29yS2VybmVsOjpwcm9j ZXNzKToKKyAgICAgICAgRGl0dG8uCisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vWmVyb1BvbGUu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6WmVyb1BvbGU6OnByb2Nlc3MpOgorICAgICAgICBEaXR0 by4KKwogMjAxMS0xMC0yMCAgUGV0ZXIgUnliaW4gIDxwZXRlci5yeWJpbkBnbWFpbC5jb20+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogcmVpbXBsZW1lbnQgcHJvdG9jb2wgYmFja2VuZC9mcm9u dGVuZCBzb3VyY2UgZ2VuZXJhdG9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9hdWRpby9CaXF1YWQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vQmlxdWFk LmNwcAppbmRleCBjNTFkNzMyNTFmNmZmZTU1OWMwN2EwOTAyY2I4MmRlYWY4Mjc4ZjVjLi4zNTY4 MTAyNzVmNjM4YTY4OTA0MzY2ODRiMDJmZThjY2Y0MDUyYTdjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9CaXF1YWQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2F1ZGlvL0JpcXVhZC5jcHAKQEAgLTMyLDYgKzMyLDcgQEAKIAogI2luY2x1ZGUgIkJp cXVhZC5oIgogCisjaW5jbHVkZSAiRGVub3JtYWxEaXNhYmxlci5oIgogI2luY2x1ZGUgPGFsZ29y aXRobT4KICNpbmNsdWRlIDxzdGRpby5oPgogI2luY2x1ZGUgPHd0Zi9NYXRoRXh0cmFzLmg+CkBA IC05NiwxMSArOTcsMTIgQEAgdm9pZCBCaXF1YWQ6OnByb2Nlc3MoY29uc3QgZmxvYXQqIHNvdXJj ZVAsIGZsb2F0KiBkZXN0UCwgc2l6ZV90IGZyYW1lc1RvUHJvY2VzcykKICAgICAgICAgeTEgPSB5 OwogICAgIH0KIAotICAgIC8vIExvY2FsIHZhcmlhYmxlcyBiYWNrIHRvIG1lbWJlcgotICAgIG1f eDEgPSB4MTsKLSAgICBtX3gyID0geDI7Ci0gICAgbV95MSA9IHkxOwotICAgIG1feTIgPSB5MjsK KyAgICAvLyBMb2NhbCB2YXJpYWJsZXMgYmFjayB0byBtZW1iZXIuIEZsdXNoIGRlbm9ybWFscyBo ZXJlIHNvIHdlCisgICAgLy8gZG9uJ3Qgc2xvdyBkb3duIHRoZSBpbm5lciBsb29wIGFib3ZlLgor ICAgIG1feDEgPSBEZW5vcm1hbERpc2FibGVyOjpmbHVzaERlbm9ybWFsRmxvYXRUb1plcm8oeDEp OworICAgIG1feDIgPSBEZW5vcm1hbERpc2FibGVyOjpmbHVzaERlbm9ybWFsRmxvYXRUb1plcm8o eDIpOworICAgIG1feTEgPSBEZW5vcm1hbERpc2FibGVyOjpmbHVzaERlbm9ybWFsRmxvYXRUb1pl cm8oeTEpOworICAgIG1feTIgPSBEZW5vcm1hbERpc2FibGVyOjpmbHVzaERlbm9ybWFsRmxvYXRU b1plcm8oeTIpOwogCiAgICAgbV9iMCA9IGIwOwogICAgIG1fYjEgPSBiMTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL0R5bmFtaWNzQ29tcHJlc3Nvcktlcm5lbC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9EeW5hbWljc0NvbXByZXNzb3JLZXJu ZWwuY3BwCmluZGV4IDIyMjljMzgxNWI1YmZkMjkwYWUxZmYxNWQzNTU0ZjVkZmIzMDcwM2UuLmU5 ZjQ5NmE1YmZhZTNmNGExZmJjNGE1YTRkNzhiYWU4ZmVkMzIwMTYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL0R5bmFtaWNzQ29tcHJlc3Nvcktlcm5lbC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vRHluYW1pY3NDb21wcmVzc29yS2VybmVs LmNwcApAQCAtMzMsNiArMzMsNyBAQAogI2luY2x1ZGUgIkR5bmFtaWNzQ29tcHJlc3Nvcktlcm5l bC5oIgogCiAjaW5jbHVkZSAiQXVkaW9VdGlsaXRpZXMuaCIKKyNpbmNsdWRlICJEZW5vcm1hbERp c2FibGVyLmgiCiAjaW5jbHVkZSA8YWxnb3JpdGhtPgogI2luY2x1ZGUgPHd0Zi9NYXRoRXh0cmFz Lmg+CiAKQEAgLTM1Miw4ICszNTMsOCBAQCB2b2lkIER5bmFtaWNzQ29tcHJlc3Nvcktlcm5lbDo6 cHJvY2VzcyhmbG9hdCogc291cmNlTCwKICAgICAgICAgICAgIC8vIExvY2FscyBiYWNrIHRvIG1l bWJlciB2YXJpYWJsZXMuCiAgICAgICAgICAgICBtX3ByZURlbGF5UmVhZEluZGV4ID0gcHJlRGVs YXlSZWFkSW5kZXg7CiAgICAgICAgICAgICBtX3ByZURlbGF5V3JpdGVJbmRleCA9IHByZURlbGF5 V3JpdGVJbmRleDsKLSAgICAgICAgICAgIG1fZGV0ZWN0b3JBdmVyYWdlID0gZGV0ZWN0b3JBdmVy YWdlOwotICAgICAgICAgICAgbV9jb21wcmVzc29yR2FpbiA9IGNvbXByZXNzb3JHYWluOworICAg ICAgICAgICAgbV9kZXRlY3RvckF2ZXJhZ2UgPSBEZW5vcm1hbERpc2FibGVyOjpmbHVzaERlbm9y bWFsRmxvYXRUb1plcm8oZGV0ZWN0b3JBdmVyYWdlKTsKKyAgICAgICAgICAgIG1fY29tcHJlc3Nv ckdhaW4gPSBEZW5vcm1hbERpc2FibGVyOjpmbHVzaERlbm9ybWFsRmxvYXRUb1plcm8oY29tcHJl c3NvckdhaW4pOwogICAgICAgICB9CiAgICAgfQogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vYXVkaW8vWmVyb1BvbGUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v YXVkaW8vWmVyb1BvbGUuY3BwCmluZGV4IDlkOTlhNGQ5MjBiZjdiMmQ4ODY1NjdkOTY1ODYyNmNm ZTIyZWIxMmYuLjJmYTQ0MDAzYTdhNTEwMGRlOTFiNzUwZjYxZjE3MTU1NDc1MmQzOGEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL1plcm9Qb2xlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9aZXJvUG9sZS5jcHAKQEAgLTMyLDYgKzMyLDgg QEAKIAogI2luY2x1ZGUgIlplcm9Qb2xlLmgiCiAKKyNpbmNsdWRlICJEZW5vcm1hbERpc2FibGVy LmgiCisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdm9pZCBaZXJvUG9sZTo6cHJvY2VzcyhmbG9h dCAqc291cmNlLCBmbG9hdCAqZGVzdGluYXRpb24sIHVuc2lnbmVkIGZyYW1lc1RvUHJvY2VzcykK QEAgLTYxLDkgKzYzLDEwIEBAIHZvaWQgWmVyb1BvbGU6OnByb2Nlc3MoZmxvYXQgKnNvdXJjZSwg ZmxvYXQgKmRlc3RpbmF0aW9uLCB1bnNpZ25lZCBmcmFtZXNUb1Byb2NlCiAgICAgICAgICpkZXN0 aW5hdGlvbisrID0gb3V0cHV0MjsKICAgICB9CiAgICAgCi0gICAgLy8gTG9jYWxzIHRvIG1lbWJl ciB2YXJpYWJsZXMuCi0gICAgbV9sYXN0WCA9IGxhc3RYOwotICAgIG1fbGFzdFkgPSBsYXN0WTsK KyAgICAvLyBMb2NhbHMgdG8gbWVtYmVyIHZhcmlhYmxlcy4gRmx1c2ggZGVub3JtYWxzIGhlcmUg c28gd2UgZG9uJ3QKKyAgICAvLyBzbG93IGRvd24gdGhlIGlubmVyIGxvb3AgYWJvdmUuCisgICAg bV9sYXN0WCA9IERlbm9ybWFsRGlzYWJsZXI6OmZsdXNoRGVub3JtYWxGbG9hdFRvWmVybyhsYXN0 WCk7CisgICAgbV9sYXN0WSA9IERlbm9ybWFsRGlzYWJsZXI6OmZsdXNoRGVub3JtYWxGbG9hdFRv WmVybyhsYXN0WSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK