70625 2011-10-21 11:15:12 -0700 check-webkit-style: Allow names starting with "_q_" used by Qt for private slots. 2011-11-01 04:36:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jturcotte jturcotte abarth levin ojan webkit.review.bot oldest_to_newest 488510 0 jturcotte 2011-10-21 11:15:12 -0700 check-webkit-style: Allow names starting with "_q_" used by Qt for private slots. 488513 1 111992 jturcotte 2011-10-21 11:16:32 -0700 Created attachment 111992 Patch 488516 2 111992 vestbo 2011-10-21 11:20:59 -0700 Comment on attachment 111992 Patch lgtm 488519 3 111992 webkit.review.bot 2011-10-21 11:23:17 -0700 Comment on attachment 111992 Patch Rejecting attachment 111992 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: cripts/webkitpy/common/system/executive.py", line 420, in run_command close_fds=self._should_close_fds()) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen return subprocess.Popen(*args, **kwargs) File "/usr/lib/python2.6/subprocess.py", line 623, in __init__ errread, errwrite) File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child raise child_exception TypeError: execv() arg 2 must contain only strings Full output: http://queues.webkit.org/results/10180981 493842 4 111992 jturcotte 2011-11-01 04:36:30 -0700 Comment on attachment 111992 Patch Clearing flags on attachment: 111992 Committed r98950: <http://trac.webkit.org/changeset/98950> 493843 5 jturcotte 2011-11-01 04:36:37 -0700 All reviewed patches have been landed. Closing bug. 111992 2011-10-21 11:16:32 -0700 2011-11-01 04:36:30 -0700 Patch bug-70625-20111021201611.patch text/plain 3367 jturcotte U3VidmVyc2lvbiBSZXZpc2lvbjogOTgxMDQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4ZTcyOTZhZGNlNWFiMmY1NmY0Nzc2ODRkOWQzZTI4YWYw MjM4ZjQ3Li5lOGU4NWU4NzM3MzI3Y2UyOTg4NzM5MjAwNzZjODNmMDJiOTQ3ZmYyIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTEtMTAtMjEgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQG5va2lh LmNvbT4KIAorICAgICAgICBjaGVjay13ZWJraXQtc3R5bGU6IEFsbG93IG5hbWVzIHN0YXJ0aW5n IHdpdGggIl9xXyIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03MDYyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFVzZWQgYnkgdGhlIFF0IHBvcnQgYXMgdGhlIHN0YW5kYXJkIHByZWZpeCBmb3IgcHJpdmF0 ZSBzbG90cy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3Bw LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0 ZXN0LnB5OgorCisyMDExLTEwLTIxICBKb2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0 ZUBub2tpYS5jb20+CisKICAgICAgICAgW1F0XSBJbXByb3ZlIGNvbW1hbmQgbGluZSBhcmd1bWVu dHMgaGFuZGxpbmcgZm9yIE1pbmlCcm93c2VyLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzA2MTYKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCA1NGIxNWQxOGViYTYzNjkxNDJlZDljZjA1YmVmOTBl YmQ2ZTliNGYzLi40MmVmMTA2ODNhNzM0ZjJjNDhhNjEyZjEzODc1MDQxZDYxZWVkMTQ0IDEwMDY0 NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAtMzA0Nywx MiArMzA0NywxNCBAQCBkZWYgY2hlY2tfaWRlbnRpZmllcl9uYW1lX2luX2RlY2xhcmF0aW9uKGZp bGVuYW1lLCBsaW5lX251bWJlciwgbGluZSwgZmlsZV9zdGF0ZQogICAgICAgICAgICAgICAgIGFu ZCBub3QgbW9kaWZpZWRfaWRlbnRpZmllci5zdGFydHN3aXRoKCdOUFBfJykKICAgICAgICAgICAg ICAgICBhbmQgbm90IG1vZGlmaWVkX2lkZW50aWZpZXIuc3RhcnRzd2l0aCgnTlBfJykKICAgICAg ICAgICAgICAgICBhbmQgbm90IG1vZGlmaWVkX2lkZW50aWZpZXIuc3RhcnRzd2l0aCgncXRfJykK KyAgICAgICAgICAgICAgICBhbmQgbm90IG1vZGlmaWVkX2lkZW50aWZpZXIuc3RhcnRzd2l0aCgn X3FfJykKICAgICAgICAgICAgICAgICBhbmQgbm90IG1vZGlmaWVkX2lkZW50aWZpZXIuc3RhcnRz d2l0aCgnY2Fpcm9fJykKICAgICAgICAgICAgICAgICBhbmQgbm90IG1vZGlmaWVkX2lkZW50aWZp ZXIuc3RhcnRzd2l0aCgnRWNvcmVfJykKICAgICAgICAgICAgICAgICBhbmQgbm90IG1vZGlmaWVk X2lkZW50aWZpZXIuc3RhcnRzd2l0aCgnRWluYV8nKQogICAgICAgICAgICAgICAgIGFuZCBub3Qg bW9kaWZpZWRfaWRlbnRpZmllci5zdGFydHN3aXRoKCdFdmFzXycpCiAgICAgICAgICAgICAgICAg YW5kIG5vdCBtb2RpZmllZF9pZGVudGlmaWVyLnN0YXJ0c3dpdGgoJ0V3a18nKQogICAgICAgICAg ICAgICAgIGFuZCBub3QgbW9kaWZpZWRfaWRlbnRpZmllci5maW5kKCc6OnF0XycpID49IDAKKyAg ICAgICAgICAgICAgICBhbmQgbm90IG1vZGlmaWVkX2lkZW50aWZpZXIuZmluZCgnOjpfcV8nKSA+ PSAwCiAgICAgICAgICAgICAgICAgYW5kIG5vdCBtb2RpZmllZF9pZGVudGlmaWVyID09ICJjb25z dF9pdGVyYXRvciIKICAgICAgICAgICAgICAgICBhbmQgbm90IG1vZGlmaWVkX2lkZW50aWZpZXIg PT0gInZtX3Rocm93Iik6CiAgICAgICAgICAgICAgICAgZXJyb3IobGluZV9udW1iZXIsICdyZWFk YWJpbGl0eS9uYW1pbmcnLCA0LCBpZGVudGlmaWVyICsgIiBpcyBpbmNvcnJlY3RseSBuYW1lZC4g RG9uJ3QgdXNlIHVuZGVyc2NvcmVzIGluIHlvdXIgaWRlbnRpZmllciBuYW1lcy4iKQpkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3Qu cHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5w eQppbmRleCAxMzA1ODhlYTVmMmMwZTRkOTQ2MTU4NGRiNjUzM2VhMjc3ZjBiNmMzLi5kYzczNjRk MDFmOTYyYzE4ZWJiZGU5OGYzZjczNDA0YzIyZDdhYTkxIDEwMDY0NAotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQpAQCAtNDQyMSw5 ICs0NDIxLDExIEBAIGNsYXNzIFdlYktpdFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAg ICAgICAgIyBUaGVyZSBpcyBhbiBleGNlcHRpb24gZm9yIHNvbWUgdW5pdCB0ZXN0cyB0aGF0IGJl Z2luIHdpdGggInRzdF8iLgogICAgICAgICBzZWxmLmFzc2VydF9saW50KCd2b2lkIHRzdF9RV2Vi RnJhbWU6OmFycmF5T2JqZWN0RW51bWVyYWJsZShpbnQgdmFyMSwgaW50IHZhcjIpJywgJycpCiAK LSAgICAgICAgIyBUaGUgUXQgQVBJIHVzZXMgbmFtZXMgdGhhdCBiZWdpbiB3aXRoICJxdF8iLgor ICAgICAgICAjIFRoZSBRdCBBUEkgdXNlcyBuYW1lcyB0aGF0IGJlZ2luIHdpdGggInF0XyIgb3Ig Il9xXyIuCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ3ZvaWQgUVRGcmFtZTo6cXRfZHJ0X2lz X2F3ZXNvbWUoaW50IHZhcjEsIGludCB2YXIyKScsICcnKQorICAgICAgICBzZWxmLmFzc2VydF9s aW50KCd2b2lkIFFURnJhbWU6Ol9xX2RydF9pc19hd2Vzb21lKGludCB2YXIxLCBpbnQgdmFyMikn LCAnJykKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgndm9pZCBxdF9kcnRfaXNfYXdlc29tZShp bnQgdmFyMSwgaW50IHZhcjIpOycsICcnKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCd2b2lk IF9xX2RydF9pc19hd2Vzb21lKGludCB2YXIxLCBpbnQgdmFyMik7JywgJycpCiAKICAgICAgICAg IyBDYWlybyBmb3J3YXJkLWRlY2xhcmF0aW9ucyBzaG91bGQgbm90IGJlIGEgZmFpbHVyZS4KICAg ICAgICAgc2VsZi5hc3NlcnRfbGludCgndHlwZWRlZiBzdHJ1Y3QgX2NhaXJvIGNhaXJvX3Q7Jywg JycpCg==