70619 2011-10-21 10:46:14 -0700 REGRESSION (r97496-r97499): 6 fast/workers tests failing on SnowLeopard Intel Release (Tests) 2011-12-09 18:27:04 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r97499%20(33907)/results.html LayoutTestFailure, MakingBotsRed, Regression P2 Normal --- 71695 1 simon.fraser levin ap atwilson dslomov fpizlo ggaren levin michaeln oliver sam simon.fraser webkit.review.bot oldest_to_newest 488479 0 simon.fraser 2011-10-21 10:46:14 -0700 The following tests started failing on SnowLeopard Intel Release (Tests) between r97497 and r97499 (inclusive): fast/workers/shared-worker-lifecycle.html fast/workers/shared-worker-frame-lifecycle.html fast/workers/storage/interrupt-database.html fast/workers/worker-close-more.html fast/workers/dedicated-worker-lifecycle.html fast/workers/worker-lifecycle.html http://trac.webkit.org/log/trunk?rev=97499&stop_rev=97497&limit=4 http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r97496%20(33906)/results.html passed http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r97499%20(33907)/results.html failed 488480 1 simon.fraser 2011-10-21 10:46:34 -0700 Please can you try to make these workers tests less flakey? They cause so much bot redness. 488497 2 levin 2011-10-21 11:01:28 -0700 Adding dslomov as fyi. I think Drew added most of these except for the interrupt-database one which I think Michael owns. I think everyone is booked at the moment but hopefully one of us will be able to look at this soon. 495075 3 simon.fraser 2011-11-02 17:10:06 -0700 We need to get these workers tests skipped, or passing. Their flakiness is not acceptable. 495078 4 levin 2011-11-02 17:14:41 -0700 Feel free to skip them unless someone volunteers to fix them (which doesn't look like it is happening at present). 495081 5 simon.fraser 2011-11-02 17:16:51 -0700 Skipped in http://trac.webkit.org/changeset/99125 495082 6 atwilson 2011-11-02 17:19:19 -0700 Yeah, if you look at the failures, they look to be DRT failures more than anything else. Looking at fast/workers/resources/worker-lifecycle.js: if (window.layoutTestController) { layoutTestController.dumpAsText(); layoutTestController.waitUntilDone(); waitUntilWorkerThreadsExit(runTests); } else { log("NOTE: Test relies on window.layoutTestController to detect when worker threads have exited. Please run this test via DumpRenderTree"); waitUntilWorkerThreadsExit(runTests); } function runTests() { if (window.layoutTestController) log("PASS: workerThreadCount = " + layoutTestController.workerThreadCount); I don't see how it's possible for the test output to be missing "PASS: workerThreadCount =" unless layoutTestController.workerThreadCount() just blocks. So, yeah, it'd be nice for someone to diagnose why DRT is not working with workers on the bots, but it doesn't specifically look like a failure in the worker code. 495087 7 levin 2011-11-02 17:22:59 -0700 I think all of these tests rely on waitUntilWorkerThreadsExit which to my memory is just plain flaky for jsc due to how garbage collection is done there. I think Drew Wilson tried to fix this but it was usually a form of let's try this because it is hard to force the gc to happen and recognize that an object is not referred to anymore. I bet they started failing due to all the gc changes that have been happening and I suspect that it isn't worth the trouble to keep them running on jsc. (I believe they work for v8 and this in turn will test the shared code in WebKit for this stuff which is the most important thing.) 495092 8 atwilson 2011-11-02 17:27:30 -0700 Still not 100% clear why we're not getting *any* output, but maybe if we get a timeout we don't dump the current text contents of the DOM (clearly my WebKit-fu is getting rusty). 495093 9 simon.fraser 2011-11-02 17:28:08 -0700 cc some JSC/GC folks. 516940 10 levin 2011-12-07 14:53:58 -0800 I bet this is the same as 71695. If so, this is related to changing to NRWT. After landing that fix, I'll unskip these and we'll see if they start passing, so I'll take this for now. 518497 11 118635 levin 2011-12-09 14:14:26 -0800 Created attachment 118635 Patch 518514 12 118635 ap 2011-12-09 14:23:46 -0800 Comment on attachment 118635 Patch This kind of change generally doesn't need review. 518721 13 118635 webkit.review.bot 2011-12-09 18:26:59 -0800 Comment on attachment 118635 Patch Clearing flags on attachment: 118635 Committed r102510: <http://trac.webkit.org/changeset/102510> 518722 14 webkit.review.bot 2011-12-09 18:27:04 -0800 All reviewed patches have been landed. Closing bug. 118635 2011-12-09 14:14:26 -0800 2011-12-09 18:26:59 -0800 Patch bug-70619-20111209141424.patch text/plain 1610 levin U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNDczCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNmUxYTE4N2U0OGI0MzNhMTlmZDc5 OGFlYzgzZjk2M2RjNjk3NzFhNy4uNWNhYjczNWY0YTA4MThmNWRlZTEzY2RiOWRjNjVkZjBlN2U2 MTEwZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDExLTEyLTA5ICBEYXZpZCBMZXZpbiAgPGxl dmluQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSRUdSRVNTSU9OIChyOTc0OTYtcjk3NDk5KTog NiBmYXN0L3dvcmtlcnMgdGVzdHMgZmFpbGluZyBvbiBTbm93TGVvcGFyZCBJbnRlbCBSZWxlYXNl IChUZXN0cykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTcwNjE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9tYWMvU2tpcHBlZDogVW5za2lwIHZhcmlvdXMgd29ya2VyIHRlc3RzIGFzIHRo ZXkgc2hvdWxkIHdvcmsKKyAgICAgICAgbm93IHRoYXQgYnVnIDcxNjk1IGlzIGZpeGVkLgorCisy MDExLTEyLTA5ICBEYXZpZCBMZXZpbiAgPGxldmluQGNocm9taXVtLm9yZz4KKwogICAgICAgICBS ZWdyZXNzaW9uKHI1MzU5NSk6IFN5bmMgeGhyIHJlcXVlc3RzIGluIHdvcmtlcnMgYXJlbid0IHRl cm1pbmF0ZWQgb24gd29ya2VyIGNsb3NlLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzE2OTUKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBlZAppbmRleCA4 NWJiNTYyYTdjNTBkNzY4ZGNmYmViYjVkNmVkZDI2Njk5NzhlYzg5Li5iYzIzNmYzYmRkMTY1Zjkx ZTYxYjMwMDVhNGFmMjIwNjgzYjBkM2Q0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBlZApAQCAt Mjg4LDE1ICsyODgsNiBAQCBmYXN0L2ZpbGVzL2FwcGx5LWJsb2ItdXJsLXRvLWltZy5odG1sCiAj IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTU3NQogZmFzdC9maWxl cy93b3JrZXJzCiAKLSMgVGhlc2Ugd29ya2VyIHRlc3RzIGFyZSBmYWlsaW5nIGFsbCB0aGUgdGlt ZQotIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzA2MTkKLWZhc3Qv d29ya2Vycy9zaGFyZWQtd29ya2VyLWxpZmVjeWNsZS5odG1sCi1mYXN0L3dvcmtlcnMvc2hhcmVk LXdvcmtlci1mcmFtZS1saWZlY3ljbGUuaHRtbAotZmFzdC93b3JrZXJzL3N0b3JhZ2UvaW50ZXJy dXB0LWRhdGFiYXNlLmh0bWwKLWZhc3Qvd29ya2Vycy93b3JrZXItY2xvc2UtbW9yZS5odG1sCi1m YXN0L3dvcmtlcnMvZGVkaWNhdGVkLXdvcmtlci1saWZlY3ljbGUuaHRtbAotZmFzdC93b3JrZXJz L3dvcmtlci1saWZlY3ljbGUuaHRtbAotCiAjIHZpZXdwb3J0IG1ldGEgdGFnIHN1cHBvcnQKIGZh c3Qvdmlld3BvcnQKIAo=