70618 2011-10-21 10:46:14 -0700 [chromium] Add isTraceEventEnabledForCategory to PlatformSupport. 2011-10-24 14:19:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 70620 1 nduca nduca fishd jamesr webkit.review.bot oldest_to_newest 488478 0 nduca 2011-10-21 10:46:14 -0700 [chromium] Add isTraceEventEnabledForCategory to PlatformSupport. 488481 1 111985 nduca 2011-10-21 10:47:07 -0700 Created attachment 111985 Patch 488487 2 webkit.review.bot 2011-10-21 10:50:08 -0700 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 488614 3 112011 nduca 2011-10-21 13:33:18 -0700 Created attachment 112011 Blanket enable instead of per-category 489201 4 112011 fishd 2011-10-23 23:27:21 -0700 Comment on attachment 112011 Blanket enable instead of per-category View in context: https://bugs.webkit.org/attachment.cgi?id=112011&action=review > Source/WebKit/chromium/public/WebKitPlatformSupport.h:233 > + virtual bool isTraceEventEnabled() const { return true; } actually, are you sure you don't want to invert this? it seems better to push settings down into webkit instead of making webkit ask the embedder each and every time via a virtual function call. most other things like this work by pushing a setting down into WebKit. see for example WebKit::setLayoutTestMode or WebKit::WebSecurityPolicy. perhaps this could be a method in WebKit.h? setTraceEventEnabled(bool)? it seems like a corresponding method could exist in TraceEvent.h. 489627 5 nduca 2011-10-24 14:05:02 -0700 You're totally right about inverting it. I investigated this a bit further and I think I know how we should do it. Unfortunately, doing that inversion means we also have to switch from having traceBegin/traceEnd to the addTraceEvent style. I filed a bug to do this, and I'm going to beg jbates to do it. :) https://bugs.webkit.org/show_bug.cgi?id=70761 489638 6 nduca 2011-10-24 14:19:26 -0700 Committed r98282: <http://trac.webkit.org/changeset/98282> 111985 2011-10-21 10:47:07 -0700 2011-10-21 13:33:15 -0700 Patch bug-70618-20111021104706.patch text/plain 3676 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogOTgwNzcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyZWEyZmM5YTJjMDMzODQx MDRkMDhlZWY5MTQzNDU4NWUzZTNiNDFhLi5hMDI2YjIxNjJhNGM2YWY1MTFkNmM3NWE4ZGEzYWZm NjYxMTFkOTE3IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMTAtMjEgIE5hdCBE dWNhICA8bmR1Y2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkIGlzVHJh Y2VFdmVudEVuYWJsZWRGb3JDYXRlZ29yeSB0byBQbGF0Zm9ybVN1cHBvcnQuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDYxOAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0v UGxhdGZvcm1TdXBwb3J0Lmg6CisKIDIwMTEtMTAtMjAgIFBldGVyIFJ5YmluICA8cGV0ZXIucnli aW5AZ21haWwuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHJlaW1wbGVtZW50IHByb3Rv Y29sIGJhY2tlbmQvZnJvbnRlbmQgc291cmNlIGdlbmVyYXRvcgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5n ZUxvZwppbmRleCBiYzZkZjFjY2QwMWRkNDFlYmFiZTI5YTBlMzNlYzdhZGY3YWY1NDViLi45ZTUw YmNmNjZkNmNiMTAwYWMyN2E5Y2U1MWMzMDhlOGMwZWZmNTkxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0No YW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTEwLTIxICBOYXQgRHVjYSAgPG5kdWNhQGNo cm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEFkZCBpc1RyYWNlRXZlbnRFbmFibGVk Rm9yQ2F0ZWdvcnkgdG8gUGxhdGZvcm1TdXBwb3J0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzA2MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHB1YmxpYy9XZWJLaXRQbGF0Zm9ybVN1cHBvcnQuaDoK KyAgICAgICAgKFdlYktpdDo6V2ViS2l0UGxhdGZvcm1TdXBwb3J0Ojppc1RyYWNlRXZlbnRFbmFi bGVkRm9yQ2F0ZWdvcnkpOgorICAgICAgICAqIHNyYy9QbGF0Zm9ybVN1cHBvcnQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UGxhdGZvcm1TdXBwb3J0Ojppc1RyYWNlRXZlbnRFbmFibGVkRm9yQ2F0 ZWdvcnkpOgorCiAyMDExLTEwLTIwICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdt YWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiAgUm9sbGVkIERFUFMuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybVN1cHBvcnQuaCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BsYXRmb3JtU3VwcG9ydC5oCmluZGV4IDkw ZjQwOTVmOTFkNmVlOGY1NDE1NzlkODY4MzdmMmNjMjEzMjM2MTguLjU3NTNmNmU4ZWE5YmUyM2Q3 NDkwMjRmM2U2YmE5YTYxMWEwNjJiZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL1BsYXRmb3JtU3VwcG9ydC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL1BsYXRmb3JtU3VwcG9ydC5oCkBAIC00MDUsNiArNDA1LDcgQEAgcHVibGlj OgogI2VuZGlmCiAKICAgICAvLyBUcmFjZSBFdmVudCAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQorICAgIHN0YXRpYyBib29sIGlzVHJhY2VF dmVudEVuYWJsZWRGb3JDYXRlZ29yeShjb25zdCBjaGFyKiBjYXRlZ29yeSk7CiAgICAgc3RhdGlj IHZvaWQgdHJhY2VFdmVudEJlZ2luKGNvbnN0IGNoYXIqIG5hbWUsIHZvaWQqLCBjb25zdCBjaGFy KiBleHRyYSk7CiAgICAgc3RhdGljIHZvaWQgdHJhY2VFdmVudEVuZChjb25zdCBjaGFyKiBuYW1l LCB2b2lkKiwgY29uc3QgY2hhciogZXh0cmEpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJLaXRQbGF0Zm9ybVN1cHBvcnQuaCBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYktpdFBsYXRmb3JtU3VwcG9ydC5oCmluZGV4IDUwZTA3OWRhODI2 YmMzYjQ0MWY1NzIyZDIyMTVmOWRhZDAyMjE1MGYuLjllMDM0Y2EwMDQ2ZDcxNzllZTcxNzVhMDli ZmZkYjRjYzhhMmFkODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYktpdFBsYXRmb3JtU3VwcG9ydC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYktpdFBsYXRmb3JtU3VwcG9ydC5oCkBAIC0yMzAsNiArMjMwLDcgQEAgcHVibGljOgog CiAgICAgLy8gQW4gZXZlbnQgaXMgaWRlbnRpZmllZCBieSB0aGUgcGFpciAobmFtZSwgaWQpLiBU aGUgZXh0cmEgcGFyYW1ldGVyCiAgICAgLy8gc3BlY2lmaWVzIGFkZGl0aW9uYWwgZGF0YSB0byBs b2cgd2l0aCB0aGUgZXZlbnQuCisgICAgdmlydHVhbCBib29sIGlzVHJhY2VFdmVudEVuYWJsZWRG b3JDYXRlZ29yeShjb25zdCBjaGFyKiBjYXRlZ29yeSkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQog ICAgIHZpcnR1YWwgdm9pZCB0cmFjZUV2ZW50QmVnaW4oY29uc3QgY2hhciogbmFtZSwgdm9pZCog aWQsIGNvbnN0IGNoYXIqIGV4dHJhKSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgdHJhY2VFdmVudEVu ZChjb25zdCBjaGFyKiBuYW1lLCB2b2lkKiBpZCwgY29uc3QgY2hhciogZXh0cmEpIHsgfQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9QbGF0Zm9ybVN1cHBvcnQuY3Bw IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvUGxhdGZvcm1TdXBwb3J0LmNwcAppbmRleCBk MWE3MjQzMjVkODE4ZWI5YTAwZGFlNTA5NWRjOWQ2MTQ3NWEzNzZjLi4yYTQ5OTk1NWY4YTI3NjBj MmVlYmQ5MDczNDQxM2Y4ZjMwYTAzZWM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9QbGF0Zm9ybVN1cHBvcnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1BsYXRmb3JtU3VwcG9ydC5jcHAKQEAgLTkzNSw2ICs5MzUsMTEgQEAgdm9pZCBQbGF0Zm9y bVN1cHBvcnQ6OnBhaW50VGhlbWVQYXJ0KAogCiAvLyBUcmFjZSBFdmVudCAtLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAKK2Jv b2wgUGxhdGZvcm1TdXBwb3J0Ojppc1RyYWNlRXZlbnRFbmFibGVkRm9yQ2F0ZWdvcnkoY29uc3Qg Y2hhciogY2F0ZWdvcnkpCit7CisgICAgcmV0dXJuIHdlYktpdFBsYXRmb3JtU3VwcG9ydCgpLT5p c1RyYWNlRXZlbnRFbmFibGVkRm9yQ2F0ZWdvcnkoY2F0ZWdvcnkpOworfQorCiB2b2lkIFBsYXRm b3JtU3VwcG9ydDo6dHJhY2VFdmVudEJlZ2luKGNvbnN0IGNoYXIqIG5hbWUsIHZvaWQqIGlkLCBj b25zdCBjaGFyKiBleHRyYSkKIHsKICAgICB3ZWJLaXRQbGF0Zm9ybVN1cHBvcnQoKS0+dHJhY2VF dmVudEJlZ2luKG5hbWUsIGlkLCBleHRyYSk7Cg== 112011 2011-10-21 13:33:18 -0700 2011-10-23 23:27:20 -0700 Blanket enable instead of per-category bug-70618-20111021133317.patch text/plain 3520 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogOTgwNzcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyZWEyZmM5YTJjMDMzODQx MDRkMDhlZWY5MTQzNDU4NWUzZTNiNDFhLi40MTY2MjdiMGRkMTE3Nzk5MTVhMjgwNDVlYjMxMTZi NmZmMTVlM2I0IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMTAtMjEgIE5hdCBE dWNhICA8bmR1Y2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkIGlzVHJh Y2VFdmVudEVuYWJsZWQgdG8gUGxhdGZvcm1TdXBwb3J0LgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzA2MTgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1BsYXRmb3JtU3Vw cG9ydC5oOgorCiAyMDExLTEwLTIwICBQZXRlciBSeWJpbiAgPHBldGVyLnJ5YmluQGdtYWlsLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiByZWltcGxlbWVudCBwcm90b2NvbCBiYWNrZW5k L2Zyb250ZW5kIHNvdXJjZSBnZW5lcmF0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg YmM2ZGYxY2NkMDFkZDQxZWJhYmUyOWEwZTMzZWM3YWRmN2FmNTQ1Yi4uYjM0MGViMzM3YjFmZjQw NDJlN2UzOWI1NDdjZTZlYzhkMTg1OGI1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxMS0xMC0yMSAgTmF0IER1Y2EgIDxuZHVjYUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgW2Nocm9taXVtXSBBZGQgaXNUcmFjZUV2ZW50RW5hYmxlZCB0byBQbGF0Zm9y bVN1cHBvcnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03MDYxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogcHVibGljL1dlYktpdFBsYXRmb3JtU3VwcG9ydC5oOgorICAgICAgICAoV2ViS2l0OjpXZWJL aXRQbGF0Zm9ybVN1cHBvcnQ6OmlzVHJhY2VFdmVudEVuYWJsZWQpOgorICAgICAgICAqIHNyYy9Q bGF0Zm9ybVN1cHBvcnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGxhdGZvcm1TdXBwb3J0Ojpp c1RyYWNlRXZlbnRFbmFibGVkKToKKwogMjAxMS0xMC0yMCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQu cmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gIFJvbGxlZCBERVBT LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUGxhdGZvcm1T dXBwb3J0LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybVN1cHBv cnQuaAppbmRleCA5MGY0MDk1ZjkxZDZlZThmNTQxNTc5ZDg2ODM3ZjJjYzIxMzIzNjE4Li4wMzJm ZTZhNmM0NmZkODhkNmU5YjU3MzQyOTcwOWQwNzBmY2M0Mzg0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybVN1cHBvcnQuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybVN1cHBvcnQuaApAQCAtNDA1LDYgKzQw NSw3IEBAIHB1YmxpYzoKICNlbmRpZgogCiAgICAgLy8gVHJhY2UgRXZlbnQgLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KKyAgICBzdGF0aWMg Ym9vbCBpc1RyYWNlRXZlbnRFbmFibGVkKCk7CiAgICAgc3RhdGljIHZvaWQgdHJhY2VFdmVudEJl Z2luKGNvbnN0IGNoYXIqIG5hbWUsIHZvaWQqLCBjb25zdCBjaGFyKiBleHRyYSk7CiAgICAgc3Rh dGljIHZvaWQgdHJhY2VFdmVudEVuZChjb25zdCBjaGFyKiBuYW1lLCB2b2lkKiwgY29uc3QgY2hh ciogZXh0cmEpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJLaXRQbGF0Zm9ybVN1cHBvcnQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YktpdFBsYXRmb3JtU3VwcG9ydC5oCmluZGV4IDUwZTA3OWRhODI2YmMzYjQ0MWY1NzIyZDIyMTVm OWRhZDAyMjE1MGYuLjRlYWJiM2JhNDcwMzUzZTY2YTdiNDVhMzNmYTNlMjMwN2M4Y2NlZTAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdFBsYXRmb3JtU3Vw cG9ydC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdFBsYXRmb3Jt U3VwcG9ydC5oCkBAIC0yMzAsNiArMjMwLDcgQEAgcHVibGljOgogCiAgICAgLy8gQW4gZXZlbnQg aXMgaWRlbnRpZmllZCBieSB0aGUgcGFpciAobmFtZSwgaWQpLiBUaGUgZXh0cmEgcGFyYW1ldGVy CiAgICAgLy8gc3BlY2lmaWVzIGFkZGl0aW9uYWwgZGF0YSB0byBsb2cgd2l0aCB0aGUgZXZlbnQu CisgICAgdmlydHVhbCBib29sIGlzVHJhY2VFdmVudEVuYWJsZWQoKSBjb25zdCB7IHJldHVybiB0 cnVlOyB9CiAgICAgdmlydHVhbCB2b2lkIHRyYWNlRXZlbnRCZWdpbihjb25zdCBjaGFyKiBuYW1l LCB2b2lkKiBpZCwgY29uc3QgY2hhciogZXh0cmEpIHsgfQogICAgIHZpcnR1YWwgdm9pZCB0cmFj ZUV2ZW50RW5kKGNvbnN0IGNoYXIqIG5hbWUsIHZvaWQqIGlkLCBjb25zdCBjaGFyKiBleHRyYSkg eyB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1BsYXRmb3JtU3Vw cG9ydC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9QbGF0Zm9ybVN1cHBvcnQuY3Bw CmluZGV4IGQxYTcyNDMyNWQ4MThlYjlhMDBkYWU1MDk1ZGM5ZDYxNDc1YTM3NmMuLjU0NTIxYjgy ZWViN2RhZjBkMWRhYWFjMmU4Y2JkNzA5MTIyZDAzNDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1BsYXRmb3JtU3VwcG9ydC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvUGxhdGZvcm1TdXBwb3J0LmNwcApAQCAtOTM1LDYgKzkzNSwxMSBAQCB2b2lk IFBsYXRmb3JtU3VwcG9ydDo6cGFpbnRUaGVtZVBhcnQoCiAKIC8vIFRyYWNlIEV2ZW50IC0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0KIAorYm9vbCBQbGF0Zm9ybVN1cHBvcnQ6OmlzVHJhY2VFdmVudEVuYWJsZWQoKQoreworICAg IHJldHVybiB3ZWJLaXRQbGF0Zm9ybVN1cHBvcnQoKS0+aXNUcmFjZUV2ZW50RW5hYmxlZCgpOwor fQorCiB2b2lkIFBsYXRmb3JtU3VwcG9ydDo6dHJhY2VFdmVudEJlZ2luKGNvbnN0IGNoYXIqIG5h bWUsIHZvaWQqIGlkLCBjb25zdCBjaGFyKiBleHRyYSkKIHsKICAgICB3ZWJLaXRQbGF0Zm9ybVN1 cHBvcnQoKS0+dHJhY2VFdmVudEJlZ2luKG5hbWUsIGlkLCBleHRyYSk7Cg==