<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>70610</bug_id>
          
          <creation_ts>2011-10-21 08:12:11 -0700</creation_ts>
          <short_desc>TEXTREL in libjavascriptcoregtk-1.0.so.0.11.0 on x86 (or i586)</short_desc>
          <delta_ts>2014-08-19 14:25:44 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alexey Shabalin">a.shabalin</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>barraclough</cc>
    
    <cc>benjamin</cc>
    
    <cc>berto</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>commit-queue</cc>
    
    <cc>mrobinson</cc>
    
    <cc>oliver</cc>
    
    <cc>ossy</cc>
    
    <cc>webkit-ews</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>xan.lopez</cc>
    
    <cc>zherczeg</cc>
    
    <cc>zorry</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>488392</commentid>
    <comment_count>0</comment_count>
    <who name="Alexey Shabalin">a.shabalin</who>
    <bug_when>2011-10-21 08:12:11 -0700</bug_when>
    <thetext>own verifying ELF objects script say about error

either the file containing the function &apos;_ZN3JSC3JIT13testPrototypeENS_7JSValueERNS_22AbstractMacroAssemblerINS_12X86AssemblerEE8JumpListE&apos; or the file containing the function &apos;cti_op_put_by_id_generic&apos; is not compiled with -fpic/-fPIC
either the file containing the function &apos;jsRoundThunk&apos; or the file containing the function &apos;expThunk&apos; is not compiled with -fpic/-fPIC
either the file containing the function &apos;expThunk&apos; or the file containing the function &apos;logThunk&apos; is not compiled with -fpic/-fPIC
either the file containing the function &apos;logThunk&apos; or the file containing the function &apos;floorThunk&apos; is not compiled with -fpic/-fPIC
either the file containing the function &apos;floorThunk&apos; or the file containing the function &apos;ceilThunk&apos; is not compiled with -fpic/-fPIC
either the file containing the function &apos;ceilThunk&apos; or the file containing the function &apos;jsRound&apos; is not compiled with -fpic/-fPIC

verify-elf: ERROR: ./usr/lib/libjavascriptcoregtk-1.0.so.0.11.0: TEXTREL entry found: 0x00000000

on x86_64 all fine.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>488600</commentid>
    <comment_count>1</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-10-21 13:21:35 -0700</bug_when>
    <thetext>What platform? Did you build yourself? How do you reproduce this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>489259</commentid>
    <comment_count>2</comment_count>
      <attachid>112169</attachid>
    <who name="Alexey Shabalin">a.shabalin</who>
    <bug_when>2011-10-24 02:58:22 -0700</bug_when>
    <thetext>Created attachment 112169
fix TEXTREL

fix TEXTREL</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>489260</commentid>
    <comment_count>3</comment_count>
    <who name="Alexey Shabalin">a.shabalin</who>
    <bug_when>2011-10-24 02:59:09 -0700</bug_when>
    <thetext>I was build for ALTLinux for x86.
Gentoo have some warning. http://gentwoo.elisp.net/emerges/88345

QA Notice: The following files contain runtime text relocations
 Text relocations force the dynamic linker to perform extra
 work at startup, waste system resources, and may pose a security
 risk.  On some architectures, the code may not even function
 properly, if at all.
 For more information, see http://hardened.gentoo.org/pic-fix-guide.xml
 Please include the following list of files in your report:
TEXTREL usr/lib/libjavascriptcoregtk-3.0.so.0.11.0

For reproduce this:
- build for i586 with --disable-silent-rules
- you can see for libjavascriptcoregtk
  &quot;/usr/bin/ld: warning: creating a DT_TEXTREL in a shared object.&quot;
- after build you can check:

$ eu-findtextrel ./libwebkitgtk-3.0.so.0.11.0 
eu-findtextrel: no text relocations reported in &apos;./libwebkitgtk-3.0.so.0.11.0&apos;

$ eu-findtextrel ./libjavascriptcoregtk-3.0.so.0.11.0 
either the file containing the function &apos;_ZN3JSC3JIT13testPrototypeENS_7JSValueERNS_22AbstractMacroAssemblerINS_12X86AssemblerEE8JumpListE&apos; or the file containing the function &apos;cti_op_put_by_id_generic&apos; is not compiled with -fpic/-fPIC
either the file containing the function &apos;jsRoundThunk&apos; or the file containing the function &apos;expThunk&apos; is not compiled with -fpic/-fPIC
either the file containing the function &apos;expThunk&apos; or the file containing the function &apos;logThunk&apos; is not compiled with -fpic/-fPIC
either the file containing the function &apos;logThunk&apos; or the file containing the function &apos;floorThunk&apos; is not compiled with -fpic/-fPIC
either the file containing the function &apos;floorThunk&apos; or the file containing the function &apos;ceilThunk&apos; is not compiled with -fpic/-fPIC
either the file containing the function &apos;ceilThunk&apos; or the file containing the function &apos;jsRound&apos; is not compiled with -fpic/-fPIC

simple patch in attach, but i have doubts about Source/JavaScriptCore/jit/JSInterfaceJIT.h in #elif CPU(X86)
 static const RegisterID regT3 = X86Registers::ebx;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>489901</commentid>
    <comment_count>4</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-10-25 00:04:34 -0700</bug_when>
    <thetext>CCing some people more familiar with JSC internals.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>490056</commentid>
    <comment_count>5</comment_count>
      <attachid>112169</attachid>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2011-10-25 08:44:49 -0700</bug_when>
    <thetext>Comment on attachment 112169
fix TEXTREL

This fix seems reasonable to me -- it&apos;s just a matter of ensuring the all the asm we have is correctly annotated to allow it to be shuffled around.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>490193</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-10-25 11:48:41 -0700</bug_when>
    <thetext>Attachment 112169 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;]&quot; exit_code: 1

Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>494808</commentid>
    <comment_count>7</comment_count>
      <attachid>112169</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-11-02 12:28:09 -0700</bug_when>
    <thetext>Comment on attachment 112169
fix TEXTREL

I will land this one. Thanks for the patch Alexey. In the future when you make a patch, do you mind making it against trunk and include a ChangeLog? See: http://www.webkit.org/coding/contributing.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>494809</commentid>
    <comment_count>8</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-11-02 12:28:55 -0700</bug_when>
    <thetext>Committed r99089: &lt;http://trac.webkit.org/changeset/99089&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>494819</commentid>
    <comment_count>9</comment_count>
    <who name="Alexey Shabalin">a.shabalin</who>
    <bug_when>2011-11-02 12:47:18 -0700</bug_when>
    <thetext>Hello.
This patch is not complete fix.
After apply this patch you can not build seed (http://live.gnome.org/Seed) on linux x86(i386, not x86_64). I don&apos;t know how fix it.

I think, should be reopen bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>494820</commentid>
    <comment_count>10</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-11-02 12:49:55 -0700</bug_when>
    <thetext>(In reply to comment #9)
&gt; After apply this patch you can not build seed (http://live.gnome.org/Seed) on linux x86(i386, not x86_64). I don&apos;t know how fix it.
&gt; 
&gt; I think, should be reopen bug.

In that case it&apos;s probably best to roll out the patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>494835</commentid>
    <comment_count>11</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-11-02 13:04:42 -0700</bug_when>
    <thetext>(In reply to comment #10)
&gt; (In reply to comment #9)
&gt; &gt; After apply this patch you can not build seed (http://live.gnome.org/Seed) on linux x86(i386, not x86_64). I don&apos;t know how fix it.

How does the build break?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>495243</commentid>
    <comment_count>12</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-11-03 00:42:25 -0700</bug_when>
    <thetext>It made many tests crash on the Qt bot :-/ (only 32 bit)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>495267</commentid>
    <comment_count>13</comment_count>
    <who name="Zoltan Herczeg">zherczeg</who>
    <bug_when>2011-11-03 01:43:42 -0700</bug_when>
    <thetext>(In reply to comment #12)
&gt; It made many tests crash on the Qt bot :-/ (only 32 bit)

ThunkGenerators.cpp:140
0xf6ccf694 &lt;floorThunk+8&gt;:      call   0xf5960f18 &lt;floor@plt&gt;
x $ebx+0x218c
0xf171004b:     0x00000000

and there is a crash after that:
0x0:    Cannot access memory at address 0x0

Thus, although the symbol is defined it points to NULL.

I think the idea is good, but we need a more sophisticated check what is available in the target system.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>495269</commentid>
    <comment_count>14</comment_count>
    <who name="Zoltan Herczeg">zherczeg</who>
    <bug_when>2011-11-03 01:52:49 -0700</bug_when>
    <thetext>Oh, one line is missing.

&gt; ThunkGenerators.cpp:140
&gt; 0xf6ccf694 &lt;floorThunk+8&gt;:      call   0xf5960f18 &lt;floor@plt&gt;

0xf5960f18 &lt;floor@plt&gt;: jmp    *0x218c(%ebx)

&gt; x $ebx+0x218c
&gt; 0xf171004b:     0x00000000

So &lt;floor@plt&gt; does an indirect jump to a NULL address.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>495270</commentid>
    <comment_count>15</comment_count>
    <who name="Zoltan Herczeg">zherczeg</who>
    <bug_when>2011-11-03 01:54:44 -0700</bug_when>
    <thetext>I created a rollout: https://bugs.webkit.org/show_bug.cgi?id=71448</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>495301</commentid>
    <comment_count>16</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-11-03 03:02:50 -0700</bug_when>
    <thetext>(In reply to comment #15)
&gt; I created a rollout: https://bugs.webkit.org/show_bug.cgi?id=71448

Rollout landed in http://trac.webkit.org/changeset/99152</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>986174</commentid>
    <comment_count>17</comment_count>
    <who name="Magnus Granberg">zorry</who>
    <bug_when>2014-03-02 14:43:05 -0800</bug_when>
    <thetext>Any progress on this bug? I still get TEXTREL when building
webkit-gtk-2.2.5 on Gentoo x86.
mv -f Tools/DumpRenderTree/gtk/.deps/Programs_DumpRenderTree-EventSender.Tpo Tools/DumpRenderTree/gtk/.deps/Programs_DumpRenderTree-EventSender.Po
mv -f Tools/DumpRenderTree/gtk/.deps/Programs_DumpRenderTree-PixelDumpSupportGtk.Tpo Tools/DumpRenderTree/gtk/.deps/Programs_DumpRenderTree-PixelDumpSupportGtk.Po
mv -f Source/JavaScriptCore/.deps/Programs_jsc_1-jsc.Tpo Source/JavaScriptCore/.deps/Programs_jsc_1-jsc.Po
mv -f Tools/DumpRenderTree/gtk/.deps/Programs_DumpRenderTree-WorkQueueItemGtk.Tpo Tools/DumpRenderTree/gtk/.deps/Programs_DumpRenderTree-WorkQueueItemGtk.Po
mv -f Tools/DumpRenderTree/gtk/.deps/Programs_DumpRenderTree-DumpRenderTree.Tpo Tools/DumpRenderTree/gtk/.deps/Programs_DumpRenderTree-DumpRenderTree.Po
/usr/lib/gcc/i686-pc-linux-gnu/4.7.3/../../../../i686-pc-linux-gnu/bin/ld: Source/JavaScriptCore/jit/.libs/libjavascriptcoregtk_1_0_la-ThunkGenerators.o: warning: relocation against `floor@@GLIBC_2.0&apos; in readonly section `.text&apos;.
/usr/lib/gcc/i686-pc-linux-gnu/4.7.3/../../../../i686-pc-linux-gnu/bin/ld: warning: creating a DT_TEXTREL in object.
libtool: link: (cd &quot;.libs&quot; &amp;&amp; rm -f &quot;libjavascriptcoregtk-1.0.so.0&quot; &amp;&amp; ln -s &quot;libjavascriptcoregtk-1.0.so.0.15.10&quot; &quot;libjavascriptcoregtk-1.0.so.0&quot;)
libtool: link: (cd &quot;.libs&quot; &amp;&amp; rm -f &quot;libjavascriptcoregtk-1.0.so&quot; &amp;&amp; ln -s &quot;libjavascriptcoregtk-1.0.so.0.15.10&quot; &quot;libjavascriptcoregtk-1.0.so&quot;)
libtool: link: ( cd &quot;.libs&quot; &amp;&amp; rm -f &quot;libjavascriptcoregtk-1.0.la&quot; &amp;&amp; ln -s &quot;../libjavascriptcoregtk-1.0.la&quot; &quot;libjavascriptcoregtk-1.0.la&quot; )</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>990143</commentid>
    <comment_count>18</comment_count>
      <attachid>226616</attachid>
    <who name="Magnus Granberg">zorry</who>
    <bug_when>2014-03-13 13:30:04 -0700</bug_when>
    <thetext>Created attachment 226616
Updated patch to fix the textrel

This patch is a update of the patch that was posted before.
Don&apos;t know if it will have that same prob as the old one for i
can&apos;t run the testsuite.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>990145</commentid>
    <comment_count>19</comment_count>
    <who name="Early Warning System Bot">webkit-ews</who>
    <bug_when>2014-03-13 13:32:45 -0700</bug_when>
    <thetext>Attachment 226616 did not pass style-queue:


Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>990150</commentid>
    <comment_count>20</comment_count>
      <attachid>226618</attachid>
    <who name="Magnus Granberg">zorry</who>
    <bug_when>2014-03-13 13:42:59 -0700</bug_when>
    <thetext>Created attachment 226618
Patch to add plt to fix the textrel

Update to fix the typo in the last patch.
To fix the textrel.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>990166</commentid>
    <comment_count>21</comment_count>
    <who name="Early Warning System Bot">webkit-ews</who>
    <bug_when>2014-03-13 14:46:22 -0700</bug_when>
    <thetext>Attachment 226618 did not pass style-queue:


Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>990403</commentid>
    <comment_count>22</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-03-14 04:40:59 -0700</bug_when>
    <thetext>(In reply to comment #20)
&gt; Created an attachment (id=226618) [details]
&gt; Patch to add plt to fix the textrel

The browser crashes all the time with this patch. Did you try to run
GtkLauncher or the MiniBrowser?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>992745</commentid>
    <comment_count>23</comment_count>
      <attachid>227339</attachid>
    <who name="Magnus Granberg">zorry</who>
    <bug_when>2014-03-20 14:48:53 -0700</bug_when>
    <thetext>Created attachment 227339
add plt and fix %ebx for use with plt

* Source/WTF/wtf/InlineASM.h GLOBAL_REFERENCE: Add plt if PIC
* Source/JavaScriptCore/jit/ThunkGenerators.cpp defineUnaryDoubleOpWrapper: if PIC then setup %ebx so we can use plt</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>992747</commentid>
    <comment_count>24</comment_count>
    <who name="Magnus Granberg">zorry</who>
    <bug_when>2014-03-20 14:55:47 -0700</bug_when>
    <thetext>(In reply to comment #22)
&gt; (In reply to comment #20)
&gt; &gt; Created an attachment (id=226618) [details] [details]
&gt; &gt; Patch to add plt to fix the textrel
&gt; 
&gt; The browser crashes all the time with this patch. Did you try to run
&gt; GtkLauncher or the MiniBrowser?
The prob is that i can&apos;t test any x86 stuff only compile.
the asm code was missing to setup %ebx with the needed info for plt.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993047</commentid>
    <comment_count>25</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-03-21 06:13:36 -0700</bug_when>
    <thetext>(In reply to comment #23)
&gt; Created an attachment (id=227339) [details]
&gt; add plt and fix %ebx for use with plt

This actually seems to work fine, thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993741</commentid>
    <comment_count>26</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-03-24 01:55:19 -0700</bug_when>
    <thetext>I did a full rebuild of webkitgtk with this patch and I haven&apos;t noticed any problem, I think we can go ahead with it.

Thanks again for the patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993761</commentid>
    <comment_count>27</comment_count>
      <attachid>227634</attachid>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-03-24 02:49:12 -0700</bug_when>
    <thetext>Created attachment 227634
Patch

I rebased your patch and added the ChangeLog entry.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1011982</commentid>
    <comment_count>28</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-05-27 09:13:10 -0700</bug_when>
    <thetext>Debian has been shipping this patch for a while and we didn&apos;t detect any problem.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1030115</commentid>
    <comment_count>29</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-08-19 14:25:44 -0700</bug_when>
    <thetext>Committed r172759: &lt;http://trac.webkit.org/changeset/172759&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>112169</attachid>
            <date>2011-10-24 02:58:22 -0700</date>
            <delta_ts>2014-03-24 02:49:12 -0700</delta_ts>
            <desc>fix TEXTREL</desc>
            <filename>webkit-1.6.1-alt-fix-TEXTREL.patch</filename>
            <type>text/plain</type>
            <size>1365</size>
            <attacher name="Alexey Shabalin">a.shabalin</attacher>
            
              <data encoding="base64">ZGlmZiAtdXIgd2Via2l0LTEuNi4xL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMu
Y3BwIHdlYmtpdC0xLjYuMS5uZXcvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5j
cHAKLS0tIHdlYmtpdC0xLjYuMS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzLmNw
cAkyMDExLTEwLTIxIDIxOjE4OjQ2LjAwMDAwMDAwMCArMDQwMAorKysgd2Via2l0LTEuNi4xLm5l
dy9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzLmNwcAkyMDExLTEwLTIxIDIxOjE5
OjUxLjM5NzUyOTE2NSArMDQwMApAQCAtODAsNyArODAsNyBAQAogI2RlZmluZSBUSFVNQl9GVU5D
X1BBUkFNKG5hbWUpCiAjZW5kaWYKIAotI2lmIChPUyhMSU5VWCkgfHwgT1MoRlJFRUJTRCkpICYm
IENQVShYODZfNjQpCisjaWYgKE9TKExJTlVYKSB8fCBPUyhGUkVFQlNEKSkgJiYgKENQVShYODYp
IHx8IENQVShYODZfNjQpKQogI2RlZmluZSBTWU1CT0xfU1RSSU5HX1JFTE9DQVRJT04obmFtZSkg
I25hbWUgIkBwbHQiCiAjZWxpZiBPUyhEQVJXSU4pIHx8IChDUFUoWDg2XzY0KSAmJiBDT01QSUxF
UihNSU5HVykgJiYgIUdDQ19WRVJTSU9OX0FUX0xFQVNUKDQsIDUsIDApKQogI2RlZmluZSBTWU1C
T0xfU1RSSU5HX1JFTE9DQVRJT04obmFtZSkgIl8iICNuYW1lCmRpZmYgLXVyIHdlYmtpdC0xLjYu
MS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1RodW5rR2VuZXJhdG9ycy5jcHAgd2Via2l0LTEu
Ni4xLm5ldy9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1RodW5rR2VuZXJhdG9ycy5jcHAKLS0t
IHdlYmtpdC0xLjYuMS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1RodW5rR2VuZXJhdG9ycy5j
cHAJMjAxMS0xMC0yMSAyMToxODo0Ni4wMDAwMDAwMDAgKzA0MDAKKysrIHdlYmtpdC0xLjYuMS5u
ZXcvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dlbmVyYXRvcnMuY3BwCTIwMTEtMTAt
MjEgMjE6MjA6MDEuMDI5NTI5ODA1ICswNDAwCkBAIC0xMDgsNyArMTA4LDcgQEAKICNkZWZpbmUg
U1lNQk9MX1NUUklORyhuYW1lKSAjbmFtZQogI2VuZGlmCiAgICAgCi0jaWYgKE9TKExJTlVYKSB8
fCBPUyhGUkVFQlNEKSkgJiYgQ1BVKFg4Nl82NCkKKyNpZiAoT1MoTElOVVgpIHx8IE9TKEZSRUVC
U0QpKSAmJiAoQ1BVKFg4NikgfHwgQ1BVKFg4Nl82NCkpCiAjZGVmaW5lIFNZTUJPTF9TVFJJTkdf
UkVMT0NBVElPTihuYW1lKSAjbmFtZSAiQHBsdCIKICNlbGlmIE9TKERBUldJTikgfHwgKENQVShY
ODZfNjQpICYmIENPTVBJTEVSKE1JTkdXKSAmJiAhR0NDX1ZFUlNJT05fQVRfTEVBU1QoNCwgNSwg
MCkpCiAjZGVmaW5lIFNZTUJPTF9TVFJJTkdfUkVMT0NBVElPTihuYW1lKSAiXyIgI25hbWUK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>226616</attachid>
            <date>2014-03-13 13:30:04 -0700</date>
            <delta_ts>2014-03-13 13:42:59 -0700</delta_ts>
            <desc>Updated patch to fix the textrel</desc>
            <filename>webkit_textrel.patch</filename>
            <type>text/plain</type>
            <size>450</size>
            <attacher name="Magnus Granberg">zorry</attacher>
            
              <data encoding="base64">LS0tIGEvU291cmNlL1dURi93dGYvSW5saW5lQVNNLmgJMjAxNC0wMy0xMSAwMDoxNDoxMS4wMDAw
MDAwMDAgKzAxMDAKKysrIGIvU291cmNlL1dURi93dGYvSW5saW5lQVNNLmgJMjAxNC0wMy0xMSAw
MDoyMDoxNy41NTUyMzkyODYgKzAxMDAKQEAgLTQ0LDYgKzQ0LDggQEAKICNkZWZpbmUgR0xPQkFM
X1JFRkVSRU5DRShuYW1lKSAjbmFtZSAiQHBsdCIKICNlbGlmIENQVShYODYpICYmIENPTVBJTEVS
KE1JTkdXKQogI2RlZmluZSBHTE9CQUxfUkVGRVJFTkNFKG5hbWUpICJAIiAjbmFtZSAiQDQiCisj
ZWxpZiAgT1MoTElOVVgpICYmIENQVShYODYpICYmIF9fUElDX18KKyNkZWZpbmUgR0xPQkFMX1JF
RkVSRU5DRShuYW1lKSBTWU1CT0xfU1RSSU5HKG5hbWUpICJAcGx0IgogI2Vsc2UKICNkZWZpbmUg
R0xPQkFMX1JFRkVSRU5DRShuYW1lKSBTWU1CT0xfU1RSSU5HKG5hbWUpCiAjZW5kaWYK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>226618</attachid>
            <date>2014-03-13 13:42:59 -0700</date>
            <delta_ts>2014-03-20 14:48:53 -0700</delta_ts>
            <desc>Patch to add plt to fix the textrel</desc>
            <filename>webkit_textrel.patch</filename>
            <type>text/plain</type>
            <size>449</size>
            <attacher name="Magnus Granberg">zorry</attacher>
            
              <data encoding="base64">LS0tIGEvU291cmNlL1dURi93dGYvSW5saW5lQVNNLmgJMjAxNC0wMy0xMSAwMDoxNDoxMS4wMDAw
MDAwMDAgKzAxMDAKKysrIGIvU291cmNlL1dURi93dGYvSW5saW5lQVNNLmgJMjAxNC0wMy0xMSAw
MDoyMDoxNy41NTUyMzkyODYgKzAxMDAKQEAgLTQ0LDYgKzQ0LDggQEAKICNkZWZpbmUgR0xPQkFM
X1JFRkVSRU5DRShuYW1lKSAjbmFtZSAiQHBsdCIKICNlbGlmIENQVShYODYpICYmIENPTVBJTEVS
KE1JTkdXKQogI2RlZmluZSBHTE9CQUxfUkVGRVJFTkNFKG5hbWUpICJAIiAjbmFtZSAiQDQiCisj
ZWxpZiBPUyhMSU5VWCkgJiYgQ1BVKFg4NikgJiYgX19QSUNfXworI2RlZmluZSBHTE9CQUxfUkVG
RVJFTkNFKG5hbWUpIFNZTUJPTF9TVFJJTkcobmFtZSkgIkBwbHQiCiAjZWxzZQogI2RlZmluZSBH
TE9CQUxfUkVGRVJFTkNFKG5hbWUpIFNZTUJPTF9TVFJJTkcobmFtZSkKICNlbmRpZgo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>227339</attachid>
            <date>2014-03-20 14:48:53 -0700</date>
            <delta_ts>2014-03-24 02:49:12 -0700</delta_ts>
            <desc>add plt and fix %ebx for use with plt</desc>
            <filename>webkit_textrel.patch</filename>
            <type>text/plain</type>
            <size>1834</size>
            <attacher name="Magnus Granberg">zorry</attacher>
            
              <data encoding="base64">LS0tIGEvU291cmNlL1dURi93dGYvSW5saW5lQVNNLmgJMjAxNC0wMy0xMSAwMDoxNDoxMS4wMDAw
MDAwMDAgKzAxMDAKKysrIGIvU291cmNlL1dURi93dGYvSW5saW5lQVNNLmgJMjAxNC0wMy0xMSAw
MDoyMDoxNy41NTUyMzkyODYgKzAxMDAKQEAgLTQ0LDYgKzQ0LDggQEAKICNkZWZpbmUgR0xPQkFM
X1JFRkVSRU5DRShuYW1lKSAjbmFtZSAiQHBsdCIKICNlbGlmIENQVShYODYpICYmIENPTVBJTEVS
KE1JTkdXKQogI2RlZmluZSBHTE9CQUxfUkVGRVJFTkNFKG5hbWUpICJAIiAjbmFtZSAiQDQiCisj
ZWxpZiBPUyhMSU5VWCkgJiYgQ1BVKFg4NikgJiYgZGVmaW5lZChfX1BJQ19fKQorI2RlZmluZSBH
TE9CQUxfUkVGRVJFTkNFKG5hbWUpIFNZTUJPTF9TVFJJTkcobmFtZSkgIkBwbHQiCiAjZWxzZQog
I2RlZmluZSBHTE9CQUxfUkVGRVJFTkNFKG5hbWUpIFNZTUJPTF9TVFJJTkcobmFtZSkKICNlbmRp
ZgotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1RodW5rR2VuZXJhdG9ycy5jcHAJMjAx
NC0wMy0yMCAyMzowNjoyMy42MTUwNjM1OTYgKzAxMDAKKysrIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL2ppdC9UaHVua0dlbmVyYXRvcnMuY3BwCTIwMTQtMDMtMjAgMjI6NDA6NTcuMDAwMDAwMDAw
ICswMTAwCkBAIC02MDQsNiArNjA0LDI5IEBAIGRvdWJsZSBqc1JvdW5kKGRvdWJsZSBkKQogICAg
ICAgICBNYXRoVGh1bmtDYWxsaW5nQ29udmVudGlvbiBmdW5jdGlvbiMjVGh1bmsoTWF0aFRodW5r
Q2FsbGluZ0NvbnZlbnRpb24pOyBcCiAgICAgfSBcCiAgICAgc3RhdGljIE1hdGhUaHVuayBVbmFy
eURvdWJsZU9wV3JhcHBlcihmdW5jdGlvbikgPSAmZnVuY3Rpb24jI1RodW5rOworI2VsaWYgQ1BV
KFg4NikgJiYgQ09NUElMRVIoR0NDKSAmJiBPUyhMSU5VWCkgJiYgZGVmaW5lZChfX1BJQ19fKQor
I2RlZmluZSBkZWZpbmVVbmFyeURvdWJsZU9wV3JhcHBlcihmdW5jdGlvbikgXAorICAgIGFzbSgg
XAorICAgICAgICAiLnRleHRcbiIgXAorICAgICAgICAiLmdsb2JsICIgU1lNQk9MX1NUUklORyhm
dW5jdGlvbiMjVGh1bmspICJcbiIgXAorICAgICAgICBISURFX1NZTUJPTChmdW5jdGlvbiMjVGh1
bmspICJcbiIgXAorICAgICAgICBTWU1CT0xfU1RSSU5HKGZ1bmN0aW9uIyNUaHVuaykgIjoiICJc
biIgXAorICAgICAgICAicHVzaGwgJWVieFxuIiBcCisgICAgICAgICJzdWJsICQyMCwgJWVzcFxu
IiBcCisgICAgICAgICJtb3ZzZCAleG1tMCwgKCVlc3ApIFxuIiBcCisgICAgICAgICJjYWxsIF9f
eDg2LmdldF9wY190aHVuay5ieFxuIiBcCisgICAgICAgICJhZGRsICRfR0xPQkFMX09GRlNFVF9U
QUJMRV8sICVlYnhcbiIgXAorICAgICAgICAiY2FsbCAiIEdMT0JBTF9SRUZFUkVOQ0UoZnVuY3Rp
b24pICJcbiIgXAorICAgICAgICAiZnN0cGwgKCVlc3ApIFxuIiBcCisgICAgICAgICJtb3ZzZCAo
JWVzcCksICV4bW0wIFxuIiBcCisgICAgICAgICJhZGRsICQyMCwgJWVzcFxuIiBcCisgICAgICAg
ICJwb3BsICVlYnhcbiIgXAorICAgICAgICAicmV0XG4iIFwKKyAgICApO1wKKyAgICBleHRlcm4g
IkMiIHsgXAorICAgICAgICBNYXRoVGh1bmtDYWxsaW5nQ29udmVudGlvbiBmdW5jdGlvbiMjVGh1
bmsoTWF0aFRodW5rQ2FsbGluZ0NvbnZlbnRpb24pOyBcCisgICAgfSBcCisgICAgc3RhdGljIE1h
dGhUaHVuayBVbmFyeURvdWJsZU9wV3JhcHBlcihmdW5jdGlvbikgPSAmZnVuY3Rpb24jI1RodW5r
OwogI2VsaWYgQ1BVKFg4NikgJiYgQ09NUElMRVIoR0NDKSAmJiAoT1MoREFSV0lOKSB8fCBPUyhM
SU5VWCkpCiAjZGVmaW5lIGRlZmluZVVuYXJ5RG91YmxlT3BXcmFwcGVyKGZ1bmN0aW9uKSBcCiAg
ICAgYXNtKCBcCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>227634</attachid>
            <date>2014-03-24 02:49:12 -0700</date>
            <delta_ts>2014-08-19 09:01:37 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>70610.diff</filename>
            <type>text/plain</type>
            <size>3011</size>
            <attacher name="Alberto Garcia">berto</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDJmNTc3OWYuLjQ2MTA4MjUgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAzLTI0ICBNYWdudXMgR3JhbmJl
cmcgIDx6b3JyeUBnZW50b28ub3JnPgorCisgICAgICAgIFRFWFRSRUwgaW4gbGliamF2YXNjcmlw
dGNvcmVndGstMS4wLnNvLjAuMTEuMCBvbiB4ODYgKG9yIGk1ODYpCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDYxMAorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNldHVwICVlYnggc28gd2UgY2FuIHVzZSB0
aGUgcGx0LgorCisgICAgICAgICogaml0L1RodW5rR2VuZXJhdG9ycy5jcHA6CisKIDIwMTQtMDMt
MjMgIEh5b3dvbiBLaW0gIDxodzEwMDgua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIE1vdmUg
YWxsIEVGTCB0eXBlZGVmcyBpbnRvIEVmbFR5cGVkZWZzLmguCmRpZmYgLS1naXQgYS9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvaml0L1RodW5rR2VuZXJhdG9ycy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvaml0L1RodW5rR2VuZXJhdG9ycy5jcHAKaW5kZXggMTdhNTUwYS4uMjRjYzBjOSAxMDA2
NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dlbmVyYXRvcnMuY3BwCisr
KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvVGh1bmtHZW5lcmF0b3JzLmNwcApAQCAtNjQz
LDYgKzY0MywzMCBAQCBkb3VibGUganNSb3VuZChkb3VibGUgZCkKICAgICB9IFwKICAgICBzdGF0
aWMgTWF0aFRodW5rIFVuYXJ5RG91YmxlT3BXcmFwcGVyKGZ1bmN0aW9uKSA9ICZmdW5jdGlvbiMj
VGh1bms7CiAKKyNlbGlmIENQVShYODYpICYmIENPTVBJTEVSKEdDQykgJiYgT1MoTElOVVgpICYm
IGRlZmluZWQoX19QSUNfXykKKyNkZWZpbmUgZGVmaW5lVW5hcnlEb3VibGVPcFdyYXBwZXIoZnVu
Y3Rpb24pIFwKKyAgICBhc20oIFwKKyAgICAgICAgIi50ZXh0XG4iIFwKKyAgICAgICAgIi5nbG9i
bCAiIFNZTUJPTF9TVFJJTkcoZnVuY3Rpb24jI1RodW5rKSAiXG4iIFwKKyAgICAgICAgSElERV9T
WU1CT0woZnVuY3Rpb24jI1RodW5rKSAiXG4iIFwKKyAgICAgICAgU1lNQk9MX1NUUklORyhmdW5j
dGlvbiMjVGh1bmspICI6IiAiXG4iIFwKKyAgICAgICAgInB1c2hsICVlYnhcbiIgXAorICAgICAg
ICAic3VibCAkMjAsICVlc3BcbiIgXAorICAgICAgICAibW92c2QgJXhtbTAsICglZXNwKSBcbiIg
XAorICAgICAgICAiY2FsbCBfX3g4Ni5nZXRfcGNfdGh1bmsuYnhcbiIgXAorICAgICAgICAiYWRk
bCAkX0dMT0JBTF9PRkZTRVRfVEFCTEVfLCAlZWJ4XG4iIFwKKyAgICAgICAgImNhbGwgIiBHTE9C
QUxfUkVGRVJFTkNFKGZ1bmN0aW9uKSAiXG4iIFwKKyAgICAgICAgImZzdHBsICglZXNwKSBcbiIg
XAorICAgICAgICAibW92c2QgKCVlc3ApLCAleG1tMCBcbiIgXAorICAgICAgICAiYWRkbCAkMjAs
ICVlc3BcbiIgXAorICAgICAgICAicG9wbCAlZWJ4XG4iIFwKKyAgICAgICAgInJldFxuIiBcCisg
ICAgKTtcCisgICAgZXh0ZXJuICJDIiB7IFwKKyAgICAgICAgTWF0aFRodW5rQ2FsbGluZ0NvbnZl
bnRpb24gZnVuY3Rpb24jI1RodW5rKE1hdGhUaHVua0NhbGxpbmdDb252ZW50aW9uKTsgXAorICAg
IH0gXAorICAgIHN0YXRpYyBNYXRoVGh1bmsgVW5hcnlEb3VibGVPcFdyYXBwZXIoZnVuY3Rpb24p
ID0gJmZ1bmN0aW9uIyNUaHVuazsKKwogI2VsaWYgQ1BVKFg4NikgJiYgQ09NUElMRVIoR0NDKSAm
JiAoT1MoREFSV0lOKSB8fCBPUyhMSU5VWCkpCiAjZGVmaW5lIGRlZmluZVVuYXJ5RG91YmxlT3BX
cmFwcGVyKGZ1bmN0aW9uKSBcCiAgICAgYXNtKCBcCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0No
YW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDc1MWY5MDcuLjNmOGJmYjcgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9n
CkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMDMtMjQgIE1hZ251cyBHcmFuYmVyZyAgPHpvcnJ5QGdl
bnRvby5vcmc+CisKKyAgICAgICAgVEVYVFJFTCBpbiBsaWJqYXZhc2NyaXB0Y29yZWd0ay0xLjAu
c28uMC4xMS4wIG9uIHg4NiAob3IgaTU4NikKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTcwNjEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgQWRkIFBMVCBpZiB3ZSdyZSBidWlsZGluZyB3aXRoIFBJQy4KKwor
ICAgICAgICAqIHd0Zi9JbmxpbmVBU00uaDoKKwogMjAxNC0wMy0yMyAgSHlvd29uIEtpbSAgPGh3
MTAwOC5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgTW92ZSBhbGwgRUZMIHR5cGVkZWZzIGlu
dG8gRWZsVHlwZWRlZnMuaC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0lubGluZUFTTS5o
IGIvU291cmNlL1dURi93dGYvSW5saW5lQVNNLmgKaW5kZXggMjhkMWJmYy4uZjIyZDdiOSAxMDA2
NDQKLS0tIGEvU291cmNlL1dURi93dGYvSW5saW5lQVNNLmgKKysrIGIvU291cmNlL1dURi93dGYv
SW5saW5lQVNNLmgKQEAgLTQ0LDYgKzQ0LDggQEAKICNkZWZpbmUgR0xPQkFMX1JFRkVSRU5DRShu
YW1lKSAjbmFtZSAiQHBsdCIKICNlbGlmIENQVShYODYpICYmIENPTVBJTEVSKE1JTkdXKQogI2Rl
ZmluZSBHTE9CQUxfUkVGRVJFTkNFKG5hbWUpICJAIiAjbmFtZSAiQDQiCisjZWxpZiBPUyhMSU5V
WCkgJiYgQ1BVKFg4NikgJiYgZGVmaW5lZChfX1BJQ19fKQorI2RlZmluZSBHTE9CQUxfUkVGRVJF
TkNFKG5hbWUpIFNZTUJPTF9TVFJJTkcobmFtZSkgIkBwbHQiCiAjZWxzZQogI2RlZmluZSBHTE9C
QUxfUkVGRVJFTkNFKG5hbWUpIFNZTUJPTF9TVFJJTkcobmFtZSkKICNlbmRpZgo=
</data>
<flag name="review"
          id="251877"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>