70603 2011-10-21 07:00:09 -0700 [WK2]Main window never gets focus using TAB key in WebKit2 GTK+. 2011-10-25 09:39:41 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 0 fbqw68 webkit-unassigned alex cgarcia gustavo.noronha gustavo kling mrobinson pnormand webkit.review.bot xan.lopez oldest_to_newest 488357 0 fbqw68 2011-10-21 07:00:09 -0700 TAB key never propagate to the Main Window in Minibrowser. 488363 1 111961 fbqw68 2011-10-21 07:08:21 -0700 Created attachment 111961 Patch fixes the Main Window focus issue with TAB key Patch fixes the Main Window focus issue with TAB key 488368 2 111961 gustavo.noronha 2011-10-21 07:20:29 -0700 Comment on attachment 111961 Patch fixes the Main Window focus issue with TAB key Attachment 111961 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10176934 488396 3 111968 fbqw68 2011-10-21 08:20:50 -0700 Created attachment 111968 Typo error fixed and updated the patch Typo error fixed and updated the patch 489992 4 111968 cgarcia 2011-10-25 06:21:54 -0700 Comment on attachment 111968 Typo error fixed and updated the patch Patch looks good to me. 490050 5 111968 gustavo 2011-10-25 08:34:10 -0700 Comment on attachment 111968 Typo error fixed and updated the patch LGTM 490071 6 111968 webkit.review.bot 2011-10-25 09:39:36 -0700 Comment on attachment 111968 Typo error fixed and updated the patch Clearing flags on attachment: 111968 Committed r98351: <http://trac.webkit.org/changeset/98351> 490072 7 webkit.review.bot 2011-10-25 09:39:41 -0700 All reviewed patches have been landed. Closing bug. 111961 2011-10-21 07:08:21 -0700 2011-10-21 08:20:50 -0700 Patch fixes the Main Window focus issue with TAB key patch_for_bug_70603 text/plain 1873 fbqw68 SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk4MDk4KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMTAtMjEgIFZhbXNoaWtyaXNobmEgWWVsbGVua2kgIDx2YW1zaGlAbW90 b3JvbGEuY29tPgorCisgICAgICAgIFtXSzJdTWFpbiB3aW5kb3cgbmV2ZXIgZ2V0cyBmb2N1cyB1 c2luZyBUQUIga2V5IGluIFdlYktpdDIgR1RLKy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTcwNjAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jOgor ICAgICAgICAoZm9jdXMpOgorICAgICAgICAodW5Gb2N1cyk6CisgICAgICAgIChicm93c2VyV2lu ZG93VUlDbGllbnRJbml0KToKKwogMjAxMS0xMC0yMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxj Z2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgd2F0Y2hsaXN0OiBBZGQgYSBuZXcgZW50cnkg Zm9yIFdlYktpdDIgR1RLKyBwdWJsaWMgQVBJCkluZGV4OiBUb29scy9NaW5pQnJvd3Nlci9ndGsv QnJvd3NlcldpbmRvdy5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93 c2VyV2luZG93LmMJKHJldmlzaW9uIDk4MDY5KQorKysgVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jy b3dzZXJXaW5kb3cuYwkod29ya2luZyBjb3B5KQpAQCAtNTYzLDYgKzU2MywxOSBAQAogICAgIHJl dHVybiBkaWFsb2c7CiB9CiAKK3N0YXRpYyB2b2lkIGZvY3VzKFdLUGFnZVJlZiBwYWdlLCBjb25z dCB2b2lkICpjbGllbnRJbmZvKQoreworICAgIEJyb3dzZXJXaW5kb3cgKndpbmRvdyA9IEJST1dT RVJfV0lORE9XKGNsaWVudEluZm8pOworICAgIGd0a193aWRnZXRfZ3JhYl9mb2N1cyhHVEtfV0lE R0VUKHdpbmRvdy0+d2ViVmlldykpOworfSAKKworc3RhdGljIHZvaWQgdW5Gb2N1cyhXS1BhZ2VS ZWYgcGFnZSwgY29uc3Qgdm9pZCAqY2xpZW50SW5mbykKK3sKKyAgICBCcm93c2VyV2luZG93ICp3 aW5kb3cgPSBCUk9XU0VSX1dJTkRPVyhjbGllbnRJbmZvKTsKKyAgICBpZiAoZ3RrX3dpZGdldF9p c190b3BsZXZlbCh3aW5kb3cpKQorICAgICAgICBndGtfd2luZG93X3NldF9mb2N1cyhHVEtfV0lO RE9XKHdpbmRvdyksIE5VTEwpOworfSAKKwogc3RhdGljIHZvaWQgcnVuSmF2YVNjcmlwdEFsZXJ0 KFdLUGFnZVJlZiBwYWdlLCBXS1N0cmluZ1JlZiBtZXNzYWdlLCBXS0ZyYW1lUmVmIGZyYW1lLCBj b25zdCB2b2lkICpjbGllbnRJbmZvKQogewogICAgIEd0a1dpZGdldCAqZGlhbG9nID0gY3JlYXRl TWVzc2FnZURpYWxvZyhHVEtfV0lORE9XKGNsaWVudEluZm8pLCBHVEtfTUVTU0FHRV9XQVJOSU5H LCBHVEtfQlVUVE9OU19DTE9TRSwgR1RLX1JFU1BPTlNFX0NMT1NFLCBtZXNzYWdlLCBmcmFtZSk7 CkBAIC02MjEsOCArNjM0LDggQEAKICAgICAgICAgc2hvd1BhZ2UsCiAgICAgICAgIGNsb3NlUGFn ZSwKICAgICAgICAgMCwgICAgICAvKiB0YWtlRm9jdXMgKi8KLSAgICAgICAgMCwgICAgICAvKiBm b2N1cyAqLwotICAgICAgICAwLCAgICAgIC8qIHVuZm9jdXMgKi8KKyAgICAgICAgZm9jdXMsCisg ICAgICAgIHVuZm9jdXMsCiAgICAgICAgIHJ1bkphdmFTY3JpcHRBbGVydCwKICAgICAgICAgcnVu SmF2YVNjcmlwdENvbmZpcm0sCiAgICAgICAgIHJ1bkphdmFTY3JpcHRQcm9tcHQsCg== 111968 2011-10-21 08:20:50 -0700 2011-10-25 09:39:36 -0700 Typo error fixed and updated the patch patch_for_bug_70603 text/plain 1885 fbqw68 SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk4MDk4KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMTAtMjEgIFZhbXNoaWtyaXNobmEgWWVsbGVua2kgIDx2YW1zaGlAbW90 b3JvbGEuY29tPgorCisgICAgICAgIFtXSzJdTWFpbiB3aW5kb3cgbmV2ZXIgZ2V0cyBmb2N1cyB1 c2luZyBUQUIga2V5IGluIFdlYktpdDIgR1RLKy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTcwNjAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jOgor ICAgICAgICAoZm9jdXMpOgorICAgICAgICAodW5Gb2N1cyk6CisgICAgICAgIChicm93c2VyV2lu ZG93VUlDbGllbnRJbml0KToKKwogMjAxMS0xMC0yMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxj Z2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgd2F0Y2hsaXN0OiBBZGQgYSBuZXcgZW50cnkg Zm9yIFdlYktpdDIgR1RLKyBwdWJsaWMgQVBJCkluZGV4OiBUb29scy9NaW5pQnJvd3Nlci9ndGsv QnJvd3NlcldpbmRvdy5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93 c2VyV2luZG93LmMJKHJldmlzaW9uIDk4MDY5KQorKysgVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jy b3dzZXJXaW5kb3cuYwkod29ya2luZyBjb3B5KQpAQCAtNTYzLDYgKzU2MywxOSBAQAogICAgIHJl dHVybiBkaWFsb2c7CiB9CiAKK3N0YXRpYyB2b2lkIGZvY3VzKFdLUGFnZVJlZiBwYWdlLCBjb25z dCB2b2lkICpjbGllbnRJbmZvKQoreworICAgIEJyb3dzZXJXaW5kb3cgKndpbmRvdyA9IEJST1dT RVJfV0lORE9XKGNsaWVudEluZm8pOworICAgIGd0a193aWRnZXRfZ3JhYl9mb2N1cyhHVEtfV0lE R0VUKHdpbmRvdy0+d2ViVmlldykpOworfSAKKworc3RhdGljIHZvaWQgdW5mb2N1cyhXS1BhZ2VS ZWYgcGFnZSwgY29uc3Qgdm9pZCAqY2xpZW50SW5mbykKK3sKKyAgICBCcm93c2VyV2luZG93ICp3 aW5kb3cgPSBCUk9XU0VSX1dJTkRPVyhjbGllbnRJbmZvKTsKKyAgICBpZiAoZ3RrX3dpZGdldF9p c190b3BsZXZlbChHVEtfV0lER0VUKHdpbmRvdykpKQorICAgICAgICBndGtfd2luZG93X3NldF9m b2N1cyhHVEtfV0lORE9XKHdpbmRvdyksIE5VTEwpOworfSAKKwogc3RhdGljIHZvaWQgcnVuSmF2 YVNjcmlwdEFsZXJ0KFdLUGFnZVJlZiBwYWdlLCBXS1N0cmluZ1JlZiBtZXNzYWdlLCBXS0ZyYW1l UmVmIGZyYW1lLCBjb25zdCB2b2lkICpjbGllbnRJbmZvKQogewogICAgIEd0a1dpZGdldCAqZGlh bG9nID0gY3JlYXRlTWVzc2FnZURpYWxvZyhHVEtfV0lORE9XKGNsaWVudEluZm8pLCBHVEtfTUVT U0FHRV9XQVJOSU5HLCBHVEtfQlVUVE9OU19DTE9TRSwgR1RLX1JFU1BPTlNFX0NMT1NFLCBtZXNz YWdlLCBmcmFtZSk7CkBAIC02MjEsOCArNjM0LDggQEAKICAgICAgICAgc2hvd1BhZ2UsCiAgICAg ICAgIGNsb3NlUGFnZSwKICAgICAgICAgMCwgICAgICAvKiB0YWtlRm9jdXMgKi8KLSAgICAgICAg MCwgICAgICAvKiBmb2N1cyAqLwotICAgICAgICAwLCAgICAgIC8qIHVuZm9jdXMgKi8KKyAgICAg ICAgZm9jdXMsCisgICAgICAgIHVuZm9jdXMsCiAgICAgICAgIHJ1bkphdmFTY3JpcHRBbGVydCwK ICAgICAgICAgcnVuSmF2YVNjcmlwdENvbmZpcm0sCiAgICAgICAgIHJ1bkphdmFTY3JpcHRQcm9t cHQsCg==