70591 2011-10-21 02:07:29 -0700 [WK2]Critical warning while building WebKit2 GTK+ 2011-10-25 01:19:07 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 0 fbqw68 webkit-unassigned alex cgarcia gustavo kling mrobinson pnormand webkit.review.bot oldest_to_newest 488276 0 fbqw68 2011-10-21 02:07:29 -0700 Below are the critical warnings displayed while building webkit. ../../Source/WebKit2/WebProcess/WebPage/WebPage.cpp: In member function ‘void WebKit::WebPage::performDragControllerAction(uint64_t, WebCore::DragData)’: ../../Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1818:16: warning: possible problem detected in invocation of delete operator: ../../Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1816:24: warning: ‘data’ has incomplete type ../../Source/WebCore/platform/DragData.h:60:7: warning: forward declaration of ‘struct WebCore::DataObjectGtk’ ../../Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1818:16: note: neither the destructor nor the class-specific operator delete will be called, even if they are declared when the class is defined. ../../Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1849:12: warning: possible problem detected in invocation of delete operator: ../../Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1847:20: warning: ‘data’ has incomplete type ../../Source/WebCore/platform/DragData.h:60:7: warning: forward declaration of ‘struct WebCore::DataObjectGtk’ ../../Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1849:12: note: neither the destructor nor the class-specific operator delete will be called, even if they are declared when the class is defined. 488281 1 111927 fbqw68 2011-10-21 02:26:11 -0700 Created attachment 111927 patch for critical warnings while building webkit patch for critical warnings while building webkit 488435 2 111927 mrobinson 2011-10-21 09:30:25 -0700 Comment on attachment 111927 patch for critical warnings while building webkit I think it would be better to include DataObjectGtk.h in the actual C++ file instead of removing this forward-declaration. 489185 3 112151 fbqw68 2011-10-23 22:42:33 -0700 Created attachment 112151 Incorporated review comments and Updated patch Incorporated review comments and Updated patch 489186 4 webkit.review.bot 2011-10-23 22:45:00 -0700 Attachment 112151 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 489188 5 112151 darin 2011-10-23 22:47:57 -0700 Comment on attachment 112151 Incorporated review comments and Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=112151&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:132 > +#include"DataObjectGtk.h" missing space here after include >> Source/WebKit2/ChangeLog:8 >> + * WebProcess/WebPage/WebPage.cpp:Included DataObjectGtk.h to avoid warrings for GTK > > Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] warnings rather than warrings 489193 6 112153 fbqw68 2011-10-23 23:00:20 -0700 Created attachment 112153 Updated the new patch Updated the new patch. 489194 7 112153 mrobinson 2011-10-23 23:05:38 -0700 Comment on attachment 112153 Updated the new patch View in context: https://bugs.webkit.org/attachment.cgi?id=112153&action=review > Source/WebKit2/ChangeLog:8 > + * WebProcess/WebPage/WebPage.cpp: Included DataObjectGtk.h to avoid warrings for GTK The code change is fine, but I'm curious why you did not fix the spelling of warning in the ChangeLog. 489873 8 fbqw68 2011-10-24 22:23:58 -0700 I verified style on patch. I do not know that it won't work on patch. 489875 9 mrobinson 2011-10-24 22:33:53 -0700 (In reply to comment #8) > I verified style on patch. I do not know that it won't work on patch. I'm confused now. The style bot cannot find spelling errors as far as I know. :) Maybe you just missed in Darin's review he mentioned that you misspelled "warnings" as "warrings." 489880 10 fbqw68 2011-10-24 23:15:37 -0700 It's not a spelling error. Error due to missing white space in ChangeLog file. 489889 11 mrobinson 2011-10-24 23:49:22 -0700 (In reply to comment #10) > It's not a spelling error. Error due to missing white space in ChangeLog file. In the last line of Darin's review he said: "warnings rather than warrings" which referred to a misspelling in the ChangeLog. I'm sorry to make such a big deal out of such an insignificant error, but I guess you didn't see that in the review. I'll gladly r+ this patch ASAP if you fix that. 489894 12 fbqw68 2011-10-24 23:53:23 -0700 I already submitted new patch(comment #6). 489895 13 112153 mrobinson 2011-10-24 23:56:08 -0700 Comment on attachment 112153 Updated the new patch View in context: https://bugs.webkit.org/attachment.cgi?id=112153&action=review >> Source/WebKit2/ChangeLog:8 >> + * WebProcess/WebPage/WebPage.cpp: Included DataObjectGtk.h to avoid warrings for GTK > > The code change is fine, but I'm curious why you did not fix the spelling of warning in the ChangeLog. The word is still misspelled. 489904 14 112301 fbqw68 2011-10-25 00:12:08 -0700 Created attachment 112301 Updated spelling mistake Updated spelling mistake. Thanks Robinson. 489913 15 112301 webkit.review.bot 2011-10-25 01:19:02 -0700 Comment on attachment 112301 Updated spelling mistake Clearing flags on attachment: 112301 Committed r98325: <http://trac.webkit.org/changeset/98325> 489914 16 webkit.review.bot 2011-10-25 01:19:07 -0700 All reviewed patches have been landed. Closing bug. 111927 2011-10-21 02:26:11 -0700 2011-10-23 22:42:33 -0700 patch for critical warnings while building webkit patch_for_bug_70591 text/plain 1109 fbqw68 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk4MDkxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMTAtMjEgIFZhbXNoaWty aXNobmEgWWVsbGVua2kgIDx2YW1zaGlAbW90b3JvbGEuY29tPgorCisgICAgICAgIENyaXRpY2Fs IHdhcm5pbmcgd2hpbGUgYnVpbGRpbmcgd2Via2l0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDU5MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vRHJhZ0RhdGEuaDogSW5jbHVkZWQgRGF0 YU9iamVjdEd0ay5oIGluc3RlYWQgb2YgZm9yd2FyZCBkZWNsYXJhdGlvbgorCiAyMDExLTEwLTIw ICBBbmRyZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIElu c3BlY3RvcjogbWFrZSBleHRlbnNpb24gdGVzdHMgcGFzcyBvbiBjaHJvbWl1bQpJbmRleDogU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vRHJhZ0RhdGEuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9EcmFnRGF0YS5oCShyZXZpc2lvbiA5ODA2NSkKKysrIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL0RyYWdEYXRhLmgJKHdvcmtpbmcgY29weSkKQEAgLTU2LDkgKzU2LDcgQEAK ICNlbGlmIFBMQVRGT1JNKFdYKQogdHlwZWRlZiBjbGFzcyB3eERhdGFPYmplY3QqIERyYWdEYXRh UmVmOwogI2VsaWYgUExBVEZPUk0oR1RLKQotbmFtZXNwYWNlIFdlYkNvcmUgewotY2xhc3MgRGF0 YU9iamVjdEd0azsKLX0KKyNpbmNsdWRlIkRhdGFPYmplY3RHdGsuaCIKIHR5cGVkZWYgV2ViQ29y ZTo6RGF0YU9iamVjdEd0ayogRHJhZ0RhdGFSZWY7CiAjZWxpZiBQTEFURk9STShDSFJPTUlVTSkK ICNpbmNsdWRlICJEcmFnRGF0YVJlZi5oIgo= 112151 2011-10-23 22:42:33 -0700 2011-10-23 23:00:20 -0700 Incorporated review comments and Updated patch patch2_for_bug_70591 text/plain 1040 fbqw68 SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAJ KHJldmlzaW9uIDk4MjAzKQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dl YlBhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjgsNiArMTI4LDEwIEBACiAjaW5jbHVkZSA8 UU1pbWVEYXRhPgogI2VuZGlmCiAKKyNpZiBQTEFURk9STShHVEspCisjaW5jbHVkZSJEYXRhT2Jq ZWN0R3RrLmgiCisjZW5kaWYKKwogI2lmbmRlZiBOREVCVUcKICNpbmNsdWRlIDx3dGYvUmVmQ291 bnRlZExlYWtDb3VudGVyLmg+CiAjZW5kaWYKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk4MjE1 KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs MTIgQEAKKzIwMTEtMTAtMjMgIFZhbXNoaWtyaXNobmEgWWVsbGVua2kgIDx2YW1zaGlAbW90b3Jv bGEuY29tPgorCisgICAgICAgIFtXSzJdQ3JpdGljYWwgd2FybmluZyB3aGlsZSBidWlsZGluZyBX ZWJLaXQyIEdUSysKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTcwNTkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6SW5jbHVkZWQgRGF0YU9iamVjdEd0 ay5oIHRvIGF2b2lkIHdhcnJpbmdzIGZvciBHVEsKKwogMjAxMS0xMC0yMyAgTWFyayBIYWhuZW5i ZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBnZXRDb25zdHJ1 Y3REYXRhVmlydHVhbAo= 112153 2011-10-23 23:00:20 -0700 2011-10-25 00:12:08 -0700 Updated the new patch patch2_for_bug_70591 text/plain 1042 fbqw68 SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAJ KHJldmlzaW9uIDk4MjAzKQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dl YlBhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjgsNiArMTI4LDEwIEBACiAjaW5jbHVkZSA8 UU1pbWVEYXRhPgogI2VuZGlmCiAKKyNpZiBQTEFURk9STShHVEspCisjaW5jbHVkZSAiRGF0YU9i amVjdEd0ay5oIgorI2VuZGlmCisKICNpZm5kZWYgTkRFQlVHCiAjaW5jbHVkZSA8d3RmL1JlZkNv dW50ZWRMZWFrQ291bnRlci5oPgogI2VuZGlmCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCShyZXZpc2lvbiA5ODIx NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDEyIEBACisyMDExLTEwLTIzICBWYW1zaGlrcmlzaG5hIFllbGxlbmtpICA8dmFtc2hpQG1vdG9y b2xhLmNvbT4KKworICAgICAgICBbV0syXUNyaXRpY2FsIHdhcm5pbmcgd2hpbGUgYnVpbGRpbmcg V2ViS2l0MiBHVEsrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03MDU5MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOiBJbmNsdWRlZCBEYXRhT2JqZWN0 R3RrLmggdG8gYXZvaWQgd2FycmluZ3MgZm9yIEdUSworCiAyMDExLTEwLTIzICBNYXJrIEhhaG5l bmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGdldENvbnN0 cnVjdERhdGFWaXJ0dWFsCg== 112301 2011-10-25 00:12:08 -0700 2011-10-25 01:19:02 -0700 Updated spelling mistake patch2_for_bug_70591 text/plain 1042 fbqw68 SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAJ KHJldmlzaW9uIDk4MjAzKQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dl YlBhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjgsNiArMTI4LDEwIEBACiAjaW5jbHVkZSA8 UU1pbWVEYXRhPgogI2VuZGlmCiAKKyNpZiBQTEFURk9STShHVEspCisjaW5jbHVkZSAiRGF0YU9i amVjdEd0ay5oIgorI2VuZGlmCisKICNpZm5kZWYgTkRFQlVHCiAjaW5jbHVkZSA8d3RmL1JlZkNv dW50ZWRMZWFrQ291bnRlci5oPgogI2VuZGlmCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCShyZXZpc2lvbiA5ODIx NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDEyIEBACisyMDExLTEwLTIzICBWYW1zaGlrcmlzaG5hIFllbGxlbmtpICA8dmFtc2hpQG1vdG9y b2xhLmNvbT4KKworICAgICAgICBbV0syXUNyaXRpY2FsIHdhcm5pbmcgd2hpbGUgYnVpbGRpbmcg V2ViS2l0MiBHVEsrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03MDU5MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOiBJbmNsdWRlZCBEYXRhT2JqZWN0 R3RrLmggdG8gYXZvaWQgd2FybmluZ3MgZm9yIEdUSworCiAyMDExLTEwLTIzICBNYXJrIEhhaG5l bmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGdldENvbnN0 cnVjdERhdGFWaXJ0dWFsCg==