7058 2006-02-03 16:05:11 -0800 REGRESSION: Tab seems to be loading forever after redirect 2006-06-26 14:05:25 -0700 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 RESOLVED FIXED InRadar, Regression P1 Normal --- 9610 6309 1 daniele.metilli webkit-unassigned adele ben bkn3 darin ddkilzer jmaxwell sullivan oldest_to_newest 31214 0 daniele.metilli 2006-02-03 16:05:11 -0800 Follow these steps: - Open WebKit, latest nightly. - WebKit will load the "thank you" page. Open another tab. - Look at the tab bar: the first tab has always that spinning symbol. Please note that: - This happens with every site, not just the "thank you" page. - It happens also with the fourth tab, not just the first. 31225 1 sullivan 2006-02-03 18:19:19 -0800 I suspect this is the same as radar bug 4432562. That bug has to do with redirects. Apparently WebKit isn't sending all the same webView: delegate callbacks to Safari, and Safari thinks there's still a pending reload forever. This bug claims that it happens for every page though, which would be different. Radar bug 4432562 only happens on windows/tabs in which a redirect has occurred. (Once the redirect occurs though, loading additional pages in the same window/tab still shows the problem.) 31287 2 daniele.metilli 2006-02-04 06:21:57 -0800 I am the original reporter, and I can confirm that it is a duplicate of 4432562. I hadn't fully understood the problem. I should have said: - It happens with every tab when loading Webkit.app/Contents/Resources/start.html or any other redirect. - It happens with every page loaded in the same tab after the redirect. 31293 3 sullivan 2006-02-04 08:01:27 -0800 It would be great to figure out when this broke, by checking older nightly builds. 31298 4 ddkilzer 2006-02-04 08:45:04 -0800 I did a binary search of the nightly builds and found the following (we lucked out!): Not broken: WebKit-SVN-r12514.dmg Broken: WebKit-SVN-r12515.dmg Revision r12515 was Darin's Timer update (no Bugzilla bug to reference), so adding him to the CC list and confirming bug. Note that I can always get this bug to occur when I click the "Check Mail" button on Yahoo! Mail after I've logged in. (I'm not sure if a redirect needs to occur within the window before that, but I always get to Yahoo! Mail after typing in http://mail.yahoo.com/ in the address bar.) Also note that no amount of hitting Cmd-. or clicking the "X" button will stop the spinner after this occurs. 31300 5 sullivan 2006-02-04 09:14:25 -0800 Great work tracking this down! I presume this means the checkin in WebCore with the following comment in ChangeLog: - use Timer for everything, kill timer features of QObject, QTimer, QTimerEvent Safari gets into a state where it knows an instant client redirect is pending, but then this state never gets cleared. So it thinks an instant client redirect is pending forever, hence the UI looks like we're still loading as we wait. So the change that broke it is either something about sending a 0-interval client redirect webView: delegate call back where one was not sent before, or something about not cancelling such a redirect. 31331 6 ddkilzer 2006-02-04 10:25:42 -0800 (In reply to comment #5) > - use Timer for everything, kill timer features of QObject, QTimer, QTimerEvent That's the one! > Safari gets into a state where it knows an instant client redirect is pending, > but then this state never gets cleared. So it thinks an instant client redirect > is pending forever, hence the UI looks like we're still loading as we wait. So > the change that broke it is either something about sending a 0-interval client > redirect webView: delegate call back where one was not sent before, or > something about not cancelling such a redirect. I added some debugging printf statements to the code and found that the bug only occurs when MacFrame::startRedirectionTimer() is called. It, in turn, calls Frame::startRedirectionTimer() which calls d->m_redirectionTimer.startOneShot(d->m_delayRedirect) with d->m_delayRedirect equal to 0.0. I can't figure out why MacFrame::startRedirectionTimer() is only called on some redirects but not others, though. 31345 7 ddkilzer 2006-02-04 11:41:27 -0800 Interestingly enough, Attachment 6173 ("Test case") from Bug 6309 triggers this bug every time. 31394 8 ddkilzer 2006-02-04 22:16:21 -0800 (In reply to comment #7) > Interestingly enough, Attachment 6173 [edit] ("Test case") from Bug 6309 triggers this > bug every time. Ignore. This is probably a different cause. 31631 9 sullivan 2006-02-06 14:12:29 -0800 *** Bug 7106 has been marked as a duplicate of this bug. *** 31673 10 6315 ddkilzer 2006-02-06 22:13:08 -0800 Created attachment 6315 Patch committed to svn 31807 11 ddkilzer 2006-02-07 21:21:25 -0800 *** Bug 3552 has been marked as a duplicate of this bug. *** 31809 12 ddkilzer 2006-02-07 21:21:30 -0800 *** Bug 6309 has been marked as a duplicate of this bug. *** 44495 13 ddkilzer 2006-06-02 20:46:53 -0700 *** Bug 9269 has been marked as a duplicate of this bug. *** 6315 2006-02-06 22:13:08 -0800 2006-02-06 22:13:08 -0800 Patch committed to svn bug-7058.diff text/plain 4592 ddkilzer SW5kZXg6IFdlYkNvcmUvbWFudWFsLXRlc3RzL3JlZGlyZWN0aW9uLXRhcmdldC5odG1sCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvbWFudWFsLXRlc3RzL3JlZGlyZWN0aW9uLXRhcmdldC5odG1sCShy ZXZpc2lvbiAwKQorKysgV2ViQ29yZS9tYW51YWwtdGVzdHMvcmVkaXJlY3Rpb24tdGFyZ2V0Lmh0 bWwJKHJldmlzaW9uIDEyNTk4KQpAQCAtMCwwICsxLDYgQEAKKzxwPgorVGhpcyB0ZXN0IGNoZWNr cyB0aGF0IHJlZGlyZWN0aW9uIGRvZXMgbm90IGxlYXZlIFNhZmFyaSB0aGlua2luZyBpdCdzIHN0 aWxsIGxvYWRpbmcuCitDaGVjayB0aGF0IHRoZSB0aXRsZSBiYXIgZG9lcyBub3Qgc2F5ICJMb2Fk aW5nIiBhbnkgbW9yZS4KK1RoZSBidWcgd2FzIDxhIGhyZWY9InJkYXI6Ly9wcm9ibGVtLzQ0MzI1 NjIiPjQ0MzI1NjI8L2E+IGluIFJhZGFyIGFuZAorPGEgaHJlZj0iaHR0cDovL2J1Z3ppbGxhLm9w ZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD03MDU4Ij43MDU4PC9hPiBpbiBCdWd6aWxsYS4K KzwvcD4KClByb3BlcnR5IGNoYW5nZXMgb246IFdlYkNvcmUvbWFudWFsLXRlc3RzL3JlZGlyZWN0 aW9uLXRhcmdldC5odG1sCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KTmFtZTogc3ZuOm1pbWUtdHlwZQogICArIHRleHQv aHRtbApOYW1lOiBzdm46ZW9sLXN0eWxlCiAgICsgbmF0aXZlCgpJbmRleDogV2ViQ29yZS9tYW51 YWwtdGVzdHMvcmVkaXJlY3QuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL21hbnVhbC10ZXN0 cy9yZWRpcmVjdC5odG1sCShyZXZpc2lvbiAwKQorKysgV2ViQ29yZS9tYW51YWwtdGVzdHMvcmVk aXJlY3QuaHRtbAkocmV2aXNpb24gMTI1OTgpCkBAIC0wLDAgKzEsMiBAQAorPG1ldGEgaHR0cC1l cXVpdj0icmVmcmVzaCIgY29udGVudD0iMDt1cmw9cmVkaXJlY3Rpb24tdGFyZ2V0Lmh0bWwiPgor PHA+U2VlIHJlZGlyZWN0aW9uLXRhcmdldC5odG1sIGZvciBkZXRhaWxzIG9mIHdoYXQgdGhpcyB0 ZXN0cy48L3A+CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBXZWJDb3JlL21hbnVhbC10ZXN0cy9yZWRp cmVjdC5odG1sCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KTmFtZTogc3ZuOm1pbWUtdHlwZQogICArIHRleHQvaHRtbApO YW1lOiBzdm46ZW9sLXN0eWxlCiAgICsgbmF0aXZlCgpJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNTk3KQorKysgV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNTk4KQpAQCAtMSwzICsxLDIwIEBACisyMDA2LTAy LTA2ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBKb2huLgorCisgICAgICAgIC0gZml4IDxyZGFyOi8vcHJvYmxlbS80NDMyNTYyPiBSRUdSRVNT SU9OIChUT1QpOgorICAgICAgICAgIFNhZmFyaSdzICJzdG9wIGxvYWRpbmciIGFjdGl2ZSwgInZp ZXcgc291cmNlIiBpbmFjdGl2ZSBhZnRlciBwYWdlIGxvYWQgWzcwNThdCisgICAgICAgICAgaHR0 cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD03MDU4CisKKyAgICAg ICAgKiBwYWdlL0ZyYW1lLmg6IE1ha2UgcmVkaXJlY3Rpb25UaW1lckZpcmVkIHZpcnR1YWwuCisg ICAgICAgICogYnJpZGdlL21hYy9NYWNGcmFtZS5oOiBPdmVycmlkZSByZWRpcmVjdGlvblRpbWVy RmlyZWQuCisgICAgICAgICogYnJpZGdlL21hYy9NYWNGcmFtZS5tbTogKFdlYkNvcmU6Ok1hY0Zy YW1lOjpyZWRpcmVjdGlvblRpbWVyRmlyZWQpOgorICAgICAgICBTZW5kIHRoZSByZWRpcmVjdGlv blRpbWVyQ2FuY2VsbGVkIGNhbGxiYWNrIGhlcmUsIGV2ZW4gdGhvdWdoIGl0IGhhcworICAgICAg ICBmaXJlZCByYXRoZXIgdGhhbiBiZWluZyBjYW5jZWxsZWQuCisKKyAgICAgICAgKiBtYW51YWwt dGVzdHMvcmVkaXJlY3QuaHRtbDogQWRkZWQuCisgICAgICAgICogbWFudWFsLXRlc3RzL3JlZGly ZWN0aW9uLXRhcmdldC5odG1sOiBBZGRlZC4KKwogMjAwNi0wMi0wNiAgRGF2aWQgSGFycmlzb24g IDxoYXJyaXNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSm9obi4KSW5kZXg6 IFdlYkNvcmUvYnJpZGdlL21hYy9NYWNGcmFtZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYnJp ZGdlL21hYy9NYWNGcmFtZS5oCShyZXZpc2lvbiAxMjU5NykKKysrIFdlYkNvcmUvYnJpZGdlL21h Yy9NYWNGcmFtZS5oCShyZXZpc2lvbiAxMjU5OCkKQEAgLTMxNiw2ICszMTYsNyBAQAogCiAgICAg dmlydHVhbCB2b2lkIHN0YXJ0UmVkaXJlY3Rpb25UaW1lcigpOwogICAgIHZpcnR1YWwgdm9pZCBz dG9wUmVkaXJlY3Rpb25UaW1lcigpOworICAgIHZpcnR1YWwgdm9pZCByZWRpcmVjdGlvblRpbWVy RmlyZWQoVGltZXI8RnJhbWU+Kik7CiAKIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIGtodG1s TW91c2VQcmVzc0V2ZW50KE1vdXNlUHJlc3NFdmVudCAqKTsKSW5kZXg6IFdlYkNvcmUvYnJpZGdl L21hYy9NYWNGcmFtZS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JyaWRnZS9tYWMvTWFjRnJh bWUubW0JKHJldmlzaW9uIDEyNTk3KQorKysgV2ViQ29yZS9icmlkZ2UvbWFjL01hY0ZyYW1lLm1t CShyZXZpc2lvbiAxMjU5OCkKQEAgLTkxNCw3ICs5MTQsMjAgQEAKICAgICAgICAgW19icmlkZ2Ug cmVwb3J0Q2xpZW50UmVkaXJlY3RDYW5jZWxsZWQ6ZC0+bV9jYW5jZWxXaXRoTG9hZEluUHJvZ3Jl c3NdOwogfQogCit2b2lkIE1hY0ZyYW1lOjpyZWRpcmVjdGlvblRpbWVyRmlyZWQoVGltZXI8RnJh bWU+KiB0aW1lcikKK3sKKyAgICAvLyBOb3RlLCBkZXNwaXRlIGl0cyBuYW1lLCB3ZSBtdXN0IGNh bGwgInJlZGlyZWN0IGNhbmNlbGxlZCIgZXZlbiB3aGVuIHRoZQorICAgIC8vIHJlZGlyZWN0IGhh cyBjb21wbGV0ZWQgc3VjY2Vzc2Z1bGx5LiBBbHRob3VnaCB0aGF0IG1heSBub3QgaGF2ZSBiZWVu IG91cgorICAgIC8vIG9yaWdpbmFsIGludGVudCwgU2FmYXJpIGRlcGVuZHMgb24gdGhpcyBiZWhh dmlvciBhdCB0aGUgdGltZSBvZiB0aGlzIHdyaXRpbmcuCisgICAgLy8gU2VlIFJhZGFyIDQ0MzI1 NjIgYW5kIEJ1Z3ppbGxhIDcwNTguCiAKKyAgICAvLyBEb24ndCByZXBvcnQgaGlzdG9yeSBuYXZp Z2F0aW9ucywganVzdCBhY3R1YWwgcmVkaXJlY3Rpb24uCisgICAgaWYgKGQtPm1fc2NoZWR1bGVk UmVkaXJlY3Rpb24gIT0gaGlzdG9yeU5hdmlnYXRpb25TY2hlZHVsZWQpCisgICAgICAgIFtfYnJp ZGdlIHJlcG9ydENsaWVudFJlZGlyZWN0Q2FuY2VsbGVkOmQtPm1fY2FuY2VsV2l0aExvYWRJblBy b2dyZXNzXTsKKworICAgIEZyYW1lOjpyZWRpcmVjdGlvblRpbWVyRmlyZWQodGltZXIpOworfQor CiBRU3RyaW5nIE1hY0ZyYW1lOjp1c2VyQWdlbnQoKSBjb25zdAogewogICAgIEtXUV9CTE9DS19F WENFUFRJT05TOwpJbmRleDogV2ViQ29yZS9wYWdlL0ZyYW1lLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wYWdlL0ZyYW1lLmgJKHJldmlzaW9uIDEyNTk3KQorKysgV2ViQ29yZS9wYWdlL0ZyYW1l LmgJKHJldmlzaW9uIDEyNTk4KQpAQCAtODAwLDYgKzgwMCw4IEBACiAgIHZpcnR1YWwgRnJhbWUq IGNyZWF0ZUZyYW1lKGNvbnN0IEtVUkwmIHVybCwgY29uc3QgUVN0cmluZyYgbmFtZSwgUmVuZGVy UGFydCogcmVuZGVyZXIsIGNvbnN0IERPTVN0cmluZyYgcmVmZXJyZXIpID0gMDsKICAgdmlydHVh bCBPYmplY3RDb250ZW50VHlwZSBvYmplY3RDb250ZW50VHlwZShjb25zdCBLVVJMJiB1cmwsIGNv bnN0IFFTdHJpbmcmIG1pbWVUeXBlKSA9IDA7CiAKKyAgICB2aXJ0dWFsIHZvaWQgcmVkaXJlY3Rp b25UaW1lckZpcmVkKFRpbWVyPEZyYW1lPiopOworCiBwdWJsaWMgc2xvdHM6CiAgIC8qKgogICAg KiBTdG9wcyBhbGwgYW5pbWF0ZWQgaW1hZ2VzIG9uIHRoZSBjdXJyZW50IGFuZCBjaGlsZCBwYWdl cwpAQCAtODEzLDcgKzgxNSw2IEBACiAgIHZvaWQgc2xvdFJlc3RvcmVEYXRhKCBjb25zdCBCeXRl QXJyYXkgJmRhdGEgKTsKICAgdm9pZCBzbG90RmluaXNoZWQoIEtJTzo6Sm9iKiApOwogICB2b2lk IHNsb3RGaW5pc2hlZFBhcnNpbmcoKTsKLSAgICB2b2lkIHJlZGlyZWN0aW9uVGltZXJGaXJlZChU aW1lcjxGcmFtZT4qKTsKICAgdm9pZCBzbG90UmVkaXJlY3Rpb24oS0lPOjpKb2IqLCBjb25zdCBL VVJMJik7CiAKICAgdm9pZCBzbG90SW5jWm9vbSgpOwo=