70554 2011-10-20 15:36:39 -0700 [Chromium] Fix opaque flag default and for ImageLayerChromium 2011-10-20 19:23:17 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 danakj webkit-unassigned backer danakj jamesr piman webkit.review.bot oldest_to_newest 487933 0 danakj 2011-10-20 15:36:39 -0700 [Chromium] Fix opaque flag default and for ImageLayerChromium 487936 1 111858 danakj 2011-10-20 15:38:28 -0700 Created attachment 111858 Patch 487940 2 danakj 2011-10-20 15:39:58 -0700 I thought I'd fix the opaque flag in a separate CL, especially since the ImageLayerChromium seems like it can be fixed along with it. Is this right? 487941 3 piman 2011-10-20 15:41:57 -0700 This LGTM 487962 4 111858 jamesr 2011-10-20 16:03:25 -0700 Comment on attachment 111858 Patch R=me Can you construct some layout tests with opaque and non-opaque images that get composited (or verify that we have such tests already) as part of the patch that disables blending for opaque layers? I want to make sure we have testing there. 487998 5 111872 danakj 2011-10-20 16:46:51 -0700 Created attachment 111872 Fixed changelog 488089 6 111872 webkit.review.bot 2011-10-20 19:23:13 -0700 Comment on attachment 111872 Fixed changelog Clearing flags on attachment: 111872 Committed r98055: <http://trac.webkit.org/changeset/98055> 488090 7 webkit.review.bot 2011-10-20 19:23:17 -0700 All reviewed patches have been landed. Closing bug. 111858 2011-10-20 15:38:28 -0700 2011-10-20 16:46:45 -0700 Patch bug-70554-20111020183827.patch text/plain 2387 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogOTgwMjcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjYThjZGMzNDMyMDljMjg1 ZDNjZmUzMjQyZGQ5ZWVmOGIwMDRmZTJjLi5jNWU2MjUzNmE2N2RhYWQwMzRmZWM0MzgxNmRiZmEz NDExOTk2ODVhIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMTAtMjAgIERhbmEg SmFuc2VucyAgPGRhbmFrakBnb29nbGUuY29tPgorCisgICAgICAgIFtDaHJvbWl1bV0gRml4IG9w YXF1ZSBmbGFnIGRlZmF1bHQgYW5kIGZvciBJbWFnZUxheWVyQ2hyb21pdW0KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwNTU0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBsYXlvdXQgdGVz dHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9JbWFnZUxheWVyQ2hy b21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VMYXllckNocm9taXVtOjpzZXRDb250 ZW50cyk6IFNldCBvcGFxdWUgZmxhZyBiYXNlZCBvbiBpZiB0aGUgaW1hZ2UgY2xhaW1zIHRvIGhh dmUgYWxwaGEuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJv bWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXllckNocm9taXVtOjpMYXllckNocm9taXVt KTogTWF0Y2ggdGhlIGRlZmF1bHQgb3BhcXVlIHZhbHVlIGluIEdyYXBoaWNzTGF5ZXJDaHJvbWl1 bS4KKwogMjAxMS0xMC0yMCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAog ICAgICAgICBSRUdSRVNTSU9OIChyOTY4MjMpOiBDb250ZXh0dWFsIG1lbnUgY2xvc2VzIGltbWVk aWF0ZWx5IHdoZW4gY29udHJvbC1jbGlja2luZyBpbiBGbGFzaCBwbHVnLWluCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9JbWFnZUxheWVyQ2hy b21pdW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vSW1h Z2VMYXllckNocm9taXVtLmNwcAppbmRleCA5NDE1ZGU0YzYyNTJlYzQzMGRiZDdlZmI3NWE5M2Zj ZDM5ZWZhZjBjLi4zNjMzNjI5NjdhY2NkZWJjMjU1OWUyOWMyNGQ0M2MxYzg4ODgwMzE3IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9JbWFnZUxh eWVyQ2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL0ltYWdlTGF5ZXJDaHJvbWl1bS5jcHAKQEAgLTE0MSw2ICsxNDEsNyBAQCB2b2lkIElt YWdlTGF5ZXJDaHJvbWl1bTo6c2V0Q29udGVudHMoSW1hZ2UqIGNvbnRlbnRzKQogICAgIG1faW1h Z2VGb3JDdXJyZW50RnJhbWUgPSBtX2NvbnRlbnRzLT5uYXRpdmVJbWFnZUZvckN1cnJlbnRGcmFt ZSgpOwogICAgIG1fZGlydHlSZWN0ID0gSW50UmVjdChJbnRQb2ludCgwLCAwKSwgYm91bmRzKCkp OwogICAgIHNldE5lZWRzRGlzcGxheSgpOworICAgIHNldE9wYXF1ZSghbV9jb250ZW50cy0+Y3Vy cmVudEZyYW1lSGFzQWxwaGEoKSk7CiB9CiAKIHZvaWQgSW1hZ2VMYXllckNocm9taXVtOjpwYWlu dENvbnRlbnRzSWZEaXJ0eSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9MYXllckNocm9taXVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyQ2hyb21pdW0uY3BwCmluZGV4IGJlOGU3OTA2ZmNk MzIzNjIzZjRkNWQ5MTk3MDFiNzBlY2RlMGE5YmUuLjJkMTU4YWJmNjY2ZTljNTcxMTA5OGYxYzZi OTk2Y2U1YmU0ZDlkNzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL0xheWVyQ2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyQ2hyb21pdW0uY3BwCkBAIC02NCw3ICs2NCw3IEBA IExheWVyQ2hyb21pdW06OkxheWVyQ2hyb21pdW0oQ0NMYXllckRlbGVnYXRlKiBkZWxlZ2F0ZSkK ICAgICAsIG1fb3BhY2l0eSgxLjApCiAgICAgLCBtX2FuY2hvclBvaW50WigwKQogICAgICwgbV9t YXNrc1RvQm91bmRzKGZhbHNlKQotICAgICwgbV9vcGFxdWUodHJ1ZSkKKyAgICAsIG1fb3BhcXVl KGZhbHNlKQogICAgICwgbV9kb3VibGVTaWRlZCh0cnVlKQogICAgICwgbV91c2VzTGF5ZXJTY2lz c29yKGZhbHNlKQogICAgICwgbV9pc05vbkNvbXBvc2l0ZWRDb250ZW50KGZhbHNlKQo= 111872 2011-10-20 16:46:51 -0700 2011-10-20 19:23:13 -0700 Fixed changelog bug-70554-20111020194650.patch text/plain 2389 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogOTgwMjcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjYThjZGMzNDMyMDljMjg1 ZDNjZmUzMjQyZGQ5ZWVmOGIwMDRmZTJjLi41ODM1YjAxYmY5OWJkMThmZWU5NDU3YmMyNGMyM2E0 ZDQ1NzZkNGQ4IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMTAtMjAgIERhbmEg SmFuc2VucyAgPGRhbmFrakBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBGaXgg b3BhcXVlIGZsYWcgZGVmYXVsdCBhbmQgZm9yIEltYWdlTGF5ZXJDaHJvbWl1bQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzA1NTQKKworICAgICAgICBS ZXZpZXdlZCBieSBKYW1lcyBSb2JpbnNvbi4KKworICAgICAgICBDb3ZlcmVkIGJ5IGxheW91dCB0 ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ltYWdlTGF5ZXJD aHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUxheWVyQ2hyb21pdW06OnNldENv bnRlbnRzKTogU2V0IG9wYXF1ZSBmbGFnIGJhc2VkIG9uIGlmIHRoZSBpbWFnZSBjbGFpbXMgdG8g aGF2ZSBhbHBoYS4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllckNo cm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheWVyQ2hyb21pdW06OkxheWVyQ2hyb21p dW0pOiBNYXRjaCB0aGUgZGVmYXVsdCBvcGFxdWUgdmFsdWUgaW4gR3JhcGhpY3NMYXllckNocm9t aXVtLgorCiAyMDExLTEwLTIwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgog CiAgICAgICAgIFJFR1JFU1NJT04gKHI5NjgyMyk6IENvbnRleHR1YWwgbWVudSBjbG9zZXMgaW1t ZWRpYXRlbHkgd2hlbiBjb250cm9sLWNsaWNraW5nIGluIEZsYXNoIHBsdWctaW4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ltYWdlTGF5ZXJD aHJvbWl1bS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9J bWFnZUxheWVyQ2hyb21pdW0uY3BwCmluZGV4IDk0MTVkZTRjNjI1MmVjNDMwZGJkN2VmYjc1YTkz ZmNkMzllZmFmMGMuLjM2MzM2Mjk2N2FjY2RlYmMyNTU5ZTI5YzI0ZDQzYzFjODg4ODAzMTcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ltYWdl TGF5ZXJDaHJvbWl1bS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vSW1hZ2VMYXllckNocm9taXVtLmNwcApAQCAtMTQxLDYgKzE0MSw3IEBAIHZvaWQg SW1hZ2VMYXllckNocm9taXVtOjpzZXRDb250ZW50cyhJbWFnZSogY29udGVudHMpCiAgICAgbV9p bWFnZUZvckN1cnJlbnRGcmFtZSA9IG1fY29udGVudHMtPm5hdGl2ZUltYWdlRm9yQ3VycmVudEZy YW1lKCk7CiAgICAgbV9kaXJ0eVJlY3QgPSBJbnRSZWN0KEludFBvaW50KDAsIDApLCBib3VuZHMo KSk7CiAgICAgc2V0TmVlZHNEaXNwbGF5KCk7CisgICAgc2V0T3BhcXVlKCFtX2NvbnRlbnRzLT5j dXJyZW50RnJhbWVIYXNBbHBoYSgpKTsKIH0KIAogdm9pZCBJbWFnZUxheWVyQ2hyb21pdW06OnBh aW50Q29udGVudHNJZkRpcnR5KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL0xheWVyQ2hyb21pdW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5jcHAKaW5kZXggYmU4ZTc5MDZm Y2QzMjM2MjNmNGQ1ZDkxOTcwMWI3MGVjZGUwYTliZS4uMmQxNThhYmY2NjZlOWM1NzExMDk4ZjFj NmI5OTZjZTViZTRkOWQ3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5jcHAKQEAgLTY0LDcgKzY0LDcg QEAgTGF5ZXJDaHJvbWl1bTo6TGF5ZXJDaHJvbWl1bShDQ0xheWVyRGVsZWdhdGUqIGRlbGVnYXRl KQogICAgICwgbV9vcGFjaXR5KDEuMCkKICAgICAsIG1fYW5jaG9yUG9pbnRaKDApCiAgICAgLCBt X21hc2tzVG9Cb3VuZHMoZmFsc2UpCi0gICAgLCBtX29wYXF1ZSh0cnVlKQorICAgICwgbV9vcGFx dWUoZmFsc2UpCiAgICAgLCBtX2RvdWJsZVNpZGVkKHRydWUpCiAgICAgLCBtX3VzZXNMYXllclNj aXNzb3IoZmFsc2UpCiAgICAgLCBtX2lzTm9uQ29tcG9zaXRlZENvbnRlbnQoZmFsc2UpCg==