70548 2011-10-20 14:25:22 -0700 Make WebCore depend on translator_glsl instead of translator_common 2011-10-20 19:29:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 piman webkit-unassigned kbr webkit.review.bot oldest_to_newest 487885 0 piman 2011-10-20 14:25:22 -0700 Make WebCore depend on translator_glsl instead of translator_common 487886 1 111849 piman 2011-10-20 14:27:05 -0700 Created attachment 111849 Patch 487888 2 piman 2011-10-20 14:29:23 -0700 This change is needed for landing http://codereview.appspot.com/5305052/ in ANGLE. Regardless, it's still the right thing to do, because translator_common is an incomplete library, it depends on symbols implemented in translator_glsl. In WebKit.gyp we also link translator_glsl which makes it work today. translator_glsl does depend on translator_common. 487921 3 111849 kbr 2011-10-20 15:24:43 -0700 Comment on attachment 111849 Patch Did you test against the current version of ANGLE, or do we need to roll forward the ANGLE DEPS in Chromium and then the Chromium revision in Source/WebKit/chromium/DEPS? 487995 4 piman 2011-10-20 16:46:09 -0700 AFAICT it works with the current version of ANGLE on linux, but I don't have a windows machine to test on. 488012 5 kbr 2011-10-20 17:15:00 -0700 (In reply to comment #4) > AFAICT it works with the current version of ANGLE on linux, but I don't have a windows machine to test on. I'm 99% sure this won't work on Windows, since Chrome depends on translator_hlsl on that platform, and we can't link in both. I'll test your patch there to verify. 488045 6 piman 2011-10-20 17:56:01 -0700 As discussed, I'm 99.9% sure we only directly depend on translator_glsl on all chrome platforms: - the code in WebCore asks for a GLSL translator - we already link translator_glsl in chrome - as you mention, we can't link in both translator_hlsl is only used inside of the ANGLE libGLESv2 (without its symbols being exported), but that should be independent. 488065 7 111849 kbr 2011-10-20 18:15:11 -0700 Comment on attachment 111849 Patch OK, I'd forgotten how this worked. Looks okay to me. 488094 8 111849 webkit.review.bot 2011-10-20 19:29:16 -0700 Comment on attachment 111849 Patch Clearing flags on attachment: 111849 Committed r98057: <http://trac.webkit.org/changeset/98057> 488095 9 webkit.review.bot 2011-10-20 19:29:20 -0700 All reviewed patches have been landed. Closing bug. 111849 2011-10-20 14:27:05 -0700 2011-10-20 19:29:16 -0700 Patch bug-70548-20111020142704.patch text/plain 1986 piman U3VidmVyc2lvbiBSZXZpc2lvbjogOTc4NzAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwNTY0N2U4M2QxYmY1ODcy MjhhNWZkZDIyOWVhMTMxMGEzMTc2Yzk4Li5kMDY2YTY4MjNiOTcyOGQwNDFmZDY3MGYyOGNkNDU0 OGVlZGEyNzg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMjAgIEFudG9p bmUgTGFib3VyICA8cGltYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIE1ha2UgV2ViQ29yZSBk ZXBlbmQgb24gdHJhbnNsYXRvcl9nbHNsIGluc3RlYWQgb2YgdHJhbnNsYXRvcl9jb21tb24KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwNTQ4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBhIGJ1 aWxkLW9ubHkgZml4LiBUZXN0ZWQgYnkgY2hlY2tpbmcgV2ViS2l0IHN0aWxsIGNvbXBpbGVzIGFu ZAorICAgICAgICBsaW5rLgorCisgICAgICAgICogV2ViQ29yZS5neXAvV2ViQ29yZS5neXA6CisK IDIwMTEtMTAtMTkgIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0Lm9yZz4KIAogICAgICAgICBV bnJldmlld2VkLCByb2xsaW5nIG91dCByOTc4NjMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cCBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dl YkNvcmUuZ3lwCmluZGV4IDUwOTk2NjcxYWM3Y2Y5MTYwNmQ5ZmZmNjVhZDM0ZTE4ZWM5NmY2MDAu LmZjMDYzYmNhYmRlNDRiZTg2MjU3YzhiYmRjMDc2ODE0ZjkzMzVjY2IgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCkBAIC0xMDk4LDcgKzEwOTgsNyBAQAogICAgICAgICAn PChjaHJvbWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0eS9ucGFwaS9ucGFwaS5neXA6bnBhcGknLAog ICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0eS9vdHMvb3RzLmd5cDpvdHMn LAogICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0eS9zcWxpdGUvc3FsaXRl Lmd5cDpzcWxpdGUnLAotICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0eS9h bmdsZS9zcmMvYnVpbGRfYW5nbGUuZ3lwOnRyYW5zbGF0b3JfY29tbW9uJywKKyAgICAgICAgJzwo Y2hyb21pdW1fc3JjX2RpcikvdGhpcmRfcGFydHkvYW5nbGUvc3JjL2J1aWxkX2FuZ2xlLmd5cDp0 cmFuc2xhdG9yX2dsc2wnLAogICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS92OC90b29scy9n eXAvdjguZ3lwOnY4JywKICAgICAgICAgJzwobGlianBlZ19neXBfcGF0aCk6bGlianBlZycsCiAg ICAgICBdLApAQCAtMTExNSw3ICsxMTE1LDcgQEAKICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2Rp cikvdGhpcmRfcGFydHkvbnBhcGkvbnBhcGkuZ3lwOm5wYXBpJywKICAgICAgICAgJzwoY2hyb21p dW1fc3JjX2RpcikvdGhpcmRfcGFydHkvb3RzL290cy5neXA6b3RzJywKICAgICAgICAgJzwoY2hy b21pdW1fc3JjX2RpcikvdGhpcmRfcGFydHkvc3FsaXRlL3NxbGl0ZS5neXA6c3FsaXRlJywKLSAg ICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvdGhpcmRfcGFydHkvYW5nbGUvc3JjL2J1aWxkX2Fu Z2xlLmd5cDp0cmFuc2xhdG9yX2NvbW1vbicsCisgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIp L3RoaXJkX3BhcnR5L2FuZ2xlL3NyYy9idWlsZF9hbmdsZS5neXA6dHJhbnNsYXRvcl9nbHNsJywK ICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvdjgvdG9vbHMvZ3lwL3Y4Lmd5cDp2OCcsCiAg ICAgICAgICc8KGxpYmpwZWdfZ3lwX3BhdGgpOmxpYmpwZWcnLAogICAgICAgXSwK