70538 2011-10-20 13:08:06 -0700 Implement mechanism to enable privileged webgl extensions 2011-10-21 09:43:37 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zmo zmo cmarrin fishd kbr webkit.review.bot oldest_to_newest 487808 0 zmo 2011-10-20 13:08:06 -0700 Per discussion with Darin Fisher, we use page/settings for the purpose and expose it through WebSettings to chromium side. 487813 1 111833 zmo 2011-10-20 13:14:10 -0700 Created attachment 111833 Patch 487815 2 webkit.review.bot 2011-10-20 13:15:31 -0700 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 487833 3 zmo 2011-10-20 13:33:07 -0700 Darin, please approve, don't disapprove. Ken, please review. Chromium-side patch will be uploaded for review shortly after. The whole mechanism has been tested. 487843 4 111833 kbr 2011-10-20 13:44:35 -0700 Comment on attachment 111833 Patch These changes look good to me. 488441 5 zmo 2011-10-21 09:43:37 -0700 Landed as r98104. The webkit-patch land script was stuck for some reason. Manually closing this bug. 111833 2011-10-20 13:14:10 -0700 2011-10-20 21:45:44 -0700 Patch bug-70538-20111020131404.patch text/plain 6147 zmo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk4MDE4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMTAtMjAgIFpoZW55YW8g TW8gIDx6bW9AZ29vZ2xlLmNvbT4KKworICAgICAgICBJbXBsZW1lbnQgbWVjaGFuaXNtIHRvIGVu YWJsZSBwcml2aWxlZ2VkIHdlYmdsIGV4dGVuc2lvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwNTM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRl eHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0OjphbGxvd1By aXZpbGVnZWRFeHRlbnNpb25zKTogY2hlY2sgcGFnZS9TZXR0aW5ncyBmbGFnLgorICAgICAgICAq IHBhZ2UvU2V0dGluZ3MuY3BwOiBBZGQgdGhlIGZsYWcuCisgICAgICAgIChXZWJDb3JlOjpTZXR0 aW5nczo6U2V0dGluZ3MpOgorICAgICAgICAoV2ViQ29yZTo6U2V0dGluZ3M6OnNldFByaXZpbGVn ZWRXZWJHTEV4dGVuc2lvbnNFbmFibGVkKToKKyAgICAgICAgKiBwYWdlL1NldHRpbmdzLmg6IERp dHRvLgorICAgICAgICAoV2ViQ29yZTo6U2V0dGluZ3M6OnByaXZpbGVnZWRXZWJHTEV4dGVuc2lv bnNFbmFibGVkKToKKwogMjAxMS0xMC0yMCAgVmluY2VudCBTY2hlaWIgIDxzY2hlaWJAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIE1vdXNlTG9jayBjb21waWxlIGFuZCBydW4gdGltZSBmbGFncy4K SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJp bmdDb250ZXh0LmNwcAkocmV2aXNpb24gOTc5OTApCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL2Nh bnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NzcsNyAr NDc3LDkgQEAgdm9pZCBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OnNldHVwRmxhZ3MoKQogCiBib29s IFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6YWxsb3dQcml2aWxlZ2VkRXh0ZW5zaW9ucygpIGNvbnN0 CiB7Ci0gICAgLy8gRklYTUU6IGltcGxlbWVudCB0aGlzIGZ1bmN0aW9uLgorICAgIFBhZ2UqIHAg PSBjYW52YXMoKS0+ZG9jdW1lbnQoKS0+cGFnZSgpOworICAgIGlmIChwICYmIHAtPnNldHRpbmdz KCkpCisgICAgICAgIHJldHVybiBwLT5zZXR0aW5ncygpLT5wcml2aWxlZ2VkV2ViR0xFeHRlbnNp b25zRW5hYmxlZCgpOwogICAgIHJldHVybiBmYWxzZTsKIH0KIApJbmRleDogU291cmNlL1dlYkNv cmUvcGFnZS9TZXR0aW5ncy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9T ZXR0aW5ncy5jcHAJKHJldmlzaW9uIDk3OTkwKQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0 aW5ncy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE4NSw2ICsxODUsNyBAQCBTZXR0aW5nczo6U2V0 dGluZ3MoUGFnZSogcGFnZSkKICAgICAsIG1fZXhwZXJpbWVudGFsTm90aWZpY2F0aW9uc0VuYWJs ZWQoZmFsc2UpCiAgICAgLCBtX3dlYkdMRW5hYmxlZChmYWxzZSkKICAgICAsIG1fb3BlbkdMTXVs dGlzYW1wbGluZ0VuYWJsZWQodHJ1ZSkKKyAgICAsIG1fcHJpdmlsZWdlZFdlYkdMRXh0ZW5zaW9u c0VuYWJsZWQoZmFsc2UpCiAgICAgLCBtX3dlYkF1ZGlvRW5hYmxlZChmYWxzZSkKICAgICAsIG1f YWNjZWxlcmF0ZWRDYW52YXMyZEVuYWJsZWQoZmFsc2UpCiAgICAgLCBtX2xlZ2FjeUFjY2VsZXJh dGVkQ2FudmFzMmRFbmFibGVkKGZhbHNlKQpAQCAtNzg3LDYgKzc4OCwxMSBAQCB2b2lkIFNldHRp bmdzOjpzZXRPcGVuR0xNdWx0aXNhbXBsaW5nRW5hCiAgICAgbV9vcGVuR0xNdWx0aXNhbXBsaW5n RW5hYmxlZCA9IGVuYWJsZWQ7CiB9CiAKK3ZvaWQgU2V0dGluZ3M6OnNldFByaXZpbGVnZWRXZWJH TEV4dGVuc2lvbnNFbmFibGVkKGJvb2wgZW5hYmxlZCkKK3sKKyAgICBtX3ByaXZpbGVnZWRXZWJH TEV4dGVuc2lvbnNFbmFibGVkID0gZW5hYmxlZDsKK30KKwogdm9pZCBTZXR0aW5nczo6c2V0QWNj ZWxlcmF0ZWQyZENhbnZhc0VuYWJsZWQoYm9vbCBlbmFibGVkKQogewogICAgIG1fYWNjZWxlcmF0 ZWRDYW52YXMyZEVuYWJsZWQgPSBlbmFibGVkOwpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9T ZXR0aW5ncy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuaAko cmV2aXNpb24gOTc5OTApCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmgJKHdvcmtp bmcgY29weSkKQEAgLTM0Miw2ICszNDIsOSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAg IHZvaWQgc2V0T3BlbkdMTXVsdGlzYW1wbGluZ0VuYWJsZWQoYm9vbCk7CiAgICAgICAgIGJvb2wg b3BlbkdMTXVsdGlzYW1wbGluZ0VuYWJsZWQoKSBjb25zdCB7IHJldHVybiBtX29wZW5HTE11bHRp c2FtcGxpbmdFbmFibGVkOyB9CiAKKyAgICAgICAgdm9pZCBzZXRQcml2aWxlZ2VkV2ViR0xFeHRl bnNpb25zRW5hYmxlZChib29sKTsKKyAgICAgICAgYm9vbCBwcml2aWxlZ2VkV2ViR0xFeHRlbnNp b25zRW5hYmxlZCgpIGNvbnN0IHsgcmV0dXJuIG1fcHJpdmlsZWdlZFdlYkdMRXh0ZW5zaW9uc0Vu YWJsZWQ7IH0KKwogICAgICAgICB2b2lkIHNldEFjY2VsZXJhdGVkMmRDYW52YXNFbmFibGVkKGJv b2wpOwogICAgICAgICBib29sIGFjY2VsZXJhdGVkMmRDYW52YXNFbmFibGVkKCkgY29uc3QgeyBy ZXR1cm4gbV9hY2NlbGVyYXRlZENhbnZhczJkRW5hYmxlZDsgfQogCkBAIC01NjAsNiArNTYzLDcg QEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBib29sIG1fZXhwZXJpbWVudGFsTm90aWZp Y2F0aW9uc0VuYWJsZWQgOiAxOwogICAgICAgICBib29sIG1fd2ViR0xFbmFibGVkIDogMTsKICAg ICAgICAgYm9vbCBtX29wZW5HTE11bHRpc2FtcGxpbmdFbmFibGVkIDogMTsKKyAgICAgICAgYm9v bCBtX3ByaXZpbGVnZWRXZWJHTEV4dGVuc2lvbnNFbmFibGVkIDogMTsKICAgICAgICAgYm9vbCBt X3dlYkF1ZGlvRW5hYmxlZCA6IDE7CiAgICAgICAgIGJvb2wgbV9hY2NlbGVyYXRlZENhbnZhczJk RW5hYmxlZCA6IDE7CiAgICAgICAgIGJvb2wgbV9sZWdhY3lBY2NlbGVyYXRlZENhbnZhczJkRW5h YmxlZCA6IDE7CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gOTgwMTgp CisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDE1IEBACisyMDExLTEwLTIwICBaaGVueWFvIE1vICA8em1vQGdvb2dsZS5jb20+CisK KyAgICAgICAgSW1wbGVtZW50IG1lY2hhbmlzbSB0byBlbmFibGUgcHJpdmlsZWdlZCB3ZWJnbCBl eHRlbnNpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03MDUzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogcHVibGljL1dlYlNldHRpbmdzLmg6IEFkZCB0aGUgZmxhZy4KKyAgICAgICAgKiBzcmMvV2Vi U2V0dGluZ3NJbXBsLmNwcDogRGl0dG8uCisgICAgICAgIChXZWJLaXQ6OldlYlNldHRpbmdzSW1w bDo6c2V0UHJpdmlsZWdlZFdlYkdMRXh0ZW5zaW9uc0VuYWJsZWQpOgorICAgICAgICAqIHNyYy9X ZWJTZXR0aW5nc0ltcGwuaDogRGl0dG8uCisKIDIwMTEtMTAtMjAgIFZpbmNlbnQgU2NoZWliICA8 c2NoZWliQGNocm9taXVtLm9yZz4KIAogICAgICAgICBNb3VzZUxvY2sgY29tcGlsZSBhbmQgcnVu IHRpbWUgZmxhZ3MuCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZXR0 aW5ncy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNl dHRpbmdzLmgJKHJldmlzaW9uIDk3OTkwKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViU2V0dGluZ3MuaAkod29ya2luZyBjb3B5KQpAQCAtOTUsNiArOTUsNyBAQCBwdWJsaWM6 CiAgICAgdmlydHVhbCB2b2lkIHNldFdlYkF1ZGlvRW5hYmxlZChib29sKSA9IDA7CiAgICAgdmly dHVhbCB2b2lkIHNldEV4cGVyaW1lbnRhbFdlYkdMRW5hYmxlZChib29sKSA9IDA7CiAgICAgdmly dHVhbCB2b2lkIHNldE9wZW5HTE11bHRpc2FtcGxpbmdFbmFibGVkKGJvb2wpID0gMDsKKyAgICB2 aXJ0dWFsIHZvaWQgc2V0UHJpdmlsZWdlZFdlYkdMRXh0ZW5zaW9uc0VuYWJsZWQoYm9vbCkgPSAw OwogICAgIHZpcnR1YWwgdm9pZCBzZXRTaG93RGVidWdCb3JkZXJzKGJvb2wpID0gMDsKICAgICB2 aXJ0dWFsIHZvaWQgc2V0U2hvd0ZQU0NvdW50ZXIoYm9vbCkgPSAwOwogICAgIHZpcnR1YWwgYm9v bCBzaG93RlBTQ291bnRlcigpIGNvbnN0ID0gMDsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlNldHRpbmdzSW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmNwcAkocmV2aXNpb24gOTc5OTApCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yODQsNiArMjg0LDExIEBAIHZvaWQgV2ViU2V0dGluZ3NJbXBsOjpzZXRPcGVuR0xNdWx0 aXNhbXAKICAgICBtX3NldHRpbmdzLT5zZXRPcGVuR0xNdWx0aXNhbXBsaW5nRW5hYmxlZChlbmFi bGVkKTsKIH0KIAordm9pZCBXZWJTZXR0aW5nc0ltcGw6OnNldFByaXZpbGVnZWRXZWJHTEV4dGVu c2lvbnNFbmFibGVkKGJvb2wgZW5hYmxlZCkKK3sKKyAgICBtX3NldHRpbmdzLT5zZXRQcml2aWxl Z2VkV2ViR0xFeHRlbnNpb25zRW5hYmxlZChlbmFibGVkKTsKK30KKwogdm9pZCBXZWJTZXR0aW5n c0ltcGw6OnNldFNob3dEZWJ1Z0JvcmRlcnMoYm9vbCBzaG93KQogewogICAgIG1fc2V0dGluZ3Mt PnNldFNob3dEZWJ1Z0JvcmRlcnMoc2hvdyk7CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJTZXR0aW5nc0ltcGwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuaAkocmV2aXNpb24gOTc5OTApCisrKyBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuaAkod29ya2luZyBjb3B5KQpAQCAtODcs NiArODcsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHNldFdlYkF1ZGlvRW5hYmxlZChi b29sKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0RXhwZXJpbWVudGFsV2ViR0xFbmFibGVkKGJvb2wp OwogICAgIHZpcnR1YWwgdm9pZCBzZXRPcGVuR0xNdWx0aXNhbXBsaW5nRW5hYmxlZChib29sKTsK KyAgICB2aXJ0dWFsIHZvaWQgc2V0UHJpdmlsZWdlZFdlYkdMRXh0ZW5zaW9uc0VuYWJsZWQoYm9v bCk7CiAgICAgdmlydHVhbCB2b2lkIHNldFNob3dEZWJ1Z0JvcmRlcnMoYm9vbCk7CiAgICAgdmly dHVhbCB2b2lkIHNldFNob3dGUFNDb3VudGVyKGJvb2wpOwogICAgIHZpcnR1YWwgYm9vbCBzaG93 RlBTQ291bnRlcigpIGNvbnN0IHsgcmV0dXJuIG1fc2hvd0ZQU0NvdW50ZXI7IH0K