70537 2011-10-20 12:30:05 -0700 [Qt][WK2] Disable Context Menus until we have a proper QML implementation 2011-10-26 01:29:58 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 70529 70315 1 zeno zeno hausmann oldest_to_newest 487780 0 zeno 2011-10-20 12:30:05 -0700 This is necessary because we currently cannot draw context menus without QtWidgets. 487811 1 111831 zeno 2011-10-20 13:10:49 -0700 Created attachment 111831 patch for review. 489978 2 111831 hausmann 2011-10-25 05:30:15 -0700 Comment on attachment 111831 patch for review. Ok... 490663 3 hausmann 2011-10-26 01:29:58 -0700 Committed r98449: <http://trac.webkit.org/changeset/98449> 111831 2011-10-20 13:10:49 -0700 2011-10-25 05:30:15 -0700 patch for review. 70525_20111020-220244.patch text/plain 3903 zeno ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzNzEzMDZlLi44ZjFjOWE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKyAyMDExLTEwLTIwICBaZW5vIEFsYmlzc2VyICA8emVuby5hbGJpc3NlckBub2tpYS5jb20+ CisgCisgICAgICAgIFtRdF1bV0syXSBEaXNhYmxlIENvbnRleHQgTWVudXMgdW50aWwgd2UgaGF2 ZSBhIHByb3BlciBRTUwgaW1wbGVtZW50YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTcwNTM3CisKKyAgICAgICAgVGhpcyBpcyBqdXN0IGEgdGVt cG9yYXJ5IGZpeCB0byBhdm9pZCBjcmFzaGVzIGluIFF0R3VpIGJhc2VkCisgICAgICAgIE1pbmlC cm93c2VyIHRoYXQgZG9lcyBub3QgbGluayB0byBRdFdpZGdldHMuCisKKyAgICAgICAgUGF0Y2gg YnkgSm9jZWx5biBUdXJjb3R0ZSA8am9jZWx5bi50dXJjb3R0ZUBub2tpYS5jb20+LAorICAgICAg ICAgICAgICAgICBaZW5vIEFsYmlzc2VyIDx6ZW5vLmFsYmlzc2VyQG5va2lhLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9x dC9XZWJDb250ZXh0TWVudVByb3h5UXQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0 TWVudVByb3h5UXQ6OnNob3dDb250ZXh0TWVudSk6CisgICAgICAgIChXZWJLaXQ6OldlYkNvbnRl eHRNZW51UHJveHlRdDo6Y3JlYXRlQ29udGV4dE1lbnUpOgorCjIwMTEtMTAtMjAgIFplbm8gQWxi aXNzZXIgIDx6ZW5vLmFsYmlzc2VyQG5va2lhLmNvbT4KCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9xdC9XZWJDb250ZXh0TWVudVByb3h5UXQuY3BwIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL3F0L1dlYkNvbnRleHRNZW51UHJveHlRdC5jcHAKaW5kZXggYTFjNWE0 NS4uYWMzYTRiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1dlYkNv bnRleHRNZW51UHJveHlRdC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1dl YkNvbnRleHRNZW51UHJveHlRdC5jcHAKQEAgLTY5LDE4ICs2OSw3IEBAIHZvaWQgV2ViQ29udGV4 dE1lbnVQcm94eVF0OjphY3Rpb25UcmlnZ2VyZWQoYm9vbCkKIAogdm9pZCBXZWJDb250ZXh0TWVu dVByb3h5UXQ6OnNob3dDb250ZXh0TWVudShjb25zdCBJbnRQb2ludCYgcG9zaXRpb24sIGNvbnN0 IFZlY3RvcjxXZWJDb250ZXh0TWVudUl0ZW1EYXRhPiYgaXRlbXMpCiB7Ci0gICAgaWYgKGl0ZW1z LmlzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgT3duUHRyPFFNZW51PiBtZW51ID0g Y3JlYXRlQ29udGV4dE1lbnUoaXRlbXMpOwotCi0gICAgLy8gV2UgY2FsbCBzaG93Q29udGV4dE1l bnUoKSwgZXZlbiB3aXRoIG5vIGl0ZW1zLCBiZWNhdXNlIHRoZSBjbGllbnQgc2hvdWxkIGJlIGFi bGUgdG8gc2hvdyBjdXN0b20gaXRlbXMKLSAgICAvLyBpZiBXZWJLaXQgaGFzIG5vdGhpbmcgdG8g c2hvdy4KLSAgICBpZiAoIW1lbnUpCi0gICAgICAgIG1lbnUgPSBhZG9wdFB0cihuZXcgUU1lbnUp OwotCi0gICAgbWVudS0+bW92ZShwb3NpdGlvbik7Ci0gICAgbV92aWV3SW50ZXJmYWNlLT5zaG93 Q29udGV4dE1lbnUoUVNoYXJlZFBvaW50ZXI8UU1lbnU+KG1lbnUubGVha1B0cigpKSk7CisgICAg Ly8gRklYTUU6IE1ha2UgdGhpcyBhIFFNTCBjb21wYXRpYmxlIGNvbnRleHQgbWVudS4KIH0KIAog dm9pZCBXZWJDb250ZXh0TWVudVByb3h5UXQ6OmhpZGVDb250ZXh0TWVudSgpCkBAIC05MCw1MSAr NzksOCBAQCB2b2lkIFdlYkNvbnRleHRNZW51UHJveHlRdDo6aGlkZUNvbnRleHRNZW51KCkKIAog UGFzc093blB0cjxRTWVudT4gV2ViQ29udGV4dE1lbnVQcm94eVF0OjpjcmVhdGVDb250ZXh0TWVu dShjb25zdCBWZWN0b3I8V2ViQ29udGV4dE1lbnVJdGVtRGF0YT4mIGl0ZW1zKSBjb25zdAogewot ICAgIE93blB0cjxRTWVudT4gbWVudSA9IGFkb3B0UHRyKG5ldyBRTWVudSk7Ci0gICAgZm9yIChp bnQgaSA9IDA7IGkgPCBpdGVtcy5zaXplKCk7ICsraSkgewotICAgICAgICBjb25zdCBXZWJDb250 ZXh0TWVudUl0ZW1EYXRhJiBpdGVtID0gaXRlbXMuYXQoaSk7Ci0gICAgICAgIHN3aXRjaCAoaXRl bS50eXBlKCkpIHsKLSAgICAgICAgY2FzZSBXZWJDb3JlOjpDaGVja2FibGVBY3Rpb25UeXBlOiAv KiBmYWxsIHRocm91Z2ggKi8KLSAgICAgICAgY2FzZSBXZWJDb3JlOjpBY3Rpb25UeXBlOiB7Ci0g ICAgICAgICAgICBRQWN0aW9uKiBxdEFjdGlvbiA9IG5ldyBRQWN0aW9uKG1lbnUuZ2V0KCkpOwot ICAgICAgICAgICAgcXRBY3Rpb24tPnNldERhdGEoUVZhcmlhbnQ6OmZyb21WYWx1ZShpdGVtKSk7 Ci0gICAgICAgICAgICBxdEFjdGlvbi0+c2V0VGV4dChpdGVtLnRpdGxlKCkpOwotICAgICAgICAg ICAgcXRBY3Rpb24tPnNldEVuYWJsZWQoaXRlbS5lbmFibGVkKCkpOwotICAgICAgICAgICAgcXRB Y3Rpb24tPnNldENoZWNrZWQoaXRlbS5jaGVja2VkKCkpOwotICAgICAgICAgICAgcXRBY3Rpb24t PnNldENoZWNrYWJsZShpdGVtLnR5cGUoKSA9PSBXZWJDb3JlOjpDaGVja2FibGVBY3Rpb25UeXBl KTsKLSAgICAgICAgICAgIGNvbm5lY3QocXRBY3Rpb24sIFNJR05BTCh0cmlnZ2VyZWQoYm9vbCkp LCB0aGlzLCBTTE9UKGFjdGlvblRyaWdnZXJlZChib29sKSksIFF0OjpEaXJlY3RDb25uZWN0aW9u KTsKLQotICAgICAgICAgICAgbWVudS0+YWRkQWN0aW9uKHF0QWN0aW9uKTsKLSAgICAgICAgICAg IGJyZWFrOwotICAgICAgICB9Ci0gICAgICAgIGNhc2UgV2ViQ29yZTo6U2VwYXJhdG9yVHlwZToK LSAgICAgICAgICAgIG1lbnUtPmFkZFNlcGFyYXRvcigpOwotICAgICAgICAgICAgYnJlYWs7Ci0g ICAgICAgIGNhc2UgV2ViQ29yZTo6U3VibWVudVR5cGU6Ci0gICAgICAgICAgICBpZiAoT3duUHRy PFFNZW51PiBzdWJNZW51ID0gY3JlYXRlQ29udGV4dE1lbnUoaXRlbS5zdWJtZW51KCkpKSB7Ci0g ICAgICAgICAgICAgICAgc3ViTWVudS0+c2V0UGFyZW50KG1lbnUuZ2V0KCkpOwotICAgICAgICAg ICAgICAgIHN1Yk1lbnUtPnNldFRpdGxlKGl0ZW0udGl0bGUoKSk7Ci0gICAgICAgICAgICAgICAg UU1lbnUqIGNvbnN0IHN1Yk1lbnVQdHIgPSBzdWJNZW51LmxlYWtQdHIoKTsKLSAgICAgICAgICAg ICAgICBtZW51LT5hZGRNZW51KHN1Yk1lbnVQdHIpOwotICAgICAgICAgICAgfQotICAgICAgICAg ICAgYnJlYWs7Ci0gICAgICAgIH0KLSAgICB9Ci0KLSAgICAvLyBEbyBub3Qgc2hvdyBzdWItbWVu dXMgd2l0aCBqdXN0IGRpc2FibGVkIGFjdGlvbnMuCi0gICAgaWYgKG1lbnUtPmlzRW1wdHkoKSkK LSAgICAgICAgcmV0dXJuIG51bGxwdHI7Ci0KLSAgICBib29sIGlzQW55QWN0aW9uRW5hYmxlZCA9 IGZhbHNlOwotICAgIFFMaXN0PFFBY3Rpb24gKj4gYWN0aW9ucyA9IG1lbnUtPmFjdGlvbnMoKTsK LSAgICBmb3IgKGludCBpID0gMDsgaSA8IGFjdGlvbnMuY291bnQoKTsgKytpKSB7Ci0gICAgICAg IGlmIChhY3Rpb25zLmF0KGkpLT5pc1Zpc2libGUoKSkKLSAgICAgICAgICAgIGlzQW55QWN0aW9u RW5hYmxlZCB8PSBhY3Rpb25zLmF0KGkpLT5pc0VuYWJsZWQoKTsKLSAgICB9Ci0gICAgaWYgKCFp c0FueUFjdGlvbkVuYWJsZWQpCi0gICAgICAgIHJldHVybiBudWxscHRyOwotCi0gICAgcmV0dXJu IG1lbnUucmVsZWFzZSgpOworICAgIC8vIEZJWE1FOiBNYWtlIHRoaXMgYSBRTUwgY29tcGF0aWJs ZSBjb250ZXh0IG1lbnUuCisgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAKICNpbmNsdWRlICJtb2Nf V2ViQ29udGV4dE1lbnVQcm94eVF0LmNwcCIK