70532 2011-10-20 12:03:21 -0700 [EFL] DRT: Allow choosing which backing store to use. 2011-11-03 12:16:02 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco gyuyoung.kim kenneth leandro lucas.de.marchi tonikitoo webkit.review.bot oldest_to_newest 487756 0 rakuco 2011-10-20 12:03:21 -0700 [EFL] DRT: Allow choosing which backing store to use. 487758 1 111818 rakuco 2011-10-20 12:05:42 -0700 Created attachment 111818 Patch 495645 2 111818 tonikitoo 2011-11-03 11:03:17 -0700 Comment on attachment 111818 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111818&action=review from IRC: <tonikitoo> rakuco, what is a singlebackingstore approach? what is the normal approach? more than one backing store? > Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:97 > + static Ewk_View_Smart_Class api = EWK_VIEW_SMART_CLASS_INIT_NAME_VERSION("DRT_View"); 'api' as a variable name here sound a bit strange. could you elaborate? 495649 3 111818 tonikitoo 2011-11-03 11:08:18 -0700 Comment on attachment 111818 Patch after talking on IRC, r+, but I am not a fan of the naming used here. feel free to improve it according to your explaination bellow <rakuco> tonikitoo: the efl port has two backing stores implemented in WebKit/efl/ewk. the single backing store just paints what's on the viewport, whereas the tiled one is similar to what exists in webcore (it predates the webcore implementation afaik). there's no normal approach (one has to choose which one to use in order to use the port), the patch makes it possible to run drt with different backing stores and check if the tests pass in both 495707 4 111818 webkit.review.bot 2011-11-03 12:15:58 -0700 Comment on attachment 111818 Patch Clearing flags on attachment: 111818 Committed r99226: <http://trac.webkit.org/changeset/99226> 495708 5 webkit.review.bot 2011-11-03 12:16:02 -0700 All reviewed patches have been landed. Closing bug. 111818 2011-10-20 12:05:42 -0700 2011-11-03 12:15:58 -0700 Patch bug-70532-20111020170558.patch text/plain 3585 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTgwMDYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1NTI4M2MxMmJiZjFkNmU4MDViYjM3NjNiYWViOTM4Yjdl YWQ0MTIyLi5lOTFlMjllZGYwOWNiNmFkM2ZjZTczYzg4YWU3NTEyZTYwYzA5NGZhIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTEtMTAtMjAgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1v Ymk+CisKKyAgICAgICAgW0VGTF0gRFJUOiBBbGxvdyBjaG9vc2luZyB3aGljaCBiYWNraW5nIHN0 b3JlIHRvIHVzZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTcwNTMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhpcyBjaGFuZ2UgbWFrZXMgaXQgcG9zc2libGUgdG8gY2hhbmdlIHRoZSBiYWNraW5nIHN0 b3JlIHVzZWQgYnkgRFJUCisgICAgICAgIGZyb20gVGlsZWQgQmFja2luZyBTdG9yZSAoVEJTKSB0 byBTaW5nbGUgQmFja2luZyBTdG9yZSAoU0JTKSBieQorICAgICAgICBzZXR0aW5nIHRoZSBlbnZp cm9ubWVudCB2YXJpYWJsZSBEUlRfVVNFX1NJTkdMRV9CQUNLSU5HX1NUT1JFIHRvIDEuCisKKyAg ICAgICAgKiBEdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwOgorICAg ICAgICAoRHVtcFJlbmRlclRyZWVDaHJvbWU6OmNyZWF0ZVZpZXcpOgorICAgICAgICAqIER1bXBS ZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZVZpZXcuY3BwOgorICAgICAgICAoc2hvdWxkVXNl U2luZ2xlQmFja2luZ1N0b3JlKToKKyAgICAgICAgKGNob29zZUFuZEluaXRpYWxpemVBcHByb3By aWF0ZVNtYXJ0Q2xhc3MpOgorICAgICAgICAoZHJ0Vmlld0FkZCk6CisgICAgICAgICogRHVtcFJl bmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlVmlldy5oOgorCiAyMDExLTEwLTIwICBIYW8gWmhl bmcgIDx6aGVuZ2hhb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBSZWR1Y2Ug ZGVwZW5kZW5jaWVzIG9mIEltYWdlRGlmZiB0byBjb21waWxlIGl0IGZvciBBbmRyb2lkLgpkaWZm IC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNw cCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHAKaW5k ZXggNDlkY2M3YjA1YjhmMzI0OWNjMjc1NTM5MGFkNWM5MjljYmQxMjhiMy4uNjIzNTg3Zjg2ZWZj ZGI4NDZmZjM4ZmJlYzAzZGZlNjBkZmYwNThjNCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRl clRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVy VHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwCkBAIC04MCw3ICs4MCw3IEBAIEV2YXNf T2JqZWN0KiBEdW1wUmVuZGVyVHJlZUNocm9tZTo6Y3JlYXRlTmV3V2luZG93KCkKIAogRXZhc19P YmplY3QqIER1bXBSZW5kZXJUcmVlQ2hyb21lOjpjcmVhdGVWaWV3KCkgY29uc3QKIHsKLSAgICBF dmFzX09iamVjdCogdmlldyA9IGRydFZpZXdUaWxlZEFkZChtX2V2YXMpOworICAgIEV2YXNfT2Jq ZWN0KiB2aWV3ID0gZHJ0Vmlld0FkZChtX2V2YXMpOwogICAgIGlmICghdmlldykKICAgICAgICAg cmV0dXJuIDA7CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVu ZGVyVHJlZVZpZXcuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVl Vmlldy5jcHAKaW5kZXggYmVkYTUzNzQ1NjVhNDEwMjRkOGRkYTU5M2IwODE5MjMwYjk2Nzk0Mi4u OTM4YzNmYmRiZWMxYWI1NzdjYjQzNWI1MTM4MDFlZDhlNTlmMGI4MSAxMDA2NDQKLS0tIGEvVG9v bHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlVmlldy5jcHAKKysrIGIvVG9vbHMv RHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlVmlldy5jcHAKQEAgLTM0LDYgKzM0LDcg QEAKICNpbmNsdWRlIDxFaW5hLmg+CiAjaW5jbHVkZSA8RXZhcy5oPgogI2luY2x1ZGUgPGNzdGRp bz4KKyNpbmNsdWRlIDxjc3RkbGliPgogCiB1c2luZyBuYW1lc3BhY2Ugc3RkOwogCkBAIC04MCwx MSArODEsMjIgQEAgc3RhdGljIHZvaWQgb25XaW5kb3dDbG9zZShFd2tfVmlld19TbWFydF9EYXRh KiBzbWFydERhdGEpCiAgICAgZWNvcmVfaWRsZXJfYWRkKG9uV2luZG93Q2xvc2VEZWxheWVkLCB2 aWV3KTsKIH0KIAotRXZhc19PYmplY3QqIGRydFZpZXdUaWxlZEFkZChFdmFzKiBldmFzKQorc3Rh dGljIGJvb2wgc2hvdWxkVXNlU2luZ2xlQmFja2luZ1N0b3JlKCkKIHsKLSAgICBzdGF0aWMgRXdr X1ZpZXdfU21hcnRfQ2xhc3MgYXBpID0gRVdLX1ZJRVdfU01BUlRfQ0xBU1NfSU5JVF9OQU1FX1ZF UlNJT04oIkRSVF9WaWV3X1RpbGVkIik7CisgICAgY29uc3QgY2hhciogdXNlU2luZ2xlQmFja2lu Z1N0b3JlID0gZ2V0ZW52KCJEUlRfVVNFX1NJTkdMRV9CQUNLSU5HX1NUT1JFIik7CisgICAgcmV0 dXJuIHVzZVNpbmdsZUJhY2tpbmdTdG9yZSAmJiAqdXNlU2luZ2xlQmFja2luZ1N0b3JlID09ICcx JzsKK30KKworc3RhdGljIGJvb2wgY2hvb3NlQW5kSW5pdGlhbGl6ZUFwcHJvcHJpYXRlU21hcnRD bGFzcyhFd2tfVmlld19TbWFydF9DbGFzcyogYXBpKQoreworICAgIHJldHVybiBzaG91bGRVc2VT aW5nbGVCYWNraW5nU3RvcmUoKSA/IGV3a192aWV3X3NpbmdsZV9zbWFydF9zZXQoYXBpKSA6IGV3 a192aWV3X3RpbGVkX3NtYXJ0X3NldChhcGkpOworfQorCitFdmFzX09iamVjdCogZHJ0Vmlld0Fk ZChFdmFzKiBldmFzKQoreworICAgIHN0YXRpYyBFd2tfVmlld19TbWFydF9DbGFzcyBhcGkgPSBF V0tfVklFV19TTUFSVF9DTEFTU19JTklUX05BTUVfVkVSU0lPTigiRFJUX1ZpZXciKTsKIAotICAg IGlmICghZXdrX3ZpZXdfdGlsZWRfc21hcnRfc2V0KCZhcGkpKQorICAgIGlmICghY2hvb3NlQW5k SW5pdGlhbGl6ZUFwcHJvcHJpYXRlU21hcnRDbGFzcygmYXBpKSkKICAgICAgICAgcmV0dXJuIDA7 CiAKICAgICBpZiAoRUlOQV9VTkxJS0VMWSghZ1BhcmVudFNtYXJ0Q2xhc3Muc2MuYWRkKSkKZGlm ZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZVZpZXcuaCBi L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZVZpZXcuaAppbmRleCAzYzlj NmIxYTJjYzM3MjYyMmNlZDM5YWQ2MjdlMjk3Y2JiMjBjMzRiLi43MmRkYWI1NmQxNThkOThlNzM1 MGM5ZDM2NTFhOWUwNTg0NzMxYTA3IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9l ZmwvRHVtcFJlbmRlclRyZWVWaWV3LmgKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1 bXBSZW5kZXJUcmVlVmlldy5oCkBAIC0yNyw2ICsyNyw2IEBACiAKICNpbmNsdWRlIDxFdmFzLmg+ CiAKLUV2YXNfT2JqZWN0KiBkcnRWaWV3VGlsZWRBZGQoRXZhcyopOworRXZhc19PYmplY3QqIGRy dFZpZXdBZGQoRXZhcyopOwogCiAjZW5kaWYgLy8gRHVtcFJlbmRlclRyZWVWaWV3X2gK