70524 2011-10-20 10:54:39 -0700 Possible REGRESSION(97879): NRWT fails when DumpRenderTree crashes 2011-10-20 20:29:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco eric abarth eric leandro ojan webkit.review.bot oldest_to_newest 487706 0 rakuco 2011-10-20 10:54:39 -0700 When running NRWT with --debug --platform=efl --no-http -p --tolerance=1, it runs until about 50% and fails with the following messages: worker/4 raised AssertionError('Unprocessed error output: ASSERTION FAILED: cairo_image_surface_get_format(surface) == CAIRO_FORMAT_ARGB32 /home/profusion/webkit/Tools/DumpRenderTree/cairo/PixelDumpSupportCairo.cpp(69) : void computeMD5HashStringForBitmapContext(BitmapContext*, char*) 1 0x42cd61 computeMD5HashStringForBitmapContext(BitmapContext*, char*) 2 0x42b9b4 dumpWebViewAsPixelsAndCompareWithExpected(std::string const&) 3 0x430645 dump() 4 0x4326b6 DumpRenderTreeChrome::onLoadFinished(void*, _Evas_Object*, void*) 5 0x7f0cd82905c3 evas_object_smart_callback_call 6 0x7f0cd68b9b24 ewk_view_load_finished 7 0x7f0cd688cb78 ewk_frame_load_finished 8 0x7f0cd68796f8 WebCore::FrameLoaderClientEfl::postProgressFinishedNotification() 9 0x7f0cd2fb7570 WebCore::ProgressTracker::finalProgressComplete() 10 0x7f0cd2fb741e WebCore::ProgressTracker::progressCompleted(WebCore::Frame*) 11 0x7f0cd2f9ecf6 WebCore::FrameLoader::checkLoadCompleteForThisFrame() 12 0x7f0cd2f9f509 WebCore::FrameLoader::checkLoadComplete() 13 0x7f0cd2f9e26a WebCore::FrameLoader::finishedLoading() 14 0x7f0cd2fb225c WebCore::MainResourceLoader::didFinishLoading(double) 15 0x7f0cd2fc4a13 WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*, double) 16 0x7f0cd393d8aa 17 0x7f0cd76c2e19 18 0x7f0cd76d2cc8 19 0x7f0cd6b5fbcd g_main_context_dispatch 20 0x7f0cd8033600 21 0x7f0cd802d65d 22 0x7f0cd802e005 23 0x7f0cd802e31f ecore_main_loop_begin 24 0x430065 25 0x430199 26 0x4307e9 main 27 0x7f0ccd5abeff __libc_start_main 28 0x41db89 '): layout_tests/controllers/worker.py:91 (in run) self._worker_connection.run_message_loop() layout_tests/controllers/message_broker.py:191 (in run_message_loop) self._broker.run_message_loop(self._run_topic, self._client, delay_secs) layout_tests/controllers/message_broker.py:127 (in run_message_loop) self._run_loop(topic_name, client, block=True, delay_secs=delay_secs) layout_tests/controllers/message_broker.py:141 (in _run_loop) self._dispatch_message(msg, client) layout_tests/controllers/message_broker.py:150 (in _dispatch_message) message_handler(message.src, *optargs) layout_tests/controllers/worker.py:111 (in handle_test_list) self._run_test(test_input) layout_tests/controllers/worker.py:126 (in _run_test) result = self.run_test_with_timeout(test_input, test_timeout_sec) layout_tests/controllers/worker.py:165 (in run_test_with_timeout) return self._run_test_in_this_thread(test_input) layout_tests/controllers/worker.py:250 (in _run_test_in_this_thread) return self.run_single_test(self._driver, test_input) layout_tests/controllers/worker.py:254 (in run_single_test) test_input, driver, self._name) layout_tests/controllers/single_test_runner.py:45 (in run_single_test) return runner.run() layout_tests/controllers/single_test_runner.py:124 (in run) return self._run_compare_test() layout_tests/controllers/single_test_runner.py:127 (in _run_compare_test) driver_output = self._driver.run_test(self._driver_input()) layout_tests/port/webkit.py:532 (in run_test) assert not self._server_process._error, "Unprocessed error output: %s" % self._server_process._error 487901 1 eric 2011-10-20 15:02:09 -0700 Very easy to fix. I should probably just remove that assert. 487971 2 eric 2011-10-20 16:17:21 -0700 So what's DRT's expected behavior on EFL when it crashes? It crashes and dumps the stack trace to stderr? Is there any sort of indication after the stacktrace that it's done dumping? I worry that I could remove the assert and replace it with just adding any remaining buffered error into the recordded error. But that might end up not reading the entire stack trace. 487979 3 111867 eric 2011-10-20 16:24:10 -0700 Created attachment 111867 Patch 487988 4 eric 2011-10-20 16:35:43 -0700 Committed r98040: <http://trac.webkit.org/changeset/98040> 488113 5 rakuco 2011-10-20 20:29:52 -0700 (In reply to comment #2) > So what's DRT's expected behavior on EFL when it crashes? It crashes and dumps the stack trace to stderr? Is there any sort of indication after the stacktrace that it's done dumping? > > I worry that I could remove the assert and replace it with just adding any remaining buffered error into the recordded error. But that might end up not reading the entire stack trace. Well, that's just wtf's ASSERT, which calls WTFReportAssertionFailure and WTFReportBacktrace, so it just depends on that (it doesn't look like there's any indication that dumping is finished). 111867 2011-10-20 16:24:10 -0700 2011-10-20 16:25:41 -0700 Patch bug-70524-20111020162409.patch text/plain 2985 eric U3VidmVyc2lvbiBSZXZpc2lvbjogOTgwMzQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4YzQxZDU4MGM3MjBhMWNlOTJiZmUyMzNlZWQ0ZjE4N2I3 NDk4ZGM5Li4zN2FlMDBiZjhlNzUwM2UwNTE2OWViZWY2NmM1OGYwMTExMjExNmRmIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg QEAKIDIwMTEtMTAtMjAgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAg IFBvc3NpYmxlIFJFR1JFU1NJT04oOTc4NzkpOiBOUldUIGZhaWxzIHdoZW4gRHVtcFJlbmRlclRy ZWUgY3Jhc2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzA1MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIGlzIGEgc3BlY3VsYXRpdmUgZml4LCBzaW5jZSBJIGRvIG5vdCB1c2UgYSBwbGF0Zm9y bQorICAgICAgICB3aGljaCBvdXRwdXRzIGNyYXNobG9ncyBvdmVyIHN0ZGVyci4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvc2VydmVyX3Byb2Nlc3MucHk6 CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHk6 CisKKzIwMTEtMTAtMjAgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCiAgICAgICAg IFJFR1JFU1NJT04oOTc4NzkpOiBQaXhlbCB0ZXN0cyBubyBsb25nZXIgd29yayB3aXRoIE5SV1Qg b24gTWFjCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 MDQ5MgogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L3NlcnZlcl9wcm9jZXNzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weQppbmRleCA1MjZjMWYzNjJiMmZhZmZhMGY2NDY1NzZj MDdiYWE4NmNlZDIzNTU3Li41YWY2MzRkY2NjNjhkMjE2Y2IxYWMzNmI5ZjMzNTVlYjdkODA5MmQw IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3Nl cnZlcl9wcm9jZXNzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvc2VydmVyX3Byb2Nlc3MucHkKQEAgLTE0Miw2ICsxNDIsOSBAQCBjbGFzcyBTZXJ2ZXJQ cm9jZXNzOgogICAgICAgICAgICAgcmV0dXJuIHNlbGYuX3BvcF9lcnJvcl9ieXRlcyhpbmRleF9h ZnRlcl9uZXdsaW5lKQogICAgICAgICByZXR1cm4gTm9uZQogCisgICAgZGVmIHBvcF9hbGxfYnVm ZmVyZWRfc3RkZXJyKHNlbGYpOgorICAgICAgICByZXR1cm4gc2VsZi5fcG9wX2Vycm9yX2J5dGVz KGxlbihzZWxmLl9lcnJvcikpCisKICAgICBkZWYgcmVhZF9zdGRvdXRfbGluZShzZWxmLCBkZWFk bGluZSk6CiAgICAgICAgIHJldHVybiBzZWxmLl9yZWFkKGRlYWRsaW5lLCBzZWxmLl9wb3Bfc3Rk b3V0X2xpbmVfaWZfcmVhZHkpCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC93ZWJraXQucHkKaW5kZXggNDQ2NWNjNWVhZjdjMDU1MjcwOGQzMmU3MGUz ZTFhNmM3NmZhODY0OC4uMjhkYmNkOGMwNzk5MjFiODc1ZTQ1OGUwNjBlMWUwYjU3ZmUxMmM5ZSAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJr aXQucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJr aXQucHkKQEAgLTUzMiw4ICs1MzIsMTIgQEAgY2xhc3MgV2ViS2l0RHJpdmVyKERyaXZlcik6CiAg ICAgICAgIHRleHQsIGF1ZGlvID0gc2VsZi5fcmVhZF9maXJzdF9ibG9jayhkZWFkbGluZSkgICMg Rmlyc3QgYmxvY2sgaXMgZWl0aGVyIHRleHQgb3IgYXVkaW8KICAgICAgICAgaW1hZ2UsIGFjdHVh bF9pbWFnZV9oYXNoID0gc2VsZi5fcmVhZF9vcHRpb25hbF9pbWFnZV9ibG9jayhkZWFkbGluZSkg ICMgVGhlIHNlY29uZCAob3B0aW9uYWwpIGJsb2NrIGlzIGltYWdlIGRhdGEuCiAKLSAgICAgICAg IyBXZSBtYXkgbm90IGhhdmUgcmVhZCBhbGwgb3V0cHV0IChpZiBhbiBlcnJvciBvY2N1cmVkKSwg YnV0IHdlIGNlcnRhaW5seSBzaG91bGQgaGF2ZSByZWFkIGFsbCBlcnJvciBieXRlcy4KLSAgICAg ICAgYXNzZXJ0IG5vdCBzZWxmLl9zZXJ2ZXJfcHJvY2Vzcy5fZXJyb3IsICJVbnByb2Nlc3NlZCBl cnJvciBvdXRwdXQ6ICVzIiAlIHNlbGYuX3NlcnZlcl9wcm9jZXNzLl9lcnJvcgorICAgICAgICAj IFdlIG1heSBub3QgaGF2ZSByZWFkIGFsbCBvZiB0aGUgb3V0cHV0IGlmIGFuIGVycm9yIChjcmFz aCkgb2NjdXJlZC4KKyAgICAgICAgIyBTaW5jZSBzb21lIHBsYXRmb3JtcyBvdXRwdXQgdGhlIHN0 YWNrdHJhY2Ugb3ZlciBlcnJvciwgd2Ugc2hvdWxkCisgICAgICAgICMgZHVtcCBhbnkgYnVmZmVy ZWQgZXJyb3IgaW50byBzZWxmLmVycm9yX2Zyb21fdGVzdC4KKyAgICAgICAgIyBGSVhNRTogV2Ug bWF5IG5lZWQgdG8gYWxzbyByZWFkIHN0ZGVyciB1bnRpbCB0aGUgcHJvY2VzcyBkaWVzPworICAg ICAgICBzZWxmLmVycm9yX2Zyb21fdGVzdCArPSBzZWxmLl9zZXJ2ZXJfcHJvY2Vzcy5wb3BfYWxs X2J1ZmZlcmVkX3N0ZGVycigpCisKICAgICAgICAgcmV0dXJuIERyaXZlck91dHB1dCh0ZXh0LCBp bWFnZSwgYWN0dWFsX2ltYWdlX2hhc2gsIGF1ZGlvLAogICAgICAgICAgICAgY3Jhc2g9c2VsZi5f ZGV0ZWN0ZWRfY3Jhc2goKSwgdGVzdF90aW1lPXRpbWUudGltZSgpIC0gc3RhcnRfdGltZSwKICAg ICAgICAgICAgIHRpbWVvdXQ9c2VsZi5fc2VydmVyX3Byb2Nlc3MudGltZWRfb3V0LCBlcnJvcj1z ZWxmLmVycm9yX2Zyb21fdGVzdCwK