70519 2011-10-20 09:54:35 -0700 [Chromium] Fixed Layout API needs to check that a FrameView has been created to avoid segfaults 2011-10-20 19:36:13 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 70559 1 fsamuel fsamuel rjkroege webkit.review.bot oldest_to_newest 487666 0 fsamuel 2011-10-20 09:54:35 -0700 Relatively straightforward problem and fix. Will post patch shortly. 488005 1 111874 fsamuel 2011-10-20 17:05:25 -0700 Created attachment 111874 Patch 488007 2 111874 abarth 2011-10-20 17:07:45 -0700 Comment on attachment 111874 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111874&action=review > Source/WebKit/chromium/ChangeLog:9 > + Simple patch. Upcoming patches for https://bugs.webkit.org/show_bug.cgi?id=70559 will make > + use of these methods in certain situations where the main frame doesn't yet have a FrameView. Ok. Please add tests for these branches as part of those bugs. 488008 3 fsamuel 2011-10-20 17:09:11 -0700 (In reply to comment #2) > (From update of attachment 111874 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=111874&action=review > > > Source/WebKit/chromium/ChangeLog:9 > > + Simple patch. Upcoming patches for https://bugs.webkit.org/show_bug.cgi?id=70559 will make > > + use of these methods in certain situations where the main frame doesn't yet have a FrameView. > > Ok. Please add tests for these branches as part of those bugs. Will do, building a test suite is one of the blockers for the master bug. :-) 488099 4 111874 webkit.review.bot 2011-10-20 19:36:09 -0700 Comment on attachment 111874 Patch Clearing flags on attachment: 111874 Committed r98059: <http://trac.webkit.org/changeset/98059> 488100 5 webkit.review.bot 2011-10-20 19:36:13 -0700 All reviewed patches have been landed. Closing bug. 111874 2011-10-20 17:05:25 -0700 2011-10-20 19:36:09 -0700 Patch bug-70519-20111020200523.patch text/plain 2475 fsamuel U3VidmVyc2lvbiBSZXZpc2lvbjogOTgwNDAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg NzM4ZDJkYWNkMjg1YWVjZWU5NGFmOWMxN2Q3NmFiNmEwYWM2ZmZkZC4uMDgwODVmOTMwMDU0ZDRi Y2YwZjc0YTEwY2UwNDYzZjRiOGE2ZGRjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxOSBAQAorMjAxMS0xMC0yMCAgRmFkeSBTYW11ZWwgIDxmc2FtdWVsQGNocm9taXVt Lm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIEZpeGVkIExheW91dCBBUEkgbmVlZHMgdG8gY2hl Y2sgdGhhdCBhIEZyYW1lVmlldyBoYXMgYmVlbiBjcmVhdGVkIHRvIGF2b2lkIHNlZ2ZhdWx0cwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzA1MTkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW1wbGUgcGF0 Y2guIFVwY29taW5nIHBhdGNoZXMgZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03MDU1OSB3aWxsIG1ha2UKKyAgICAgICAgdXNlIG9mIHRoZXNlIG1ldGhvZHMgaW4g Y2VydGFpbiBzaXR1YXRpb25zIHdoZXJlIHRoZSBtYWluIGZyYW1lIGRvZXNuJ3QgeWV0IGhhdmUg YSBGcmFtZVZpZXcuCisKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJWaWV3SW1wbDo6aXNGaXhlZExheW91dE1vZGVFbmFibGVkKToKKyAgICAgICAg KFdlYktpdDo6V2ViVmlld0ltcGw6OmVuYWJsZUZpeGVkTGF5b3V0TW9kZSk6CisgICAgICAgIChX ZWJLaXQ6OldlYlZpZXdJbXBsOjpmaXhlZExheW91dFNpemUpOgorICAgICAgICAoV2ViS2l0OjpX ZWJWaWV3SW1wbDo6c2V0Rml4ZWRMYXlvdXRTaXplKToKKwogMjAxMS0xMC0yMCAgTmF0IER1Y2Eg IDxuZHVjYUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBSb3V0ZSBvblN3YXBC dWZmZXJzQ29tcGxldGUgZnJvbSBMYXllclJlbmRlcmVyIHRvIENDU2NoZWR1bGVyLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IDE1YzhlMjQ1YTY0MzNl MGIzNGIzMzZiMjNkYWNhMDA1OGRjZmQ3NzAuLjRlOGM2NmNmODQ4Zjc0Y2RmOTkxMDM2YzU4OTgz ZWE3ODAyMzA2N2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZp ZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5j cHAKQEAgLTE5MTksNyArMTkxOSw3IEBAIGJvb2wgV2ViVmlld0ltcGw6OmlzRml4ZWRMYXlvdXRN b2RlRW5hYmxlZCgpIGNvbnN0CiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIEZyYW1lKiBm cmFtZSA9IHBhZ2UoKS0+bWFpbkZyYW1lKCk7Ci0gICAgaWYgKCFmcmFtZSkKKyAgICBpZiAoIWZy YW1lIHx8ICFmcmFtZS0+dmlldygpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICByZXR1 cm4gZnJhbWUtPnZpZXcoKS0+dXNlRml4ZWRMYXlvdXQoKTsKQEAgLTE5MzEsNyArMTkzMSw3IEBA IHZvaWQgV2ViVmlld0ltcGw6OmVuYWJsZUZpeGVkTGF5b3V0TW9kZShib29sIGVuYWJsZSkKICAg ICAgICAgcmV0dXJuOwogCiAgICAgRnJhbWUqIGZyYW1lID0gcGFnZSgpLT5tYWluRnJhbWUoKTsK LSAgICBpZiAoIWZyYW1lKQorICAgIGlmICghZnJhbWUgfHwgIWZyYW1lLT52aWV3KCkpCiAgICAg ICAgIHJldHVybjsKIAogICAgIGZyYW1lLT52aWV3KCktPnNldFVzZUZpeGVkTGF5b3V0KGVuYWJs ZSk7CkBAIC0xOTQzLDcgKzE5NDMsNyBAQCBXZWJTaXplIFdlYlZpZXdJbXBsOjpmaXhlZExheW91 dFNpemUoKSBjb25zdAogICAgICAgICByZXR1cm4gV2ViU2l6ZSgpOwogCiAgICAgRnJhbWUqIGZy YW1lID0gcGFnZSgpLT5tYWluRnJhbWUoKTsKLSAgICBpZiAoIWZyYW1lKQorICAgIGlmICghZnJh bWUgfHwgIWZyYW1lLT52aWV3KCkpCiAgICAgICAgIHJldHVybiBXZWJTaXplKCk7CiAKICAgICBy ZXR1cm4gZnJhbWUtPnZpZXcoKS0+Zml4ZWRMYXlvdXRTaXplKCk7CkBAIC0xOTU1LDcgKzE5NTUs NyBAQCB2b2lkIFdlYlZpZXdJbXBsOjpzZXRGaXhlZExheW91dFNpemUoY29uc3QgV2ViU2l6ZSYg bGF5b3V0U2l6ZSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgRnJhbWUqIGZyYW1lID0gcGFnZSgp LT5tYWluRnJhbWUoKTsKLSAgICBpZiAoIWZyYW1lKQorICAgIGlmICghZnJhbWUgfHwgIWZyYW1l LT52aWV3KCkpCiAgICAgICAgIHJldHVybjsKIAogICAgIGZyYW1lLT52aWV3KCktPnNldEZpeGVk TGF5b3V0U2l6ZShsYXlvdXRTaXplKTsK