<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>70500</bug_id>
          
          <creation_ts>2011-10-20 07:44:11 -0700</creation_ts>
          <short_desc>[GTK] webkitgtk&apos;s pkgconfig file needs to require javascriptcoregtk</short_desc>
          <delta_ts>2011-10-20 07:59:40 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Gustavo Noronha (kov)">gustavo</reporter>
          <assigned_to name="Gustavo Noronha (kov)">gustavo</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>487557</commentid>
    <comment_count>0</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2011-10-20 07:44:11 -0700</bug_when>
    <thetext>[GTK] webkitgtk&apos;s pkgconfig file needs to require javascriptcoregtk</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>487558</commentid>
    <comment_count>1</comment_count>
      <attachid>111771</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2011-10-20 07:45:04 -0700</bug_when>
    <thetext>Created attachment 111771
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>487559</commentid>
    <comment_count>2</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2011-10-20 07:46:50 -0700</bug_when>
    <thetext>We want to keep API compatibility, so applications that built before continue building. With the release of 1.6.x that&apos;s not the case for applications that use JSC, though:

$ gcc -o test test.c $(pkg-config --cflags --libs webkitgtk-3.0)
/tmp/ccKd7Use.o:gcds.c:function set_can_register_cb: error: undefined reference to &apos;JSValueMakeNull&apos;
/tmp/ccKd7Use.o:gcds.c:function set_can_register_cb: error: undefined reference to &apos;JSValueGetType&apos;
/tmp/ccKd7Use.o:gcds.c:function set_can_register_cb: error: undefined reference to &apos;JSValueToBoolean&apos;
/tmp/ccKd7Use.o:gcds.c:function main: error: undefined reference to &apos;JSContextGetGlobalObject&apos;
/tmp/ccKd7Use.o:gcds.c:function main: error: undefined reference to &apos;JSStringCreateWithUTF8CString&apos;
/tmp/ccKd7Use.o:gcds.c:function main: error: undefined reference to &apos;JSObjectMakeFunctionWithCallback&apos;
/tmp/ccKd7Use.o:gcds.c:function main: error: undefined reference to &apos;JSObjectSetProperty&apos;
/tmp/ccKd7Use.o:gcds.c:function main: error: undefined reference to &apos;JSStringRelease&apos;
collect2: ld returned 1 exit status

We need to add javascriptcoregtk-x.0 to the Requires of the webkit{,gtk}-x.0 one.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>487562</commentid>
    <comment_count>3</comment_count>
      <attachid>111771</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2011-10-20 07:49:24 -0700</bug_when>
    <thetext>Comment on attachment 111771
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>487565</commentid>
    <comment_count>4</comment_count>
      <attachid>111771</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2011-10-20 07:59:34 -0700</bug_when>
    <thetext>Comment on attachment 111771
Patch

Clearing flags on attachment: 111771

Committed r97979: &lt;http://trac.webkit.org/changeset/97979&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>487566</commentid>
    <comment_count>5</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2011-10-20 07:59:40 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>111771</attachid>
            <date>2011-10-20 07:45:04 -0700</date>
            <delta_ts>2011-10-20 07:59:33 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-70500-20111020124502.patch</filename>
            <type>text/plain</type>
            <size>1324</size>
            <attacher name="Gustavo Noronha (kov)">gustavo</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTc5MTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3Rr
L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCBiZjZlY2E4NjA5
NWY5NzM4NTFlYzI5ZmMxOWJhMWRmZTJmNTgxZjQ3Li5jZWQ5MGZkYzAyZTk2ZmYyMWU0OTBjODY2
YzZjYTZkZjRhYWJiNDE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK
KysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEt
MTAtMjAgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CisKKyAgICAgICAg
W0dUS10gd2Via2l0Z3RrJ3MgcGtnY29uZmlnIGZpbGUgbmVlZHMgdG8gcmVxdWlyZSBqYXZhc2Ny
aXB0Y29yZWd0aworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9NzA1MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICAqIHdlYmtpdC5wYy5pbjogYWRkIGphdmFzY3JpcHRjb3JlZ3RrIHRvIFJlcXVpcmVzCisKIDIw
MTEtMTAtMTkgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CiAKICAgICAg
ICAgR1RLKyBidWlsZCBmaXguIFJlbmFtZSB0aGUgSU5DTFVERVMgdmFyaWFibGUgc28gaXQgaXMg
bm90IHBpY2tlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0LnBjLmluIGIv
U291cmNlL1dlYktpdC9ndGsvd2Via2l0LnBjLmluCmluZGV4IDRiMmFkMWZlMTc4NmE0YTYyYThk
OTkwOWE3NjNiYzVmNTYyODAwNmYuLjFkMGM0ZTliYjliZDJjNGVlYjdhYmI1MjRjNWQxNjg4ZjU0
MWU0OGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC5wYy5pbgorKysgYi9T
b3VyY2UvV2ViS2l0L2d0ay93ZWJraXQucGMuaW4KQEAgLTYsNiArNiw2IEBAIGluY2x1ZGVkaXI9
QGluY2x1ZGVkaXJACiBOYW1lOiBXZWJLaXQKIERlc2NyaXB0aW9uOiBXZWIgY29udGVudCBlbmdp
bmUgZm9yIEdUSysKIFZlcnNpb246IEBWRVJTSU9OQAotUmVxdWlyZXM6IGdsaWItMi4wIGd0ayst
QEdUS19BUElfVkVSU0lPTkAgbGlic291cC0yLjQKK1JlcXVpcmVzOiBnbGliLTIuMCBndGsrLUBH
VEtfQVBJX1ZFUlNJT05AIGxpYnNvdXAtMi40IGphdmFzY3JpcHRjb3JlZ3RrLUBXRUJLSVRHVEtf
QVBJX1ZFUlNJT05ACiBMaWJzOiAtTCR7bGliZGlyfSAtbHdlYmtpdGd0ay1AV0VCS0lUR1RLX0FQ
SV9WRVJTSU9OQAogQ2ZsYWdzOiAtSSR7aW5jbHVkZWRpcn0vd2Via2l0Z3RrLUBXRUJLSVRHVEtf
QVBJX1ZFUlNJT05ACg==
</data>

          </attachment>
      

    </bug>

</bugzilla>