70490 2011-10-20 04:09:32 -0700 m_client in DeviceMotionController can never be 0, so no need to check for it 2011-10-20 08:31:45 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kenneth kenneth hausmann kling ossy webkit.review.bot oldest_to_newest 487467 0 kenneth 2011-10-20 04:09:32 -0700 SSIA 487468 1 111752 kenneth 2011-10-20 04:10:27 -0700 Created attachment 111752 Patch 487469 2 111752 kenneth 2011-10-20 04:14:27 -0700 Comment on attachment 111752 Patch Lets wait for the cq to commit my other patch 487526 3 111752 webkit.review.bot 2011-10-20 06:20:34 -0700 Comment on attachment 111752 Patch Clearing flags on attachment: 111752 Committed r97972: <http://trac.webkit.org/changeset/97972> 487527 4 webkit.review.bot 2011-10-20 06:20:40 -0700 All reviewed patches have been landed. Closing bug. 487594 5 ossy 2011-10-20 08:31:45 -0700 It was rolled out mistakenly, but landed again: http://trac.webkit.org/changeset/97982 111752 2011-10-20 04:10:27 -0700 2011-10-20 06:20:34 -0700 Patch 0001-m_client-in-DeviceMotionController-can-never-be-0-so.patch text/plain 4505 kenneth RnJvbSAxZWE4YTE4NDJmZTFlZGE1N2Y2MDc2MjI5ZDViZjNmMjFkODM5MzRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiA8a2VubmV0aEB3 ZWJraXQub3JnPgpEYXRlOiBUaHUsIDIwIE9jdCAyMDExIDEzOjA5OjUzICswMjAwClN1YmplY3Q6 IFtQQVRDSF0gbV9jbGllbnQgaW4gRGV2aWNlTW90aW9uQ29udHJvbGxlciBjYW4gbmV2ZXIgYmUg MCwgc28gbm8gbmVlZCB0byBjaGVjayBmb3IgaXQKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD03MDQ5MAoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpObyBiZWhh dmlvciBjaGFuZ2UsIHRodXMgbm8gbmV3IHRlc3RzLgoKKiBkb20vRGV2aWNlTW90aW9uQ29udHJv bGxlci5jcHA6CihXZWJDb3JlOjpEZXZpY2VNb3Rpb25Db250cm9sbGVyOjp0aW1lckZpcmVkKToK KFdlYkNvcmU6OkRldmljZU1vdGlvbkNvbnRyb2xsZXI6OmFkZExpc3RlbmVyKToKKFdlYkNvcmU6 OkRldmljZU1vdGlvbkNvbnRyb2xsZXI6OnJlbW92ZUxpc3RlbmVyKToKKFdlYkNvcmU6OkRldmlj ZU1vdGlvbkNvbnRyb2xsZXI6OnJlbW92ZUFsbExpc3RlbmVycyk6CihXZWJDb3JlOjpEZXZpY2VN b3Rpb25Db250cm9sbGVyOjpzdXNwZW5kKToKKFdlYkNvcmU6OkRldmljZU1vdGlvbkNvbnRyb2xs ZXI6OnJlc3VtZSk6Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgIHwgICAxNyArKysrKysrKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvZG9tL0Rldmlj ZU1vdGlvbkNvbnRyb2xsZXIuY3BwIHwgICAxOSArKysrKysrKystLS0tLS0tLS0tCiAyIGZpbGVz IGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCA1NDk2ODc1Li40NWM0MTJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMTAt MjAgIEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuICA8a2VubmV0aEB3ZWJraXQub3JnPgorCisg ICAgICAgIG1fY2xpZW50IGluIERldmljZU1vdGlvbkNvbnRyb2xsZXIgY2FuIG5ldmVyIGJlIDAs IHNvIG5vIG5lZWQgdG8gY2hlY2sgZm9yIGl0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03MDQ5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE5vIGJlaGF2aW9yIGNoYW5nZSwgdGh1cyBubyBuZXcgdGVzdHMu CisKKyAgICAgICAgKiBkb20vRGV2aWNlTW90aW9uQ29udHJvbGxlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpEZXZpY2VNb3Rpb25Db250cm9sbGVyOjp0aW1lckZpcmVkKToKKyAgICAgICAgKFdl YkNvcmU6OkRldmljZU1vdGlvbkNvbnRyb2xsZXI6OmFkZExpc3RlbmVyKToKKyAgICAgICAgKFdl YkNvcmU6OkRldmljZU1vdGlvbkNvbnRyb2xsZXI6OnJlbW92ZUxpc3RlbmVyKToKKyAgICAgICAg KFdlYkNvcmU6OkRldmljZU1vdGlvbkNvbnRyb2xsZXI6OnJlbW92ZUFsbExpc3RlbmVycyk6Cisg ICAgICAgIChXZWJDb3JlOjpEZXZpY2VNb3Rpb25Db250cm9sbGVyOjpzdXNwZW5kKToKKyAgICAg ICAgKFdlYkNvcmU6OkRldmljZU1vdGlvbkNvbnRyb2xsZXI6OnJlc3VtZSk6CisKIDIwMTEtMTAt MTggIEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuICA8a2VubmV0aEB3ZWJraXQub3JnPgogCiAg ICAgICAgIFByb3Blcmx5IHN1c3BlbmQvcmVzdW1lIEdlb2xvY2F0aW9uL0RldmljZU1vdGlvbi9E ZXZpY2VPcmllbnRhdGlvbiBvYmplY3RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20v RGV2aWNlTW90aW9uQ29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRGV2aWNlTW90 aW9uQ29udHJvbGxlci5jcHAKaW5kZXggNjJiYTQ3Yi4uYzRiZWQ5NyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZG9tL0RldmljZU1vdGlvbkNvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9EZXZpY2VNb3Rpb25Db250cm9sbGVyLmNwcApAQCAtNDgsMTAgKzQ4LDEwIEBA IERldmljZU1vdGlvbkNvbnRyb2xsZXI6On5EZXZpY2VNb3Rpb25Db250cm9sbGVyKCkKIHZvaWQg RGV2aWNlTW90aW9uQ29udHJvbGxlcjo6dGltZXJGaXJlZChUaW1lcjxEZXZpY2VNb3Rpb25Db250 cm9sbGVyPiogdGltZXIpCiB7CiAgICAgQVNTRVJUX1VOVVNFRCh0aW1lciwgdGltZXIgPT0gJm1f dGltZXIpOwotICAgIEFTU0VSVCghbV9jbGllbnQgfHwgbV9jbGllbnQtPmN1cnJlbnREZXZpY2VN b3Rpb24oKSk7CisgICAgQVNTRVJUKG1fY2xpZW50LT5jdXJyZW50RGV2aWNlTW90aW9uKCkpOwog ICAgIG1fdGltZXIuc3RvcCgpOwogICAgIAotICAgIFJlZlB0cjxEZXZpY2VNb3Rpb25EYXRhPiBk ZXZpY2VNb3Rpb25EYXRhID0gbV9jbGllbnQgPyBtX2NsaWVudC0+Y3VycmVudERldmljZU1vdGlv bigpIDogRGV2aWNlTW90aW9uRGF0YTo6Y3JlYXRlKCk7CisgICAgUmVmUHRyPERldmljZU1vdGlv bkRhdGE+IGRldmljZU1vdGlvbkRhdGEgPSBtX2NsaWVudC0+Y3VycmVudERldmljZU1vdGlvbigp OwogICAgIFJlZlB0cjxEZXZpY2VNb3Rpb25FdmVudD4gZXZlbnQgPSBEZXZpY2VNb3Rpb25FdmVu dDo6Y3JlYXRlKGV2ZW50TmFtZXMoKS5kZXZpY2Vtb3Rpb25FdmVudCwgZGV2aWNlTW90aW9uRGF0 YS5nZXQoKSk7CiAgCiAgICAgVmVjdG9yPFJlZlB0cjxET01XaW5kb3c+ID4gbGlzdGVuZXJzVmVj dG9yOwpAQCAtNjMsOSArNjMsOSBAQCB2b2lkIERldmljZU1vdGlvbkNvbnRyb2xsZXI6OnRpbWVy RmlyZWQoVGltZXI8RGV2aWNlTW90aW9uQ29udHJvbGxlcj4qIHRpbWVyKQogICAgIAogdm9pZCBE ZXZpY2VNb3Rpb25Db250cm9sbGVyOjphZGRMaXN0ZW5lcihET01XaW5kb3cqIHdpbmRvdykKIHsK LSAgICAvLyBJZiBubyBjbGllbnQgaXMgcHJlc2VudCBvciB0aGUgY2xpZW50IGFscmVhZHkgaGFz IG1vdGlvbiBkYXRhLAorICAgIC8vIElmIHRoZSBjbGllbnQgYWxyZWFkeSBoYXMgbW90aW9uIGRh dGEsCiAgICAgLy8gaW1tZWRpYXRlbHkgdHJpZ2dlciBhbiBhc3luY2hyb25vdXMgcmVzcG9uc2Uu Ci0gICAgaWYgKCFtX2NsaWVudCB8fCBtX2NsaWVudC0+Y3VycmVudERldmljZU1vdGlvbigpKSB7 CisgICAgaWYgKG1fY2xpZW50LT5jdXJyZW50RGV2aWNlTW90aW9uKCkpIHsKICAgICAgICAgbV9u ZXdMaXN0ZW5lcnMuYWRkKHdpbmRvdyk7CiAgICAgICAgIGlmICghbV90aW1lci5pc0FjdGl2ZSgp KQogICAgICAgICAgICAgbV90aW1lci5zdGFydE9uZVNob3QoMCk7CkBAIC03Myw3ICs3Myw3IEBA IHZvaWQgRGV2aWNlTW90aW9uQ29udHJvbGxlcjo6YWRkTGlzdGVuZXIoRE9NV2luZG93KiB3aW5k b3cpCiAgICAgCiAgICAgYm9vbCB3YXNFbXB0eSA9IG1fbGlzdGVuZXJzLmlzRW1wdHkoKTsKICAg ICBtX2xpc3RlbmVycy5hZGQod2luZG93KTsKLSAgICBpZiAod2FzRW1wdHkgJiYgbV9jbGllbnQp CisgICAgaWYgKHdhc0VtcHR5KQogICAgICAgICBtX2NsaWVudC0+c3RhcnRVcGRhdGluZygpOwog fQogCkBAIC04MSw3ICs4MSw3IEBAIHZvaWQgRGV2aWNlTW90aW9uQ29udHJvbGxlcjo6cmVtb3Zl TGlzdGVuZXIoRE9NV2luZG93KiB3aW5kb3cpCiB7CiAgICAgbV9saXN0ZW5lcnMucmVtb3ZlKHdp bmRvdyk7CiAgICAgbV9uZXdMaXN0ZW5lcnMucmVtb3ZlKHdpbmRvdyk7Ci0gICAgaWYgKG1fbGlz dGVuZXJzLmlzRW1wdHkoKSAmJiBtX2NsaWVudCkKKyAgICBpZiAobV9saXN0ZW5lcnMuaXNFbXB0 eSgpKQogICAgICAgICBtX2NsaWVudC0+c3RvcFVwZGF0aW5nKCk7CiB9CiAKQEAgLTkzLDE5ICs5 MywxOCBAQCB2b2lkIERldmljZU1vdGlvbkNvbnRyb2xsZXI6OnJlbW92ZUFsbExpc3RlbmVycyhE T01XaW5kb3cqIHdpbmRvdykKIAogICAgIG1fbGlzdGVuZXJzLnJlbW92ZUFsbCh3aW5kb3cpOwog ICAgIG1fbmV3TGlzdGVuZXJzLnJlbW92ZSh3aW5kb3cpOwotICAgIGlmIChtX2xpc3RlbmVycy5p c0VtcHR5KCkgJiYgbV9jbGllbnQpCisgICAgaWYgKG1fbGlzdGVuZXJzLmlzRW1wdHkoKSkKICAg ICAgICAgbV9jbGllbnQtPnN0b3BVcGRhdGluZygpOwogfQogCiB2b2lkIERldmljZU1vdGlvbkNv bnRyb2xsZXI6OnN1c3BlbmQoKQogewotICAgIGlmIChtX2NsaWVudCkKLSAgICAgICAgbV9jbGll bnQtPnN0b3BVcGRhdGluZygpOworICAgIG1fY2xpZW50LT5zdG9wVXBkYXRpbmcoKTsKIH0KIAog dm9pZCBEZXZpY2VNb3Rpb25Db250cm9sbGVyOjpyZXN1bWUoKQogewotICAgIGlmIChtX2NsaWVu dCAmJiAhbV9saXN0ZW5lcnMuaXNFbXB0eSgpKQorICAgIGlmICghbV9saXN0ZW5lcnMuaXNFbXB0 eSgpKQogICAgICAgICBtX2NsaWVudC0+c3RhcnRVcGRhdGluZygpOwogfQogCi0tIAoxLjcuNC4x Cgo=