70487 2011-10-20 03:36:06 -0700 fast/frames/frame-element-name.html fails intermittently after r97881 2011-10-20 04:36:05 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ossy ossy dbates eric ossy zherczeg oldest_to_newest 487453 0 ossy 2011-10-20 03:36:06 -0700 fast/frames/frame-element-name.html fails intermittently, because sometimes frames aren't loaded in time because of additional script running. Fix is coming soon. 487460 1 111747 ossy 2011-10-20 04:01:17 -0700 Created attachment 111747 Patch 487472 2 111747 zherczeg 2011-10-20 04:16:26 -0700 Comment on attachment 111747 Patch r=me but please write a little more about the issue and why this fix helps 487479 3 ossy 2011-10-20 04:31:21 -0700 diff: --- /ramdisk/qt-linux-release/build/layout-test-results/fast/frames/frame-element-name-expected.txt +++ /ramdisk/qt-linux-release/build/layout-test-results/fast/frames/frame-element-name-actual.txt @@ -3,41 +3,29 @@ -------- Frame: 'left' -------- -PASS escape(window.frameElement.name) is "left" -PASS escape(window.name) is "left" -------- Frame: '<!--framePath //<!--frame1-->-->' -------- -PASS escape(window.frameElement.name) is "" -PASS escape(window.name) is "" -------- Frame: '<!--framePath //<!--frame2-->-->' -------- -PASS escape(window.frameElement.name) is "_blank" -PASS escape(window.name) is "_blank" -------- Frame: '_parent' -------- -PASS escape(window.frameElement.name) is "_parent" -PASS escape(window.name) is "_parent" -------- Frame: '_self' -------- -PASS escape(window.frameElement.name) is "_self" -PASS escape(window.name) is "_self" -------- Frame: '_top' -------- -PASS escape(window.frameElement.name) is "_top" -PASS escape(window.name) is "_top" 487482 4 ossy 2011-10-20 04:35:49 -0700 Landed in http://trac.webkit.org/changeset/97963 111747 2011-10-20 04:01:17 -0700 2011-10-20 04:36:05 -0700 Patch bug-70487-20111020110113.patch text/plain 1737 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogOTc4ODEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAzMmM3MGNiYzI3OGJjZGI1Mzg5MzE4 MDEwYTQ4ZjNhNzJhNjFmZmNlLi5jYzE4NDYyNzU1ZWNmYmMxZWQ5YzhlOTk4NTYyNWE0NmNiYjNm YTNlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMTAtMjAgIENzYWJhIE9zenRyb2dvbsOh YyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBmYXN0L2ZyYW1lcy9mcmFtZS1lbGVtZW50 LW5hbWUuaHRtbCBmYWlscyBpbnRlcm1pdHRlbnRseSBhZnRlciByOTc4ODEKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwNDg3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2ZyYW1lcy9mcmFtZS1l bGVtZW50LW5hbWUuaHRtbDoKKwogMjAxMS0xMC0xOSAgRXJpayBBcnZpZHNzb24gIDxhcnZAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIEpTIFRlc3QgSGFybmVzczogSW5zZXJ0IHRoZSBzdHlsZXNo ZWV0IGR5bmFtaWNhbGx5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9mcmFt ZS1lbGVtZW50LW5hbWUuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL2ZyYW1lLWVsZW1l bnQtbmFtZS5odG1sCmluZGV4IGYyNmIyOTg3ZDgzNzY2YTM4OWQzMzc5YjQzYzJhMDNmOTE2Yjk0 YTMuLmZiYTJjZmQ0OWQ5NzRmYWZlNzdmMDdjMmUzMDE0MDY3Y2ZlZjU1ODcgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL2ZyYW1lLWVsZW1lbnQtbmFtZS5odG1sCisrKyBiL0xh eW91dFRlc3RzL2Zhc3QvZnJhbWVzL2ZyYW1lLWVsZW1lbnQtbmFtZS5odG1sCkBAIC0xLDExICsx LDIwIEBACiA8aHRtbD4KIDxoZWFkPgogPHNjcmlwdD4KLWlmICh3aW5kb3cubGF5b3V0VGVzdENv bnRyb2xsZXIpCitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CiAgICAgbGF5b3V0 VGVzdENvbnRyb2xsZXIuZHVtcENoaWxkRnJhbWVzQXNUZXh0KCk7CisgICAgbGF5b3V0VGVzdENv bnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworfQorCitmdW5jdGlvbiBmcmFtZXNMb2FkZWQoKQor eworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIGxheW91dFRl c3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKK30KKwogPC9zY3JpcHQ+CiA8L2hlYWQ+Ci0gPGZy YW1lc2V0IGJvcmRlcj0iMSIgY29scz0iMTUwLDE1MCwxNTAsMTUwLDE1MCwqIiBzdHlsZT0nYm9y ZGVyOiBzb2xpZCAxcHg7Jz4KKyA8ZnJhbWVzZXQgYm9yZGVyPSIxIiBjb2xzPSIxNTAsMTUwLDE1 MCwxNTAsMTUwLCoiIHN0eWxlPSdib3JkZXI6IHNvbGlkIDFweDsnIG9ubG9hZD0iZnJhbWVzTG9h ZGVkKCkiPgogICA8ZnJhbWUgbWFyZ2lud2lkdGg9IjEiIHNyYz0icmVzb3VyY2VzL2ZyYW1lLWVs ZW1lbnQtbmFtZS5odG1sP2V4cGVjdGVkTmFtZT1sZWZ0IiBuYW1lPSJsZWZ0Ij4KICAgPGZyYW1l IHNyYz0icmVzb3VyY2VzL2ZyYW1lLWVsZW1lbnQtbmFtZS5odG1sP2V4cGVjdGVkTmFtZT0iPgog ICA8ZnJhbWUgc3JjPSJyZXNvdXJjZXMvZnJhbWUtZWxlbWVudC1uYW1lLmh0bWw/ZXhwZWN0ZWRO YW1lPV9ibGFuayIgbmFtZT0iX2JsYW5rIj4K