70473 2011-10-19 22:02:09 -0700 Remove Now Unused FileChooserSettings.deprecatedAcceptTypes 2011-10-20 10:32:52 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned joepeck tkent webkit.review.bot oldest_to_newest 487326 0 joepeck 2011-10-19 22:02:09 -0700 The last users of this was removed recently with EFL and Chromium switching to the new FileChooserSettings.acceptMIMETypes. The variable is now unused and can be removed. Bugs and their fixes: <http://webkit.org/b/70002> [EFL]: Move from FileChooserSettings deprecatedAcceptType to acceptMIMETypes <http://trac.webkit.org/changeset/97421> <http://webkit.org/b/70003> [Chromium]: Move from FileChooserSettings deprecatedAcceptType to acceptMIMETypes <http://trac.webkit.org/changeset/97910> 487338 1 111726 joepeck 2011-10-19 22:27:55 -0700 Created attachment 111726 [PATCH] Proposed Fix Remove the slot and the few places it was set. 487697 2 111726 webkit.review.bot 2011-10-20 10:32:48 -0700 Comment on attachment 111726 [PATCH] Proposed Fix Clearing flags on attachment: 111726 Committed r97997: <http://trac.webkit.org/changeset/97997> 487698 3 webkit.review.bot 2011-10-20 10:32:52 -0700 All reviewed patches have been landed. Closing bug. 111726 2011-10-19 22:27:55 -0700 2011-10-20 10:32:48 -0700 [PATCH] Proposed Fix proposed-diff.patch text/plain 2291 joepeck cGVjb3Jhcm9bL1ZvbHVtZXMvRGF0YS9Db2RlL3dlYmtpdC1vcGVuLXNvdXJjZV0oRklMRS1VUExP QUQtcGFyc2VkLW1pbWUtdHlwZXMpJCBnaXQgZGlmZiAtLWNhY2hlZApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDk0 ZGY5YmUuLjUwOTE3OTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0xMC0xOSAg Sm9zZXBoIFBlY29yYXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJlbW92ZSBO b3cgVW51c2VkIEZpbGVDaG9vc2VyU2V0dGluZ3MuZGVwcmVjYXRlZEFjY2VwdFR5cGVzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDQ3MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHRtbC9GaWxlSW5w dXRUeXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZpbGVJbnB1dFR5cGU6OmhhbmRsZURPTUFj dGl2YXRlRXZlbnQpOgorICAgICAgICAoV2ViQ29yZTo6RmlsZUlucHV0VHlwZTo6cmVjZWl2ZURy b3BGb3JEaXJlY3RvcnlVcGxvYWQpOgorICAgICAgICAqIHBsYXRmb3JtL0ZpbGVDaG9vc2VyLmg6 CisKIDIwMTEtMTAtMTkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAg ICBBdHRlbXB0IHRvIGZpeCB0aGUgUXQgYnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0ZpbGVJbnB1dFR5cGUuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9GaWxlSW5wdXRU eXBlLmNwcAppbmRleCBhYzljZmJjLi5kZTA1ZmE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0ZpbGVJbnB1dFR5cGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRmlsZUlu cHV0VHlwZS5jcHAKQEAgLTE1Myw3ICsxNTMsNiBAQCB2b2lkIEZpbGVJbnB1dFR5cGU6OmhhbmRs ZURPTUFjdGl2YXRlRXZlbnQoRXZlbnQqIGV2ZW50KQogI2Vsc2UKICAgICAgICAgc2V0dGluZ3Mu YWxsb3dzTXVsdGlwbGVGaWxlcyA9IGlucHV0LT5mYXN0SGFzQXR0cmlidXRlKG11bHRpcGxlQXR0 cik7CiAjZW5kaWYKLSAgICAgICAgc2V0dGluZ3MuZGVwcmVjYXRlZEFjY2VwdFR5cGVzID0gaW5w dXQtPmFjY2VwdCgpOwogICAgICAgICBzZXR0aW5ncy5hY2NlcHRNSU1FVHlwZXMgPSBpbnB1dC0+ YWNjZXB0TUlNRVR5cGVzKCk7CiAgICAgICAgIHNldHRpbmdzLnNlbGVjdGVkRmlsZXMgPSBtX2Zp bGVMaXN0LT5wYXRocygpOwogICAgICAgICBjaHJvbWUtPnJ1bk9wZW5QYW5lbChpbnB1dC0+ZG9j dW1lbnQoKS0+ZnJhbWUoKSwgbmV3RmlsZUNob29zZXIoc2V0dGluZ3MpKTsKQEAgLTMyOSw3ICsz MjgsNiBAQCB2b2lkIEZpbGVJbnB1dFR5cGU6OnJlY2VpdmVEcm9wRm9yRGlyZWN0b3J5VXBsb2Fk KGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBwYXRocykKICAgICAgICAgc2V0dGluZ3MuYWxsb3dzRGly ZWN0b3J5VXBsb2FkID0gdHJ1ZTsKICAgICAgICAgc2V0dGluZ3MuYWxsb3dzTXVsdGlwbGVGaWxl cyA9IHRydWU7CiAgICAgICAgIHNldHRpbmdzLnNlbGVjdGVkRmlsZXMuYXBwZW5kKHBhdGhzWzBd KTsKLSAgICAgICAgc2V0dGluZ3MuZGVwcmVjYXRlZEFjY2VwdFR5cGVzID0gaW5wdXQtPmFjY2Vw dCgpOwogICAgICAgICBzZXR0aW5ncy5hY2NlcHRNSU1FVHlwZXMgPSBpbnB1dC0+YWNjZXB0TUlN RVR5cGVzKCk7CiAgICAgICAgIGNocm9tZS0+ZW51bWVyYXRlQ2hvc2VuRGlyZWN0b3J5KG5ld0Zp bGVDaG9vc2VyKHNldHRpbmdzKSk7CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vRmlsZUNob29zZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0ZpbGVDaG9v c2VyLmgKaW5kZXggZjVmYzgzZS4uYTliNTQwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vRmlsZUNob29zZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9GaWxl Q2hvb3Nlci5oCkBAIC00Miw3ICs0Miw2IEBAIHN0cnVjdCBGaWxlQ2hvb3NlclNldHRpbmdzIHsK ICNpZiBFTkFCTEUoRElSRUNUT1JZX1VQTE9BRCkKICAgICBib29sIGFsbG93c0RpcmVjdG9yeVVw bG9hZDsKICNlbmRpZgotICAgIFN0cmluZyBkZXByZWNhdGVkQWNjZXB0VHlwZXM7CiAgICAgVmVj dG9yPFN0cmluZz4gYWNjZXB0TUlNRVR5cGVzOwogICAgIFZlY3RvcjxTdHJpbmc+IHNlbGVjdGVk RmlsZXM7CiB9Owo=