70467 2011-10-19 19:49:57 -0700 Optimization triggers in the old JIT may sometimes fire repeatedly even though there is no optimization to be done 2011-10-19 23:33:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 69996 1 fpizlo webkit-unassigned oldest_to_newest 487247 0 fpizlo 2011-10-19 19:49:57 -0700 If cti_optimize_from_ret fires but finds it has no work to do, it currently just returns. This means that it will fire again the next time even though there is still likely to be no work to do. This may cause slow downs since cti_optimize_from_ret is a stub call. 487275 1 111719 fpizlo 2011-10-19 20:43:05 -0700 Created attachment 111719 the patch 487279 2 111719 oliver 2011-10-19 20:46:26 -0700 Comment on attachment 111719 the patch r=me 487351 3 fpizlo 2011-10-19 23:33:08 -0700 Landed in http://trac.webkit.org/changeset/97940 111719 2011-10-19 20:43:05 -0700 2011-10-19 20:46:26 -0700 the patch fixoptret_patch_1.diff text/plain 2131 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTc5MjcpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAK KzIwMTEtMTAtMTkgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBP cHRpbWl6YXRpb24gdHJpZ2dlcnMgaW4gdGhlIG9sZCBKSVQgbWF5IHNvbWV0aW1lcyBmaXJlIHJl cGVhdGVkbHkgZXZlbgorICAgICAgICB0aG91Z2ggdGhlcmUgaXMgbm8gb3B0aW1pemF0aW9uIHRv IGJlIGRvbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTcwNDY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAor ICAgICAgICBJZiBvcHRpbWl6ZV9mcm9tX3JldCBkb2VzIG5vdGhpbmcsIGl0IGRlbGF5cyB0aGUg bmV4dCBvcHRpbWl6YXRpb24gdHJpZ2dlci4KKyAgICAgICAgVGhpcyBpcyBwZXJmb3JtYW5jZS1u ZXV0cmFsLgorCisgICAgICAgICogaml0L0pJVFN0dWJzLmNwcDoKKyAgICAgICAgKEpTQzo6REVG SU5FX1NUVUJfRlVOQ1RJT04pOgorICAgICAgICAqIHJ1bnRpbWUvSGV1cmlzdGljcy5jcHA6Cisg ICAgICAgIChKU0M6OkhldXJpc3RpY3M6OmluaXRpYWxpemVIZXVyaXN0aWNzKToKKwogMjAxMS0x MC0xOSAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAg ICAgUG9pc29uaW5nIG9mIHN0cmljdCBjYWxsZXIsYXJndW1lbnRzIGluYXBwcm9wcmlhdGVseSBw b2lzb25pbmcgImluIgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5jcHAJ KHJldmlzaW9uIDk3ODgyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTIwMjMsNiArMjAyMyw3IEBAIERFRklORV9TVFVCX0ZVTkNU SU9OKHZvaWQsIG9wdGltaXplX2Zyb20KICAgICAgICAgICAgIGNvZGVCbG9jay0+cmVvcHRpbWl6 ZShjYWxsRnJhbWUtPmdsb2JhbERhdGEoKSk7CiAgICAgICAgIH0KIAorICAgICAgICBjb2RlQmxv Y2stPm9wdGltaXplU29vbigpOwogICAgICAgICByZXR1cm47CiAgICAgfQogICAgIApJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSGV1cmlzdGljcy5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSGV1cmlzdGljcy5jcHAJKHJldmlzaW9u IDk3ODgyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSGV1cmlzdGljcy5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTEwMiw3ICsxMDIsNyBAQCB2b2lkIGluaXRpYWxpemVIZXVyaXN0 aWNzKCkKICAgICBTRVQoZXhlY3V0aW9uQ291bnRlclZhbHVlRm9yT3B0aW1pemVBZnRlcldhcm1V cCwgICAgIC0xMDAwKTsKICAgICBTRVQoZXhlY3V0aW9uQ291bnRlclZhbHVlRm9yT3B0aW1pemVB ZnRlckxvbmdXYXJtVXAsIC01MDAwKTsKICAgICBTRVQoZXhlY3V0aW9uQ291bnRlclZhbHVlRm9y RG9udE9wdGltaXplQW55dGltZVNvb24sIHN0ZDo6bnVtZXJpY19saW1pdHM8aW50MzJfdD46Om1p bigpKTsKLSAgICBTRVQoZXhlY3V0aW9uQ291bnRlclZhbHVlRm9yT3B0aW1pemVTb29uLCAgICAg ICAgICAgIC0xMDApOworICAgIFNFVChleGVjdXRpb25Db3VudGVyVmFsdWVGb3JPcHRpbWl6ZVNv b24sICAgICAgICAgICAgLTEwMDApOwogICAgIFNFVChleGVjdXRpb25Db3VudGVyVmFsdWVGb3JP cHRpbWl6ZU5leHRJbnZvY2F0aW9uLCAgMCk7CiAKICAgICBTRVQoZXhlY3V0aW9uQ291bnRlcklu Y3JlbWVudEZvckxvb3AsICAgMSk7Cg==