70466 2011-10-19 19:47:03 -0700 DFG ConvertThis emits slow code when the source node is known to be, but not predicted to be, a final object 2011-10-19 23:38:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 69996 1 fpizlo webkit-unassigned oldest_to_newest 487243 0 fpizlo 2011-10-19 19:47:03 -0700 Patch forthcoming. 487274 1 111718 fpizlo 2011-10-19 20:42:57 -0700 Created attachment 111718 the patch 487278 2 111718 oliver 2011-10-19 20:46:00 -0700 Comment on attachment 111718 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=111718&action=review r=me > Source/JavaScriptCore/dfg/DFGAbstractState.cpp:509 > - > + No reason to land this change 487359 3 fpizlo 2011-10-19 23:38:43 -0700 Landed in http://trac.webkit.org/changeset/97942 111718 2011-10-19 20:42:57 -0700 2011-10-19 20:46:00 -0700 the patch fixconvertthis_patch_1.diff text/plain 3057 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTc5MjgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAK KzIwMTEtMTAtMTkgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBE RkcgQ29udmVydFRoaXMgZW1pdHMgc2xvdyBjb2RlIHdoZW4gdGhlIHNvdXJjZSBub2RlIGlzIGtu b3duIHRvIGJlLAorICAgICAgICBidXQgbm90IHByZWRpY3RlZCB0byBiZSwgYSBmaW5hbCBvYmpl Y3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwNDY2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAg ICBBZGRlZCBhIG5ldyBjYXNlIGluIENvbnZlcnRUaGlzIGNvbXBpbGF0aW9uLgorCisgICAgICAg ICogZGZnL0RGR0Fic3RyYWN0U3RhdGUuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkFic3RyYWN0 U3RhdGU6OmV4ZWN1dGUpOgorICAgICAgICAqIGRmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNw cDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZSk6CisgICAgICAg ICogZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1 bGF0aXZlSklUOjpjb21waWxlKToKKwogMjAxMS0xMC0xOSAgWXVxaWFuZyBYaWFuICA8eXVxaWFu Zy54aWFuQGludGVsLmNvbT4KIAogICAgICAgICBERkcgSklUIDMyXzY0IC0gcmVtb3ZlIHVubmVj ZXNzYXJ5IGRvdWJsZSB1bmJveGluZ3MgaW4gZmlsbERvdWJsZS9maWxsU3BlY3VsYXRlRG91Ymxl CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0U3RhdGUuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RTdGF0ZS5j cHAJKHJldmlzaW9uIDk3ODgyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0 cmFjdFN0YXRlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTA2LDcgKzUwNiw3IEBAIGJvb2wgQWJz dHJhY3RTdGF0ZTo6ZXhlY3V0ZShOb2RlSW5kZXggbm8KICAgICAgICAgICAgIGRlc3RpbmF0aW9u ID0gc291cmNlOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KLSAgICAgICAgICAgIAor ICAgICAgICAKICAgICAgICAgZGVzdGluYXRpb24gPSBzb3VyY2U7CiAgICAgICAgIGRlc3RpbmF0 aW9uLm1lcmdlKFByZWRpY3RPYmplY3RPdGhlcik7CiAgICAgICAgIGJyZWFrOwpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQu Y3BwCShyZXZpc2lvbiA5Nzg4MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3Bl Y3VsYXRpdmVKSVQzMl82NC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3OTUsNiArMTc5NSwxMiBA QCB2b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxlKE5vZGUmIG5vZGUpCiAgICAgfQogICAgICAg ICAKICAgICBjYXNlIENvbnZlcnRUaGlzOiB7CisgICAgICAgIGlmIChpc09iamVjdFByZWRpY3Rp b24obV9zdGF0ZS5mb3JOb2RlKG5vZGUuY2hpbGQxKCkpLm1fdHlwZSkpIHsKKyAgICAgICAgICAg IFNwZWN1bGF0ZUNlbGxPcGVyYW5kIHRoaXNWYWx1ZSh0aGlzLCBub2RlLmNoaWxkMSgpKTsKKyAg ICAgICAgICAgIGNlbGxSZXN1bHQodGhpc1ZhbHVlLmdwcigpLCBtX2NvbXBpbGVJbmRleCk7Cisg ICAgICAgICAgICBicmVhazsKKyAgICAgICAgfQorICAgICAgICAKICAgICAgICAgaWYgKGlzT3Ro ZXJQcmVkaWN0aW9uKGF0KG5vZGUuY2hpbGQxKCkpLnByZWRpY3Rpb24oKSkpIHsKICAgICAgICAg ICAgIEpTVmFsdWVPcGVyYW5kIHRoaXNWYWx1ZSh0aGlzLCBub2RlLmNoaWxkMSgpKTsKICAgICAg ICAgICAgIEdQUlRlbXBvcmFyeSBzY3JhdGNoKHRoaXMsIHRoaXNWYWx1ZSk7CkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHAJKHJl dmlzaW9uIDk3ODgyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2 ZUpJVDY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTg4OCw2ICsxODg4LDEyIEBAIHZvaWQgU3Bl Y3VsYXRpdmVKSVQ6OmNvbXBpbGUoTm9kZSYgbm9kZSkKICAgICB9CiAgICAgICAgIAogICAgIGNh c2UgQ29udmVydFRoaXM6IHsKKyAgICAgICAgaWYgKGlzT2JqZWN0UHJlZGljdGlvbihtX3N0YXRl LmZvck5vZGUobm9kZS5jaGlsZDEoKSkubV90eXBlKSkgeworICAgICAgICAgICAgU3BlY3VsYXRl Q2VsbE9wZXJhbmQgdGhpc1ZhbHVlKHRoaXMsIG5vZGUuY2hpbGQxKCkpOworICAgICAgICAgICAg Y2VsbFJlc3VsdCh0aGlzVmFsdWUuZ3ByKCksIG1fY29tcGlsZUluZGV4KTsKKyAgICAgICAgICAg IGJyZWFrOworICAgICAgICB9CisgICAgICAgIAogICAgICAgICBpZiAoaXNPdGhlclByZWRpY3Rp b24oYXQobm9kZS5jaGlsZDEoKSkucHJlZGljdGlvbigpKSkgewogICAgICAgICAgICAgSlNWYWx1 ZU9wZXJhbmQgdGhpc1ZhbHVlKHRoaXMsIG5vZGUuY2hpbGQxKCkpOwogICAgICAgICAgICAgR1BS VGVtcG9yYXJ5IHNjcmF0Y2godGhpcywgdGhpc1ZhbHVlKTsK