<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>70449</bug_id>
          
          <creation_ts>2011-10-19 16:01:03 -0700</creation_ts>
          <short_desc>Chromium doesn&apos;t support git branch builds, so don&apos;t add the branch to the product dir</short_desc>
          <delta_ts>2011-10-19 19:27:50 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>jochen</reporter>
          <assigned_to>jochen</assigned_to>
          <cc>aroben</cc>
    
    <cc>dbates</cc>
    
    <cc>eric</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>487082</commentid>
    <comment_count>0</comment_count>
    <who name="">jochen</who>
    <bug_when>2011-10-19 16:01:03 -0700</bug_when>
    <thetext>Chromium doesn&apos;t support git branch builds, so don&apos;t add the branch to the product dir</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>487084</commentid>
    <comment_count>1</comment_count>
      <attachid>111687</attachid>
    <who name="">jochen</who>
    <bug_when>2011-10-19 16:02:17 -0700</bug_when>
    <thetext>Created attachment 111687
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>487085</commentid>
    <comment_count>2</comment_count>
    <who name="">jochen</who>
    <bug_when>2011-10-19 16:03:40 -0700</bug_when>
    <thetext>Eric, can you have a look at this please?

without this, you can&apos;t run-chromium-webkit-unit-tests when using git branch builds (which is useful if you use the same repository for chromium-mac and mac development)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>487095</commentid>
    <comment_count>3</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-10-19 16:06:47 -0700</bug_when>
    <thetext>Um.  Seems OK to me, but I know very little about this perl or our branch build system.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>487235</commentid>
    <comment_count>4</comment_count>
      <attachid>111687</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-10-19 19:27:46 -0700</bug_when>
    <thetext>Comment on attachment 111687
Patch

Clearing flags on attachment: 111687

Committed r97923: &lt;http://trac.webkit.org/changeset/97923&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>487236</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-10-19 19:27:50 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>111687</attachid>
            <date>2011-10-19 16:02:17 -0700</date>
            <delta_ts>2011-10-19 19:27:46 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-70449-20111020010215.patch</filename>
            <type>text/plain</type>
            <size>1203</size>
            <attacher>jochen</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTc2NDAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi
L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4MWQ4MWQwOWY5ZDkxNDc2MGE5N2I4NjdiNjNhZjRiZDli
OWJlYmEzLi5kMTRmZWQ5MmM0NDk3NDlhMTA0OWNkODhiNmNjZGEzMjEyY2QyNmUzIDEwMDY0NAot
LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg
QEAKKzIwMTEtMTAtMTkgIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJvbWl1bS5vcmc+CisK
KyAgICAgICAgQ2hyb21pdW0gZG9lc24ndCBzdXBwb3J0IGdpdCBicmFuY2ggYnVpbGRzLCBzbyBk
b24ndCBhZGQgdGhlIGJyYW5jaCB0byB0aGUgcHJvZHVjdCBkaXIKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwNDQ5CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06Cisg
ICAgICAgIChkZXRlcm1pbmVCYXNlUHJvZHVjdERpcik6CisKIDIwMTEtMTAtMTcgIERpbWl0cmkg
R2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBnYXJkZW4tby1tYXRp
YyBvcGVyYXRpb25zIGZhaWwgYmVjYXVzZSBvZiBDU1AuCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp
cHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggYTJj
OWQxNTdhYWI5MWFhOTFiMzNkMWQ4MTI3ZTlmZjkxZTRlMTJhOS4uNmNlMDk3YzBkMTEwNTViMjE1
ODYxMmM1Nzk3NzgxMGViZGI4Mzc0ZCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRk
aXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMTg2LDcgKzE4Niw3
IEBAIHN1YiBkZXRlcm1pbmVCYXNlUHJvZHVjdERpcgogICAgICAgICAkYmFzZVByb2R1Y3REaXIg
PSAiJHNvdXJjZURpci9XZWJLaXRCdWlsZCI7CiAgICAgfQogCi0gICAgaWYgKGlzR2l0KCkgJiYg
aXNHaXRCcmFuY2hCdWlsZCgpKSB7CisgICAgaWYgKGlzR2l0KCkgJiYgaXNHaXRCcmFuY2hCdWls
ZCgpICYmICFpc0Nocm9taXVtKCkpIHsKICAgICAgICAgbXkgJGJyYW5jaCA9IGdpdEJyYW5jaCgp
OwogICAgICAgICAkYmFzZVByb2R1Y3REaXIgPSAiJGJhc2VQcm9kdWN0RGlyLyRicmFuY2giOwog
ICAgIH0K
</data>

          </attachment>
      

    </bug>

</bugzilla>