70429 2011-10-19 09:57:55 -0700 HTMLBodyElement: Simplify link/alink/vlink attribute parsing. 2011-10-19 14:27:45 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling darin koivisto tonikitoo oldest_to_newest 486861 0 kling 2011-10-19 09:57:55 -0700 HTMLBodyElement: Simplify link/alink/vlink attribute parsing. 486865 1 111641 kling 2011-10-19 10:02:01 -0700 Created attachment 111641 Proposed patch 486868 2 111641 tonikitoo 2011-10-19 10:09:08 -0700 Comment on attachment 111641 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=111641&action=review I was just working on a change that depends on this code :) > Source/WebCore/html/HTMLBodyElement.h:-95 > - virtual void didMoveToNewOwnerDocument(); related removal? 487009 3 111641 kling 2011-10-19 14:27:36 -0700 Comment on attachment 111641 Proposed patch Clearing flags on attachment: 111641 Committed r97877: <http://trac.webkit.org/changeset/97877> 487010 4 kling 2011-10-19 14:27:45 -0700 All reviewed patches have been landed. Closing bug. 111641 2011-10-19 10:02:01 -0700 2011-10-19 14:27:35 -0700 Proposed patch bug-70429.diff text/plain 4789 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiZTRiZWNjLi43NjE4N2NjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTEtMTAtMTkgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIEhUTUxCb2R5RWxlbWVudDogU2ltcGxpZnkgbGluay9hbGluay92bGluayBhdHRyaWJ1dGUg cGFyc2luZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTcwNDI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SW5zdGVhZCBvZiBjYXJyeWluZyBhcm91bmQgYSBDU1NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbiB3 aXRoIHRoZSBib2R5IGVsZW1lbnQsCisgICAgICAgIGp1c3QgdXNlIENTU1BhcnNlcjo6cGFyc2VD b2xvcigpIHRvIHBhcnNlIHRoZSB0aHJlZSBsaW5rIGNvbG9yIGF0dHJpYnV0ZXMuCisKKyAgICAg ICAgKiBodG1sL0hUTUxCb2R5RWxlbWVudC5oOgorICAgICAgICAqIGh0bWwvSFRNTEJvZHlFbGVt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxCb2R5RWxlbWVudDo6fkhUTUxCb2R5RWxl bWVudCk6CisKKyAgICAgICAgICAgIFJlbW92ZSBIVE1MQm9keUVsZW1lbnQ6Om1fbGlua0RlY2wg YW5kIGFsbCB0aGUgdm9vZG9vIHRoYXQgd2VudCBhbG9uZyB3aXRoIGl0LgorCisgICAgICAgIChX ZWJDb3JlOjpIVE1MQm9keUVsZW1lbnQ6OnBhcnNlTWFwcGVkQXR0cmlidXRlKToKKworICAgICAg ICAgICAgVXNlIENTU1BhcnNlciBkaXJlY3RseSB0byBwYXJzZSB0aGUgY29sb3IgdmFsdWVzIGZv ciB7bGluayxhbGluayx2bGlua31BdHRyLgorCiAyMDExLTEwLTE5ICBWc2V2b2xvZCBWbGFzb3Yg IDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEVuYWJsZSBj YXNlU2Vuc2l0aXZlIHNlYXJjaCAvIFJlZ2V4IHN1cHBvcnQgaW4gYWR2YW5jZWQgc2VhcmNoLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQm9keUVsZW1lbnQuY3BwIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MQm9keUVsZW1lbnQuY3BwCmluZGV4IGRmM2ZjZDguLjIxNGRm NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEJvZHlFbGVtZW50LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxCb2R5RWxlbWVudC5jcHAKQEAgLTI1LDggKzI1 LDcgQEAKICNpbmNsdWRlICJIVE1MQm9keUVsZW1lbnQuaCIKIAogI2luY2x1ZGUgIkF0dHJpYnV0 ZS5oIgotI2luY2x1ZGUgIkNTU1N0eWxlU2VsZWN0b3IuaCIKLSNpbmNsdWRlICJDU1NTdHlsZVNo ZWV0LmgiCisjaW5jbHVkZSAiQ1NTUGFyc2VyLmgiCiAjaW5jbHVkZSAiQ1NTVmFsdWVLZXl3b3Jk cy5oIgogI2luY2x1ZGUgIkV2ZW50TmFtZXMuaCIKICNpbmNsdWRlICJGcmFtZS5oIgpAQCAtNTks MTggKzU4LDYgQEAgUGFzc1JlZlB0cjxIVE1MQm9keUVsZW1lbnQ+IEhUTUxCb2R5RWxlbWVudDo6 Y3JlYXRlKGNvbnN0IFF1YWxpZmllZE5hbWUmIHRhZ05hbWUKIAogSFRNTEJvZHlFbGVtZW50Ojp+ SFRNTEJvZHlFbGVtZW50KCkKIHsKLSAgICBpZiAobV9saW5rRGVjbCkgewotICAgICAgICBtX2xp bmtEZWNsLT5zZXROb2RlKDApOwotICAgICAgICBtX2xpbmtEZWNsLT5zZXRQYXJlbnQoMCk7Ci0g ICAgfQotfQotCi12b2lkIEhUTUxCb2R5RWxlbWVudDo6Y3JlYXRlTGlua0RlY2woKQotewotICAg IG1fbGlua0RlY2wgPSBDU1NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbjo6Y3JlYXRlKCk7Ci0gICAg bV9saW5rRGVjbC0+c2V0UGFyZW50KGRvY3VtZW50KCktPmVsZW1lbnRTaGVldCgpKTsKLSAgICBt X2xpbmtEZWNsLT5zZXROb2RlKHRoaXMpOwotICAgIG1fbGlua0RlY2wtPnNldFN0cmljdFBhcnNp bmcoIWRvY3VtZW50KCktPmluUXVpcmtzTW9kZSgpKTsKIH0KIAogYm9vbCBIVE1MQm9keUVsZW1l bnQ6Om1hcFRvRW50cnkoY29uc3QgUXVhbGlmaWVkTmFtZSYgYXR0ck5hbWUsIE1hcHBlZEF0dHJp YnV0ZUVudHJ5JiByZXN1bHQpIGNvbnN0CkBAIC0xMjQsMTggKzExMSwxNCBAQCB2b2lkIEhUTUxC b2R5RWxlbWVudDo6cGFyc2VNYXBwZWRBdHRyaWJ1dGUoQXR0cmlidXRlKiBhdHRyKQogICAgICAg ICAgICAgZWxzZQogICAgICAgICAgICAgICAgIGRvY3VtZW50KCktPnJlc2V0QWN0aXZlTGlua0Nv bG9yKCk7CiAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICBpZiAoIW1fbGlua0RlY2wpCi0g ICAgICAgICAgICAgICAgY3JlYXRlTGlua0RlY2woKTsKLSAgICAgICAgICAgIG1fbGlua0RlY2wt PnNldFByb3BlcnR5KENTU1Byb3BlcnR5Q29sb3IsIGF0dHItPnZhbHVlKCksIGZhbHNlLCBmYWxz ZSk7Ci0gICAgICAgICAgICBSZWZQdHI8Q1NTVmFsdWU+IHZhbCA9IG1fbGlua0RlY2wtPmdldFBy b3BlcnR5Q1NTVmFsdWUoQ1NTUHJvcGVydHlDb2xvcik7Ci0gICAgICAgICAgICBpZiAodmFsICYm IHZhbC0+aXNQcmltaXRpdmVWYWx1ZSgpKSB7Ci0gICAgICAgICAgICAgICAgQ29sb3IgY29sID0g ZG9jdW1lbnQoKS0+c3R5bGVTZWxlY3RvcigpLT5nZXRDb2xvckZyb21QcmltaXRpdmVWYWx1ZShz dGF0aWNfY2FzdDxDU1NQcmltaXRpdmVWYWx1ZSo+KHZhbC5nZXQoKSkpOworICAgICAgICAgICAg UkdCQTMyIGNvbG9yOworICAgICAgICAgICAgaWYgKENTU1BhcnNlcjo6cGFyc2VDb2xvcihjb2xv ciwgYXR0ci0+dmFsdWUoKSwgIWRvY3VtZW50KCktPmluUXVpcmtzTW9kZSgpKSkgewogICAgICAg ICAgICAgICAgIGlmIChhdHRyLT5uYW1lKCkgPT0gbGlua0F0dHIpCi0gICAgICAgICAgICAgICAg ICAgIGRvY3VtZW50KCktPnNldExpbmtDb2xvcihjb2wpOworICAgICAgICAgICAgICAgICAgICBk b2N1bWVudCgpLT5zZXRMaW5rQ29sb3IoY29sb3IpOwogICAgICAgICAgICAgICAgIGVsc2UgaWYg KGF0dHItPm5hbWUoKSA9PSB2bGlua0F0dHIpCi0gICAgICAgICAgICAgICAgICAgIGRvY3VtZW50 KCktPnNldFZpc2l0ZWRMaW5rQ29sb3IoY29sKTsKKyAgICAgICAgICAgICAgICAgICAgZG9jdW1l bnQoKS0+c2V0VmlzaXRlZExpbmtDb2xvcihjb2xvcik7CiAgICAgICAgICAgICAgICAgZWxzZQot ICAgICAgICAgICAgICAgICAgICBkb2N1bWVudCgpLT5zZXRBY3RpdmVMaW5rQ29sb3IoY29sKTsK KyAgICAgICAgICAgICAgICAgICAgZG9jdW1lbnQoKS0+c2V0QWN0aXZlTGlua0NvbG9yKGNvbG9y KTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgICAgICAKQEAgLTM0NSwxNiArMzI4LDQg QEAgdm9pZCBIVE1MQm9keUVsZW1lbnQ6OmFkZFN1YnJlc291cmNlQXR0cmlidXRlVVJMcyhMaXN0 SGFzaFNldDxLVVJMPiYgdXJscykgY29uc3QKICAgICBhZGRTdWJyZXNvdXJjZVVSTCh1cmxzLCBk b2N1bWVudCgpLT5jb21wbGV0ZVVSTChnZXRBdHRyaWJ1dGUoYmFja2dyb3VuZEF0dHIpKSk7CiB9 CiAKLXZvaWQgSFRNTEJvZHlFbGVtZW50OjpkaWRNb3ZlVG9OZXdPd25lckRvY3VtZW50KCkKLXsK LSAgICAvLyBXaGVuIG1vdmluZyBib2R5IGVsZW1lbnRzIGJldHdlZW4gZG9jdW1lbnRzLCB3ZSBz aG91bGQgaGF2ZSB0byByZXNldCB0aGUgcGFyZW50IHNoZWV0IGZvciBhbnkKLSAgICAvLyBsaW5r IHN0eWxlIGRlY2xhcmF0aW9ucy4gIElmIHdlIGRvbid0IHdlIG1pZ2h0IGNyYXNoIGxhdGVyLgot ICAgIC8vIEluIHByYWN0aWNlIEkgY2FuJ3QgcmVwcm9kdWNlIHRoaXMgdGhlb3JldGljYWwgcHJv YmxlbS4KLSAgICAvLyB3ZWJhcmNoaXZlL2Fkb3B0LWF0dHJpYnV0ZS1zdHlsZWQtYm9keS13ZWJh cmNoaXZlLmh0bWwgdHJpZXMgdG8gbWFrZSBzdXJlIHRoaXMgY3Jhc2ggd29uJ3Qgc3VyZmFjZS4K LSAgICBpZiAobV9saW5rRGVjbCkKLSAgICAgICAgbV9saW5rRGVjbC0+c2V0UGFyZW50KGRvY3Vt ZW50KCktPmVsZW1lbnRTaGVldCgpKTsKLSAgICAKLSAgICBIVE1MRWxlbWVudDo6ZGlkTW92ZVRv TmV3T3duZXJEb2N1bWVudCgpOwotfQotCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxCb2R5RWxlbWVudC5oIGIvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MQm9keUVsZW1lbnQuaAppbmRleCA0MGFiOGNjLi41YzYzMjY0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxCb2R5RWxlbWVudC5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTEJvZHlFbGVtZW50LmgKQEAgLTc0LDggKzc0LDYgQEAgcHJpdmF0ZToK ICAgICB2aXJ0dWFsIHZvaWQgcGFyc2VNYXBwZWRBdHRyaWJ1dGUoQXR0cmlidXRlKik7CiAKICAg ICB2aXJ0dWFsIHZvaWQgaW5zZXJ0ZWRJbnRvRG9jdW1lbnQoKTsKLQotICAgIHZvaWQgY3JlYXRl TGlua0RlY2woKTsKICAgICAKICAgICB2aXJ0dWFsIGJvb2wgaXNVUkxBdHRyaWJ1dGUoQXR0cmli dXRlKikgY29uc3Q7CiAgICAgCkBAIC05MSwxMCArODksNiBAQCBwcml2YXRlOgogICAgIHZpcnR1 YWwgaW50IHNjcm9sbFdpZHRoKCk7CiAgICAgCiAgICAgdmlydHVhbCB2b2lkIGFkZFN1YnJlc291 cmNlQXR0cmlidXRlVVJMcyhMaXN0SGFzaFNldDxLVVJMPiYpIGNvbnN0OwotICAgIAotICAgIHZp cnR1YWwgdm9pZCBkaWRNb3ZlVG9OZXdPd25lckRvY3VtZW50KCk7Ci0KLSAgICBSZWZQdHI8Q1NT TXV0YWJsZVN0eWxlRGVjbGFyYXRpb24+IG1fbGlua0RlY2w7CiB9OwogCiB9IC8vbmFtZXNwYWNl Cg==