70420 2011-10-19 07:50:40 -0700 [Gtk][Geolocation] Build guards missing in geolocation clients 2011-10-19 11:55:23 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 zan webkit-unassigned gustavo webkit.review.bot oldest_to_newest 486788 0 zan 2011-10-19 07:50:40 -0700 Client-based geolocation support, added in r97746 (bug #64970), was not wrapped into ENABLE(CLIENT_BASED_GEOLOCATION) guards, as noted by Xan [1]. This bug will oversee the fixing of that problem. [1] https://bugs.webkit.org/show_bug.cgi?id=64970#c28 486803 1 111624 zan 2011-10-19 08:17:31 -0700 Created attachment 111624 Patch This patch adds build guards that should make non-geolocation builds buildable. 486811 2 111624 gustavo 2011-10-19 08:24:52 -0700 Comment on attachment 111624 Patch Looks correct to me! 486906 3 gustavo 2011-10-19 11:54:15 -0700 Committed r97871: <http://trac.webkit.org/changeset/97871> 486907 4 111624 gustavo 2011-10-19 11:55:23 -0700 Comment on attachment 111624 Patch Clearing flags. 111624 2011-10-19 08:17:31 -0700 2011-10-19 11:55:23 -0700 Patch bug-70420-20111019171722.patch text/plain 3621 zan U3VidmVyc2lvbiBSZXZpc2lvbjogOTc4NTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3Rr L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCA4MDY2MWRkNmYy MzkxZGEwNGZmZjUyNzcwYzFmNzkxODVlMzg2MjUyLi4xMmVlYjJiZDQ5YmE5NjYwYWI2MGZjYWY0 OTk4NWI4MTZmZGNhOGI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEt MTAtMTkgIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KKworICAgICAgICBb R3RrXVtHZW9sb2NhdGlvbl0gQnVpbGQgZ3VhcmRzIG1pc3NpbmcgaW4gZ2VvbG9jYXRpb24gY2xp ZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzA0 MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRz IGJ1aWxkIGd1YXJkcyB0aGF0IHdlcmUgZm9yZ290dGVuIHdoZW4gY2xpZW50LWJhc2VkCisgICAg ICAgIGdlb2xvY2F0aW9uIHdhcyBpbnRyb2R1Y2VkIGluIHI5Nzc0Ni4gVGhpcyBzaG91bGQgbWFr ZSBidWlsZHMKKyAgICAgICAgd2l0aG91dCBnZW9sb2NhdGlvbiBzdXBwb3J0IHN1Y2NlZWQgYWdh aW4uCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9HZW9sb2NhdGlvbkNsaWVudEd0ay5jcHA6 CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvR2VvbG9jYXRpb25DbGllbnRHdGsuaDoKKyAgICAg ICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6CisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdf aW5pdCk6CisKIDIwMTEtMTAtMTggIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNv bT4KIAogICAgICAgICBbR3RrXSBTdXBwb3J0IGZvciBjbGllbnQtYmFzZWQgZ2VvbG9jYXRpb24K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0dlb2xvY2F0aW9u Q2xpZW50R3RrLmNwcCBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0dlb2xvY2F0 aW9uQ2xpZW50R3RrLmNwcAppbmRleCAwNWY4YmQ5YjIwZDA3NDY2MzQ5N2QxMGEyNDY0NzM5Y2Y5 ODFjNjY4Li5mYWMxZDczYWZlM2E1MDgyMmEwZDEzZjkxODM0MjJjOTdmMzM5NTRlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9HZW9sb2NhdGlvbkNsaWVudEd0 ay5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvR2VvbG9jYXRpb25D bGllbnRHdGsuY3BwCkBAIC0yMSw2ICsyMSw4IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5j bHVkZSAiR2VvbG9jYXRpb25DbGllbnRHdGsuaCIKIAorI2lmIEVOQUJMRShDTElFTlRfQkFTRURf R0VPTE9DQVRJT04pCisKICNpbmNsdWRlICJDaHJvbWUuaCIKICNpbmNsdWRlICJHZW9sb2NhdGlv bi5oIgogI2luY2x1ZGUgIkdlb2xvY2F0aW9uQ29udHJvbGxlci5oIgpAQCAtMTc0LDMgKzE3Niw1 IEBAIHZvaWQgR2VvbG9jYXRpb25DbGllbnQ6OmVycm9yT2NjdXJlZChjb25zdCBjaGFyKiBtZXNz YWdlKQogfQogCiB9CisKKyNlbmRpZiAvLyBFTkFCTEUoQ0xJRU5UX0JBU0VEX0dFT0xPQ0FUSU9O KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvR2VvbG9jYXRp b25DbGllbnRHdGsuaCBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0dlb2xvY2F0 aW9uQ2xpZW50R3RrLmgKaW5kZXggMjY0MmUzOTlmMzcyNmMxMTAyNTY1M2YzMGQ2NGYzMTAzNDUw MTViYi4uYmYxN2M3MTM1YWE1ZGMzMGZjNWMwYzFiNjc5ZDhhZjVkOTllOTY3ZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvR2VvbG9jYXRpb25DbGllbnRHdGsu aAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9HZW9sb2NhdGlvbkNsaWVu dEd0ay5oCkBAIC0yMSw2ICsyMSw4IEBACiAjaWZuZGVmIEdlb2xvY2F0aW9uQ2xpZW50R3RrX2gK ICNkZWZpbmUgR2VvbG9jYXRpb25DbGllbnRHdGtfaAogCisjaWYgRU5BQkxFKENMSUVOVF9CQVNF RF9HRU9MT0NBVElPTikKKwogI2luY2x1ZGUgIkdSZWZQdHIuaCIKICNpbmNsdWRlICJHZW9sb2Nh dGlvbkNsaWVudC5oIgogI2luY2x1ZGUgIkdlb2xvY2F0aW9uUG9zaXRpb24uaCIKQEAgLTc1LDQg Kzc3LDYgQEAgcHJpdmF0ZToKIH07CiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKIAorI2VuZGlmIC8v IEVOQUJMRShDTElFTlRfQkFTRURfR0VPTE9DQVRJT04pCisKICNlbmRpZiAvLyBHZW9sb2NhdGlv bkNsaWVudEd0a19oCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0 d2Vidmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAK aW5kZXggYTc5NDI4OTlkOGMzOGEzMzkyOGFlZjZkZGQ5YWFiNWNiMmI3MGFlYi4uOGNkOGJiNWUy MjlmOTU0YWFjNDhkOGM3ZDk3NzI3ZGRjNjdhYTU1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dl YmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtMzMxNywxNSArMzMxNywxOSBAQCBzdGF0aWMgdm9p ZCB3ZWJraXRfd2ViX3ZpZXdfaW5pdChXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KQogICAgIHBhZ2VD bGllbnRzLmRldmljZU9yaWVudGF0aW9uQ2xpZW50ID0gc3RhdGljX2Nhc3Q8V2ViQ29yZTo6RGV2 aWNlT3JpZW50YXRpb25DbGllbnQqPihuZXcgRGV2aWNlT3JpZW50YXRpb25DbGllbnRHdGspOwog I2VuZGlmCiAKKyNpZiBFTkFCTEUoQ0xJRU5UX0JBU0VEX0dFT0xPQ0FUSU9OKQogICAgIGlmIChE dW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6OmR1bXBSZW5kZXJUcmVlTW9kZUVuYWJsZWQoKSkKICAg ICAgICAgcGFnZUNsaWVudHMuZ2VvbG9jYXRpb25DbGllbnQgPSBuZXcgR2VvbG9jYXRpb25DbGll bnRNb2NrOwogICAgIGVsc2UKICAgICAgICAgcGFnZUNsaWVudHMuZ2VvbG9jYXRpb25DbGllbnQg PSBuZXcgV2ViS2l0OjpHZW9sb2NhdGlvbkNsaWVudCh3ZWJWaWV3KTsKKyNlbmRpZgogCiAgICAg cHJpdi0+Y29yZVBhZ2UgPSBuZXcgUGFnZShwYWdlQ2xpZW50cyk7CiAKKyNpZiBFTkFCTEUoQ0xJ RU5UX0JBU0VEX0dFT0xPQ0FUSU9OKQogICAgIGlmIChEdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6 OmR1bXBSZW5kZXJUcmVlTW9kZUVuYWJsZWQoKSkKICAgICAgICAgc3RhdGljX2Nhc3Q8R2VvbG9j YXRpb25DbGllbnRNb2NrKj4ocGFnZUNsaWVudHMuZ2VvbG9jYXRpb25DbGllbnQpLT5zZXRDb250 cm9sbGVyKHByaXYtPmNvcmVQYWdlLT5nZW9sb2NhdGlvbkNvbnRyb2xsZXIoKSk7CisjZW5kaWYK IAogICAgIC8vIFBhZ2VzIHdpdGhpbiBhIHNhbWUgc2Vzc2lvbiBuZWVkIHRvIGJlIGxpbmtlZCB0 b2dldGhlciBvdGhlcndpc2Ugc29tZSBmdW5jdGlvbmFsaXRpZXMgc3VjaAogICAgIC8vIGFzIHZp c2l0ZWQgbGluayBjb2xvcmF0aW9uIChhY3Jvc3MgcGFnZXMpIGFuZCBjaGFuZ2luZyBwb3B1cCB3 aW5kb3cgbG9jYXRpb24gd2lsbCBub3Qgd29yay4K