70413 2011-10-19 07:05:50 -0700 [Qt] Disable fullscreen api on Qt by default 2011-10-20 06:01:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cshu cshu hausmann noam ossy webkit.review.bot oldest_to_newest 486751 0 cshu 2011-10-19 07:05:50 -0700 As the WebKit side of implementation for fullscreen api feature has not been done yet, we'd better turn off the feature on the WebCore side by default. 486792 1 111619 cshu 2011-10-19 07:53:51 -0700 Created attachment 111619 patch 1 486883 2 cshu 2011-10-19 10:47:02 -0700 It turns out the WK2 support for this feature is trivial, at least from layout test point of view. We don't have to disable this feature. Please refer to bug 70111. 486967 3 cshu 2011-10-19 13:42:37 -0700 Even the current implementation in Qt WK2 is able to make most of the fullscreen api tests pass, the real stuff is still not there yet. So we still want to disable the feature. 486991 4 111619 cshu 2011-10-19 14:06:40 -0700 Comment on attachment 111619 patch 1 Clearing flags on attachment: 111619 Committed r97875: <http://trac.webkit.org/changeset/97875> 486992 5 cshu 2011-10-19 14:06:48 -0700 All reviewed patches have been landed. Closing bug. 487366 6 ossy 2011-10-19 23:49:35 -0700 You forgot running layout tests before landing and watching bots after landing ... I had to update an expected result to make buildbot happy _instead of you_ guys: http://trac.webkit.org/changeset/97943/trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 487517 7 cshu 2011-10-20 06:01:57 -0700 Sorry about the layout test failures. I left work before the buildbot finished building. 111619 2011-10-19 07:53:51 -0700 2011-10-19 14:06:40 -0700 patch 1 70413_1.patch text/plain 3263 cshu SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3ODU5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMTkgIENoYW5nIFNo dSAgPGNzaHVAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdIERpc2FibGUgZnVsbHNjcmVlbiBh cGkgb24gUXQgYnkgZGVmYXVsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzA0MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBcyB0aGUgV2ViS2l0IHNpZGUgb2YgaW1wbGVtZW50YXRpb24gZm9yIGZ1bGxz Y3JlZW4gYXBpIGZlYXR1cmUgaGFzIG5vdCBiZWVuIGRvbmUgeWV0LAorICAgICAgICB3ZSdkIGJl dHRlciB0dXJuIG9mZiB0aGUgZmVhdHVyZSBvbiB0aGUgV2ViQ29yZSBzaWRlIGJ5IGRlZmF1bHQu CisKKyAgICAgICAgKiBmZWF0dXJlcy5wcmk6CisKIDIwMTEtMTAtMTkgIENocmlzIEZsZWl6YWNo ICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBBWDogYnV0dG9ucyBvZiBudW1iZXIg dHlwZSA8aW5wdXQ+IGNvbnRyb2xzIGFyZSBub3QgZnVsbHkgYWNjZXNzaWJsZQpJbmRleDogU291 cmNlL1dlYkNvcmUvZmVhdHVyZXMucHJpCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Zl YXR1cmVzLnByaQkocmV2aXNpb24gOTc4NTkpCisrKyBTb3VyY2UvV2ViQ29yZS9mZWF0dXJlcy5w cmkJKHdvcmtpbmcgY29weSkKQEAgLTE3NSw3ICsxNzUsNyBAQCBtYWVtbzV8bWFlbW82IHsKICAg ICB9CiB9CiAKLSFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfRlVMTFNDUkVFTl9BUEk9Lik6IERF RklORVMgKz0gRU5BQkxFX0ZVTExTQ1JFRU5fQVBJPTEKKyFjb250YWlucyhERUZJTkVTLCBFTkFC TEVfRlVMTFNDUkVFTl9BUEk9Lik6IERFRklORVMgKz0gRU5BQkxFX0ZVTExTQ1JFRU5fQVBJPTAK IAogIyMgRm9yd2FyZCBlbmFibGVkIGZlYXR1cmUgbWFjcm9zIHRvIEphdmFTY3JpcHQgZW5hYmxl ZCBmZWF0dXJlcyBtYWNyb3MKIEZFQVRVUkVfREVGSU5FU19KQVZBU0NSSVBUID0gTEFOR1VBR0Vf SkFWQVNDUklQVD0xCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA5Nzg1OSkKKysrIExheW91dFRlc3RzL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDExLTEwLTE5ICBDaGFu ZyBTaHUgIDxjc2h1QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1F0XSBEaXNhYmxlIGZ1bGxzY3Jl ZW4gYXBpIG9uIFF0IGJ5IGRlZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTcwNDEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDExLTEwLTE5ICBCYWxh enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdIDIgaW5zcGVj dG9yL2V4dGVuc2lvbnMgdGVzdHMgdGltZXMgb3V0IG9uIE1hYyBhZnRlciByOTc4NTAKSW5kZXg6 IExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkocmV2aXNpb24gOTc4NTkpCisrKyBMYXlvdXRUZXN0cy9w bGF0Zm9ybS9xdC9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC0yNDYsMjkgKzI0Niw3IEBAIGZh c3QvaGlkcGkKIAogIyBbUXRdIFF0V2ViS2l0IG5lZWRzIGZ1bGxzY3JlZW4gYXBpIHN1cHBvcnQK ICMgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDEzMj4KLWZ1bGxz Y3JlZW4vZnVsbC1zY3JlZW4tY2FuY2VsLmh0bWwKLWZ1bGxzY3JlZW4vZnVsbC1zY3JlZW4tY3Nz Lmh0bWwKLWZ1bGxzY3JlZW4vZnVsbC1zY3JlZW4tZnJhbWVzZXQuaHRtbAotZnVsbHNjcmVlbi9m dWxsLXNjcmVlbi1pZnJhbWUtYWxsb3dlZC5odG1sCi1mdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLWlm cmFtZS1sZWdhY3kuaHRtbAotZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1pZnJhbWUtekluZGV4Lmh0 bWwKLWZ1bGxzY3JlZW4vZnVsbC1zY3JlZW4ta2V5Ym9hcmQtZGlzYWJsZWQuaHRtbAotZnVsbHNj cmVlbi9mdWxsLXNjcmVlbi1rZXlib2FyZC1lbmFibGVkLmh0bWwKLWZ1bGxzY3JlZW4vZnVsbC1z Y3JlZW4tcGxhY2Vob2xkZXIuaHRtbAotZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1yZW1vdmUtYW5j ZXN0b3ItYWZ0ZXIuaHRtbAotZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1yZW1vdmUtYW5jZXN0b3Iu aHRtbAotZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1yZW1vdmUtY2hpbGRyZW4uaHRtbAotZnVsbHNj cmVlbi9mdWxsLXNjcmVlbi1yZW1vdmUuaHRtbAotZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1yZW1v dmUtc2libGluZy5odG1sCi1mdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLXJlbmRlci1pbmxpbmUuaHRt bAotZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1yZXF1ZXN0Lmh0bWwKLWZ1bGxzY3JlZW4vZnVsbC1z Y3JlZW4tc3RhY2tpbmctY29udGV4dC5odG1sCi1mdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLXR3aWNl Lmh0bWwKLWZ1bGxzY3JlZW4vZnVsbC1zY3JlZW4tekluZGV4LWFmdGVyLmh0bWwKLWZ1bGxzY3Jl ZW4vZnVsbC1zY3JlZW4tekluZGV4Lmh0bWwKLWZ1bGxzY3JlZW4vcGFyZW50LWZsb3ctaW5saW5l LXdpdGgtYmxvY2stY2hpbGQuaHRtbAotZnVsbHNjcmVlbi92aWRlby1jb250cm9scy1vdmVycmlk ZS5odG1sCi1mdWxsc2NyZWVuL3ZpZGVvLXNwZWNpZmllZC1zaXplLmh0bWwKK2Z1bGxzY3JlZW4K IHBsdWdpbnMvZnVsbHNjcmVlbi1wbHVnaW5zLWRvbnQtcmVsb2FkLmh0bWwKIAogIyA9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0gIwo=