70394 2011-10-18 18:34:45 -0700 Date.prototype.toISOString fails to throw exception 2011-10-18 18:49:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough webkit-unassigned oldest_to_newest 486503 0 barraclough 2011-10-18 18:34:45 -0700 Should throw a range error if the internal value is not finite. 486508 1 111549 barraclough 2011-10-18 18:37:57 -0700 Created attachment 111549 Fix 486511 2 111549 sam 2011-10-18 18:42:32 -0700 Comment on attachment 111549 Fix View in context: https://bugs.webkit.org/attachment.cgi?id=111549&action=review > Source/JavaScriptCore/runtime/DatePrototype.cpp:510 > + if (!isfinite(thisDateObj->internalNumber())) > + return throwVMError(exec, createRangeError(exec, "Invalid Date")); > + > + WHITESPACE!! ! !!!! !!! 486513 3 barraclough 2011-10-18 18:49:19 -0700 Fixed in r97826 111549 2011-10-18 18:37:57 -0700 2011-10-18 18:42:32 -0700 Fix 70394.patch text/plain 3943 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTc4MjMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMTAtMTggIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgor CisgICAgICAgIERhdGUucHJvdG90eXBlLnRvSVNPU3RyaW5nIGZhaWxzIHRvIHRocm93IGV4Y2Vw dGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzAz OTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1 bnRpbWUvRGF0ZVByb3RvdHlwZS5jcHA6CisgICAgICAgIChKU0M6OmRhdGVQcm90b0Z1bmNUb0lT T1N0cmluZyk6CisgICAgICAgICAgICAtIFNob3VsZCB0aHJvdyBhIHJhbmdlIGVycm9yIGlmIHRo ZSBpbnRlcm5hbCB2YWx1ZSBpcyBub3QgZmluaXRlLgorCiAyMDExLTEwLTE4ICBNYXJrIEhhaG5l bmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIHN0YXRpYyBw dXQgdG8gcHV0QnlJbmRleApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRGF0 ZVByb3RvdHlwZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvRGF0ZVByb3RvdHlwZS5jcHAJKHJldmlzaW9uIDk3NzkxKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvRGF0ZVByb3RvdHlwZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUwMyw3 ICs1MDMsMTEgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBkYXRlUHJvdG9GdQogICAg ICAgICByZXR1cm4gdGhyb3dWTVR5cGVFcnJvcihleGVjKTsKICAgICAKICAgICBEYXRlSW5zdGFu Y2UqIHRoaXNEYXRlT2JqID0gYXNEYXRlSW5zdGFuY2UodGhpc1ZhbHVlKTsgCi0gICAgCisKKyAg ICBpZiAoIWlzZmluaXRlKHRoaXNEYXRlT2JqLT5pbnRlcm5hbE51bWJlcigpKSkKKyAgICAgICAg cmV0dXJuIHRocm93Vk1FcnJvcihleGVjLCBjcmVhdGVSYW5nZUVycm9yKGV4ZWMsICJJbnZhbGlk IERhdGUiKSk7CisKKwogICAgIGNvbnN0IEdyZWdvcmlhbkRhdGVUaW1lKiBncmVnb3JpYW5EYXRl VGltZSA9IHRoaXNEYXRlT2JqLT5ncmVnb3JpYW5EYXRlVGltZVVUQyhleGVjKTsKICAgICBpZiAo IWdyZWdvcmlhbkRhdGVUaW1lKQogICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzTm9u dHJpdmlhbFN0cmluZyhleGVjLCAiSW52YWxpZCBEYXRlIikpOwpJbmRleDogTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24g OTc4MjMpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr MSwxNSBAQAorMjAxMS0xMC0xOCAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBs ZS5jb20+CisKKyAgICAgICAgRGF0ZS5wcm90b3R5cGUudG9JU09TdHJpbmcgZmFpbHMgdG8gdGhy b3cgZXhjZXB0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03MDM5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogZmFzdC9qcy9kYXRlLXRvaXNvc3RyaW5nLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBm YXN0L2pzL3NjcmlwdC10ZXN0cy9kYXRlLXRvaXNvc3RyaW5nLmpzOgorICAgICAgICAodGhyb3dz UmFuZ2VFcnJvcik6CisgICAgICAgICAgICAtIGZpeGVkIHRlc3QgY2FzZS4KKwogMjAxMS0xMC0x OCAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVcGRhdGUg Y2hyb21pdW0gbGVvcGFyZCBjZyBiYXNlbGluZS4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvanMv ZGF0ZS10b2lzb3N0cmluZy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv ZmFzdC9qcy9kYXRlLXRvaXNvc3RyaW5nLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gOTc3OTEpCisr KyBMYXlvdXRUZXN0cy9mYXN0L2pzL2RhdGUtdG9pc29zdHJpbmctZXhwZWN0ZWQudHh0CSh3b3Jr aW5nIGNvcHkpCkBAIC0xMiw3ICsxMiw3IEBAIFBBU1MgbmV3IERhdGUoJzEgSmFudWFyeSA0MDAw IFVUQycpLnRvSVMKIFBBU1MgbmV3IERhdGUoJzEgSmFudWFyeSAxMDAwMDAgVVRDJykudG9JU09T dHJpbmcoKSBpcyAnKzEwMDAwMC0wMS0wMVQwMDowMDowMC4wMDBaJwogUEFTUyBuZXcgRGF0ZSgn MSBKYW51YXJ5IC0xIFVUQycpLnRvSVNPU3RyaW5nKCkgaXMgJy0wMDAwMDEtMDEtMDFUMDA6MDA6 MDAuMDAwWicKIFBBU1MgbmV3IERhdGUoJzEwIE1hcmNoIDIwMDAgVVRDJykudG9JU09TdHJpbmco KSBpcyAnMjAwMC0wMy0xMFQwMDowMDowMC4wMDBaJwotUEFTUyBuZXcgRGF0ZShOYU4pLnRvSVNP U3RyaW5nKCkgaXMgJ0ludmFsaWQgRGF0ZScKK1BBU1MgdGhyb3dzUmFuZ2VFcnJvcigibmV3IERh dGUoTmFOKS50b0lTT1N0cmluZygpIikgaXMgdHJ1ZQogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQg aXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL3Njcmlw dC10ZXN0cy9kYXRlLXRvaXNvc3RyaW5nLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zh c3QvanMvc2NyaXB0LXRlc3RzL2RhdGUtdG9pc29zdHJpbmcuanMJKHJldmlzaW9uIDk3NzkxKQor KysgTGF5b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvZGF0ZS10b2lzb3N0cmluZy5qcwko d29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDE1IEBACiBkZXNjcmlwdGlvbigiVGVzdHMgZm9yIERh dGUudG9JU09TdHJpbmciKTsKIAorZnVuY3Rpb24gdGhyb3dzUmFuZ2VFcnJvcihzdHIpCit7Cisg ICAgdHJ5IHsKKyAgICAgICAgZXZhbChzdHIpOworICAgIH0gY2F0Y2ggKGUpIHsKKyAgICAgICAg cmV0dXJuIGUgaW5zdGFuY2VvZiBSYW5nZUVycm9yOworICAgIH0KKyAgICByZXR1cm4gZmFsc2U7 Cit9CisKIHNob3VsZFRocm93KCJEYXRlLnRvSVNPU3RyaW5nLmNhbGwoe30pIik7CiBzaG91bGRU aHJvdygiRGF0ZS50b0lTT1N0cmluZy5jYWxsKDApIik7CiAKQEAgLTEwLDYgKzIwLDYgQEAgc2hv dWxkQmUoIm5ldyBEYXRlKCcxIEphbnVhcnkgNDAwMCBVVEMnKQogc2hvdWxkQmUoIm5ldyBEYXRl KCcxIEphbnVhcnkgMTAwMDAwIFVUQycpLnRvSVNPU3RyaW5nKCkiLCAiJysxMDAwMDAtMDEtMDFU MDA6MDA6MDAuMDAwWiciKTsKIHNob3VsZEJlKCJuZXcgRGF0ZSgnMSBKYW51YXJ5IC0xIFVUQycp LnRvSVNPU3RyaW5nKCkiLCAiJy0wMDAwMDEtMDEtMDFUMDA6MDA6MDAuMDAwWiciKTsKIHNob3Vs ZEJlKCJuZXcgRGF0ZSgnMTAgTWFyY2ggMjAwMCBVVEMnKS50b0lTT1N0cmluZygpIiwgIicyMDAw LTAzLTEwVDAwOjAwOjAwLjAwMFonIik7Ci1zaG91bGRCZSgibmV3IERhdGUoTmFOKS50b0lTT1N0 cmluZygpIiwgIidJbnZhbGlkIERhdGUnIik7CitzaG91bGRCZVRydWUoJ3Rocm93c1JhbmdlRXJy b3IoIm5ldyBEYXRlKE5hTikudG9JU09TdHJpbmcoKSIpJyk7CiAKIHN1Y2Nlc3NmdWxseVBhcnNl ZCA9IHRydWU7Cg==