70389 2011-10-18 17:25:12 -0700 Assertion failure when going back in page with navigated subframes 2011-10-18 18:37:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 70393 1 andersca andersca dpranke japhet webkit.review.bot oldest_to_newest 486462 0 andersca 2011-10-18 17:25:12 -0700 Assertion failure when going back in page with navigated subframes 486468 1 111537 andersca 2011-10-18 17:32:07 -0700 Created attachment 111537 Patch 486480 2 andersca 2011-10-18 17:51:28 -0700 Committed r97821: <http://trac.webkit.org/changeset/97821> 486493 3 dpranke 2011-10-18 18:20:01 -0700 Oddly, the -expected.txt file in the patch has "This tests that navigating two subframes and then going back using history.go(-2) won't assert." once, but the file that actually got landed has that line repeated. I assume that is a mistake somehow? I will land an updated baseline if you aren't around to comment on this in the next ~30 min or so. 486502 4 dpranke 2011-10-18 18:34:42 -0700 filed bug 70393 to fix the baseline. 486506 5 dpranke 2011-10-18 18:37:00 -0700 landed an updated baseline. 111537 2011-10-18 17:32:07 -0700 2011-10-18 17:38:00 -0700 Patch bug-70389-20111018173211.patch text/plain 6475 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogOTc3NzgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiYjk2NmRjMTUwYzU5MDky NDc2YzI3M2M2YjNlNjIxYTljYTgxNWMxLi4yYjIxZGU1ZTFiNGMwYzJjMzQ0NzgzYTc4ZDg2MDY0 ZTE5NWUxN2FlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTEtMTAtMTggIEFuZGVy cyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBBc3NlcnRpb24gZmFp bHVyZSB3aGVuIGdvaW5nIGJhY2sgaW4gcGFnZSB3aXRoIG5hdmlnYXRlZCBzdWJmcmFtZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwMzg5CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS84OTg4NDQ0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGZhc3QvaGlzdG9yeS9oaXN0b3J5LWJhY2stdHdp Y2Utd2l0aC1zdWJmcmFtZXMtYXNzZXJ0Lmh0bWwKKworICAgICAgICBJZiBhIHNpbmdsZSBuYXZp Z2F0aW9uIGVuZHMgdXAgbG9hZGluZyBtdWx0aXBsZSBmcmFtZSwgdGhlIGZpcnN0IGNvbW1pdHRl ZCBmcmFtZSB3aWxsCisgICAgICAgIGVuZCB1cCBjYWxsaW5nIHJlY3Vyc2l2ZVVwZGF0ZUZvckNv bW1pdCBvbiB0aGUgbWFpbiBmcmFtZSB3aGljaCB3aWxsIG51bGwgb3V0IHRoZSBwcm92aXNpb25h bCBpdGVtCisgICAgICAgIGZvciBhbGwgZnJhbWVzIG9uIHRoZSBwYWdlLiBUaGlzIG1lYW5zIHRo YXQgaXQgY2FuIG51bGwgb3V0IHRoZSBwcm92aXNpb25hbCBpdGVtIGZvciBhbnkgZnJhbWVzCisg ICAgICAgIHRoYXQgYXJlIHN0aWxsIHlldCB0byBiZSBjb21taXR0ZWQgd2hpY2ggY2F1c2VzIHRo ZSBhZm9yZW1lbnRpb25lZCBhc3NlcnRpb24gZmFpbHVyZS4KKworICAgICAgICBGaXggdGhpcyBi eSBvbmx5IG51bGxpbmcgb3V0IHRoZSBwcm92aXNpb25hbCBoaXN0b3J5IGl0ZW0gKGFuZCBzYXZp bmcvcmVzdG9yaW5nIHRoZSBzY3JvbGwgcG9zaXRpb24gYW5kCisgICAgICAgIHNvbWUgb3RoZXIg dGhpbmdzKSBmb3IgZnJhbWVzIHRoYXQgYWxyZWFkeSBjb250YWluIHRoZSBVUkwgdGhhdCB0aGUg aXRlbSByZXF1ZXN0ZWQuIElmIGEgZnJhbWUgaXMgYmVpbmcgbG9hZGVkLAorICAgICAgICBpdCB3 aWxsIG51bGwgb3V0IGl0cyBwcm92aXNpb25hbCBoaXN0b3J5IGl0ZW0gd2hlbiBpdCdzIGNvbW1p dHRlZC4KKworICAgICAgICAqIGxvYWRlci9IaXN0b3J5Q29udHJvbGxlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpIaXN0b3J5Q29udHJvbGxlcjo6cmVjdXJzaXZlVXBkYXRlRm9yQ29tbWl0KToK KwogMjAxMS0xMC0xOCAgQW5uYSBDYXZlbmRlciAgPGFubmFjY0BjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgQ2hhbmdlIENvZGVHZW5lcmF0b3JHT2JqZWN0LnBtIHRvIHVzZSBnX3ZhbHVlX2dldF91 aW50KCkgaW5zdGVhZCBvZiBnX3ZhbHVlX2dldF91c2hvcnQoKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvbG9hZGVyL0hpc3RvcnlDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xv YWRlci9IaXN0b3J5Q29udHJvbGxlci5jcHAKaW5kZXggM2JiYmZjMzFlNTY3YmFmNGI3NzU1YmYw MWMwZmIyMmJhMzczMTYyZC4uYzZjN2IwMjdkNGY2ZTA5ZjZjOWMxYjNlZGQzOTlkZjIzZWU1ZjRl OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0hpc3RvcnlDb250cm9sbGVyLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3BwCkBAIC00 NzIsMjQgKzQ3MiwyNiBAQCB2b2lkIEhpc3RvcnlDb250cm9sbGVyOjpyZWN1cnNpdmVVcGRhdGVG b3JDb21taXQoKQogICAgIC8vIEZvciBlYWNoIGZyYW1lIHRoYXQgYWxyZWFkeSBoYWQgdGhlIGNv bnRlbnQgdGhlIGl0ZW0gcmVxdWVzdGVkIChiYXNlZCBvbgogICAgIC8vIChhIG1hdGNoaW5nIFVS TCBhbmQgZnJhbWUgdHJlZSBzbmFwc2hvdCksIGp1c3QgcmVzdG9yZSB0aGUgc2Nyb2xsIHBvc2l0 aW9uLgogICAgIC8vIFNhdmUgZm9ybSBzdGF0ZSAod29ya3MgZnJvbSBjdXJyZW50SXRlbSwgc2lu Y2UgbV9mcmFtZUxvYWRDb21wbGV0ZSBpcyB0cnVlKQotICAgIEFTU0VSVChtX2ZyYW1lTG9hZENv bXBsZXRlKTsKLSAgICBzYXZlRG9jdW1lbnRTdGF0ZSgpOwotICAgIHNhdmVTY3JvbGxQb3NpdGlv bkFuZFZpZXdTdGF0ZVRvSXRlbShtX2N1cnJlbnRJdGVtLmdldCgpKTsKKyAgICBpZiAoaXRlbXNB cmVDbG9uZXMobV9jdXJyZW50SXRlbS5nZXQoKSwgbV9wcm92aXNpb25hbEl0ZW0uZ2V0KCkpKSB7 CisgICAgICAgIEFTU0VSVChtX2ZyYW1lTG9hZENvbXBsZXRlKTsKKyAgICAgICAgc2F2ZURvY3Vt ZW50U3RhdGUoKTsKKyAgICAgICAgc2F2ZVNjcm9sbFBvc2l0aW9uQW5kVmlld1N0YXRlVG9JdGVt KG1fY3VycmVudEl0ZW0uZ2V0KCkpOwogCi0gICAgaWYgKEZyYW1lVmlldyogdmlldyA9IG1fZnJh bWUtPnZpZXcoKSkKLSAgICAgICAgdmlldy0+c2V0V2FzU2Nyb2xsZWRCeVVzZXIoZmFsc2UpOwor ICAgICAgICBpZiAoRnJhbWVWaWV3KiB2aWV3ID0gbV9mcmFtZS0+dmlldygpKQorICAgICAgICAg ICAgdmlldy0+c2V0V2FzU2Nyb2xsZWRCeVVzZXIoZmFsc2UpOwogCi0gICAgLy8gTm93IGNvbW1p dCB0aGUgcHJvdmlzaW9uYWwgaXRlbQotICAgIG1fZnJhbWVMb2FkQ29tcGxldGUgPSBmYWxzZTsK LSAgICBtX3ByZXZpb3VzSXRlbSA9IG1fY3VycmVudEl0ZW07Ci0gICAgbV9jdXJyZW50SXRlbSA9 IG1fcHJvdmlzaW9uYWxJdGVtOwotICAgIG1fcHJvdmlzaW9uYWxJdGVtID0gMDsKKyAgICAgICAg Ly8gTm93IGNvbW1pdCB0aGUgcHJvdmlzaW9uYWwgaXRlbQorICAgICAgICBtX2ZyYW1lTG9hZENv bXBsZXRlID0gZmFsc2U7CisgICAgICAgIG1fcHJldmlvdXNJdGVtID0gbV9jdXJyZW50SXRlbTsK KyAgICAgICAgbV9jdXJyZW50SXRlbSA9IG1fcHJvdmlzaW9uYWxJdGVtOworICAgICAgICBtX3By b3Zpc2lvbmFsSXRlbSA9IDA7CiAKLSAgICAvLyBSZXN0b3JlIGZvcm0gc3RhdGUgKHdvcmtzIGZy b20gY3VycmVudEl0ZW0pCi0gICAgcmVzdG9yZURvY3VtZW50U3RhdGUoKTsKKyAgICAgICAgLy8g UmVzdG9yZSBmb3JtIHN0YXRlICh3b3JrcyBmcm9tIGN1cnJlbnRJdGVtKQorICAgICAgICByZXN0 b3JlRG9jdW1lbnRTdGF0ZSgpOwogCi0gICAgLy8gUmVzdG9yZSB0aGUgc2Nyb2xsIHBvc2l0aW9u ICh3ZSBjaG9vc2UgdG8gZG8gdGhpcyByYXRoZXIgdGhhbiBnb2luZyBiYWNrIHRvIHRoZSBhbmNo b3IgcG9pbnQpCi0gICAgcmVzdG9yZVNjcm9sbFBvc2l0aW9uQW5kVmlld1N0YXRlKCk7CisgICAg ICAgIC8vIFJlc3RvcmUgdGhlIHNjcm9sbCBwb3NpdGlvbiAod2UgY2hvb3NlIHRvIGRvIHRoaXMg cmF0aGVyIHRoYW4gZ29pbmcgYmFjayB0byB0aGUgYW5jaG9yIHBvaW50KQorICAgICAgICByZXN0 b3JlU2Nyb2xsUG9zaXRpb25BbmRWaWV3U3RhdGUoKTsKKyAgICB9CiAKICAgICAvLyBJdGVyYXRl IG92ZXIgdGhlIHJlc3Qgb2YgdGhlIHRyZWUKICAgICBmb3IgKEZyYW1lKiBjaGlsZCA9IG1fZnJh bWUtPnRyZWUoKS0+Zmlyc3RDaGlsZCgpOyBjaGlsZDsgY2hpbGQgPSBjaGlsZC0+dHJlZSgpLT5u ZXh0U2libGluZygpKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDQzY2NmNjdmYzliMDE1MWMxMTcxMTM4NDQzM2E1MzU4MTE5 MWM3MjUuLmU1YTc4ZmFiYTU1MzU1NDdiMzdkZmYyZmM0YzRkNGE4ZTY1ZmZiMWUgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNCBAQAorMjAxMS0xMC0xOCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBw bGUuY29tPgorCisgICAgICAgIEFzc2VydGlvbiBmYWlsdXJlIHdoZW4gZ29pbmcgYmFjayBpbiBw YWdlIHdpdGggbmF2aWdhdGVkIHN1YmZyYW1lcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzAzODkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzg5ODg0 NDQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBm YXN0L2hpc3RvcnkvaGlzdG9yeS1iYWNrLXR3aWNlLXdpdGgtc3ViZnJhbWVzLWFzc2VydC1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvaGlzdG9yeS9oaXN0b3J5LWJhY2stdHdp Y2Utd2l0aC1zdWJmcmFtZXMtYXNzZXJ0Lmh0bWw6IEFkZGVkLgorCiAyMDExLTEwLTE4ICBDYXJ5 IENsYXJrICA8Y2FyeWNsYXJrQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmViYXNlbGluZSBtb3N0 IHJlbWFpbmluZyBJTUFHRSBkaWZmcyBmb3IgY2hyb21pdW0tbWFjIChTa2lhKQpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9oaXN0b3J5L2hpc3RvcnktYmFjay10d2ljZS13aXRoLXN1YmZy YW1lcy1hc3NlcnQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9oaXN0b3J5L2hpc3Rv cnktYmFjay10d2ljZS13aXRoLXN1YmZyYW1lcy1hc3NlcnQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLjJlYzk4NGZmMzg3NmQxOTg4MDVlZmM5MzFlMjYzOWMyNTVlOTJjNTAKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2hpc3RvcnkvaGlzdG9yeS1iYWNrLXR3aWNlLXdpdGgt c3ViZnJhbWVzLWFzc2VydC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwyIEBACitUaGlzIHRlc3Rz IHRoYXQgbmF2aWdhdGluZyB0d28gc3ViZnJhbWVzIGFuZCB0aGVuIGdvaW5nIGJhY2sgdXNpbmcg aGlzdG9yeS5nbygtMikgd29uJ3QgYXNzZXJ0LgorIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9oaXN0b3J5L2hpc3RvcnktYmFjay10d2ljZS13aXRoLXN1YmZyYW1lcy1hc3NlcnQuaHRt bCBiL0xheW91dFRlc3RzL2Zhc3QvaGlzdG9yeS9oaXN0b3J5LWJhY2stdHdpY2Utd2l0aC1zdWJm cmFtZXMtYXNzZXJ0Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNTJlZGM4Mzg2MjA0OGMwODExOTM3NjExZjRi ZGUxMWNkNzFkMjBjNAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvaGlzdG9y eS9oaXN0b3J5LWJhY2stdHdpY2Utd2l0aC1zdWJmcmFtZXMtYXNzZXJ0Lmh0bWwKQEAgLTAsMCAr MSwzOCBAQAorPCFET0NUWVBFIGh0bWw+Cis8c2NyaXB0PgoraWYgKGxheW91dFRlc3RDb250cm9s bGVyKSB7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgIGxheW91 dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKK30KKworZnVuY3Rpb24gcnVuVGVzdCgp IHsKKyAgICB2YXIgbG9hZENvdW50ID0gMjsKKyAgICB2YXIgZGlkR29CYWNrID0gZmFsc2U7CisK KyAgICB2YXIgZnJhbWUxID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2ZyYW1lMScpOworICAg IHZhciBmcmFtZTIgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZnJhbWUyJyk7CisgICAgZnJh bWUxLm9ubG9hZCA9IGZyYW1lMi5vbmxvYWQgPSBmdW5jdGlvbigpIHsKKyAgICAgICAgbG9hZENv dW50LS07CisgICAgICAgIGlmIChsb2FkQ291bnQpCisgICAgICAgICAgICByZXR1cm47CisKKyAg ICAgICAgaWYgKCFkaWRHb0JhY2spIHsKKyAgICAgICAgICAgIC8vIFdlJ3ZlIG5hdmlnYXRlZCBi b3RoIGZyYW1lcywgbm93IGdvIGJhY2sgMiBzdGVwcy4KKyAgICAgICAgICAgIGxvYWRDb3VudCA9 IDI7CisgICAgICAgICAgICBoaXN0b3J5LmdvKC0yKTsKKyAgICAgICAgICAgIGRpZEdvQmFjayA9 IHRydWU7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKyAgICAgICAgCisgICAgICAg IGlmIChsYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9s bGVyLm5vdGlmeURvbmUoKTsKKyAgICB9CisKKyAgICBmcmFtZTEuc3JjID0gZnJhbWUyLnNyYyA9 ICdkYXRhOnRleHQvaHRtbCxuYXZpZ2F0ZWQnOyAKK30KKzwvc2NyaXB0PgorPGJvZHkgb25sb2Fk PSJzZXRUaW1lb3V0KHJ1blRlc3QsIDApIj4KKzxkaXY+VGhpcyB0ZXN0cyB0aGF0IG5hdmlnYXRp bmcgdHdvIHN1YmZyYW1lcyBhbmQgdGhlbiBnb2luZyBiYWNrIHVzaW5nIGhpc3RvcnkuZ28oLTIp IHdvbid0IGFzc2VydC48L2Rpdj4KKzxpZnJhbWUgaWQ9J2ZyYW1lMScgc3JjPSdkYXRhOnRleHQv aHRtbCxmcmFtZTEnPjwvaWZyYW1lPgorPGlmcmFtZSBpZD0nZnJhbWUyJyBzcmM9J2RhdGE6dGV4 dC9odG1sLGZyYW1lMic+PC9pZnJhbWU+Cis8L2JvZHk+Cg==