70380 2011-10-18 16:14:06 -0700 Stop leaking internal names in WKView API header 2011-10-18 16:24:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam oldest_to_newest 486405 0 sam 2011-10-18 16:14:06 -0700 Stop leaking internal names in WKView API header 486406 1 111521 sam 2011-10-18 16:16:07 -0700 Created attachment 111521 Patch 486408 2 111521 andersca 2011-10-18 16:17:49 -0700 Comment on attachment 111521 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111521&action=review > Source/WebKit2/ChangeLog:9 > + WKView due to the 32 objective-c ABI, we must rename the existing variable unused. If This should say either "32-bit Objective-C ABI" or "fragile Objective-C ABI" > Source/WebKit2/ChangeLog:10 > + drop 32 bit support, we will be able to remove it. "32-bit" 486419 3 sam 2011-10-18 16:24:38 -0700 Committed r97811: <http://trac.webkit.org/changeset/97811> 111521 2011-10-18 16:16:07 -0700 2011-10-18 16:17:49 -0700 Patch bug-70380-20111018161606.patch text/plain 4171 sam SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3ODA3KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMTAtMTggIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBTdG9wIGxlYWtpbmcgaW50ZXJuYWwgbmFt ZXMgaW4gV0tWaWV3IEFQSSBoZWFkZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTcwMzgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTW92ZSBfZnJhbWVTaXplVXBkYXRlc0Rpc2FibGVkQ291bnQgdG8gV0tW aWV3RGF0YS4gU2luY2Ugd2UgY2Fubm90IGNoYW5nZSB0aGUgc2l6ZSBvZgorICAgICAgICBXS1Zp ZXcgZHVlIHRvIHRoZSAzMiBvYmplY3RpdmUtYyBBQkksIHdlIG11c3QgcmVuYW1lIHRoZSBleGlz dGluZyB2YXJpYWJsZSB1bnVzZWQuIElmCisgICAgICAgIGRyb3AgMzIgYml0IHN1cHBvcnQsIHdl IHdpbGwgYmUgYWJsZSB0byByZW1vdmUgaXQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21h Yy9XS1ZpZXcuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW06CisgICAg ICAgICgtW1dLVmlldyBkaXNhYmxlRnJhbWVTaXplVXBkYXRlc10pOgorICAgICAgICAoLVtXS1Zp ZXcgZW5hYmxlRnJhbWVTaXplVXBkYXRlc10pOgorICAgICAgICAoLVtXS1ZpZXcgZnJhbWVTaXpl VXBkYXRlc0Rpc2FibGVkXSk6CisgICAgICAgICogV2ViS2l0Mi54Y29kZXByb2ovcHJvamVjdC5w Ynhwcm9qOgorCiAyMDExLTEwLTE4ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgogCiAgICAgICAgIFtXSzJdIENyYXNoIGFmdGVyIHN0b3JpbmcgY3JlZGVudGlhbHMgaW4gS2V5 Y2hhaW4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5oCShy ZXZpc2lvbiA5Nzc5NCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmll dy5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw3ICszMSw3IEBACiBXS19FWFBPUlQKIEBpbnRlcmZh Y2UgV0tWaWV3IDogTlNWaWV3IDxOU1RleHRJbnB1dENsaWVudD4gewogICAgIFdLVmlld0RhdGEg Kl9kYXRhOwotICAgIHVuc2lnbmVkIF9mcmFtZVNpemVVcGRhdGVzRGlzYWJsZWRDb3VudDsKKyAg ICB1bnNpZ25lZCBfdW51c2VkOwogfQogCiAtIChpZClpbml0V2l0aEZyYW1lOihOU1JlY3QpZnJh bWUgY29udGV4dFJlZjooV0tDb250ZXh0UmVmKWNvbnRleHRSZWY7CkluZGV4OiBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCShyZXZpc2lvbiA5NzgwNikKKysrIFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkod29ya2luZyBjb3B5KQpA QCAtMTcwLDYgKzE3MCw4IEBAIEBpbnRlcmZhY2UgV0tWaWV3RGF0YSA6IE5TT2JqZWN0IHsKICAg ICBCT09MIF9pblNlY3VyZUlucHV0U3RhdGU7CiAKICAgICBOU1JlY3QgX3dpbmRvd0JvdHRvbUNv cm5lckludGVyc2VjdGlvblJlY3Q7CisgICAgCisgICAgdW5zaWduZWQgX2ZyYW1lU2l6ZVVwZGF0 ZXNEaXNhYmxlZENvdW50OwogfQogQGVuZAogCkBAIC0yNjQxLDIxICsyNjQzLDIxIEBAIC0gKHZv aWQpaGFuZGxlQ29ycmVjdGlvblBhbmVsUmVzdWx0OihOU1MKIAogLSAodm9pZClkaXNhYmxlRnJh bWVTaXplVXBkYXRlcwogewotICAgIF9mcmFtZVNpemVVcGRhdGVzRGlzYWJsZWRDb3VudCsrOwor ICAgIF9kYXRhLT5fZnJhbWVTaXplVXBkYXRlc0Rpc2FibGVkQ291bnQrKzsKIH0KIAogLSAodm9p ZCllbmFibGVGcmFtZVNpemVVcGRhdGVzCiB7Ci0gICAgaWYgKCFfZnJhbWVTaXplVXBkYXRlc0Rp c2FibGVkQ291bnQpCisgICAgaWYgKCFfZGF0YS0+X2ZyYW1lU2l6ZVVwZGF0ZXNEaXNhYmxlZENv dW50KQogICAgICAgICByZXR1cm47CiAgICAgCi0gICAgaWYgKCEoLS1fZnJhbWVTaXplVXBkYXRl c0Rpc2FibGVkQ291bnQpKQorICAgIGlmICghKC0tX2RhdGEtPl9mcmFtZVNpemVVcGRhdGVzRGlz YWJsZWRDb3VudCkpCiAgICAgICAgIFtzZWxmIF9zZXREcmF3aW5nQXJlYVNpemU6W3NlbGYgZnJh bWVdLnNpemVdOwogfQogCiAtIChCT09MKWZyYW1lU2l6ZVVwZGF0ZXNEaXNhYmxlZAogewotICAg IHJldHVybiBfZnJhbWVTaXplVXBkYXRlc0Rpc2FibGVkQ291bnQgPiAwOworICAgIHJldHVybiBf ZGF0YS0+X2ZyYW1lU2l6ZVVwZGF0ZXNEaXNhYmxlZENvdW50ID4gMDsKIH0KIAogLSAodm9pZClw ZXJmb3JtRGljdGlvbmFyeUxvb2t1cEF0Q3VycmVudE1vdXNlTG9jYXRpb24KSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL1dlYktpdDIueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvago9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9XZWJLaXQyLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oJKHJldmlz aW9uIDk3ODA0KQorKysgU291cmNlL1dlYktpdDIvV2ViS2l0Mi54Y29kZXByb2ovcHJvamVjdC5w Ynhwcm9qCSh3b3JraW5nIGNvcHkpCkBAIC0zMTk1LDcgKzMxOTUsNiBAQAogCQlCQ0NGMDg1QzEx M0YzQjc1MDBDNjUwQzUgLyogbWFjICovID0gewogCQkJaXNhID0gUEJYR3JvdXA7CiAJCQljaGls ZHJlbiA9ICgKLQkJCQlGNkQ2MzJCQTEzM0QxODFCMDA3NDNENzcgLyogV2ViQ29va2llTWFuYWdl clByb3h5TWFjLm1tICovLAogCQkJCTFBNjQyOTJDMTJERTVGOTgwMENBQUUyQyAvKiBCYWNraW5n U3RvcmVNYWMubW0gKi8sCiAJCQkJQjg3OEI2MTMxMzM0MjhEQzAwNjg4OEU5IC8qIENvcnJlY3Rp b25QYW5lbC5oICovLAogCQkJCUI4NzhCNjE0MTMzNDI4REMwMDY4ODhFOSAvKiBDb3JyZWN0aW9u UGFuZWwubW0gKi8sCkBAIC0zMjAzLDYgKzMyMDIsNyBAQAogCQkJCTFBMUM2NDg2MTFGNDE1Qjcw MDU1M0MxOSAvKiBXZWJDb250ZXh0TWFjLm1tICovLAogCQkJCTUxQUNCQjlFMTI3QThGMkMwMEQy MDNCOSAvKiBXZWJDb250ZXh0TWVudVByb3h5TWFjLmggKi8sCiAJCQkJNTFBQ0JCOUYxMjdBOEYy QzAwRDIwM0I5IC8qIFdlYkNvbnRleHRNZW51UHJveHlNYWMubW0gKi8sCisJCQkJRjZENjMyQkEx MzNEMTgxQjAwNzQzRDc3IC8qIFdlYkNvb2tpZU1hbmFnZXJQcm94eU1hYy5tbSAqLywKIAkJCQlD RENBODVERTEzMkFEMDUzMDBFOTYxREYgLyogV2ViRnVsbFNjcmVlbk1hbmFnZXJQcm94eU1hYy5t bSAqLywKIAkJCQkxQ0E4QjkzNTEyN0M3NzRFMDA1NzZDMkIgLyogV2ViSW5zcGVjdG9yUHJveHlN YWMubW0gKi8sCiAJCQkJQkM4NTdFODUxMkI3MUVCQjAwRURFQjJFIC8qIFdlYlBhZ2VQcm94eU1h Yy5tbSAqLywKQEAgLTMyMTAsOCArMzIxMCw4IEBACiAJCQkJQkM1NzUwOTYxMjY4RjNDNjAwNkYw RjEyIC8qIFdlYlBvcHVwTWVudVByb3h5TWFjLm1tICovLAogCQkJCUJDODRFQjE3MTJBNzEwMEMw MDgzRjJEQSAvKiBXZWJQcmVmZXJlbmNlc01hYy5tbSAqLywKIAkJCQk1MUQxMzA1NzEzODJGMTA1 MDAzNTFFREQgLyogV2ViUHJvY2Vzc1Byb3h5TWFjLm1tICovLAotCQkJCUNEQ0E4NUM2MTMyQUJB NEUwMEU5NjFERiAvKiBXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tICovLAogCQkJCUNE Q0E4NUM3MTMyQUJBNEUwMEU5NjFERiAvKiBXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLmgg Ki8sCisJCQkJQ0RDQTg1QzYxMzJBQkE0RTAwRTk2MURGIC8qIFdLRnVsbFNjcmVlbldpbmRvd0Nv bnRyb2xsZXIubW0gKi8sCiAJCQkpOwogCQkJcGF0aCA9IG1hYzsKIAkJCXNvdXJjZVRyZWUgPSAi PGdyb3VwPiI7Cg==