70376 2011-10-18 15:58:56 -0700 [WK2] Crash after storing credentials in Keychain 2011-10-18 16:14:05 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified OS X 10.6 RESOLVED FIXED InRadar P1 Normal --- 1 ap ap oldest_to_newest 486382 0 ap 2011-10-18 15:58:56 -0700 Steps to reproduce: 1. Open any site that uses HTTP credentials. 2. When asked to, enter the credentials. 3. Mark "Remember in Keychain" checkbox. 4. Press Enter. Results: credentials are stored, but Web process crashes. <rdar://problem/9647503> 486388 1 111516 ap 2011-10-18 16:03:18 -0700 Created attachment 111516 proposed fix 486404 2 ap 2011-10-18 16:14:05 -0700 Committed <http://trac.webkit.org/changeset/97807>. 111516 2011-10-18 16:03:18 -0700 2011-10-18 16:05:49 -0700 proposed fix KeychainItem.txt text/plain 2113 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3ODAxKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMTAtMTggIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl0gQ3Jhc2ggYWZ0ZXIg c3RvcmluZyBjcmVkZW50aWFscyBpbiBLZXljaGFpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzAzNzYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzk2 NDc1MDM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTaGFyZWQvbWFjL1NlY0tleWNoYWluSXRlbVJlc3BvbnNlRGF0YS5jcHA6CisgICAgICAgIChX ZWJLaXQ6OlNlY0tleWNoYWluSXRlbVJlc3BvbnNlRGF0YTo6ZW5jb2RlKToKKyAgICAgICAgKFdl YktpdDo6U2VjS2V5Y2hhaW5JdGVtUmVzcG9uc2VEYXRhOjpkZWNvZGUpOgorICAgICAgICBBY3R1 YWxseSBzZW5kIGtleWNoYWluIGl0ZW0gb3ZlciwgdG9vLiBJbiBzaGltU2VjS2V5Y2hhaW5JdGVt Q3JlYXRlRnJvbUNvbnRlbnQoKSwgd2UgYXJlCisgICAgICAgIGdvaW5nIHRvIHVzZSBpdCB0byBv dmVycmlkZSBTZWNLZXljaGFpbkl0ZW1DcmVhdGVGcm9tQ29udGVudCgpLCBhbmQgd2UgY2Fubm90 IHJldHVybiBub0VycgorICAgICAgICBmcm9tIHRoaXMgZnVuY3Rpb24gd2l0aG91dCByZXR1cm5p bmcgYSBub24tbnVsbCBrZXljaGFpbiBpdGVtLgorCiAyMDExLTEwLTE4ICBTYW0gV2VpbmlnICA8 c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTW92ZSBXS1ZpZXcgaGVscGVyIGZpbGVzIGludG8g YSBzdWItZ3JvdXAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvU2VjS2V5Y2hhaW5J dGVtUmVzcG9uc2VEYXRhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQv bWFjL1NlY0tleWNoYWluSXRlbVJlc3BvbnNlRGF0YS5jcHAJKHJldmlzaW9uIDk3Nzg1KQorKysg U291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9TZWNLZXljaGFpbkl0ZW1SZXNwb25zZURhdGEuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC03Miw2ICs3MiwxMCBAQCB2b2lkIFNlY0tleWNoYWluSXRlbVJl c3BvbnNlRGF0YTo6ZW5jb2RlCiAgICAgZW5jb2Rlci0+ZW5jb2RlQm9vbChtX2RhdGEuZ2V0KCkp OwogICAgIGlmIChtX2RhdGEpCiAgICAgICAgIENvcmVJUEM6OmVuY29kZShlbmNvZGVyLCBtX2Rh dGEuZ2V0KCkpOworCisgICAgZW5jb2Rlci0+ZW5jb2RlQm9vbChtX2tleWNoYWluSXRlbS5nZXQo KSk7CisgICAgaWYgKG1fa2V5Y2hhaW5JdGVtKQorICAgICAgICBDb3JlSVBDOjplbmNvZGUoZW5j b2RlciwgbV9rZXljaGFpbkl0ZW0uZ2V0KCkpOwogfQogCiBib29sIFNlY0tleWNoYWluSXRlbVJl c3BvbnNlRGF0YTo6ZGVjb2RlKENvcmVJUEM6OkFyZ3VtZW50RGVjb2RlciogZGVjb2RlciwgU2Vj S2V5Y2hhaW5JdGVtUmVzcG9uc2VEYXRhJiBzZWNLZXljaGFpbkl0ZW1SZXNwb25zZURhdGEpCkBA IC0xMDUsNiArMTA5LDEzIEBAIGJvb2wgU2VjS2V5Y2hhaW5JdGVtUmVzcG9uc2VEYXRhOjpkZWNv ZGUKICAgICBpZiAoZXhwZWN0RGF0YSAmJiAhQ29yZUlQQzo6ZGVjb2RlKGRlY29kZXIsIHNlY0tl eWNoYWluSXRlbVJlc3BvbnNlRGF0YS5tX2RhdGEpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAK KyAgICBib29sIGV4cGVjdEl0ZW07CisgICAgaWYgKCFkZWNvZGVyLT5kZWNvZGVCb29sKGV4cGVj dEl0ZW0pKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBpZiAoZXhwZWN0SXRlbSAmJiAh Q29yZUlQQzo6ZGVjb2RlKGRlY29kZXIsIHNlY0tleWNoYWluSXRlbVJlc3BvbnNlRGF0YS5tX2tl eWNoYWluSXRlbSkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIHJldHVybiB0cnVlOwog fQogCg==