70371 2011-10-18 15:02:40 -0700 DRT should always print a newline after #EOF 2011-10-19 12:13:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 56729 1 eric eric abarth dpranke oldest_to_newest 486333 0 eric 2011-10-18 15:02:40 -0700 DRT should always print a newline after #EOF 486340 1 111509 eric 2011-10-18 15:06:24 -0700 Created attachment 111509 Patch 486345 2 eric 2011-10-18 15:13:14 -0700 Important to let this land through the commit-queue to make sure I didn't screw anything up in my testing. 486350 3 dpranke 2011-10-18 15:18:49 -0700 this change looks fine. Note that we don't enforce that the #EOF start at the beginning of the line either (specifically, in the case of audio tests where the main output is binary data, not text). Does it make sense to change that as well? 486354 4 eric 2011-10-18 15:30:15 -0700 The code seems mixed about whether #EOF is on its own line or not. Since adding a \n before #EOF might add a \n to some test results, I decided to avoid it for now. You're right that it's possible we're silently ignoring some content in ORWT due to lack of requiring #EOF to be on a line by itself. 486355 5 111509 eric 2011-10-18 15:32:00 -0700 Comment on attachment 111509 Patch re-testing ORWT, I'm seeing failure. Checking... 486910 6 eric 2011-10-19 12:13:20 -0700 This is invalid. I was just confused. puts always prints a newline after the string. This change caused us to print double-newlines. The opposite change is probably correct to remove the \n from all the places where we currently have "#EOF\n". 111509 2011-10-18 15:06:24 -0700 2011-10-18 15:32:00 -0700 Patch bug-70371-20111018150623.patch text/plain 6634 eric U3VidmVyc2lvbiBSZXZpc2lvbjogOTc3OTAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2YTU2NDM2MmM3ZWViMjI0NzI0OTM4NzJjNjFiYWU4NTMz YzNmM2RlLi41YmQ1YjFkN2ZmZGYyNTZlZjMyZDUyYjYzN2M3NjlhNTAxYWY1ZWY2IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzUg QEAKKzIwMTEtMTAtMTggIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAg IERSVCBzaG91bGQgYWx3YXlzIHByaW50IGEgbmV3bGluZSBhZnRlciAjRU9GCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDM3MQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9SV1QgZGlkbid0IG5vdGljZSBp ZiBEUlQgaW1wbGVtZW50YXRpb25zIHByaW50ZWQgXG4gYWZ0ZXIgI0VPRgorICAgICAgICBvciBu b3QgYXMgaXQgd2FzIG1hdGNoaW5nIGFueSBsaW5lIGNvbnRhaW5pbmcgI0VPRi4KKyAgICAgICAg TlJXVCBpcyBhIGJpdCBtb3JlIGNhcmVmdWwsIGJ1dCBzdGlsbCB1c2VzIHJzdHJpcCgpIGluIG1v c3QgcGxhY2VzCisgICAgICAgIHRvIHJlbW92ZSB0aGUgdHJhaWxpbmcgbmV3bGluZSBiZWZvcmUg Y2hlY2tpbmcgYWdhaW5zdCAjRU9GLgorICAgICAgICBCb3RoIGltcGxlbWVudGF0aW9ucyBoYXZl IGNvbW1lbnRzIHdoaWNoIGRvY3VtZW50IHRoZSBhc3N1bXB0aW9uCisgICAgICAgIHRoYXQgdGhl ICNFT0YgaGFzIGEgdHJhaWxpbmcgbmV3bGluZSAoZXZlbiB0aG91Z2ggaXQgZG9lc24ndCBhbHdh eXMpLgorICAgICAgICBTbyB0aGlzIGNoYW5nZSBqdXN0IG1ha2VzIHVzIGNvbnNpc3RlbnQuCisK KyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9EdW1wUmVuZGVyVHJlZS5jcHA6Cisg ICAgICAgIChtYWluKToKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRy ZWUuY3BwOgorICAgICAgICAoc2VuZFBpeGVsUmVzdWx0c0VPRik6CisgICAgICAgIChkdW1wKToK KyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAg ICAoZHVtcCk6CisgICAgICAgIChzZW5kUGl4ZWxSZXN1bHRzRU9GKToKKyAgICAgICAgKiBEdW1w UmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW06CisgICAgICAgIChkdW1wKToKKyAgICAg ICAgKiBEdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkR1bXBSZW5kZXJUcmVlOjpkdW1wKToKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS93 aW4vRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAoZHVtcCk6CisgICAgICAgICogRHVtcFJl bmRlclRyZWUvd3gvRHVtcFJlbmRlclRyZWVXeC5jcHA6CisgICAgICAgIChkdW1wKToKKwogMjAx MS0xMC0xOCAgRGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFNwbGl0IFRlc3RFeHBlY3RhdGlvbnNFZGl0b3IgaW50byBpdHMgb3duIGZpbGUuCmRpZmYg LS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9EdW1wUmVuZGVyVHJlZS5jcHAg Yi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9EdW1wUmVuZGVyVHJlZS5jcHAKaW5kZXgg NTk2ODYxNzM4MzAyNDk0ZjNlNTM1NzFiMjE0MmIyZWQxNWQxZjM2NC4uNWRmZTkzZDI3YzA3ZGE5 NDU2ZTJhMGEyOWJhYmYxODk5YjA1YmU5MCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRy ZWUvY2hyb21pdW0vRHVtcFJlbmRlclRyZWUuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL0R1bXBSZW5kZXJUcmVlLmNwcApAQCAtMjYxLDcgKzI2MSw3IEBAIGludCBtYWlu KGludCBhcmdjLCBjaGFyKiBhcmd2W10pCiAgICAgICAgICAgICAgICAgcnVuVGVzdChzaGVsbCwg cGFyYW1zLCB0ZXN0U3RyaW5nLCB0ZXN0U2hlbGxNb2RlKTsKICAgICAgICAgICAgIH0KICAgICAg ICAgfSBlbHNlIGlmICghdGVzdHMuc2l6ZSgpKQotICAgICAgICAgICAgcHV0cygiI0VPRiIpOwor ICAgICAgICAgICAgcHV0cygiI0VPRlxuIik7CiAgICAgICAgIGVsc2UgewogICAgICAgICAgICAg cGFyYW1zLnByaW50U2VwYXJhdG9ycyA9IHRlc3RzLnNpemUoKSA+IDE7CiAgICAgICAgICAgICBm b3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgdGVzdHMuc2l6ZSgpOyBpKyspCmRpZmYgLS1naXQgYS9U b29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWUuY3BwIGIvVG9vbHMvRHVtcFJl bmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlLmNwcAppbmRleCBiYjhmN2QyZDdhOGQyOTkzODM5 NjQyZmFmNWQyMzQzNTE3YjBkYWYzLi4wNTVhNWUwMzdiNTIwYmY2OTc0OTc0OWI4MDE5NjE3Zjlh Yjc5MGM5IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRy ZWUuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZS5jcHAK QEAgLTExNSw3ICsxMTUsNyBAQCBzdGF0aWMgYm9vbCBzaG91bGREdW1wQXNUZXh0KGNvbnN0IFN0 cmluZyYgcGF0aE9yVVJMKQogCiBzdGF0aWMgdm9pZCBzZW5kUGl4ZWxSZXN1bHRzRU9GKCkKIHsK LSAgICBwdXRzKCIjRU9GIik7CisgICAgcHV0cygiI0VPRlxuIik7CiAgICAgZmZsdXNoKHN0ZG91 dCk7CiAgICAgZmZsdXNoKHN0ZGVycik7CiB9CkBAIC0zNTgsNyArMzU4LDcgQEAgdm9pZCBkdW1w KCkKICAgICAgICAgICAgIGR1bXBCYWNrRm9yd2FyZExpc3RGb3JXZWJWaWV3cygpOwogCiAgICAg ICAgIGlmIChwcmludFNlcGFyYXRvcnMpIHsKLSAgICAgICAgICAgIHB1dHMoIiNFT0YiKTsKKyAg ICAgICAgICAgIHB1dHMoIiNFT0ZcbiIpOwogICAgICAgICAgICAgZnB1dHMoIiNFT0ZcbiIsIHN0 ZGVycik7CiAgICAgICAgICAgICBmZmx1c2goc3Rkb3V0KTsKICAgICAgICAgICAgIGZmbHVzaChz dGRlcnIpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJU cmVlLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKaW5k ZXggNjM0ZTJjNzM0YTM5ZGI0MTBjZGNjYzA3Zjc3ZDZhMTczYTM2NDQwNy4uM2I4Y2M4MDY5ODU5 MWYzOTg5MmM4ZjNhMTQ0MDUxOTRiNzdjOTcxOCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRl clRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9n dGsvRHVtcFJlbmRlclRyZWUuY3BwCkBAIC01NzcsNyArNTc3LDcgQEAgdm9pZCBkdW1wKCkKICAg ICAgICAgfQogCiAgICAgICAgIGlmIChwcmludFNlcGFyYXRvcnMpIHsKLSAgICAgICAgICAgIHB1 dHMoIiNFT0YiKTsgLy8gdGVybWluYXRlIHRoZSBjb250ZW50IGJsb2NrCisgICAgICAgICAgICBw dXRzKCIjRU9GXG4iKTsgLy8gdGVybWluYXRlIHRoZSBjb250ZW50IGJsb2NrCiAgICAgICAgICAg ICBmcHV0cygiI0VPRlxuIiwgc3RkZXJyKTsKICAgICAgICAgICAgIGZmbHVzaChzdGRvdXQpOwog ICAgICAgICAgICAgZmZsdXNoKHN0ZGVycik7CkBAIC02MzUsNyArNjM1LDcgQEAgc3RhdGljIHZv aWQgc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRTdGF0ZVZhbHVlc0ZvclRlc3RpbmcoKQogCiBzdGF0 aWMgdm9pZCBzZW5kUGl4ZWxSZXN1bHRzRU9GKCkKIHsKLSAgICBwdXRzKCIjRU9GIik7CisgICAg cHV0cygiI0VPRlxuIik7CiAKICAgICBmZmx1c2goc3Rkb3V0KTsKICAgICBmZmx1c2goc3RkZXJy KTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5t bSBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbQppbmRleCA1ZTc2 NDk1ZWY0ZjBkN2RhN2UyZjA4NmI2YWMzMGM2OTUwY2E3ODAzLi4zMDVhOWZiZTQ1NDMxMDJiNDZl NWE4YWM2M2MzMmVjYmQ4NTZkNDM4IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9t YWMvRHVtcFJlbmRlclRyZWUubW0KKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBS ZW5kZXJUcmVlLm1tCkBAIC0xMTAyLDcgKzExMDIsNyBAQCB2b2lkIGR1bXAoKQogICAgICAgICBp bnZhbGlkYXRlQW55UHJldmlvdXNXYWl0VG9EdW1wV2F0Y2hkb2coKTsKIAogICAgICAgICBpZiAo cHJpbnRTZXBhcmF0b3JzKSB7Ci0gICAgICAgICAgICBwdXRzKCIjRU9GIik7ICAgICAgIC8vIHRl cm1pbmF0ZSB0aGUgY29udGVudCBibG9jaworICAgICAgICAgICAgcHV0cygiI0VPRlxuIik7IC8v IHRlcm1pbmF0ZSB0aGUgY29udGVudCBibG9jawogICAgICAgICAgICAgZnB1dHMoIiNFT0ZcbiIs IHN0ZGVycik7CiAgICAgICAgIH0gICAgICAgICAgICAKICAgICB9CkBAIC0xMTExLDcgKzExMTEs NyBAQCB2b2lkIGR1bXAoKQogICAgICAgICAvLyBGSVhNRTogd2hlbiBpc1ByaW50aW5nIGlzIHNl dCwgZHVtcCB0aGUgaW1hZ2Ugd2l0aCBwYWdlIHNlcGFyYXRvcnMuCiAgICAgICAgIGR1bXBXZWJW aWV3QXNQaXhlbHNBbmRDb21wYXJlV2l0aEV4cGVjdGVkKGdMYXlvdXRUZXN0Q29udHJvbGxlci0+ ZXhwZWN0ZWRQaXhlbEhhc2goKSk7CiAKLSAgICBwdXRzKCIjRU9GIik7ICAgLy8gdGVybWluYXRl IHRoZSAocG9zc2libHkgZW1wdHkpIHBpeGVscyBibG9jaworICAgIHB1dHMoIiNFT0ZcbiIpOyAv LyB0ZXJtaW5hdGUgdGhlIChwb3NzaWJseSBlbXB0eSkgcGl4ZWxzIGJsb2NrCiAKICAgICBmZmx1 c2goc3Rkb3V0KTsKICAgICBmZmx1c2goc3RkZXJyKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUv cXQvRHVtcFJlbmRlclRyZWVRdC5jcHAKaW5kZXggY2E3NDNhZTJlYTdiZWQ2NzQwZmJkYzA0NTI3 MGFmZDY5YWZhZjc3ZC4uYjgxY2QzNTI0ZDM0MGUzZWM1NGQ3ZjI4NjQ3OWJhYzIzNjUzYWZhNCAx MDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHAK KysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHAKQEAgLTEw MDcsNyArMTAwNyw3IEBAIHZvaWQgRHVtcFJlbmRlclRyZWU6OmR1bXAoKQogICAgICAgICBmZmx1 c2goc3Rkb3V0KTsKICAgICB9CiAKLSAgICBwdXRzKCIjRU9GIik7ICAgLy8gdGVybWluYXRlIHRo ZSAocG9zc2libHkgZW1wdHkpIHBpeGVscyBibG9jaworICAgIHB1dHMoIiNFT0ZcbiIpOyAvLyB0 ZXJtaW5hdGUgdGhlIChwb3NzaWJseSBlbXB0eSkgcGl4ZWxzIGJsb2NrCiAKICAgICBmZmx1c2go c3Rkb3V0KTsKICAgICBmZmx1c2goc3RkZXJyKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS93aW4v RHVtcFJlbmRlclRyZWUuY3BwCmluZGV4IDliZTE5NzU0YmJhZGQ5MDI0ZTFjM2IwNDM1Y2UxZDg2 OTNmOTZkMjMuLjY3ZjJmMDU5YWYzYWYwMTE0MzQ0M2RkNDM0Mzc0ZTViNjkwNzhmYTQgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHAKKysrIGIv VG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcApAQCAtNzY2LDcgKzc2 Niw3IEBAIHZvaWQgZHVtcCgpCiAgICAgfQogCiAgICAgaWYgKHByaW50U2VwYXJhdG9ycykgewot ICAgICAgICBwdXRzKCIjRU9GIik7ICAgLy8gdGVybWluYXRlIHRoZSBjb250ZW50IGJsb2NrCisg ICAgICAgIHB1dHMoIiNFT0ZcbiIpOyAvLyB0ZXJtaW5hdGUgdGhlIGNvbnRlbnQgYmxvY2sKICAg ICAgICAgZnB1dHMoIiNFT0ZcbiIsIHN0ZGVycik7CiAgICAgICAgIGZmbHVzaChzdGRvdXQpOwog ICAgICAgICBmZmx1c2goc3RkZXJyKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L3d4L0R1bXBSZW5kZXJUcmVlV3guY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvd3gvRHVtcFJl bmRlclRyZWVXeC5jcHAKaW5kZXggNzE0MmFmMjM3NGFmODczY2EyZTljOTU0MGIxMWZmOWY4YzM0 Y2VlNy4uNmRlMThmZDE1NzBjZWM5MDlhZjMwMGIwNzY1MTg2NzZmMzE0ODBiNSAxMDA2NDQKLS0t IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvd3gvRHVtcFJlbmRlclRyZWVXeC5jcHAKKysrIGIvVG9v bHMvRHVtcFJlbmRlclRyZWUvd3gvRHVtcFJlbmRlclRyZWVXeC5jcHAKQEAgLTE5NCw3ICsxOTQs NyBAQCB2b2lkIGR1bXAoKQogICAgICAgICB9CiAKICAgICAgICAgaWYgKHByaW50U2VwYXJhdG9y cykgewotICAgICAgICAgICAgcHV0cygiI0VPRiIpOworICAgICAgICAgICAgcHV0cygiI0VPRlxu Iik7CiAgICAgICAgICAgICBmcHV0cygiI0VPRlxuIiwgc3RkZXJyKTsKICAgICAgICAgICAgIGZm bHVzaChzdGRvdXQpOwogICAgICAgICAgICAgZmZsdXNoKHN0ZGVycik7CkBAIC0yMDksNyArMjA5 LDcgQEAgdm9pZCBkdW1wKCkKICAgICAgICAgZmZsdXNoKHN0ZG91dCk7CiAgICAgfQogCi0gICAg cHV0cygiI0VPRiIpOworICAgIHB1dHMoIiNFT0ZcbiIpOwogICAgIGZmbHVzaChzdGRvdXQpOwog ICAgIGZmbHVzaChzdGRlcnIpOwogCg==