70345 2011-10-18 11:47:41 -0700 Add WebKit API to hide the definition window 2011-10-18 16:08:19 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Mac Unspecified RESOLVED FIXED P2 Normal --- 70363 70366 1 dkaleta dkaleta darin kdecker sam oldest_to_newest 486201 0 dkaleta 2011-10-18 11:47:41 -0700 Add WebKit API to hide the definition window. 486217 1 111478 dkaleta 2011-10-18 12:18:06 -0700 Created attachment 111478 patch 486287 2 kdecker 2011-10-18 13:50:14 -0700 Committed revision 97788. 486375 3 dkaleta 2011-10-18 15:54:53 -0700 Need to fix SL build. 486376 4 111515 dkaleta 2011-10-18 15:55:57 -0700 Created attachment 111515 patch that doesn't break SL build 486379 5 111515 darin 2011-10-18 15:57:16 -0700 Comment on attachment 111515 patch that doesn't break SL build I might put the #ifndef inside the method and make it harmless but pointless to call it on SnowLeopard, but this is OK. 486381 6 111515 sam 2011-10-18 15:58:56 -0700 Comment on attachment 111515 patch that doesn't break SL build View in context: https://bugs.webkit.org/attachment.cgi?id=111515&action=review > Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h:38 > +#if !defined(BUILDING_ON_SNOW_LEOPARD) I don't think you can do #if !defined(BUILDING_ON_SNOW_LEOPARD) in a header. Reversing drain's r+. You can just put the #if !defined(BUILDING_ON_SNOW_LEOPARD) in the implementation. 486383 7 darin 2011-10-18 15:59:19 -0700 Going down the reversing drain! 486389 8 111517 dkaleta 2011-10-18 16:03:36 -0700 Created attachment 111517 yet another patch 486393 9 111517 sam 2011-10-18 16:04:21 -0700 Comment on attachment 111517 yet another patch Better, I will test and land. 486399 10 sam 2011-10-18 16:08:19 -0700 Landed in 97806. 111478 2011-10-18 12:18:06 -0700 2011-10-18 15:59:27 -0700 patch textmate stdin iWy8SM.txt text/plain 1757 dkaleta SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3NzgwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMTAtMTggIERhbWlhbiBL YWxldGEgIDxka2FsZXRhQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgV2ViS2l0IEFQSSB0byBo aWRlIHRoZSBkZWZpbml0aW9uIHdpbmRvdworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzAzNDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbToKKyAgICAgICAg KC1bV0tWaWV3IGhpZGVXb3JkRGVmaW5pdGlvbldpbmRvd10pOiBIaWRlcyB0aGUgZGVmaW5pdGlv biB3aW5kb3cuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3UHJpdmF0ZS5oOgor CiAyMDExLTEwLTE4ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAg QWx3YXlzIGVuYWJsZSBFTkFCTEUoWFBBVEgpCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL21hYy9XS1ZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCShyZXZpc2lvbiA5Nzc2MCkKKysrIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjY1Myw2ICsy NjUzLDExIEBAIC0gKHZvaWQpcGVyZm9ybURpY3Rpb25hcnlMb29rdXBBdEN1cnJlbnQKICAgICBf ZGF0YS0+X3BhZ2UtPnBlcmZvcm1EaWN0aW9uYXJ5TG9va3VwQXRMb2NhdGlvbihGbG9hdFBvaW50 KHRoZVBvaW50LngsIHRoZVBvaW50LnkpKTsKIH0KIAorLSAodm9pZCloaWRlV29yZERlZmluaXRp b25XaW5kb3cKK3sKKyAgICBXS0hpZGVXb3JkRGVmaW5pdGlvbldpbmRvdygpOworfQorCiAtIChO U0ludGVnZXIpc3BlbGxDaGVja2VyRG9jdW1lbnRUYWcKIHsKICAgICBpZiAoIV9kYXRhLT5faGFz U3BlbGxDaGVja2VyRG9jdW1lbnRUYWcpIHsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvbWFjL1dLVmlld1ByaXZhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL21hYy9XS1ZpZXdQcml2YXRlLmgJKHJldmlzaW9uIDk3NzYwKQorKysgU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3UHJpdmF0ZS5oCSh3b3JraW5nIGNv cHkpCkBAIC0zNCw2ICszNCw3IEBAIEBpbnRlcmZhY2UgV0tWaWV3IChQcml2YXRlKQogLSAoQk9P TClmcmFtZVNpemVVcGRhdGVzRGlzYWJsZWQ7CiAKIC0gKHZvaWQpcGVyZm9ybURpY3Rpb25hcnlM b29rdXBBdEN1cnJlbnRNb3VzZUxvY2F0aW9uOworLSAodm9pZCloaWRlV29yZERlZmluaXRpb25X aW5kb3c7CiAKIC0gKE5TSW50ZWdlcilzcGVsbENoZWNrZXJEb2N1bWVudFRhZzsKIC0gKHZvaWQp aGFuZGxlQ29ycmVjdGlvblBhbmVsUmVzdWx0OihOU1N0cmluZyopcmVzdWx0Owo= 111515 2011-10-18 15:55:57 -0700 2011-10-18 16:03:36 -0700 patch that doesn't break SL build textmate stdin ag3UXf.txt text/plain 1838 dkaleta SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3Nzk5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMTAtMTggIERhbWlhbiBL YWxldGEgIDxka2FsZXRhQGFwcGxlLmNvbT4KKworICAgICAgICBUaGlzIHJldmlzZWQgZml4IGRv ZXNuJ3QgYnJlYWsgU0wgYnVpbGQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD03MDM0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tOgorICAgICAgICAoK1tX S1ZpZXcgaGlkZVdvcmREZWZpbml0aW9uV2luZG93XSk6IEhpZGVzIHRoZSBkZWZpbml0aW9uIHdp bmRvdy4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXdQcml2YXRlLmg6CisKIDIw MTEtMTAtMTggIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI5Nzc4OC4KSW5kZXg6IFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHJldmlzaW9uIDk3Nzk2KQorKysgU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBA IC0yNjUzLDYgKzI2NTMsMTMgQEAgLSAodm9pZClwZXJmb3JtRGljdGlvbmFyeUxvb2t1cEF0Q3Vy cmVudAogICAgIF9kYXRhLT5fcGFnZS0+cGVyZm9ybURpY3Rpb25hcnlMb29rdXBBdExvY2F0aW9u KEZsb2F0UG9pbnQodGhlUG9pbnQueCwgdGhlUG9pbnQueSkpOwogfQogCisjaWYgIWRlZmluZWQo QlVJTERJTkdfT05fU05PV19MRU9QQVJEKQorKyAodm9pZCloaWRlV29yZERlZmluaXRpb25XaW5k b3cKK3sKKyAgICBXS0hpZGVXb3JkRGVmaW5pdGlvbldpbmRvdygpOworfQorI2VuZGlmCisKIC0g KE5TSW50ZWdlcilzcGVsbENoZWNrZXJEb2N1bWVudFRhZwogewogICAgIGlmICghX2RhdGEtPl9o YXNTcGVsbENoZWNrZXJEb2N1bWVudFRhZykgewpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9tYWMvV0tWaWV3UHJpdmF0ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlld1ByaXZhdGUuaAkocmV2aXNpb24gOTc3OTYpCisrKyBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXdQcml2YXRlLmgJKHdvcmtpbmcg Y29weSkKQEAgLTM1LDYgKzM1LDEwIEBAIEBpbnRlcmZhY2UgV0tWaWV3IChQcml2YXRlKQogCiAt ICh2b2lkKXBlcmZvcm1EaWN0aW9uYXJ5TG9va3VwQXRDdXJyZW50TW91c2VMb2NhdGlvbjsKIAor I2lmICFkZWZpbmVkKEJVSUxESU5HX09OX1NOT1dfTEVPUEFSRCkKKysgKHZvaWQpaGlkZVdvcmRE ZWZpbml0aW9uV2luZG93OworI2VuZGlmCisKIC0gKE5TSW50ZWdlcilzcGVsbENoZWNrZXJEb2N1 bWVudFRhZzsKIC0gKHZvaWQpaGFuZGxlQ29ycmVjdGlvblBhbmVsUmVzdWx0OihOU1N0cmluZyop cmVzdWx0OwogQGVuZAo= 111517 2011-10-18 16:03:36 -0700 2011-10-18 16:04:21 -0700 yet another patch textmate stdin aVtcgi.txt text/plain 1816 dkaleta SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3Nzk5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMTAtMTggIERhbWlhbiBL YWxldGEgIDxka2FsZXRhQGFwcGxlLmNvbT4KKworICAgICAgICBUaGlzIHJldmlzZWQgZml4IGRv ZXNuJ3QgYnJlYWsgU0wgYnVpbGQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD03MDM0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tOgorICAgICAgICAoK1tX S1ZpZXcgaGlkZVdvcmREZWZpbml0aW9uV2luZG93XSk6IEhpZGVzIHRoZSBkZWZpbml0aW9uIHdp bmRvdy4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXdQcml2YXRlLmg6CisKIDIw MTEtMTAtMTggIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI5Nzc4OC4KSW5kZXg6IFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHJldmlzaW9uIDk3Nzk2KQorKysgU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBA IC0yNjUzLDYgKzI2NTMsMTMgQEAgLSAodm9pZClwZXJmb3JtRGljdGlvbmFyeUxvb2t1cEF0Q3Vy cmVudAogICAgIF9kYXRhLT5fcGFnZS0+cGVyZm9ybURpY3Rpb25hcnlMb29rdXBBdExvY2F0aW9u KEZsb2F0UG9pbnQodGhlUG9pbnQueCwgdGhlUG9pbnQueSkpOwogfQogCisrICh2b2lkKWhpZGVX b3JkRGVmaW5pdGlvbldpbmRvdworeworI2lmICFkZWZpbmVkKEJVSUxESU5HX09OX1NOT1dfTEVP UEFSRCkKKyAgICBXS0hpZGVXb3JkRGVmaW5pdGlvbldpbmRvdygpOworI2VuZGlmCit9CisKIC0g KE5TSW50ZWdlcilzcGVsbENoZWNrZXJEb2N1bWVudFRhZwogewogICAgIGlmICghX2RhdGEtPl9o YXNTcGVsbENoZWNrZXJEb2N1bWVudFRhZykgewpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9tYWMvV0tWaWV3UHJpdmF0ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlld1ByaXZhdGUuaAkocmV2aXNpb24gOTc3OTYpCisrKyBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXdQcml2YXRlLmgJKHdvcmtpbmcg Y29weSkKQEAgLTM0LDYgKzM0LDcgQEAgQGludGVyZmFjZSBXS1ZpZXcgKFByaXZhdGUpCiAtIChC T09MKWZyYW1lU2l6ZVVwZGF0ZXNEaXNhYmxlZDsKIAogLSAodm9pZClwZXJmb3JtRGljdGlvbmFy eUxvb2t1cEF0Q3VycmVudE1vdXNlTG9jYXRpb247CisrICh2b2lkKWhpZGVXb3JkRGVmaW5pdGlv bldpbmRvdzsKIAogLSAoTlNJbnRlZ2VyKXNwZWxsQ2hlY2tlckRvY3VtZW50VGFnOwogLSAodm9p ZCloYW5kbGVDb3JyZWN0aW9uUGFuZWxSZXN1bHQ6KE5TU3RyaW5nKilyZXN1bHQ7Cg==