70340 2011-10-18 10:41:57 -0700 Crash in WebProcess at com.apple.AppKit: -[NSFilePromiseDragSource draggedImage:endedAt:operation:] + 101 2011-10-18 16:18:02 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac OS X 10.7 RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica darin mitz oldest_to_newest 486159 0 enrica 2011-10-18 10:41:57 -0700 AppKit is not retaining the dragging source. This seems to lead to crashes under some unknown circumstances. 486164 1 111468 enrica 2011-10-18 10:51:43 -0700 Created attachment 111468 patch 486196 2 111468 darin 2011-10-18 11:36:16 -0700 Comment on attachment 111468 patch OK, lets give this a try. 486205 3 111468 mitz 2011-10-18 11:50:37 -0700 Comment on attachment 111468 patch View in context: https://bugs.webkit.org/attachment.cgi?id=111468&action=review > Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:61 > @interface NSFilePromiseDragSource : NSObject > { > + id _dragSource; Must we use this extra knowledge about NSFilePromise’s ivar layout (and assign to this ivar)? Couldn’t we have added this as an ivar to WKPasteboardFilePromiseOwner? Perhaps this doesn’t matter in the Objective-C runtime used for WebKit2? 486210 4 darin 2011-10-18 12:03:16 -0700 (In reply to comment #3) > Must we use this extra knowledge about NSFilePromise’s ivar layout (and assign to this ivar)? No, we don’t have to. > Couldn’t we have added this as an ivar to WKPasteboardFilePromiseOwner? Yes, we could have done that instead. Enrica and I discussed that option. > Perhaps this doesn’t matter in the Objective-C runtime used for WebKit2? That doesn’t sound right to me. I’m not even sure how that would work. 486410 5 enrica 2011-10-18 16:18:02 -0700 Committed revision 97808. 111468 2011-10-18 10:51:43 -0700 2011-10-18 11:50:37 -0700 patch bug9548174.txt text/plain 2415 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3Nzc0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMTAtMTggIEVucmljYSBD YXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCBpbiBXZWJQcm9jZXNz IGF0IGNvbS5hcHBsZS5BcHBLaXQ6IC1bTlNGaWxlUHJvbWlzZURyYWdTb3VyY2UgZHJhZ2dlZElt YWdlOmVuZGVkQXQ6b3BlcmF0aW9uOl0gKyAxMDEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTcwMzQwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85NTQ4 MTc0PgorICAgICAgICAKKyAgICAgICAgV2UgaGF2ZSBzZWVuIGEgbnVtYmVyIG9mIGNyYXNoIHJl cG9ydHMgZm9yIHRoaXMgaXNzdWUgdGhhdCBzZWVtIHRvIG9jY3VyciB3aGVuCisgICAgICAgIHRo ZSB1c2VyIGRyYWdzIGFuIGltYWdlIGZyb20gYSB3ZWIgcGFnZSBvbnRvIHRoZSBkZXNrdG9wLgor ICAgICAgICBXZSBoYXZlIG5vdCBiZWVuIGFibGUgdG8gcmVwcm9kdWNlIHRoaXMgY3Jhc2gsIHRo ZXJlZm9yZSB0aGlzIGlzIGEgc3BlY3VsYXRpdmUgZml4LAorICAgICAgICBidXQgdGhlIHRoZW9y eSBpcyB0aGF0IHRoZSBkcmFnZ2luZyBzb3VyY2UgaGFzIGJlZW4gYWxyZWFkeSByZWxlYXNlZCB3 aGVuIGRyYWdnZWRJbWFnZQorICAgICAgICBpcyBjYWxsZWQuCisgICAgICAgIFRoaXMgcGF0Y2gg YXR0ZW1wdHMgYSBmaXggZm9yIHRoZSBwcm9ibGVtIGJ5IHJldGFpbmluZyB0aGUgZHJhZ2dpbmcg c291cmNlIHdoZW4KKyAgICAgICAgTlNGaWxlUHJvbWlzZURyYWdTb3VyY2UgaXMgY3JlYXRlZC4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlBy b2Nlc3MvV2ViQ29yZVN1cHBvcnQvbWFjL1dlYkRyYWdDbGllbnRNYWMubW06CisgICAgICAgICgt W1dLUGFzdGVib2FyZEZpbGVQcm9taXNlT3duZXIgaW5pdFdpdGhTb3VyY2U6XSk6CisgICAgICAg ICgtW1dLUGFzdGVib2FyZEZpbGVQcm9taXNlT3duZXIgZGVhbGxvY10pOgorCiAyMDExLTEwLTE4 ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWx3YXlzIGVuYWJs ZSBFTkFCTEUoWFBBVEgpCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVT dXBwb3J0L21hYy9XZWJEcmFnQ2xpZW50TWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvbWFjL1dlYkRyYWdDbGllbnRNYWMubW0JKHJl dmlzaW9uIDk3NzY1KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9y dC9tYWMvV2ViRHJhZ0NsaWVudE1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtNTgsNiArNTgsNyBA QCB1c2luZyBuYW1lc3BhY2UgV2ViS2l0OwogLy8gQ3JlYXRlIGl0IGV4cGxpY2l0bHkgYmVjYXVz ZSBkcmFnSW1hZ2UgaXMgY2FsbGVkIGluIHRoZSBVSSBwcm9jZXNzLgogQGludGVyZmFjZSBOU0Zp bGVQcm9taXNlRHJhZ1NvdXJjZSA6IE5TT2JqZWN0CiB7CisgICAgaWQgX2RyYWdTb3VyY2U7CiAg ICAgY2hhciBfdW5rbm93bkZpZWxkc1syNTZdOwogfQogLSAoaWQpaW5pdFdpdGhTb3VyY2U6KGlk KWRyYWdTb3VyY2U7CkBAIC0xODksNiArMTkwLDIxIEBAIHZvaWQgV2ViRHJhZ0NsaWVudDo6ZHJh Z0VuZGVkKCkKIAogQGltcGxlbWVudGF0aW9uIFdLUGFzdGVib2FyZEZpbGVQcm9taXNlT3duZXIK IAorLSAoaWQpaW5pdFdpdGhTb3VyY2U6KGlkKWRyYWdTb3VyY2UKK3sKKyAgICBzZWxmID0gW3N1 cGVyIGluaXRXaXRoU291cmNlOmRyYWdTb3VyY2VdOworICAgIGlmICghc2VsZikKKyAgICAgICAg cmV0dXJuIG5pbDsKKyAgICBbX2RyYWdTb3VyY2UgcmV0YWluXTsKKyAgICByZXR1cm4gc2VsZjsK K30KKworLSAodm9pZClkZWFsbG9jCit7CisgICAgW19kcmFnU291cmNlIHJlbGVhc2VdOworICAg IFtzdXBlciBkZWFsbG9jXTsKK30KKwogLy8gVGhlIEFwcEtpdCBpbXBsZW1lbnRhdGlvbiBvZiBj b3B5RHJvcERpcmVjdG9yeSBnZXRzIHRoZSBjdXJyZW50IHBhc3RlYm9hcmQgaW4KIC8vIGEgd2F5 IHRoYXQgb25seSB3b3JrcyBpbiB0aGUgcHJvY2VzcyB3aGVyZSB0aGUgZHJhZyBpcyBpbml0aWF0 ZWQuIFdlIHN1cHBseQogLy8gYW4gaW1wbGVtZW50YXRpb24gdGhhdCBnZXRzIHRoZSBwYXN0ZWJv YXJkIGJ5IG5hbWUgaW5zdGVhZC4K