70333 2011-10-18 09:37:52 -0700 [Qt][WK2]: Shouldn't send unhandled TouchCancel event to gesture recognizers 2022-02-28 03:49:10 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dinu.jacob dinu.jacob hausmann oldest_to_newest 486100 0 dinu.jacob 2011-10-18 09:37:52 -0700 QtPanGestureRecognizer and QtPinchGestureRecognizer needs only TouchBegin, TouchUpdate and TouchEnd. Sending TouchCancel event that is not handled results in an ASSERT in the gesture recognizers. 486102 1 dinu.jacob 2011-10-18 09:38:56 -0700 In QTouchWebPageProxy::doneWithTouchEvent, the gesture recognizers should be reset even if TouchCancel event is not handled. 486106 2 111455 dinu.jacob 2011-10-18 09:42:04 -0700 Created attachment 111455 patch 494125 3 111455 hausmann 2011-11-01 14:04:04 -0700 Comment on attachment 111455 patch Fair enough :) How do you synthesize TouchCancel? As a result of window deactivation maybe? 494567 4 dinu.jacob 2011-11-02 05:48:12 -0700 (In reply to comment #3) > (From update of attachment 111455 [details]) > Fair enough :) > > How do you synthesize TouchCancel? As a result of window deactivation maybe? Yes, and according to W3C spec, also if there are more touch points on the touch surface than an allowed 'max'. 494568 5 dinu.jacob 2011-11-02 05:48:54 -0700 Can you also commit the patch please? Thanks, Dinu 494572 6 hausmann 2011-11-02 05:56:24 -0700 Committed r99054: <http://trac.webkit.org/changeset/99054> 494573 7 dinu.jacob 2011-11-02 05:57:03 -0700 (In reply to comment #6) > Committed r99054: <http://trac.webkit.org/changeset/99054> Thanks Simon. 111455 2011-10-18 09:42:04 -0700 2022-02-28 03:49:10 -0800 patch 70333.patch text/plain 1392 dinu.jacob SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3NzY1KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMTggIERpbnUgSmFj b2IgIDxkaW51LmphY29iQG5va2lhLmNvbT4KKworICAgICAgICBbUXRdW1dLMl06IFNob3VsZG4n dCBzZW5kIHVuaGFuZGxlZCBUb3VjaENhbmNlbCBldmVudCB0byBnZXN0dXJlIHJlY29nbml6ZXJz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDMzMwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdlc3R1cmUg cmVjb2duaXplcnMgc2hvdWxkIGJlIHJlc2V0IGZvciB1bmhhbmRsZWQgVG91Y2hDYW5jZWwgZXZl bnQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvcXQvcXRvdWNod2VicGFnZXByb3h5LmNwcDoKKyAg ICAgICAgKFFUb3VjaFdlYlBhZ2VQcm94eTo6ZG9uZVdpdGhUb3VjaEV2ZW50KToKKwogMjAxMS0x MC0xOCAgRGludSBKYWNvYiAgPGRpbnUuamFjb2JAbm9raWEuY29tPgogCiAgICAgICAgIFtRdF1b V0syXSBBU1NFUlQgd2hlbiBkaXNwbGF5aW5nIGNvbnRleHQgbWVudSBpbiBpbnB1dCBmaWVsZApJ bmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L3F0b3VjaHdlYnBhZ2Vwcm94eS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L3F0b3VjaHdlYnBhZ2Vw cm94eS5jcHAJKHJldmlzaW9uIDk3NzU2KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0 L3F0b3VjaHdlYnBhZ2Vwcm94eS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU0LDcgKzU0LDcgQEAg dm9pZCBRVG91Y2hXZWJQYWdlUHJveHk6OnBhaW50Q29udGVudChRUAogI2lmIEVOQUJMRShUT1VD SF9FVkVOVFMpCiB2b2lkIFFUb3VjaFdlYlBhZ2VQcm94eTo6ZG9uZVdpdGhUb3VjaEV2ZW50KGNv bnN0IE5hdGl2ZVdlYlRvdWNoRXZlbnQmIGV2ZW50LCBib29sIHdhc0V2ZW50SGFuZGxlZCkKIHsK LSAgICBpZiAod2FzRXZlbnRIYW5kbGVkKSB7CisgICAgaWYgKHdhc0V2ZW50SGFuZGxlZCB8fCBl dmVudC50eXBlKCkgPT0gV2ViRXZlbnQ6OlRvdWNoQ2FuY2VsKSB7CiAgICAgICAgIG1fcGFuR2Vz dHVyZVJlY29nbml6ZXIucmVzZXQoKTsKICAgICAgICAgbV9waW5jaEdlc3R1cmVSZWNvZ25pemVy LnJlc2V0KCk7CiAgICAgfSBlbHNlIHsK