70313 2011-10-18 01:12:58 -0700 [Chromium] buildbot runs nrwt with --chromium instead of --chromium-cg-mac 2011-10-18 12:23:38 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa dpranke jamesr mihaip ojan tkent tony oldest_to_newest 485900 0 rniwa 2011-10-18 01:12:58 -0700 Chromium Mac bots need to run tests with fully-qualified --chromium-cg-mac instead of just --platform in order to use correct expectations. But we're currently running nrwt with --chromium. 485923 1 111411 rniwa 2011-10-18 02:11:36 -0700 Created attachment 111411 fixes the bug 486069 2 111411 abarth 2011-10-18 08:38:13 -0700 Comment on attachment 111411 fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=111411&action=review Why don't we always pass the full platform? > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:91 > +def appendCustomBuildFlags(step, platform, fullPlatform="", useFullPlatformCorChromiumCGMac=False): useFullPlatformCorChromiumCGMac => useFullPlatformForChromiumCGMac ? 486094 3 rniwa 2011-10-18 09:32:22 -0700 (In reply to comment #2) > (From update of attachment 111411 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=111411&action=review > > Why don't we always pass the full platform? I couldn't tell if full platform is supported for all ports or not. I'd rather not break other ports since I'd expect this work-around to go away once CG -> Skia transition is done. > > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:91 > > +def appendCustomBuildFlags(step, platform, fullPlatform="", useFullPlatformCorChromiumCGMac=False): > > useFullPlatformCorChromiumCGMac => useFullPlatformForChromiumCGMac ? Yeah, it's a typo. 486097 4 111452 rniwa 2011-10-18 09:35:15 -0700 Created attachment 111452 fixed typo 486101 5 111452 abarth 2011-10-18 09:38:01 -0700 Comment on attachment 111452 fixed typo Can you add a FIXME comment about removing this once Skia is the default on Mac? 486110 6 rniwa 2011-10-18 09:45:19 -0700 (In reply to comment #5) > (From update of attachment 111452 [details]) > Can you add a FIXME comment about removing this once Skia is the default on Mac? Good idea. Will do. 486126 7 rniwa 2011-10-18 10:08:55 -0700 I guess I'll land this tonight when bots are quiet. 486222 8 rniwa 2011-10-18 12:23:38 -0700 Committed r97781: <http://trac.webkit.org/changeset/97781> 111411 2011-10-18 02:11:36 -0700 2011-10-18 09:35:11 -0700 fixes the bug bug-70313-20111018021135.patch text/plain 2143 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk3NzI2KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMTAtMTggIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgW0Nocm9taXVtXSBidWlsZGJvdCBydW5zIG5yd3Qgd2l0aCAtLWNocm9taXVtIGlu c3RlYWQgb2YgLS1jaHJvbWl1bS1jZy1tYWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTcwMzEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRml4ZWQgdGhlIGJ1ZyBieSBwYXNzaW5nIC0tcGxhdGZvcm0gLS1j aHJvbWl1bS1jZy1tYWMgaW4gUnVuV2ViS2l0VGVzdHMuIFdlIGNhbid0IGFsd2F5cyBhZGQKKyAg ICAgICAgdGhpcyBwYXJhbWV0ZXIgYmVjYXVzZSBidWlsZC13ZWJraXQgYW5kIG90aGVyIHNjcmlw dHMgZG9uJ3QgYWNjZXB0IGl0LgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQu d2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZzoKKwogMjAxMS0xMC0xNyAgS2VudCBUYW11cmEg IDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQSBmb2xsb3ctdXAgb2Ygcjk3NzE2LgpJ bmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCShyZXZpc2lvbiA5NzcyNCkKKysrIFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcJKHdvcmtpbmcg Y29weSkKQEAgLTg4LDkgKzg4LDExIEBAIGNsYXNzIENsZWFudXBDaHJvbWl1bUNyYXNoTG9ncyhz aGVsbC5TaGUKICAgICBoYWx0T25GYWlsdXJlID0gRmFsc2UKIAogCi1kZWYgYXBwZW5kQ3VzdG9t QnVpbGRGbGFncyhzdGVwLCBwbGF0Zm9ybSwgZnVsbFBsYXRmb3JtPSIiKToKK2RlZiBhcHBlbmRD dXN0b21CdWlsZEZsYWdzKHN0ZXAsIHBsYXRmb3JtLCBmdWxsUGxhdGZvcm09IiIsIHVzZUZ1bGxQ bGF0Zm9ybUNvckNocm9taXVtQ0dNYWM9RmFsc2UpOgogICAgIGlmIGZ1bGxQbGF0Zm9ybSA9PSAi Y2hyb21pdW0tYW5kcm9pZCI6CiAgICAgICAgIHN0ZXAuc2V0Q29tbWFuZChzdGVwLmNvbW1hbmQg KyBbJy0tY2hyb21pdW0tYW5kcm9pZCddKQorICAgIGVsaWYgdXNlRnVsbFBsYXRmb3JtQ29yQ2hy b21pdW1DR01hYyBhbmQgZnVsbFBsYXRmb3JtLmZpbmQoJy1jZy1tYWMnKSA+IDA6CisgICAgICAg IHN0ZXAuc2V0Q29tbWFuZChzdGVwLmNvbW1hbmQgKyBbJy0tcGxhdGZvcm0nLCBmdWxsUGxhdGZv cm1dKQogICAgIGVsaWYgcGxhdGZvcm0gaW4gKCdjaHJvbWl1bScsICdlZmwnLCAnZ3RrJywgJ3F0 JywgJ3dpbmNhaXJvJywgJ3dpbmNlJywgJ3d4Jyk6CiAgICAgICAgIHN0ZXAuc2V0Q29tbWFuZChz dGVwLmNvbW1hbmQgKyBbJy0tJyArIHBsYXRmb3JtXSkKIApAQCAtMjQzLDcgKzI0NSw3IEBAIGNs YXNzIFJ1bldlYktpdFRlc3RzKHNoZWxsLlRlc3QpOgogCiAgICAgZGVmIHN0YXJ0KHNlbGYpOgog ICAgICAgICBwbGF0Zm9ybSA9IHNlbGYuZ2V0UHJvcGVydHkoJ3BsYXRmb3JtJykKLSAgICAgICAg YXBwZW5kQ3VzdG9tQnVpbGRGbGFncyhzZWxmLCBwbGF0Zm9ybSwgc2VsZi5nZXRQcm9wZXJ0eSgn ZnVsbFBsYXRmb3JtJykpCisgICAgICAgIGFwcGVuZEN1c3RvbUJ1aWxkRmxhZ3Moc2VsZiwgcGxh dGZvcm0sIHNlbGYuZ2V0UHJvcGVydHkoJ2Z1bGxQbGF0Zm9ybScpLCBUcnVlKQogICAgICAgICBp ZiBwbGF0Zm9ybSA9PSAid2luIjoKICAgICAgICAgICAgIHJvb3RBcmd1bWVudCA9IFsnLS1yb290 PScgKyBvcy5wYXRoLmpvaW4oIldlYktpdEJ1aWxkIiwgc2VsZi5nZXRQcm9wZXJ0eSgnY29uZmln dXJhdGlvbicpLCAiYmluIildCiAgICAgICAgIGVsc2U6Cg== 111452 2011-10-18 09:35:15 -0700 2011-10-18 09:38:01 -0700 fixed typo bug-70313-20111018093514.patch text/plain 2143 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk3NzI2KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMTAtMTggIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgW0Nocm9taXVtXSBidWlsZGJvdCBydW5zIG5yd3Qgd2l0aCAtLWNocm9taXVtIGlu c3RlYWQgb2YgLS1jaHJvbWl1bS1jZy1tYWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTcwMzEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRml4ZWQgdGhlIGJ1ZyBieSBwYXNzaW5nIC0tcGxhdGZvcm0gLS1j aHJvbWl1bS1jZy1tYWMgaW4gUnVuV2ViS2l0VGVzdHMuIFdlIGNhbid0IGFsd2F5cyBhZGQKKyAg ICAgICAgdGhpcyBwYXJhbWV0ZXIgYmVjYXVzZSBidWlsZC13ZWJraXQgYW5kIG90aGVyIHNjcmlw dHMgZG9uJ3QgYWNjZXB0IGl0LgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQu d2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZzoKKwogMjAxMS0xMC0xNyAgS2VudCBUYW11cmEg IDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQSBmb2xsb3ctdXAgb2Ygcjk3NzE2LgpJ bmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCShyZXZpc2lvbiA5NzcyNCkKKysrIFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcJKHdvcmtpbmcg Y29weSkKQEAgLTg4LDkgKzg4LDExIEBAIGNsYXNzIENsZWFudXBDaHJvbWl1bUNyYXNoTG9ncyhz aGVsbC5TaGUKICAgICBoYWx0T25GYWlsdXJlID0gRmFsc2UKIAogCi1kZWYgYXBwZW5kQ3VzdG9t QnVpbGRGbGFncyhzdGVwLCBwbGF0Zm9ybSwgZnVsbFBsYXRmb3JtPSIiKToKK2RlZiBhcHBlbmRD dXN0b21CdWlsZEZsYWdzKHN0ZXAsIHBsYXRmb3JtLCBmdWxsUGxhdGZvcm09IiIsIHVzZUZ1bGxQ bGF0Zm9ybUZvckNocm9taXVtQ0dNYWM9RmFsc2UpOgogICAgIGlmIGZ1bGxQbGF0Zm9ybSA9PSAi Y2hyb21pdW0tYW5kcm9pZCI6CiAgICAgICAgIHN0ZXAuc2V0Q29tbWFuZChzdGVwLmNvbW1hbmQg KyBbJy0tY2hyb21pdW0tYW5kcm9pZCddKQorICAgIGVsaWYgdXNlRnVsbFBsYXRmb3JtRm9yQ2hy b21pdW1DR01hYyBhbmQgZnVsbFBsYXRmb3JtLmZpbmQoJy1jZy1tYWMnKSA+IDA6CisgICAgICAg IHN0ZXAuc2V0Q29tbWFuZChzdGVwLmNvbW1hbmQgKyBbJy0tcGxhdGZvcm0nLCBmdWxsUGxhdGZv cm1dKQogICAgIGVsaWYgcGxhdGZvcm0gaW4gKCdjaHJvbWl1bScsICdlZmwnLCAnZ3RrJywgJ3F0 JywgJ3dpbmNhaXJvJywgJ3dpbmNlJywgJ3d4Jyk6CiAgICAgICAgIHN0ZXAuc2V0Q29tbWFuZChz dGVwLmNvbW1hbmQgKyBbJy0tJyArIHBsYXRmb3JtXSkKIApAQCAtMjQzLDcgKzI0NSw3IEBAIGNs YXNzIFJ1bldlYktpdFRlc3RzKHNoZWxsLlRlc3QpOgogCiAgICAgZGVmIHN0YXJ0KHNlbGYpOgog ICAgICAgICBwbGF0Zm9ybSA9IHNlbGYuZ2V0UHJvcGVydHkoJ3BsYXRmb3JtJykKLSAgICAgICAg YXBwZW5kQ3VzdG9tQnVpbGRGbGFncyhzZWxmLCBwbGF0Zm9ybSwgc2VsZi5nZXRQcm9wZXJ0eSgn ZnVsbFBsYXRmb3JtJykpCisgICAgICAgIGFwcGVuZEN1c3RvbUJ1aWxkRmxhZ3Moc2VsZiwgcGxh dGZvcm0sIHNlbGYuZ2V0UHJvcGVydHkoJ2Z1bGxQbGF0Zm9ybScpLCBUcnVlKQogICAgICAgICBp ZiBwbGF0Zm9ybSA9PSAid2luIjoKICAgICAgICAgICAgIHJvb3RBcmd1bWVudCA9IFsnLS1yb290 PScgKyBvcy5wYXRoLmpvaW4oIldlYktpdEJ1aWxkIiwgc2VsZi5nZXRQcm9wZXJ0eSgnY29uZmln dXJhdGlvbicpLCAiYmluIildCiAgICAgICAgIGVsc2U6Cg==