70312 2011-10-18 00:22:51 -0700 [EFL][WK2] Added missing files to build WebKit2 EFL 2011-10-19 01:31:41 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61838 0 t.morawski webkit-unassigned gyuyoung.kim leandro rakuco webkit.review.bot oldest_to_newest 485876 0 t.morawski 2011-10-18 00:22:51 -0700 Added missing files to build WebKit2 EFL to fix few linking time errors. 485878 1 111400 t.morawski 2011-10-18 00:25:30 -0700 Created attachment 111400 Patch 485999 2 111400 leandro 2011-10-18 06:28:19 -0700 Comment on attachment 111400 Patch LGTM. Just a minor nit: I'd comment which files were added to CMakeListsEfl.txt in the changelog entry. 486008 3 111432 t.morawski 2011-10-18 06:41:59 -0700 Created attachment 111432 Patch 2 486009 4 t.morawski 2011-10-18 06:42:43 -0700 > Just a minor nit: I'd comment which files were added to CMakeListsEfl.txt in the changelog entry Chamgelog has been changed. 486579 5 111432 rniwa 2011-10-18 23:41:54 -0700 Comment on attachment 111432 Patch 2 You didn't svn add files :( 486580 6 111432 rniwa 2011-10-18 23:43:22 -0700 Comment on attachment 111432 Patch 2 Oops I take back. These files do exist. r=me. 486615 7 111432 webkit.review.bot 2011-10-19 01:31:37 -0700 Comment on attachment 111432 Patch 2 Clearing flags on attachment: 111432 Committed r97841: <http://trac.webkit.org/changeset/97841> 486616 8 webkit.review.bot 2011-10-19 01:31:41 -0700 All reviewed patches have been landed. Closing bug. 111400 2011-10-18 00:25:30 -0700 2011-10-18 06:41:59 -0700 Patch patch1.patch text/plain 1165 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHNFZmwudHh0IGIvU291cmNlL1dl YkNvcmUvQ01ha2VMaXN0c0VmbC50eHQKaW5kZXggN2UxOTA3NC4uYzlhZTViZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0c0VmbC50eHQKKysrIGIvU291cmNlL1dlYkNvcmUv Q01ha2VMaXN0c0VmbC50eHQKQEAgLTE0Nyw3ICsxNDcsOSBAQCBJRiAoV1RGX1VTRV9TT1VQKQog ICApCiAgIExJU1QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUwogICAgIHBsYXRmb3JtL25ldHdvcmsv c291cC9Db29raWVKYXJTb3VwLmNwcAorICAgIHBsYXRmb3JtL25ldHdvcmsvc291cC9DcmVkZW50 aWFsU3RvcmFnZVNvdXAuY3BwCiAgICAgcGxhdGZvcm0vbmV0d29yay9zb3VwL0dPd25QdHJTb3Vw LmNwcAorICAgIHBsYXRmb3JtL25ldHdvcmsvc291cC9Qcm94eVNlcnZlclNvdXAuY3BwCiAgICAg cGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKICAgICBwbGF0Zm9y bS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VSZXF1ZXN0U291cC5jcHAKICAgICBwbGF0Zm9ybS9uZXR3 b3JrL3NvdXAvUmVzb3VyY2VSZXNwb25zZVNvdXAuY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjdiMTYyOC4u NmI1MzkyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDExLTEwLTE4ICBUb21hc3og TW9yYXdza2kgIDx0Lm1vcmF3c2tpQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl0g QWRkZWQgbWlzc2luZyBmaWxlcyB0byBidWlsZCBXZWJLaXQyIEVGTAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzAzMTIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlcyBmZXcgbGlua2luZyB0aW1lIGVy cm9ycy4KKworICAgICAgICAqIENNYWtlTGlzdHNFZmwudHh0OgorCiAyMDExLTEwLTE3ICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByOTc2NjkuCg== 111432 2011-10-18 06:41:59 -0700 2011-10-19 01:31:37 -0700 Patch 2 patch2.patch text/plain 1360 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHNFZmwudHh0IGIvU291cmNlL1dl YkNvcmUvQ01ha2VMaXN0c0VmbC50eHQKaW5kZXggN2UxOTA3NC4uYzlhZTViZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0c0VmbC50eHQKKysrIGIvU291cmNlL1dlYkNvcmUv Q01ha2VMaXN0c0VmbC50eHQKQEAgLTE0Nyw3ICsxNDcsOSBAQCBJRiAoV1RGX1VTRV9TT1VQKQog ICApCiAgIExJU1QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUwogICAgIHBsYXRmb3JtL25ldHdvcmsv c291cC9Db29raWVKYXJTb3VwLmNwcAorICAgIHBsYXRmb3JtL25ldHdvcmsvc291cC9DcmVkZW50 aWFsU3RvcmFnZVNvdXAuY3BwCiAgICAgcGxhdGZvcm0vbmV0d29yay9zb3VwL0dPd25QdHJTb3Vw LmNwcAorICAgIHBsYXRmb3JtL25ldHdvcmsvc291cC9Qcm94eVNlcnZlclNvdXAuY3BwCiAgICAg cGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKICAgICBwbGF0Zm9y bS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VSZXF1ZXN0U291cC5jcHAKICAgICBwbGF0Zm9ybS9uZXR3 b3JrL3NvdXAvUmVzb3VyY2VSZXNwb25zZVNvdXAuY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGM4MjM4YS4u ODc2NTliNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDExLTEwLTE4ICBUb21hc3og TW9yYXdza2kgIDx0Lm1vcmF3c2tpQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl0g QWRkZWQgbWlzc2luZyBmaWxlcyB0byBidWlsZCBXZWJLaXQyIEVGTAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzAzMTIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBtaXNzaW5nIGZpbGVzIHRvIFdl YkNvcmUvQ01ha2VMaXN0RWZsLnR4dCBzY3JpcHQ6CisgICAgICAgIC0gcGxhdGZvcm0vbmV0d29y ay9zb3VwL0NyZWRlbnRpYWxTdG9yYWdlU291cC5jcHAKKyAgICAgICAgLSBwbGF0Zm9ybS9uZXR3 b3JrL3NvdXAvUHJveHlTZXJ2ZXJTb3VwLmNwcAorICAgICAgICBGaXhlcyBmZXcgbGlua2luZyB0 aW1lIGVycm9ycy4KKworICAgICAgICAqIENNYWtlTGlzdHNFZmwudHh0OgorCiAyMDExLTEwLTE4 ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9O KHI5NzI0OCk6IDp2aXNpdGVkIGFzIGRlc2NlbmRhbnQgc2VsZWN0b3IgYnJva2VuCg==