70310 2011-10-17 23:51:38 -0700 [EFL] Added missing dummy platformDescription function 2011-10-19 00:17:12 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 t.morawski webkit-unassigned gyuyoung.kim leandro lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 485856 0 t.morawski 2011-10-17 23:51:38 -0700 Added dummy platformDescription function needed to compile WK2. 485859 1 111395 t.morawski 2011-10-17 23:53:23 -0700 Created attachment 111395 Patch 485877 2 111395 gyuyoung.kim 2011-10-18 00:24:12 -0700 Comment on attachment 111395 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111395&action=review > Source/WebCore/platform/efl/ContextMenuEfl.cpp:23 > + Why do you add an empty line to here? > Source/WebCore/platform/efl/ContextMenuEfl.cpp:52 > + It looks unneeded an empty line. 485883 3 111402 t.morawski 2011-10-18 00:33:22 -0700 Created attachment 111402 Patch 2 485884 4 111402 gyuyoung.kim 2011-10-18 00:38:21 -0700 Comment on attachment 111402 Patch 2 LGTM. 486000 5 111402 leandro 2011-10-18 06:28:48 -0700 Comment on attachment 111402 Patch 2 LGTM. 486589 6 111402 webkit.review.bot 2011-10-19 00:17:07 -0700 Comment on attachment 111402 Patch 2 Clearing flags on attachment: 111402 Committed r97837: <http://trac.webkit.org/changeset/97837> 486590 7 webkit.review.bot 2011-10-19 00:17:12 -0700 All reviewed patches have been landed. Closing bug. 111395 2011-10-17 23:53:23 -0700 2011-10-18 00:33:22 -0700 Patch patch1.patch text/plain 1382 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmN2IxNjI4Li4wMmZjNzYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMTAtMTcgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lAc2Ftc3VuZy5jb20+ CisKKyAgICAgICAgW0VGTF0gQWRkZWQgbWlzc2luZyBkdW1teSBwbGF0Zm9ybURlc2NyaXB0aW9u IGZ1bmN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03MDMxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZGVkIGR1bW15IHBsYXRmb3JtRGVzY3JpcHRpb24gZnVuY3Rpb24gbmVlZGVkIHRvIGNvbXBp bGUgV0syLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL0NvbnRleHRNZW51RWZsLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkNvbnRleHRNZW51OjpwbGF0Zm9ybURlc2NyaXB0aW9uKToKKwogMjAx MS0xMC0xNyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjk3NjY5LgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZWZsL0NvbnRleHRNZW51RWZsLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2VmbC9Db250ZXh0TWVudUVmbC5jcHAKaW5kZXggNDVkMTc1OC4uZDQzMTk3OCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0NvbnRleHRNZW51RWZsLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvQ29udGV4dE1lbnVFZmwuY3BwCkBA IC0yMCw5ICsyMCwxMSBAQAogICovCiAKICNpbmNsdWRlICJjb25maWcuaCIKKwogI2luY2x1ZGUg IkNvbnRleHRNZW51LmgiCiAKICNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5oIgorI2luY2x1ZGUg IlBsYXRmb3JtTWVudURlc2NyaXB0aW9uLmgiCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAt NDcsMTEgKzQ5LDE4IEBAIHZvaWQqIENvbnRleHRNZW51OjpuYXRpdmVNZW51KCkgY29uc3QKIHsK ICAgICByZXR1cm4gY3JlYXRlTmF0aXZlTWVudUZyb21JdGVtcyhtX2l0ZW1zKTsKIH0KKwogI2Vs c2UKIENvbnRleHRNZW51OjpDb250ZXh0TWVudSgpCiB7CiAgICAgbm90SW1wbGVtZW50ZWQoKTsK IH0KKworUGxhdGZvcm1NZW51RGVzY3JpcHRpb24gQ29udGV4dE1lbnU6OnBsYXRmb3JtRGVzY3Jp cHRpb24oKSBjb25zdAoreworICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgcmV0dXJuIDA7Cit9 CiAjZW5kaWYKIAogfQo= 111402 2011-10-18 00:33:22 -0700 2011-10-19 00:17:07 -0700 Patch 2 patch2.patch text/plain 1248 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmN2IxNjI4Li4wMmZjNzYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMTAtMTcgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lAc2Ftc3VuZy5jb20+ CisKKyAgICAgICAgW0VGTF0gQWRkZWQgbWlzc2luZyBkdW1teSBwbGF0Zm9ybURlc2NyaXB0aW9u IGZ1bmN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03MDMxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZGVkIGR1bW15IHBsYXRmb3JtRGVzY3JpcHRpb24gZnVuY3Rpb24gbmVlZGVkIHRvIGNvbXBp bGUgV0syLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL0NvbnRleHRNZW51RWZsLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkNvbnRleHRNZW51OjpwbGF0Zm9ybURlc2NyaXB0aW9uKToKKwogMjAx MS0xMC0xNyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjk3NjY5LgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZWZsL0NvbnRleHRNZW51RWZsLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2VmbC9Db250ZXh0TWVudUVmbC5jcHAKaW5kZXggNDVkMTc1OC4uNDZhMjBkYyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0NvbnRleHRNZW51RWZsLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvQ29udGV4dE1lbnVFZmwuY3BwCkBA IC0yMyw2ICsyMyw3IEBACiAjaW5jbHVkZSAiQ29udGV4dE1lbnUuaCIKIAogI2luY2x1ZGUgIk5v dEltcGxlbWVudGVkLmgiCisjaW5jbHVkZSAiUGxhdGZvcm1NZW51RGVzY3JpcHRpb24uaCIKIAog bmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC01Miw2ICs1MywxMiBAQCBDb250ZXh0TWVudTo6Q29u dGV4dE1lbnUoKQogewogICAgIG5vdEltcGxlbWVudGVkKCk7CiB9CisKK1BsYXRmb3JtTWVudURl c2NyaXB0aW9uIENvbnRleHRNZW51OjpwbGF0Zm9ybURlc2NyaXB0aW9uKCkgY29uc3QKK3sKKyAg ICBub3RJbXBsZW1lbnRlZCgpOworICAgIHJldHVybiAwOworfQogI2VuZGlmCiAKIH0K