70309 2011-10-17 23:32:44 -0700 [EFL][WK2] Fix compilation error by include WebErrors.h file. 2011-10-18 04:51:48 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61838 0 t.morawski webkit-unassigned gyuyoung.kim webkit.review.bot oldest_to_newest 485842 0 t.morawski 2011-10-17 23:32:44 -0700 Added a header file to fix compilation error. 485848 1 111391 t.morawski 2011-10-17 23:36:36 -0700 Created attachment 111391 Patch 485881 2 111391 gyuyoung.kim 2011-10-18 00:28:56 -0700 Comment on attachment 111391 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111391&action=review > Source/WebKit2/WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:27 > + It seems to me this is unneeded line. According to webkit coding style guideline, there is no an empty line below config.h http://www.webkit.org/coding/coding-style.html 485887 3 111403 t.morawski 2011-10-18 00:46:16 -0700 Created attachment 111403 Patch 2 485896 4 111403 gyuyoung.kim 2011-10-18 01:06:02 -0700 Comment on attachment 111403 Patch 2 Why do you use <WebCore/ResourceErrror.h>? EFL build script includes WebCore directory as include directory ? It looks other ports use <WebCore/ResourceError.h> BTW, If this patch is to fix build break, committer can land this patch to fix build break. Could you modify ChangeLog again as below? For example, *Unreviewd build fix* instead of *Reviewed by NOBODY (OOPS!).* Then, only request cq?, not r? 485898 5 gyuyoung.kim 2011-10-18 01:07:07 -0700 (In reply to comment #4) > (From update of attachment 111403 [details]) > Why do you use <WebCore/ResourceErrror.h>? I mean why not you don't use <WebCore/ResourceError.h>. 485902 6 111407 t.morawski 2011-10-18 01:17:07 -0700 Created attachment 111407 Patch 3 485903 7 t.morawski 2011-10-18 01:20:42 -0700 > EFL build script includes WebCore directory as include directory ? > I mean why not you don't use <WebCore/ResourceError.h>. Yes, it is included and this code can be compiled. But I have changed it to follow other port. Thank you and I am sorry for that. 485905 8 111409 t.morawski 2011-10-18 01:26:36 -0700 Created attachment 111409 Patch 4 485965 9 111409 webkit.review.bot 2011-10-18 04:51:43 -0700 Comment on attachment 111409 Patch 4 Clearing flags on attachment: 111409 Committed r97739: <http://trac.webkit.org/changeset/97739> 485966 10 webkit.review.bot 2011-10-18 04:51:48 -0700 All reviewed patches have been landed. Closing bug. 111391 2011-10-17 23:36:36 -0700 2011-10-18 00:46:16 -0700 Patch patch1.patch text/plain 1173 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjZjhjMmQwLi41M2MxNTAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMTAtMTcgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lAc2Ftc3VuZy5jb20+ CisKKyAgICAgICAgW0VGTF1bV0syXSBGaXggY29tcGlsYXRpb24gZXJyb3IgYnkgaW5jbHVkZSBX ZWJFcnJvcnMuaCBmaWxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NzAzMDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGRlZCBhIGhlYWRlciBmaWxlIHRvIGZpeCBjb21waWxhdGlvbiBlcnJvci4KKwor ICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvZWZsL1dlYkVycm9yc0VmbC5jcHA6 CisKIDIwMTEtMTAtMTcgIEpvbiBMZWUgIDxqb25sZWVAYXBwbGUuY29tPgogCiAgICAgICAgIEZp bHRlcmluZyBvZiBVUkxzIHdoZW4gc2VyaWFsaXppbmcgYmFjayBmb3J3YXJkIGxpc3Qgc2F2ZXMg YmFkIGN1cnJlbnQgaW5kZXggdmFsdWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViQ29yZVN1cHBvcnQvZWZsL1dlYkVycm9yc0VmbC5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L2VmbC9XZWJFcnJvcnNFZmwuY3BwCmluZGV4IGJi ZTFiZjguLjY4MWEyMmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi Q29yZVN1cHBvcnQvZWZsL1dlYkVycm9yc0VmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9lZmwvV2ViRXJyb3JzRWZsLmNwcApAQCAtMjQsOCArMjQs MTAgQEAKICAqLwogCiAjaW5jbHVkZSAiY29uZmlnLmgiCisKICNpbmNsdWRlICJXZWJFcnJvcnMu aCIKIAorI2luY2x1ZGUgPFJlc291cmNlRXJyb3IuaD4KICNpbmNsdWRlIDxXZWJDb3JlL05vdElt cGxlbWVudGVkLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9SZXNvdXJjZVJlcXVlc3QuaD4KICNpbmNs dWRlIDxXZWJDb3JlL1Jlc291cmNlUmVzcG9uc2UuaD4K 111403 2011-10-18 00:46:16 -0700 2011-10-18 01:17:07 -0700 Patch 2 patch2.patch text/plain 1163 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjZjhjMmQwLi5hNDExMjJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMTAtMTcgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lAc2Ftc3VuZy5jb20+ CisKKyAgICAgICAgW0VGTF1bV0syXSBGaXggY29tcGlsYXRpb24gZXJyb3IgYnkgaW5jbHVkZSBX ZWJFcnJvcnMuaCBmaWxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NzAzMDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGRlZCBhIGhlYWRlciBmaWxlIHRvIGZpeCBjb21waWxhdGlvbiBlcnJvci4KKwor ICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvZWZsL1dlYkVycm9yc0VmbC5jcHA6 CisKIDIwMTEtMTAtMTcgIEpvbiBMZWUgIDxqb25sZWVAYXBwbGUuY29tPgogCiAgICAgICAgIEZp bHRlcmluZyBvZiBVUkxzIHdoZW4gc2VyaWFsaXppbmcgYmFjayBmb3J3YXJkIGxpc3Qgc2F2ZXMg YmFkIGN1cnJlbnQgaW5kZXggdmFsdWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViQ29yZVN1cHBvcnQvZWZsL1dlYkVycm9yc0VmbC5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L2VmbC9XZWJFcnJvcnNFZmwuY3BwCmluZGV4IGJi ZTFiZjguLmM1NjhmOTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi Q29yZVN1cHBvcnQvZWZsL1dlYkVycm9yc0VmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9lZmwvV2ViRXJyb3JzRWZsLmNwcApAQCAtMjYsNiArMjYs NyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIldlYkVycm9ycy5oIgogCisjaW5j bHVkZSA8UmVzb3VyY2VFcnJvci5oPgogI2luY2x1ZGUgPFdlYkNvcmUvTm90SW1wbGVtZW50ZWQu aD4KICNpbmNsdWRlIDxXZWJDb3JlL1Jlc291cmNlUmVxdWVzdC5oPgogI2luY2x1ZGUgPFdlYkNv cmUvUmVzb3VyY2VSZXNwb25zZS5oPgo= 111407 2011-10-18 01:17:07 -0700 2011-10-18 01:26:36 -0700 Patch 3 patch3.patch text/plain 1164 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjZjhjMmQwLi42MmYxMTkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMTAtMTcgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lAc2Ftc3VuZy5jb20+ CisKKyAgICAgICAgW0VGTF1bV0syXSBGaXggY29tcGlsYXRpb24gZXJyb3IgYnkgaW5jbHVkZSBX ZWJFcnJvcnMuaCBmaWxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NzAzMDkKKworICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeAorCisgICAgICAg IEFkZGVkIGEgaGVhZGVyIGZpbGUgdG8gZml4IGNvbXBpbGF0aW9uIGVycm9yLgorCisgICAgICAg ICogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9lZmwvV2ViRXJyb3JzRWZsLmNwcDoKKwogMjAx MS0xMC0xNyAgSm9uIExlZSAgPGpvbmxlZUBhcHBsZS5jb20+CiAKICAgICAgICAgRmlsdGVyaW5n IG9mIFVSTHMgd2hlbiBzZXJpYWxpemluZyBiYWNrIGZvcndhcmQgbGlzdCBzYXZlcyBiYWQgY3Vy cmVudCBpbmRleCB2YWx1ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJDb3JlU3VwcG9ydC9lZmwvV2ViRXJyb3JzRWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViQ29yZVN1cHBvcnQvZWZsL1dlYkVycm9yc0VmbC5jcHAKaW5kZXggYmJlMWJmOC4u ZmNhMTdiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3Vw cG9ydC9lZmwvV2ViRXJyb3JzRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYkNvcmVTdXBwb3J0L2VmbC9XZWJFcnJvcnNFZmwuY3BwCkBAIC0yNiw2ICsyNiw3IEBACiAj aW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiV2ViRXJyb3JzLmgiCiAKKyNpbmNsdWRlIDxX ZWJDb3JlL1Jlc291cmNlRXJyb3IuaD4KICNpbmNsdWRlIDxXZWJDb3JlL05vdEltcGxlbWVudGVk Lmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9SZXNvdXJjZVJlcXVlc3QuaD4KICNpbmNsdWRlIDxXZWJD b3JlL1Jlc291cmNlUmVzcG9uc2UuaD4K 111409 2011-10-18 01:26:36 -0700 2011-10-18 04:51:43 -0700 Patch 4 patch4.patch text/plain 1145 t.morawski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjZjhjMmQwLi42MmYxMTkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMTAtMTcgIFRvbWFzeiBNb3Jhd3NraSAgPHQubW9yYXdza2lAc2Ftc3VuZy5jb20+ CisKKyAgICAgICAgW0VGTF1bV0syXSBGaXggY29tcGlsYXRpb24gZXJyb3IgYnkgaW5jbHVkZSBX ZWJFcnJvcnMuaCBmaWxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NzAzMDkKKworICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeAorCisgICAgICAg IEFkZGVkIGEgaGVhZGVyIGZpbGUgdG8gZml4IGNvbXBpbGF0aW9uIGVycm9yLgorCisgICAgICAg ICogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9lZmwvV2ViRXJyb3JzRWZsLmNwcDoKKwogMjAx MS0xMC0xNyAgSm9uIExlZSAgPGpvbmxlZUBhcHBsZS5jb20+CiAKICAgICAgICAgRmlsdGVyaW5n IG9mIFVSTHMgd2hlbiBzZXJpYWxpemluZyBiYWNrIGZvcndhcmQgbGlzdCBzYXZlcyBiYWQgY3Vy cmVudCBpbmRleCB2YWx1ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJDb3JlU3VwcG9ydC9lZmwvV2ViRXJyb3JzRWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViQ29yZVN1cHBvcnQvZWZsL1dlYkVycm9yc0VmbC5jcHAKaW5kZXggYmJlMWJmOC4u NDE3ODIzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3Vw cG9ydC9lZmwvV2ViRXJyb3JzRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYkNvcmVTdXBwb3J0L2VmbC9XZWJFcnJvcnNFZmwuY3BwCkBAIC0yNyw2ICsyNyw3IEBACiAj aW5jbHVkZSAiV2ViRXJyb3JzLmgiCiAKICNpbmNsdWRlIDxXZWJDb3JlL05vdEltcGxlbWVudGVk Lmg+CisjaW5jbHVkZSA8V2ViQ29yZS9SZXNvdXJjZUVycm9yLmg+CiAjaW5jbHVkZSA8V2ViQ29y ZS9SZXNvdXJjZVJlcXVlc3QuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1Jlc291cmNlUmVzcG9uc2Uu aD4KIAo=