70300 2011-10-17 20:03:35 -0700 r97693 caused 42 failures on the chromium mac bots 2011-10-21 17:10:01 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 70660 1 ojan ojan hyatt tony oldest_to_newest 485754 0 ojan 2011-10-17 20:03:35 -0700 http://trac.webkit.org/changeset/97693 I'm unable to reproduce this locally. Trying a clean build and a clobber on the bots. In the meantime, will mark these as failing to green the tree. The change itself is not platform-specific, so I'm not really sure what could possibly cause this to only fail on chromium-mac and not on any other port/platform. fast/html/details-mouse-click.html fast/ruby/base-shorter-than-text.html fast/table/038-vertical.html fast/table/auto-with-percent-height-vertical.html fast/table/border-collapsing/002-vertical.html fast/table/border-collapsing/004-vertical.html fast/table/border-collapsing/equal-precedence-resolution-vertical.html fast/table/height-percent-test-vertical.html fast/table/rowspan-paint-order-vertical.html fast/table/table-display-types-vertical.html fast/writing-mode/basic-vertical-line.html fast/writing-mode/english-lr-text.html fast/writing-mode/table-hit-test.html fast/writing-mode/vertical-font-fallback.html editing/selection/vertical-lr-ltr-extend-line-backward-br.html editing/selection/vertical-lr-ltr-extend-line-forward-br.html editing/selection/vertical-rl-ltr-extend-line-backward-br.html editing/selection/vertical-rl-ltr-extend-line-backward-p.html editing/selection/vertical-rl-ltr-extend-line-backward-wrap.html editing/selection/vertical-rl-ltr-extend-line-forward-br.html editing/selection/vertical-rl-ltr-extend-line-forward-p.html editing/selection/vertical-rl-ltr-extend-line-forward-wrap.html editing/selection/vertical-rl-rtl-extend-line-backward-br.html editing/selection/vertical-rl-rtl-extend-line-backward-p.html editing/selection/vertical-rl-rtl-extend-line-forward-br.html editing/selection/vertical-rl-rtl-extend-line-forward-p.html fast/backgrounds/background-leakage-transforms.html fast/css/focus-ring-multiline-writingmode-vertical.html fast/css/h1-in-section-elements.html fast/repaint/repaint-across-writing-mode-boundary.html fast/repaint/table-writing-modes-h.html fast/repaint/table-writing-modes-v.html fast/table/027-vertical.html fast/table/028-vertical.html fast/table/040-vertical.html fast/table/border-collapsing/rtl-border-collapsing-vertical.html fast/table/colspanMinWidth-vertical.html fast/table/growCellForImageQuirk-vertical.html fast/text/justify-ideograph-vertical.html fast/writing-mode/fallback-orientation.html fast/writing-mode/margin-collapse.html fast/writing-mode/text-orientation-basic.html 487779 1 ojan 2011-10-20 12:29:57 -0700 Turns out this is a 32 vs 64 bit issue. If I build chromium's DRT 64bit the tests pass. If I build it 32bit, the tests fail. I've reduce to the following one-line test case: <div style="height: 100px; width: 100px; -webkit-writing-mode: vertical-lr;" ></div> In 32bit, the body element has height 0 in the render dump. The thing that confuses me is that I've stepped though RenderBlock::layoutBlock and the height is always non-zero. So, I don't get where it would be set to 0. 488767 2 112045 ojan 2011-10-21 16:58:04 -0700 Created attachment 112045 Patch 488774 3 ojan 2011-10-21 17:10:01 -0700 Committed r98173: <http://trac.webkit.org/changeset/98173> 112045 2011-10-21 16:58:04 -0700 2011-10-21 16:58:35 -0700 Patch bug-70300-20111021165803.patch text/plain 1739 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogOTgwNTIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlYWQ5YmQ5NjU4YjAyOTFh NzEyM2JiMjc5ZWNmZGZkMjBkMjVhZmQ1Li45ZTFkMzFkNzQ4OWY3YjgxMTE0YjkxMTI1NWFlOWFl YWFmNWY3NWNjIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMTAtMjEgIE9qYW4g VmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAgICByOTc2OTMgY2F1c2VkIDQyIGZh aWx1cmVzIG9uIHRoZSBjaHJvbWl1bSBtYWMgYm90cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzAzMDAKKworICAgICAgICBDYW4ndCB0ZXN0IHRoaXMg dW50aWwgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwNjYwCisgICAg ICAgIGlzIGZpeGVkLiBUaGUgZml4IGZvciB0aGF0IGJ1ZyB3aWxsIHRlc3QgdGhpcyBjb2RlcGF0 aCBhcyB3ZWxsIHRob3VnaC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6Y29tcHV0ZUJsb2NrUHJlZmVycmVkTG9n aWNhbFdpZHRocyk6CisKIDIwMTEtMTAtMjAgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KIAogICAgICAgICBBdHRlbXB0IHRvIGZpeCBjcmFzaCBmb3IgaW5maW5pdGUgcmVjdXJzaW9u LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKaW5kZXggNThlMGYxZjYw NmIzMzUzM2IxNzc4MDk1NDQ5NjM3YWIzMGE4ZmQ5OS4uMjAzODJlZmVlMmFiZDU2M2M1MDE0M2Q4 ODlkZGRlODQyMDc0NTkxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckJsb2NrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2su Y3BwCkBAIC01MjU4LDcgKzUyNTgsNyBAQCB2b2lkIFJlbmRlckJsb2NrOjpjb21wdXRlQmxvY2tQ cmVmZXJyZWRMb2dpY2FsV2lkdGhzKCkKICAgICAgICAgaWYgKGNoaWxkLT5pc0JveCgpICYmIGNo aWxkLT5pc0hvcml6b250YWxXcml0aW5nTW9kZSgpICE9IGlzSG9yaXpvbnRhbFdyaXRpbmdNb2Rl KCkpIHsKICAgICAgICAgICAgIFJlbmRlckJveCogY2hpbGRCb3ggPSB0b1JlbmRlckJveChjaGls ZCk7CiAgICAgICAgICAgICBMYXlvdXRVbml0IG9sZEhlaWdodCA9IGNoaWxkQm94LT5sb2dpY2Fs SGVpZ2h0KCk7Ci0gICAgICAgICAgICBzZXRMb2dpY2FsSGVpZ2h0KGNoaWxkQm94LT5ib3JkZXJB bmRQYWRkaW5nTG9naWNhbEhlaWdodCgpKTsKKyAgICAgICAgICAgIGNoaWxkQm94LT5zZXRMb2dp Y2FsSGVpZ2h0KGNoaWxkQm94LT5ib3JkZXJBbmRQYWRkaW5nTG9naWNhbEhlaWdodCgpKTsKICAg ICAgICAgICAgIGNoaWxkQm94LT5jb21wdXRlTG9naWNhbEhlaWdodCgpOwogICAgICAgICAgICAg Y2hpbGRNaW5QcmVmZXJyZWRMb2dpY2FsV2lkdGggPSBjaGlsZE1heFByZWZlcnJlZExvZ2ljYWxX aWR0aCA9IGNoaWxkQm94LT5sb2dpY2FsSGVpZ2h0KCk7CiAgICAgICAgICAgICBjaGlsZEJveC0+ c2V0TG9naWNhbEhlaWdodChvbGRIZWlnaHQpOwo=