70288 2011-10-17 16:53:02 -0700 REGRESSION(r97641): "This change may have broken mouse/hit-test coordinate tests." (Requested by jeffm7 on #webkit). 2011-10-17 18:09:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 70152 1 webkit.review.bot webkit.review.bot darin jeffm rniwa oldest_to_newest 485632 0 webkit.review.bot 2011-10-17 16:53:02 -0700 http://trac.webkit.org/changeset/97641 broke the build: "This change may have broken mouse/hit-test coordinate tests." (Requested by jeffm7 on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 485633 1 111348 webkit.review.bot 2011-10-17 16:53:37 -0700 Created attachment 111348 ROLLOUT of r97641 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 485691 2 rniwa 2011-10-17 18:05:14 -0700 This patch appears to have caused 15+ tests to fail on Snow Leopard: http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r97655%20(2609)/results.html Tests passed on r97640 but fail on r97646. 485696 3 111348 webkit.review.bot 2011-10-17 18:09:14 -0700 Comment on attachment 111348 ROLLOUT of r97641 Clearing flags on attachment: 111348 Committed r97688: <http://trac.webkit.org/changeset/97688> 485697 4 webkit.review.bot 2011-10-17 18:09:18 -0700 All reviewed patches have been landed. Closing bug. 111348 2011-10-17 16:53:37 -0700 2011-10-17 18:09:13 -0700 ROLLOUT of r97641 bug-70288-20111017235102.patch text/plain 2987 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogOTc2NzMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkN2YwYTA0YzEwYmVmYjlh NGY0MzQwNzNmZGVhYzdiN2ZhODc0MGI1Li42ODg3YjA3NzExZjQ2ZmYzNGU5YWY4ZWJlMjQ1NDJm NWM4NDI3M2MyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTAtMTcgIFNoZXJp ZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgorCisgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGxpbmcgb3V0IHI5NzY0MS4KKyAgICAgICAgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9j aGFuZ2VzZXQvOTc2NDEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTcwMjg4CisKKyAgICAgICAgIlRoaXMgY2hhbmdlIG1heSBoYXZlIGJyb2tlbiBtb3Vz ZS9oaXQtdGVzdCBjb29yZGluYXRlIHRlc3RzLiIKKyAgICAgICAgKFJlcXVlc3RlZCBieSBqZWZm bTcgb24gI3dlYmtpdCkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9XaWRnZXQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6V2lkZ2V0Ojpjb252ZXJ0RnJvbUNvbnRhaW5pbmdXaW5kb3cpOgorICAgICAg ICAoV2ViQ29yZTo6V2lkZ2V0Ojpjb252ZXJ0VG9Db250YWluaW5nV2luZG93KToKKwogMjAxMS0x MC0xNyAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSB1 bm5lY2Vzc2FyeSBjYWxscyB0byBjb2x1bW5SZWN0QXQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vV2lkZ2V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1dpZGdl dC5jcHAKaW5kZXggNWI1NjY5ZWQyY2I0NmM1ZmVjMGFkMzI5NGRlZTk2YjMyOGZhYzY1Zi4uNjEz YzQ3MzBhNDk4ZDI4ZGNiZWMwOGViM2FlOThmMGIxZjU2Nzc2MiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vV2lkZ2V0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9XaWRnZXQuY3BwCkBAIC0xMDcsMjIgKzEwNywzOCBAQCBJbnRQb2ludCBXaWRnZXQ6OmNvbnZl cnRUb1Jvb3RWaWV3KGNvbnN0IEludFBvaW50JiBsb2NhbFBvaW50KSBjb25zdAogCiBJbnRSZWN0 IFdpZGdldDo6Y29udmVydEZyb21Db250YWluaW5nV2luZG93KGNvbnN0IEludFJlY3QmIHdpbmRv d1JlY3QpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIGNvbnZlcnRGcm9tUm9vdFZpZXcoY29udmVydEZy b21Db250YWluaW5nV2luZG93VG9Sb290KHRoaXMsIHdpbmRvd1JlY3QpKTsKKyAgICBpZiAoY29u c3QgU2Nyb2xsVmlldyogcGFyZW50U2Nyb2xsVmlldyA9IHBhcmVudCgpKSB7CisgICAgICAgIElu dFJlY3QgcGFyZW50UmVjdCA9IHBhcmVudFNjcm9sbFZpZXctPmNvbnZlcnRGcm9tQ29udGFpbmlu Z1dpbmRvdyh3aW5kb3dSZWN0KTsKKyAgICAgICAgcmV0dXJuIGNvbnZlcnRGcm9tQ29udGFpbmlu Z1ZpZXcocGFyZW50UmVjdCk7CisgICAgfQorICAgIHJldHVybiBjb252ZXJ0RnJvbUNvbnRhaW5p bmdXaW5kb3dUb1Jvb3QodGhpcywgd2luZG93UmVjdCk7CiB9CiAKIEludFJlY3QgV2lkZ2V0Ojpj b252ZXJ0VG9Db250YWluaW5nV2luZG93KGNvbnN0IEludFJlY3QmIGxvY2FsUmVjdCkgY29uc3QK IHsKLSAgICByZXR1cm4gY29udmVydEZyb21Sb290VG9Db250YWluaW5nV2luZG93KHRoaXMsIGNv bnZlcnRUb1Jvb3RWaWV3KGxvY2FsUmVjdCkpOworICAgIGlmIChjb25zdCBTY3JvbGxWaWV3KiBw YXJlbnRTY3JvbGxWaWV3ID0gcGFyZW50KCkpIHsKKyAgICAgICAgSW50UmVjdCBwYXJlbnRSZWN0 ID0gY29udmVydFRvQ29udGFpbmluZ1ZpZXcobG9jYWxSZWN0KTsKKyAgICAgICAgcmV0dXJuIHBh cmVudFNjcm9sbFZpZXctPmNvbnZlcnRUb0NvbnRhaW5pbmdXaW5kb3cocGFyZW50UmVjdCk7Cisg ICAgfQorICAgIHJldHVybiBjb252ZXJ0RnJvbVJvb3RUb0NvbnRhaW5pbmdXaW5kb3codGhpcywg bG9jYWxSZWN0KTsKIH0KIAogSW50UG9pbnQgV2lkZ2V0Ojpjb252ZXJ0RnJvbUNvbnRhaW5pbmdX aW5kb3coY29uc3QgSW50UG9pbnQmIHdpbmRvd1BvaW50KSBjb25zdAogewotICAgIHJldHVybiBj b252ZXJ0RnJvbVJvb3RWaWV3KGNvbnZlcnRGcm9tQ29udGFpbmluZ1dpbmRvd1RvUm9vdCh0aGlz LCB3aW5kb3dQb2ludCkpOworICAgIGlmIChjb25zdCBTY3JvbGxWaWV3KiBwYXJlbnRTY3JvbGxW aWV3ID0gcGFyZW50KCkpIHsKKyAgICAgICAgSW50UG9pbnQgcGFyZW50UG9pbnQgPSBwYXJlbnRT Y3JvbGxWaWV3LT5jb252ZXJ0RnJvbUNvbnRhaW5pbmdXaW5kb3cod2luZG93UG9pbnQpOworICAg ICAgICByZXR1cm4gY29udmVydEZyb21Db250YWluaW5nVmlldyhwYXJlbnRQb2ludCk7CisgICAg fQorICAgIHJldHVybiBjb252ZXJ0RnJvbUNvbnRhaW5pbmdXaW5kb3dUb1Jvb3QodGhpcywgd2lu ZG93UG9pbnQpOwogfQogCiBJbnRQb2ludCBXaWRnZXQ6OmNvbnZlcnRUb0NvbnRhaW5pbmdXaW5k b3coY29uc3QgSW50UG9pbnQmIGxvY2FsUG9pbnQpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIGNvbnZl cnRGcm9tUm9vdFRvQ29udGFpbmluZ1dpbmRvdyh0aGlzLCBjb252ZXJ0VG9Sb290Vmlldyhsb2Nh bFBvaW50KSk7CisgICAgaWYgKGNvbnN0IFNjcm9sbFZpZXcqIHBhcmVudFNjcm9sbFZpZXcgPSBw YXJlbnQoKSkgeworICAgICAgICBJbnRQb2ludCBwYXJlbnRQb2ludCA9IGNvbnZlcnRUb0NvbnRh aW5pbmdWaWV3KGxvY2FsUG9pbnQpOworICAgICAgICByZXR1cm4gcGFyZW50U2Nyb2xsVmlldy0+ Y29udmVydFRvQ29udGFpbmluZ1dpbmRvdyhwYXJlbnRQb2ludCk7CisgICAgfQorICAgIHJldHVy biBjb252ZXJ0RnJvbVJvb3RUb0NvbnRhaW5pbmdXaW5kb3codGhpcywgbG9jYWxQb2ludCk7CiB9 CiAKICNpZiAhUExBVEZPUk0oTUFDKQo=