70284 2011-10-17 16:29:35 -0700 r97638 caused 3 printing crashes 2011-10-17 23:39:17 -0700 1 1 1 Unclassified WebKit Printing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Normal --- 1 ojan koivisto hyatt koivisto simon.fraser zimmermann oldest_to_newest 485611 0 ojan 2011-10-17 16:29:35 -0700 As per http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=printing%2Fpage-format-data-display-none.html%20printing%2Fpage-format-data.html%20printing%2Fpage-rule-selection.html%20&group=%40ToT%20-%20webkit.org it was http://trac.webkit.org/changeset/97638/ that caused the crashes. printing/page-format-data-display-none.html printing/page-format-data.html printing/page-rule-selection.html 485843 1 111390 koivisto 2011-10-17 23:34:57 -0700 Created attachment 111390 null check 485846 2 111390 tkent 2011-10-17 23:35:54 -0700 Comment on attachment 111390 null check ok 485849 3 koivisto 2011-10-17 23:39:17 -0700 http://trac.webkit.org/changeset/97724 111390 2011-10-17 23:34:57 -0700 2011-10-17 23:35:53 -0700 null check page-rule-crash.patch text/plain 1264 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk3NzIzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMTcgIEFudHRpIEtv aXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgorCisgICAgICAgIHI5NzYzOCBjYXVzZWQgMyBwcmlu dGluZyBjcmFzaGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03MDI4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE51bGwgY2hlY2sgZWxlbWVudC4KKworICAgICAgICAqIGNzcy9DU1NTdHlsZVNlbGVjdG9y LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1N0eWxlU2VsZWN0b3I6OmFwcGx5RGVjbGFyYXRp b25zKToKKwogMjAxMS0xMC0xNyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFp bC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjk3NjY5LgpJbmRleDog U291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAkocmV2aXNpb24gOTc2MzgpCisr KyBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTIxNzQsNyArMjE3NCw3IEBAIHZvaWQgQ1NTU3R5bGVTZWxlY3Rvcjo6YXBwbHlEZWNsYXJh dGlvbnMKICAgICBpZiAoc3RhcnRJbmRleCA9PSAtMSkKICAgICAgICAgcmV0dXJuOwogCi0gICAg aWYgKG1fZWxlbWVudC0+aXNMaW5rKCkpIHsKKyAgICBpZiAobV9lbGVtZW50ICYmIG1fZWxlbWVu dC0+aXNMaW5rKCkpIHsKICAgICAgICAgZm9yIChpbnQgaSA9IHN0YXJ0SW5kZXg7IGkgPD0gZW5k SW5kZXg7ICsraSkgewogICAgICAgICAgICAgQ1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb24qIHN0 eWxlRGVjbGFyYXRpb24gPSBtX21hdGNoZWREZWNsc1tpXS5zdHlsZURlY2xhcmF0aW9uOwogICAg ICAgICAgICAgdW5zaWduZWQgbGlua01hdGNoVHlwZSA9IG1fbWF0Y2hlZERlY2xzW2ldLmxpbmtN YXRjaFR5cGU7Cg==