70282 2011-10-17 16:19:23 -0700 Filtering of URLs when serializing back forward list saves bad current index value 2011-10-17 17:41:05 -0700 1 1 1 Unclassified WebKit History 528+ (Nightly build) Mac OS X 10.7 RESOLVED FIXED InRadar P2 Normal --- 1 jonlee jonlee webkit-bug-importer oldest_to_newest 485606 0 jonlee 2011-10-17 16:19:23 -0700 <rdar://problem/10057763> 485664 1 111357 jonlee 2011-10-17 17:29:49 -0700 Created attachment 111357 Patch 485668 2 111357 sam 2011-10-17 17:37:50 -0700 Comment on attachment 111357 Patch Can you think of a way to test this in TestWebKitAPI? 485672 3 jonlee 2011-10-17 17:41:05 -0700 Committed r97681: <http://trac.webkit.org/changeset/97681> 111357 2011-10-17 17:29:49 -0700 2011-10-17 17:37:49 -0700 Patch bug-70282-20111017172950.patch text/plain 3159 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogOTc2NjQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAzYWNiM2FkM2NhMzM4MjRj MTE5MjRlM2Q3MmUwYjEzM2MyY2I3ZWQwLi40MTQzNGQyZGY0NzhiNmRkMjkxYWM3NjQ0ZjgzNDUx YzMyNjk5MmJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMTAtMTcgIEpvbiBM ZWUgIDxqb25sZWVAYXBwbGUuY29tPgorCisgICAgICAgIEZpbHRlcmluZyBvZiBVUkxzIHdoZW4g c2VyaWFsaXppbmcgYmFjayBmb3J3YXJkIGxpc3Qgc2F2ZXMgYmFkIGN1cnJlbnQgaW5kZXggdmFs dWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwMjgy CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMDA1Nzc2Mz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHJlYWRpbmcgdGhlIHNlcmlhbGl6ZWQg Yi1mIGxpc3QsIHBlcmZvcm0gYSBzYW5pdHkgY2hlY2sgb24gdGhlIGN1cnJlbnQgaW5kZXguCisg ICAgICAgIElmIGl0IGlzIGludmFsaWQsIHdlIHNldCBpdCB0byBOb0N1cnJlbnRJdGVtSW5kZXgg dG8gcHJldmVudCBmdXJ0aGVyIGNvcnJ1cHRpb24gb2YKKyAgICAgICAgdGhlIGxpc3QuCisKKyAg ICAgICAgV2hlbiBzZXJpYWxpemluZyB0aGUgYi1mIGxpc3QsIGN1cnJlbnRJbmRleCBjYW4gYmUg bmVnYXRpdmUgaW4gdGhlIGNhc2Ugd2hlcmUgdGhlIGxpc3QKKyAgICAgICAgaGFzIG9uZSBpdGVt IG9ubHksIGFuZCB0aGF0IGl0ZW0gZ2V0cyBmaWx0ZXJlZCBvdXQuIEluIHRoaXMgaW5zdGFuY2Ug Y3VycmVudEluZGV4IHNob3VsZAorICAgICAgICBqdXN0IGJlIC0xLiBBIGNyYXNoaW5nIGNhc2Ug c2hvd2VkIGFuIGluZGV4IHRoYXQgd2FzIG1vcmUgbmVnYXRpdmUsIGEgc2l0dWF0aW9uIHRoYXQg SQorICAgICAgICBjb3VsZCBub3QgcmVwbGljYXRlLiBTaW5jZSB0aGlzIHZhbHVlIHdpbGwgZ2V0 IGNsZWFuZWQgdXAgd2hlbiB0aGUgYi1mIGxpc3QgaXMgcmVzdG9yZWQsCisgICAgICAgIEkganVz dCBzdHJlbmd0aGVuZWQgdGhlIGFzc2VydGlvbiB0byBjaGVjayBmb3IgYSBtb3JlIG5lZ2F0aXZl IGluZGV4IGluIGNhc2Ugd2UgcnVuIGludG8gaXQgYWdhaW4uCisKKyAgICAgICAgKiBVSVByb2Nl c3MvY2YvV2ViQmFja0ZvcndhcmRMaXN0Q0YuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJCYWNr Rm9yd2FyZExpc3Q6OmNyZWF0ZUNGRGljdGlvbmFyeVJlcHJlc2VudGF0aW9uKTogVXBkYXRlIHRo ZSBhc3NlcnRpb24KKyAgICAgICAgaW4gY2FzZSB3ZSBnbyBiZXlvbmQgTm9DdXJyZW50SXRlbUlu ZGV4ICh3aGljaCwgYXMgYW4gaW50LCBpcyAtMSkuCisgICAgICAgIChXZWJLaXQ6OldlYkJhY2tG b3J3YXJkTGlzdDo6cmVzdG9yZUZyb21DRkRpY3Rpb25hcnlSZXByZXNlbnRhdGlvbik6CisKIDIw MTEtMTAtMTQgIENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFRo cm90dGxlIHJhdGUgb2YgcmVxdWVzdEFuaW1hdGlvbkZyYW1lIHdoZW4gcGFnZSBpcyBub3Qgdmlz aWJsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2NmL1dlYkJhY2tGb3J3 YXJkTGlzdENGLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9jZi9XZWJCYWNrRm9yd2Fy ZExpc3RDRi5jcHAKaW5kZXggMmI1M2Y0NDBiZGZhYzQ1MTU1MmM1YWUxMTBjNGIzMDUwMDI0MzMx Ny4uMTNiZTU0MGJkZjNmNDU0ZjI3YjMzM2FmODNmNmI1MzA1OTJiMTljYiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2NmL1dlYkJhY2tGb3J3YXJkTGlzdENGLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvY2YvV2ViQmFja0ZvcndhcmRMaXN0Q0YuY3BwCkBA IC04Miw3ICs4Miw3IEBAIENGRGljdGlvbmFyeVJlZiBXZWJCYWNrRm9yd2FyZExpc3Q6OmNyZWF0 ZUNGRGljdGlvbmFyeVJlcHJlc2VudGF0aW9uKFdlYlBhZ2VQcm94CiAgICAgICAgIENGQXJyYXlB cHBlbmRWYWx1ZShlbnRyaWVzLmdldCgpLCBlbnRyeURpY3Rpb25hcnkuZ2V0KCkpOwogICAgIH0K IAotICAgIEFTU0VSVChjdXJyZW50SW5kZXggPCBDRkFycmF5R2V0Q291bnQoZW50cmllcy5nZXQo KSkpOworICAgIEFTU0VSVChjdXJyZW50SW5kZXggPCBDRkFycmF5R2V0Q291bnQoZW50cmllcy5n ZXQoKSkgJiYgY3VycmVudEluZGV4ID49IHN0YXRpY19jYXN0PGludD4oTm9DdXJyZW50SXRlbUlu ZGV4KSk7CiAgICAgUmV0YWluUHRyPENGTnVtYmVyUmVmPiBjdXJyZW50SW5kZXhOdW1iZXIoQWRv cHRDRiwgQ0ZOdW1iZXJDcmVhdGUoMCwga0NGTnVtYmVySW50VHlwZSwgJmN1cnJlbnRJbmRleCkp OwogCiAgICAgY29uc3Qgdm9pZCoga2V5c1syXSA9IHsgU2Vzc2lvbkhpc3RvcnlDdXJyZW50SW5k ZXhLZXkoKSwgU2Vzc2lvbkhpc3RvcnlFbnRyaWVzS2V5KCkgfTsKQEAgLTE1OCw4ICsxNTgsMTEg QEAgYm9vbCBXZWJCYWNrRm9yd2FyZExpc3Q6OnJlc3RvcmVGcm9tQ0ZEaWN0aW9uYXJ5UmVwcmVz ZW50YXRpb24oQ0ZEaWN0aW9uYXJ5UmVmIGQKICAgICAgICAgbmV3RW50cmllcy5hcHBlbmQoV2Vi QmFja0ZvcndhcmRMaXN0SXRlbTo6Y3JlYXRlKG9yaWdpbmFsVVJMLCBlbnRyeVVSTCwgZW50cnlU aXRsZSwgQ0ZEYXRhR2V0Qnl0ZVB0cihiYWNrRm9yd2FyZERhdGEpLCBDRkRhdGFHZXRMZW5ndGgo YmFja0ZvcndhcmREYXRhKSwgZ2VuZXJhdGVXZWJCYWNrRm9yd2FyZEl0ZW1JRCgpKSk7CiAgICAg fQogICAgIAotICAgIG1fY3VycmVudCA9IGN1cnJlbnRJbmRleDsKICAgICBtX2VudHJpZXMgPSBu ZXdFbnRyaWVzOworICAgIG1fY3VycmVudCA9IGN1cnJlbnRJbmRleDsKKyAgICAvLyBQZXJmb3Jt IGEgc2FuaXR5IGNoZWNrOiBpbiBjYXNlIHdlJ3JlIG91dCBvZiByYW5nZSwgd2UgcmVzZXQuCisg ICAgaWYgKG1fY3VycmVudCAhPSBOb0N1cnJlbnRJdGVtSW5kZXggJiYgbV9jdXJyZW50ID49IG5l d0VudHJpZXMuc2l6ZSgpKQorICAgICAgICBtX2N1cnJlbnQgPSBOb0N1cnJlbnRJdGVtSW5kZXg7 CiAKICAgICByZXR1cm4gdHJ1ZTsKIH0K